197968 2019-05-16 16:01:14 -0700 REGRESSION (r15133): Fix leak of JSStringRef in minidom 2019-05-16 18:17:55 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue ews-watchlist ggaren joepeck keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1536948 0 ddkilzer 2019-05-16 16:01:14 -0700 Fix leak of JSStringRef in minidom. This regressed with the original commit back on July 1, 2006 in r15133 (nearly 13 years ago). <https://trac.webkit.org/r15133> Found by searching for incorrect uses of JSValueToStringCopy() that weren't calling JSStringRelease() or weren't adopting the result into a JSRetainPtr<JSStringRef> container. 1536949 1 webkit-bug-importer 2019-05-16 16:01:36 -0700 <rdar://problem/50872430> 1536964 2 370088 ddkilzer 2019-05-16 16:30:25 -0700 Created attachment 370088 Patch v1 1536981 3 370088 joepeck 2019-05-16 17:51:15 -0700 Comment on attachment 370088 Patch v1 r=me 1536993 4 370088 commit-queue 2019-05-16 18:17:53 -0700 Comment on attachment 370088 Patch v1 Clearing flags on attachment: 370088 Committed r245430: <https://trac.webkit.org/changeset/245430> 1536994 5 commit-queue 2019-05-16 18:17:55 -0700 All reviewed patches have been landed. Closing bug. 370088 2019-05-16 16:30:25 -0700 2019-05-16 18:17:53 -0700 Patch v1 bug-197968-20190516163024.patch text/plain 3181 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 YjRkYTQ3MmUwY2U5OTNjMTU0MTkzZjliOGZlZTQwNDRlNzk2ZTU5Li45NzY5YjAyY2VmM2E5OGY5 ODkwNGQxNmQwMmU0NTUyMGE4M2FhZmM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOS0wNS0xNiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxNTEzMyk6IEZpeCBsZWFrIG9mIEpTU3RyaW5nUmVm IGluIG1pbmlkb20KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE5Nzk2OD4KKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzUwODcyNDMwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogQVBJL3Rlc3RzL21pbmlkb20uYzoKKyAgICAgICAgKHBy aW50KTogQ2FsbCBKU1N0cmluZ1JlbGVhc2UoKSB0byBmaXggdGhlIGxlYWsuCisKIDIwMTktMDUt MTUgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgQm91bmQgbGl2 ZW5lc3Mgb2YgU2V0QXJndW1lbnRNYXliZSBub2RlcyB3aGVuIG1heGltYWwgZmx1c2ggaW5zZXJ0 aW9uIHBoYXNlIGlzIGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9B UEkvdGVzdHMvbWluaWRvbS5jIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy9taW5p ZG9tLmMKaW5kZXggNDFmMThjZGY3MjkwNDM2OTBjZmU3NzNiYTQwZDhiNWI0NGNhNzA5OC4uNmVi YjM5OWFjMGI5ODUxOGExNDMxNTY0ZWYwNWI5OGJlN2EwZjViMSAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy9taW5pZG9tLmMKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL0FQSS90ZXN0cy9taW5pZG9tLmMKQEAgLTkxLDYgKzkxLDcgQEAgc3RhdGljIEpTVmFs dWVSZWYgcHJpbnQoSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2JqZWN0UmVmIG9iamVjdCwgSlNP YmplY3RSZWYgdGgKICAgICAgICAgY2hhciBzdHJpbmdVVEY4W251bUNoYXJzXTsKICAgICAgICAg SlNTdHJpbmdHZXRVVEY4Q1N0cmluZyhzdHJpbmcsIHN0cmluZ1VURjgsIG51bUNoYXJzKTsKICAg ICAgICAgcHJpbnRmKCIlc1xuIiwgc3RyaW5nVVRGOCk7CisgICAgICAgIEpTU3RyaW5nUmVsZWFz ZShzdHJpbmcpOwogICAgIH0KICAgICAKICAgICByZXR1cm4gSlNWYWx1ZU1ha2VVbmRlZmluZWQo Y29udGV4dCk7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cK aW5kZXggZDk3ODYzYTBmODUxNWE1NmM2MDlhYmUzN2ZhNDIwMmM2OTgxYTNiYy4uYjI5NWIwY2Ix NTM1N2E3ZDk2ZmU0ZTFjNzRkNmI5YTQ2ZGFjMWU5ZCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdl TG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA1LTE2ICBE YXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAo cjE1MTMzKTogRml4IGxlYWsgb2YgSlNTdHJpbmdSZWYgaW4gbWluaWRvbQorICAgICAgICA8aHR0 cHM6Ly93ZWJraXQub3JnL2IvMTk3OTY4PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTA4NzI0 MzA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBU ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdE9iakMvVXNlckNvbnRlbnRUZXN0Lm1tOgorICAgICAg ICAoZXhwZWN0U2NyaXB0VmFsdWVJc1N0cmluZyk6IERyaXZlLWJ5IGZpeCB0byB1c2UgYWRvcHQo KSBpbnN0ZWFkCisgICAgICAgIG9mIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiBzdHJpbmcoQWRv cHQsIEpTVmFsdWVUb1N0cmluZ0NvcHkoLi4uKSkuCisKIDIwMTktMDUtMTYgIERhdmlkIEtpbHpl ciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyODQxNjApOiBM ZWFrIG9mIE9wYXF1ZUpTU3RyaW5nIHVuZGVyIFdUUjo6SlNUZXN0UnVubmVyOjpwYXRoVG9Mb2Nh bFJlc291cmNlICgzMiBieXRlcykgaW4gY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50IHJ1bm5p bmcgbGF5b3V0IHRlc3RzCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdE9iakMvVXNlckNvbnRlbnRUZXN0Lm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXRPYmpDL1VzZXJDb250ZW50VGVzdC5tbQppbmRleCBiNjNkMWQ2NjhhNzJkNWY3MWQwYmUw ZDI5MWM3YTZlYTIxMjM4ZTcwLi40ZmJhOTFmZDQ4MDc3MTRhOTJlNzcyYmU3N2VlYjJiYWJiZGU1 MDRmIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdE9iakMvVXNl ckNvbnRlbnRUZXN0Lm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0T2Jq Qy9Vc2VyQ29udGVudFRlc3QubW0KQEAgLTc3LDcgKzc3LDcgQEAgc3RhdGljIHZvaWQgZXhwZWN0 U2NyaXB0VmFsdWVJc1N0cmluZyhXS1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZVJlZiBzZXJpYWxpemVk U2NyaXAKICAgICBKU1ZhbHVlUmVmIHNjcmlwdFZhbHVlID0gV0tTZXJpYWxpemVkU2NyaXB0VmFs dWVEZXNlcmlhbGl6ZShzZXJpYWxpemVkU2NyaXB0VmFsdWUsIHNjcmlwdENvbnRleHQsIDApOwog ICAgIEVYUEVDVF9UUlVFKEpTVmFsdWVJc1N0cmluZyhzY3JpcHRDb250ZXh0LCBzY3JpcHRWYWx1 ZSkpOwogICAgIAotICAgIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiBzY3JpcHRTdHJpbmcoQWRv cHQsIEpTVmFsdWVUb1N0cmluZ0NvcHkoc2NyaXB0Q29udGV4dCwgc2NyaXB0VmFsdWUsIDApKTsK KyAgICBhdXRvIHNjcmlwdFN0cmluZyA9IGFkb3B0KEpTVmFsdWVUb1N0cmluZ0NvcHkoc2NyaXB0 Q29udGV4dCwgc2NyaXB0VmFsdWUsIDApKTsKICAgICBFWFBFQ1RfVFJVRShKU1N0cmluZ0lzRXF1 YWxUb1VURjhDU3RyaW5nKHNjcmlwdFN0cmluZy5nZXQoKSwgZXhwZWN0ZWRWYWx1ZSkpOwogICAg IAogICAgIEpTR2xvYmFsQ29udGV4dFJlbGVhc2Uoc2NyaXB0Q29udGV4dCk7Cg==