197930 2019-05-15 15:47:33 -0700 REGRESSION (r245072): Missing code in Document::styleColorOptions to propagate StyleColor::Options::UseInactiveAppearance 2019-05-15 16:50:42 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bdakin cdumez commit-queue dbates esprehn+autocc ews-watchlist kangil.han megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1536643 0 timothy 2019-05-15 15:47:33 -0700 Some code was missed in my initial patch (r245072) that didn't propagate StyleColor::Options::UseInactiveAppearance from the Page. <rdar://problem/49833954> 1536648 1 370002 timothy 2019-05-15 15:55:41 -0700 Created attachment 370002 Patch 1536651 2 370002 wenson_hsieh 2019-05-15 15:58:37 -0700 Comment on attachment 370002 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370002&action=review > Source/WebCore/dom/Document.cpp:6941 > + if (Page* documentPage = page()) Nit - auto* 1536654 3 370002 megan_gardner 2019-05-15 16:02:04 -0700 Comment on attachment 370002 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370002&action=review > Source/WebCore/dom/Document.cpp:6943 > + return useInactiveAppearance; Couldn't this just be if (Page* documentPage = page()) return documentPage->useInactiveAppearance(); return false; 1536655 4 370006 timothy 2019-05-15 16:09:17 -0700 Created attachment 370006 Patch 1536663 5 370006 commit-queue 2019-05-15 16:50:40 -0700 Comment on attachment 370006 Patch Clearing flags on attachment: 370006 Committed r245368: <https://trac.webkit.org/changeset/245368> 1536664 6 commit-queue 2019-05-15 16:50:42 -0700 All reviewed patches have been landed. Closing bug. 370002 2019-05-15 15:55:41 -0700 2019-05-15 16:09:16 -0700 Patch bug-197930-20190515155540.patch text/plain 2717 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRkYjZhZTg1YmEzYzEw Y2RhYjkwZDY2MDljMmQzODI5NmViMTVlMC4uM2MyOTZlOWRlNDZmNzEzNDhlYzI2Zjg1MTFiMDk3 Yjk5YmIyYzExMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA1LTE1ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChy MjQ1MDcyKTogTWlzc2luZyBjb2RlIGluIERvY3VtZW50OjpzdHlsZUNvbG9yT3B0aW9ucyB0byBw cm9wYWdhdGUgU3R5bGVDb2xvcjo6T3B0aW9uczo6VXNlSW5hY3RpdmVBcHBlYXJhbmNlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc5MzAKKyAgICAg ICAgcmRhcjovL3Byb2JsZW0vNDk4MzM5NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgc29tZSBjb2RlIHRoYXQgd2FzIG1pc3NpbmcgZnJvbSBE b2N1bWVudCBpbiBteSBvcmlnaW5hbCBwYXRjaCBmb3IgcjI0NTA3Mi4KKworICAgICAgICAqIGRv bS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6dXNlSW5hY3RpdmVB cHBlYXJhbmNlIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzdHlsZUNvbG9y T3B0aW9ucyBjb25zdCk6CisgICAgICAgICogZG9tL0RvY3VtZW50Lmg6CisKIDIwMTktMDUtMTUg IFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIGdldFVzZXJNZWRp YSBzYW5kYm94IGV4dGVuc2lvbnMgc2hvdWxkIG5vdCBiZSByZXZva2VkIHdoZW4gYSBnZXRVc2Vy TWVkaWEgYWxsb3dlZCByZXF1ZXN0IGlzIGJlaW5nIHByb2Nlc3NlZApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAKaW5kZXggYTJmYmQ4ZmRjOGE2Y2VjMjEwYWVlMDRjYmFmYjllY2E0NWU4MGY0OS4uMWYx NTZhY2UyYTkwY2Y4ZTIzYTAxMWUxM2I0MWRhY2JkZWFkMGJmNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1l bnQuY3BwCkBAIC02OTM1LDYgKzY5MzUsMTQgQEAgYm9vbCBEb2N1bWVudDo6dXNlRGFya0FwcGVh cmFuY2UoY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxlKSBjb25zdAogICAgIHJldHVybiBmYWxzZTsK IH0KIAorYm9vbCBEb2N1bWVudDo6dXNlSW5hY3RpdmVBcHBlYXJhbmNlKCkgY29uc3QKK3sKKyAg ICBib29sIHVzZUluYWN0aXZlQXBwZWFyYW5jZSA9IGZhbHNlOworICAgIGlmIChQYWdlKiBkb2N1 bWVudFBhZ2UgPSBwYWdlKCkpCisgICAgICAgIHVzZUluYWN0aXZlQXBwZWFyYW5jZSA9IGRvY3Vt ZW50UGFnZS0+dXNlSW5hY3RpdmVBcHBlYXJhbmNlKCk7CisgICAgcmV0dXJuIHVzZUluYWN0aXZl QXBwZWFyYW5jZTsKK30KKwogT3B0aW9uU2V0PFN0eWxlQ29sb3I6Ok9wdGlvbnM+IERvY3VtZW50 OjpzdHlsZUNvbG9yT3B0aW9ucyhjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUpIGNvbnN0CiB7CiAg ICAgT3B0aW9uU2V0PFN0eWxlQ29sb3I6Ok9wdGlvbnM+IG9wdGlvbnM7CkBAIC02OTQyLDYgKzY5 NTAsOCBAQCBPcHRpb25TZXQ8U3R5bGVDb2xvcjo6T3B0aW9ucz4gRG9jdW1lbnQ6OnN0eWxlQ29s b3JPcHRpb25zKGNvbnN0IFJlbmRlclN0eWxlKiBzdAogICAgICAgICBvcHRpb25zLmFkZChTdHls ZUNvbG9yOjpPcHRpb25zOjpVc2VTeXN0ZW1BcHBlYXJhbmNlKTsKICAgICBpZiAodXNlRGFya0Fw cGVhcmFuY2Uoc3R5bGUpKQogICAgICAgICBvcHRpb25zLmFkZChTdHlsZUNvbG9yOjpPcHRpb25z OjpVc2VEYXJrQXBwZWFyYW5jZSk7CisgICAgaWYgKHVzZUluYWN0aXZlQXBwZWFyYW5jZSgpKQor ICAgICAgICBvcHRpb25zLmFkZChTdHlsZUNvbG9yOjpPcHRpb25zOjpVc2VJbmFjdGl2ZUFwcGVh cmFuY2UpOwogICAgIHJldHVybiBvcHRpb25zOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCmluZGV4 IDEzNWVmMGI2Y2Q4Y2U1NTE1Y2U0NzFlYWMyMDIzZmZhOGU0ODc1N2IuLjk3MWZlNGNlODJiOTE0 OGRjY2Q5OWNjNDI2MDYwMDUyYWM4NTMzYzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBAIC01Njcs NiArNTY3LDcgQEAgcHVibGljOgogICAgIGZsb2F0IGRldmljZVNjYWxlRmFjdG9yKCkgY29uc3Q7 CiAKICAgICBXRUJDT1JFX0VYUE9SVCBib29sIHVzZVN5c3RlbUFwcGVhcmFuY2UoKSBjb25zdDsK KyAgICBXRUJDT1JFX0VYUE9SVCBib29sIHVzZUluYWN0aXZlQXBwZWFyYW5jZSgpIGNvbnN0Owog ICAgIFdFQkNPUkVfRVhQT1JUIGJvb2wgdXNlRGFya0FwcGVhcmFuY2UoY29uc3QgUmVuZGVyU3R5 bGUqKSBjb25zdDsKIAogICAgIE9wdGlvblNldDxTdHlsZUNvbG9yOjpPcHRpb25zPiBzdHlsZUNv bG9yT3B0aW9ucyhjb25zdCBSZW5kZXJTdHlsZSopIGNvbnN0Owo= 370006 2019-05-15 16:09:17 -0700 2019-05-15 16:50:40 -0700 Patch bug-197930-20190515160916.patch text/plain 3300 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRkYjZhZTg1YmEzYzEw Y2RhYjkwZDY2MDljMmQzODI5NmViMTVlMC4uZDNiOTMyZjk1Mjg1NDA1YWE1Y2I0MWM4YTMwYzk4 NGRkODMzZWIyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA1LTE1ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChy MjQ1MDcyKTogTWlzc2luZyBjb2RlIGluIERvY3VtZW50OjpzdHlsZUNvbG9yT3B0aW9ucyB0byBw cm9wYWdhdGUgU3R5bGVDb2xvcjo6T3B0aW9uczo6VXNlSW5hY3RpdmVBcHBlYXJhbmNlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc5MzAKKyAgICAg ICAgcmRhcjovL3Byb2JsZW0vNDk4MzM5NTQKKworICAgICAgICBSZXZpZXdlZCBieSBXZW5zb24g SHNpZWggYW5kIE1lZ2FuIEdhcmRuZXIuCisKKyAgICAgICAgQWRkIHNvbWUgY29kZSB0aGF0IHdh cyBtaXNzaW5nIGZyb20gRG9jdW1lbnQgaW4gbXkgb3JpZ2luYWwgcGF0Y2ggZm9yIHIyNDUwNzIu CisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1l bnQ6OnVzZVN5c3RlbUFwcGVhcmFuY2UgY29uc3QpOiBEcml2ZS1ieSBmaXggY29kZSBzdHlsZS4K KyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp1c2VJbmFjdGl2ZUFwcGVhcmFuY2UgY29uc3Qp OiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzdHlsZUNvbG9yT3B0aW9ucyBj b25zdCk6IEFkZCBTdHlsZUNvbG9yOjpPcHRpb25zOjpVc2VJbmFjdGl2ZUFwcGVhcmFuY2UuCisg ICAgICAgICogZG9tL0RvY3VtZW50Lmg6IEFkZGVkIHVzZUluYWN0aXZlQXBwZWFyYW5jZSgpLgor CiAyMDE5LTA1LTE1ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAg ICBnZXRVc2VyTWVkaWEgc2FuZGJveCBleHRlbnNpb25zIHNob3VsZCBub3QgYmUgcmV2b2tlZCB3 aGVuIGEgZ2V0VXNlck1lZGlhIGFsbG93ZWQgcmVxdWVzdCBpcyBiZWluZyBwcm9jZXNzZWQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGEyZmJkOGZkYzhhNmNlYzIxMGFlZTA0Y2JhZmI5ZWNh NDVlODBmNDkuLmNlY2Q3NjY2MmJlNjUxMzk2ZGM3ODUxMmRhZjJmZDMxMTRlMmQ5MjcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvZG9tL0RvY3VtZW50LmNwcApAQCAtNjg5MSwxMCArNjg5MSw5IEBAIGZsb2F0IERvY3VtZW50 OjpkZXZpY2VTY2FsZUZhY3RvcigpIGNvbnN0CiAKIGJvb2wgRG9jdW1lbnQ6OnVzZVN5c3RlbUFw cGVhcmFuY2UoKSBjb25zdAogewotICAgIGJvb2wgdXNlU3lzdGVtQXBwZWFyYW5jZSA9IGZhbHNl OwotICAgIGlmIChQYWdlKiBkb2N1bWVudFBhZ2UgPSBwYWdlKCkpCi0gICAgICAgIHVzZVN5c3Rl bUFwcGVhcmFuY2UgPSBkb2N1bWVudFBhZ2UtPnVzZVN5c3RlbUFwcGVhcmFuY2UoKTsKLSAgICBy ZXR1cm4gdXNlU3lzdGVtQXBwZWFyYW5jZTsKKyAgICBpZiAoYXV0byogZG9jdW1lbnRQYWdlID0g cGFnZSgpKQorICAgICAgICByZXR1cm4gZG9jdW1lbnRQYWdlLT51c2VTeXN0ZW1BcHBlYXJhbmNl KCk7CisgICAgcmV0dXJuIGZhbHNlOwogfQogCiBib29sIERvY3VtZW50Ojp1c2VEYXJrQXBwZWFy YW5jZShjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUpIGNvbnN0CkBAIC02OTM1LDYgKzY5MzQsMTMg QEAgYm9vbCBEb2N1bWVudDo6dXNlRGFya0FwcGVhcmFuY2UoY29uc3QgUmVuZGVyU3R5bGUqIHN0 eWxlKSBjb25zdAogICAgIHJldHVybiBmYWxzZTsKIH0KIAorYm9vbCBEb2N1bWVudDo6dXNlSW5h Y3RpdmVBcHBlYXJhbmNlKCkgY29uc3QKK3sKKyAgICBpZiAoYXV0byogZG9jdW1lbnRQYWdlID0g cGFnZSgpKQorICAgICAgICByZXR1cm4gZG9jdW1lbnRQYWdlLT51c2VJbmFjdGl2ZUFwcGVhcmFu Y2UoKTsKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKIE9wdGlvblNldDxTdHlsZUNvbG9yOjpPcHRp b25zPiBEb2N1bWVudDo6c3R5bGVDb2xvck9wdGlvbnMoY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxl KSBjb25zdAogewogICAgIE9wdGlvblNldDxTdHlsZUNvbG9yOjpPcHRpb25zPiBvcHRpb25zOwpA QCAtNjk0Miw2ICs2OTQ4LDggQEAgT3B0aW9uU2V0PFN0eWxlQ29sb3I6Ok9wdGlvbnM+IERvY3Vt ZW50OjpzdHlsZUNvbG9yT3B0aW9ucyhjb25zdCBSZW5kZXJTdHlsZSogc3QKICAgICAgICAgb3B0 aW9ucy5hZGQoU3R5bGVDb2xvcjo6T3B0aW9uczo6VXNlU3lzdGVtQXBwZWFyYW5jZSk7CiAgICAg aWYgKHVzZURhcmtBcHBlYXJhbmNlKHN0eWxlKSkKICAgICAgICAgb3B0aW9ucy5hZGQoU3R5bGVD b2xvcjo6T3B0aW9uczo6VXNlRGFya0FwcGVhcmFuY2UpOworICAgIGlmICh1c2VJbmFjdGl2ZUFw cGVhcmFuY2UoKSkKKyAgICAgICAgb3B0aW9ucy5hZGQoU3R5bGVDb2xvcjo6T3B0aW9uczo6VXNl SW5hY3RpdmVBcHBlYXJhbmNlKTsKICAgICByZXR1cm4gb3B0aW9uczsKIH0KIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuaAppbmRleCAxMzVlZjBiNmNkOGNlNTUxNWNlNDcxZWFjMjAyM2ZmYThlNDg3NTdiLi45 NzFmZTRjZTgyYjkxNDhkY2NkOTljYzQyNjA2MDA1MmFjODUzM2M1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1l bnQuaApAQCAtNTY3LDYgKzU2Nyw3IEBAIHB1YmxpYzoKICAgICBmbG9hdCBkZXZpY2VTY2FsZUZh Y3RvcigpIGNvbnN0OwogCiAgICAgV0VCQ09SRV9FWFBPUlQgYm9vbCB1c2VTeXN0ZW1BcHBlYXJh bmNlKCkgY29uc3Q7CisgICAgV0VCQ09SRV9FWFBPUlQgYm9vbCB1c2VJbmFjdGl2ZUFwcGVhcmFu Y2UoKSBjb25zdDsKICAgICBXRUJDT1JFX0VYUE9SVCBib29sIHVzZURhcmtBcHBlYXJhbmNlKGNv bnN0IFJlbmRlclN0eWxlKikgY29uc3Q7CiAKICAgICBPcHRpb25TZXQ8U3R5bGVDb2xvcjo6T3B0 aW9ucz4gc3R5bGVDb2xvck9wdGlvbnMoY29uc3QgUmVuZGVyU3R5bGUqKSBjb25zdDsK