197927 2019-05-15 14:37:28 -0700 Crash under WebCore::TimerBase::~TimerBase after a download is canceled 2019-05-29 10:29:48 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198298 InRadar P2 Normal --- 1 david_quesada webkit-unassigned achristensen beidson bfulgham cdumez commit-queue jonlee rniwa sroberts webkit-bug-importer oldest_to_newest 1536602 0 david_quesada 2019-05-15 14:37:28 -0700 rdar://problem/50822728 1536644 1 370001 david_quesada 2019-05-15 15:49:02 -0700 Created attachment 370001 Patch 1539073 2 370001 rniwa 2019-05-24 14:46:08 -0700 Comment on attachment 370001 Patch Looks sane to me. 1539078 3 370001 commit-queue 2019-05-24 15:13:08 -0700 Comment on attachment 370001 Patch Clearing flags on attachment: 370001 Committed r245756: <https://trac.webkit.org/changeset/245756> 1539079 4 commit-queue 2019-05-24 15:13:09 -0700 All reviewed patches have been landed. Closing bug. 1539128 5 sroberts 2019-05-24 17:30:14 -0700 Hello, it appears like after changes in r245756 the following API tests are flakey timeouts TestWebKitAPI.DownloadProgress.LoseProgressWhenDownloadIsCanceled Appears to time out every WK2 run https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK1%20%28Tests%29/builds/5157/steps/run-api-tests/logs/stdio Also these 2 can also timeout on WK1 TestWebKitAPI.DownloadProgress.CancelDownloadWhenProgressIsCanceled TestWebKitAPI._WKDownload.DownloadMonitorCancel https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK1%20%28Tests%29/builds/5158/steps/run-api-tests/logs/stdio We are having issues with Debug builders right now, so I do not have spades to test with. I will try to get some to test with, but this seems like the most likely culprit for these Timeouts. 370001 2019-05-15 15:49:02 -0700 2019-05-24 15:13:08 -0700 Patch file_197927.txt text/plain 3306 david_quesada Y29tbWl0IDEwODU5YWMwM2Q4YjZjNjZhMmFmYWJlNTYwY2ZjMWNiYmQwMDAxMGENCkF1dGhvcjog RGF2aWQgUXVlc2FkYSA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+DQpEYXRlOiAgIFdlZCBNYXkg MTUgMTU6NDg6MDcgMjAxOSAtMDcwMA0KDQogICAgQ3Jhc2ggdW5kZXIgV2ViQ29yZTo6VGltZXJC YXNlOjp+VGltZXJCYXNlIGFmdGVyIGEgZG93bmxvYWQgaXMgY2FuY2VsZWQNCiAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3OTI3DQogICAgcmRhcjovL3Byb2Js ZW0vNTA4MjI3MjgNCiAgICANCiAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4NCiAgICAN CiAgICAqIE5ldHdvcmtQcm9jZXNzL0Rvd25sb2Fkcy9jb2NvYS9Eb3dubG9hZENvY29hLm1tOg0K ICAgIChXZWJLaXQ6OkRvd25sb2FkOjpwbGF0Zm9ybUNhbmNlbE5ldHdvcmtMb2FkKToNCiAgICAg ICAgQ0ZOZXR3b3JrIG1ha2VzIG5vIGd1YXJhbnRlZXMgYWJvdXQgd2hhdCB0aHJlYWQgaXMgdXNl ZCB0byBjYWxsIHRoZSBjb21wbGV0aW9uIGJsb2NrDQogICAgICAgIHBhc3NlZCB0byAtW05TVVJM U2Vzc2lvbkRvd25sb2FkVGFzayBjYW5jZWxCeVByb2R1Y2luZ1Jlc3VtZURhdGFdLCBhbmQgaW4g c29tZSBjYXNlcywNCiAgICAgICAgaXQgY2FuIGJlIGNhbGxlZCBvbiBhIGJhY2tncm91bmQgcXVl dWUuIFRoaXMgZXZlbnR1YWxseSBjYXVzZXMgdGhlIERvd25sb2FkIHRvIGJlDQogICAgICAgIGRl YWxsb2NhdGVkIG9uIHRoZSBiYWNrZ3JvdW5kIHF1ZXVlLCB3aGljaCB0cmlnZ2VycyBhIHJlbGVh c2UgYXNzZXJ0aW9uIGZhaWx1cmUgaW4NCiAgICAgICAgflRpbWVyQmFzZS4gV2hlbiBDRk5ldHdv cmsgZmluaXNoZXMgY2FuY2VsaW5nIHRoZSBkb3dubG9hZCwgd2Ugc2hvdWxkIG1vdmUgdG8gdGhl DQogICAgICAgIG1haW4gdGhyZWFkIGJlZm9yZSBjYWxsaW5nIGRpZENhbmNlbCgpLg0KDQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zw0KaW5kZXggMTAyMDVjOGFmNWUuLmYwNDcwNWM3MjNjIDEwMDY0NA0KLS0tIGEvU291cmNlL1dl YktpdC9DaGFuZ2VMb2cNCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nDQpAQCAtMSwzICsx LDIwIEBADQorMjAxOS0wNS0xNSAgRGF2aWQgUXVlc2FkYSAgPGRhdmlkX3F1ZXNhZGFAYXBwbGUu Y29tPg0KKw0KKyAgICAgICAgQ3Jhc2ggdW5kZXIgV2ViQ29yZTo6VGltZXJCYXNlOjp+VGltZXJC YXNlIGFmdGVyIGEgZG93bmxvYWQgaXMgY2FuY2VsZWQNCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc5MjcNCisgICAgICAgIHJkYXI6Ly9wcm9ibGVt LzUwODIyNzI4DQorDQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4NCisNCisg ICAgICAgICogTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL2NvY29hL0Rvd25sb2FkQ29jb2EubW06 DQorICAgICAgICAoV2ViS2l0OjpEb3dubG9hZDo6cGxhdGZvcm1DYW5jZWxOZXR3b3JrTG9hZCk6 DQorICAgICAgICAgICAgQ0ZOZXR3b3JrIG1ha2VzIG5vIGd1YXJhbnRlZXMgYWJvdXQgd2hhdCB0 aHJlYWQgaXMgdXNlZCB0byBjYWxsIHRoZSBjb21wbGV0aW9uIGJsb2NrDQorICAgICAgICAgICAg cGFzc2VkIHRvIC1bTlNVUkxTZXNzaW9uRG93bmxvYWRUYXNrIGNhbmNlbEJ5UHJvZHVjaW5nUmVz dW1lRGF0YV0sIGFuZCBpbiBzb21lIGNhc2VzLA0KKyAgICAgICAgICAgIGl0IGNhbiBiZSBjYWxs ZWQgb24gYSBiYWNrZ3JvdW5kIHF1ZXVlLiBUaGlzIGV2ZW50dWFsbHkgY2F1c2VzIHRoZSBEb3du bG9hZCB0byBiZQ0KKyAgICAgICAgICAgIGRlYWxsb2NhdGVkIG9uIHRoZSBiYWNrZ3JvdW5kIHF1 ZXVlLCB3aGljaCB0cmlnZ2VycyBhIHJlbGVhc2UgYXNzZXJ0aW9uIGZhaWx1cmUgaW4NCisgICAg ICAgICAgICB+VGltZXJCYXNlLiBXaGVuIENGTmV0d29yayBmaW5pc2hlcyBjYW5jZWxpbmcgdGhl IGRvd25sb2FkLCB3ZSBzaG91bGQgbW92ZSB0byB0aGUNCisgICAgICAgICAgICBtYWluIHRocmVh ZCBiZWZvcmUgY2FsbGluZyBkaWRDYW5jZWwoKS4NCisNCiAyMDE5LTA1LTE1ICBTaWh1aSBMaXUg IDxzaWh1aV9saXVAYXBwbGUuY29tPg0KIA0KICAgICAgICAgQWRkIGFzc2VydGlvbnMgdG8gaGVs cCBkaWFnbm9zZSBjcmFzaCBhdCBXZWJQcm9jZXNzUHJveHk6OnByb2Nlc3NQb29sKCkNCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0Rvd25sb2Fkcy9jb2NvYS9Eb3du bG9hZENvY29hLm1tIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMvY29j b2EvRG93bmxvYWRDb2NvYS5tbQ0KaW5kZXggMDA2ZTQwMDI1ODUuLmYxMDQ2N2ZlZTdmIDEwMDY0 NA0KLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMvY29jb2EvRG93 bmxvYWRDb2NvYS5tbQ0KKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9h ZHMvY29jb2EvRG93bmxvYWRDb2NvYS5tbQ0KQEAgLTgxLDEwICs4MSwxMiBAQCB2b2lkIERvd25s b2FkOjpwbGF0Zm9ybUNhbmNlbE5ldHdvcmtMb2FkKCkNCiB7DQogICAgIEFTU0VSVChtX2Rvd25s b2FkVGFzayk7DQogICAgIFttX2Rvd25sb2FkVGFzayBjYW5jZWxCeVByb2R1Y2luZ1Jlc3VtZURh dGE6XihOU0RhdGEgKnJlc3VtZURhdGEpIHsNCi0gICAgICAgIGlmIChyZXN1bWVEYXRhICYmIHJl c3VtZURhdGEuYnl0ZXMgJiYgcmVzdW1lRGF0YS5sZW5ndGgpDQotICAgICAgICAgICAgZGlkQ2Fu Y2VsKElQQzo6RGF0YVJlZmVyZW5jZShyZWludGVycHJldF9jYXN0PGNvbnN0IHVpbnQ4X3QqPihy ZXN1bWVEYXRhLmJ5dGVzKSwgcmVzdW1lRGF0YS5sZW5ndGgpKTsNCi0gICAgICAgIGVsc2UNCi0g ICAgICAgICAgICBkaWRDYW5jZWwoeyB9KTsNCisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW3Ro aXMsIHJlc3VtZURhdGEgPSByZXRhaW5QdHIocmVzdW1lRGF0YSldIHsNCisgICAgICAgICAgICBp ZiAocmVzdW1lRGF0YSAmJiByZXN1bWVEYXRhLmdldCgpLmJ5dGVzICYmIHJlc3VtZURhdGEuZ2V0 KCkubGVuZ3RoKQ0KKyAgICAgICAgICAgICAgICBkaWRDYW5jZWwoSVBDOjpEYXRhUmVmZXJlbmNl KHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgdWludDhfdCo+KHJlc3VtZURhdGEuZ2V0KCkuYnl0ZXMp LCByZXN1bWVEYXRhLmdldCgpLmxlbmd0aCkpOw0KKyAgICAgICAgICAgIGVsc2UNCisgICAgICAg ICAgICAgICAgZGlkQ2FuY2VsKHsgfSk7DQorICAgICAgICB9KTsNCiAgICAgfV07DQogfQ0KIA0K