<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>197857</bug_id>
          
          <creation_ts>2019-05-13 15:47:42 -0700</creation_ts>
          <short_desc>IndexSet::isEmpty should use BitVector::isEmpty() instead of size()</short_desc>
          <delta_ts>2019-05-13 20:39:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>197637</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Robin Morisset">rmorisset</reporter>
          <assigned_to name="Robin Morisset">rmorisset</assigned_to>
          <cc>benjamin</cc>
    
    <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>dbates</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1535840</commentid>
    <comment_count>0</comment_count>
    <who name="Robin Morisset">rmorisset</who>
    <bug_when>2019-05-13 15:47:42 -0700</bug_when>
    <thetext>I missed this use of size() when adding isEmpty() to BitVector in https://bugs.webkit.org/show_bug.cgi?id=197637</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1535844</commentid>
    <comment_count>1</comment_count>
      <attachid>369796</attachid>
    <who name="Robin Morisset">rmorisset</who>
    <bug_when>2019-05-13 15:49:38 -0700</bug_when>
    <thetext>Created attachment 369796
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1535950</commentid>
    <comment_count>2</comment_count>
      <attachid>369796</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-05-13 20:38:19 -0700</bug_when>
    <thetext>Comment on attachment 369796
Patch

Clearing flags on attachment: 369796

Committed r245271: &lt;https://trac.webkit.org/changeset/245271&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1535951</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-05-13 20:38:20 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1535952</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-05-13 20:39:18 -0700</bug_when>
    <thetext>&lt;rdar://problem/50751634&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>369796</attachid>
            <date>2019-05-13 15:49:38 -0700</date>
            <delta_ts>2019-05-13 20:38:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>patch197857</filename>
            <type>text/plain</type>
            <size>972</size>
            <attacher name="Robin Morisset">rmorisset</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAyNDUyNjApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA1LTEzICBSb2JpbiBNb3Jpc3NldCAgPHJt
b3Jpc3NldEBhcHBsZS5jb20+CisKKyAgICAgICAgSW5kZXhTZXQ6OmlzRW1wdHkgc2hvdWxkIHVz
ZSBCaXRWZWN0b3I6OmlzRW1wdHkoKSBpbnN0ZWFkIG9mIHNpemUoKQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3ODU3CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvSW5kZXhTZXQuaDoKKyAgICAg
ICAgKFdURjo6SW5kZXhTZXQ6OmlzRW1wdHkgY29uc3QpOgorCiAyMDE5LTA1LTEzICBZdXN1a2Ug
U3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dURl0gUmVtb3ZlIFRocmVh
ZGluZyB3b3JrYXJvdW5kIGZvciBzdXBwb3J0IGxpYnJhcmllcyBpbiBXaW5kb3dzCkluZGV4OiBT
b3VyY2UvV1RGL3d0Zi9JbmRleFNldC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0lu
ZGV4U2V0LmgJKHJldmlzaW9uIDI0NTE5NSkKKysrIFNvdXJjZS9XVEYvd3RmL0luZGV4U2V0LmgJ
KHdvcmtpbmcgY29weSkKQEAgLTc2LDcgKzc2LDcgQEAKIAogICAgIGJvb2wgaXNFbXB0eSgpIGNv
bnN0CiAgICAgewotICAgICAgICByZXR1cm4gIXNpemUoKTsKKyAgICAgICAgcmV0dXJuIG1fc2V0
LmlzRW1wdHkoKTsKICAgICB9CiAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBDb2xsZWN0aW9uVHlw
ZT4K
</data>

          </attachment>
      

    </bug>

</bugzilla>