197837 2019-05-13 07:12:37 -0700 GraphicsLayer contentsVisible property miscomputed when using backing sharing 2019-05-13 08:23:17 -0700 1 1 1 Unclassified WebKit Compositing WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 koivisto webkit-unassigned simon.fraser oldest_to_newest 1535605 0 koivisto 2019-05-13 07:12:37 -0700 The attached test case produces layer tree (GraphicsLayer (anchor 0.00 0.00) (bounds 800.00 600.00) (deep color 1) (children 1 (GraphicsLayer (bounds 800.00 600.00) (contentsOpaque 1) (deep color 1) (children 2 (GraphicsLayer (position 8.00 8.00) (bounds 500.00 500.00) (contentsOpaque 1) (deep color 1) ) (GraphicsLayer (position 30.00 30.00) (bounds 250.00 250.00) (drawsContent 1) (contentsVisible 0) (deep color 1) ) ) ) ) ) The layer with (contentsVisible 0) has visible contents in backing sharing descendants. 1535606 1 369729 koivisto 2019-05-13 07:12:52 -0700 Created attachment 369729 test 1535607 2 koivisto 2019-05-13 07:18:13 -0700 Maybe we can simply remove contentsVisible and userInteractionEnabled GraphicsLayer properties? Their purpose seems to be entirely subsumed by the event region. 1535617 3 simon.fraser 2019-05-13 08:15:35 -0700 Does the event region control whether an overflow scroll is interactive? If so, then it sounds like we can remove these. But we need to make sure that the pointer-events and visibility properties are correctly reflected in event regions, and that event regions correctly disable interaction on UIScrollViews. More tests required! 1535621 4 koivisto 2019-05-13 08:23:17 -0700 (In reply to Simon Fraser (smfr) from comment #3) > Does the event region control whether an overflow scroll is interactive? Yep. > If > so, then it sounds like we can remove these. But we need to make sure that > the pointer-events and visibility properties are correctly reflected in > event regions, and that event regions correctly disable interaction on > UIScrollViews. More tests required! Event regions do respect both visibility and pointer-events and has some testing for those too already. 369729 2019-05-13 07:12:52 -0700 2019-05-13 07:12:52 -0700 test backing-sharing-visibility.html text/html 1113 koivisto PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDxzdHlsZT4KICAgICAgICAucmVsYXRp dmUgewogICAgICAgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgICAgICAgICAgIHRvcDogMjBw eDsKICAgICAgICAgICAgbGVmdDogMjBweDsKICAgICAgICAgICAgaGVpZ2h0OiAxMHB4OwogICAg ICAgICAgICB3aWR0aDogMTBweDsKICAgICAgICAgICAgbWFyZ2luOiAxMHB4OwogICAgICAgICAg ICB2aXNpYmlsaXR5OiBoaWRkZW47CiAgICAgICAgfQogICAgICAgIAogICAgICAgIC5zaGFyaW5n IHsKCQkJcG9zaXRpb246IHJlbGF0aXZlOwoJCQl0b3A6IDUwcHg7CgkJCWxlZnQ6IDUwcHg7CiAg ICAgICAgICAgIHdpZHRoOiAyMDBweDsKICAgICAgICAgICAgaGVpZ2h0OiAyMDBweDsKICAgICAg ICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CiAgICAgICAgICAgIHZpc2liaWxpdHk6IHZp c2libGU7CiAgICAgICAgfQoKICAgICAgICAudHJpZ2dlciB7CiAgICAgICAgICAgIHRyYW5zZm9y bTogdHJhbnNsYXRlWigwKTsKICAgICAgICAgICAgd2lkdGg6IDUwMHB4OwogICAgICAgICAgICBo ZWlnaHQ6IDUwMHB4OwogICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBzaWx2ZXI7CiAgICAg ICAgfQogICAgPC9zdHlsZT4KICAgIDxzY3JpcHQ+CiAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVu bmVyKQogICAgICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKCiAgICAgICAgd2luZG93 LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCAoKSA9PiB7CiAgICAgICAgICAgIGlmICh3aW5kb3cu aW50ZXJuYWxzKQogICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2xheWVy cycpLnRleHRDb250ZW50ID0gaW50ZXJuYWxzLmxheWVyVHJlZUFzVGV4dChkb2N1bWVudCk7CiAg ICAgICAgfSwgZmFsc2UpOwogICAgPC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHk+CiAgICA8ZGl2IGNs YXNzPSJ0cmlnZ2VyIj48L2Rpdj4KICAgIDxkaXYgY2xhc3M9InJlbGF0aXZlIj4KICAgICAgICA8 ZGl2IGNsYXNzPSJzaGFyaW5nIj4KICAgICAgICA8L2Rpdj4KICAgIDwvZGl2Pgo8cHJlIGlkPSJs YXllcnMiPjwvcHJlPgo8L2JvZHk+CjwvaHRtbD4K