197801 2019-05-10 15:07:10 -0700 A service worker instance should be terminated when its SWServer is destroyed 2019-05-13 15:08:04 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf beidson cdumez commit-queue ggaren webkit-bug-importer oldest_to_newest 1535204 0 youennf 2019-05-10 15:07:10 -0700 A service worker instance should be terminated when its SWServer is destroyed 1535211 1 youennf 2019-05-10 15:30:21 -0700 <rdar://problem/50587270> 1535212 2 369608 youennf 2019-05-10 15:33:34 -0700 Created attachment 369608 Patch 1535246 3 369608 commit-queue 2019-05-10 16:33:44 -0700 Comment on attachment 369608 Patch Clearing flags on attachment: 369608 Committed r245200: <https://trac.webkit.org/changeset/245200> 1535248 4 commit-queue 2019-05-10 16:33:45 -0700 All reviewed patches have been landed. Closing bug. 1535786 5 ggaren 2019-05-13 14:32:09 -0700 What mechanism prevents two concurrent but independent sessions from sharing a service worker? 1535809 6 cdumez 2019-05-13 15:08:04 -0700 (In reply to Geoffrey Garen from comment #5) > What mechanism prevents two concurrent but independent sessions from sharing > a service worker? We use a different SWServer instance per session ID. Service worker instances are owned by each SWServer instance so I do not believe different session can share service workers. 369608 2019-05-10 15:33:34 -0700 2019-05-10 16:33:44 -0700 Patch bug-197801-20190510153333.patch text/plain 3303 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1MTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzgwOWYyYTg1YTRmNGU5 YmVmZWM4NzcxNDdlNzg0MzU5OTUyODM2Ny4uNDU2Y2FlZmZmMzk5OTI3YjU0MGJmNDJhYmEzY2E1 ZmU1NzVlNDg0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA1LTEwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBIHNlcnZpY2Ugd29ya2Vy IGluc3RhbmNlIHNob3VsZCBiZSB0ZXJtaW5hdGVkIHdoZW4gaXRzIFNXU2VydmVyIGlzIGRlc3Ry b3llZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3 ODAxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MDU4NzI3MD4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbiBzZXNzaW9uIGRlc3RydWN0aW9uLCB0 aGUgU1dTZXJ2ZXIgaXMgZGVzdHJveWVkLgorICAgICAgICBBdCB0aGF0IHRpbWUsIGl0IHNob3Vs ZCB0ZXJtaW5hdGUgYWxsIGl0cyBydW5uaW5nIHNlcnZpY2Ugd29ya2Vycy4KKyAgICAgICAgQ292 ZXJlZCBieSB1cGRhdGVkIEFQSSB0ZXN0LgorCisgICAgICAgICogd29ya2Vycy9zZXJ2aWNlL3Nl cnZlci9TV1NlcnZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTV1NlcnZlcjo6flNXU2VydmVy KToKKwogMjAxOS0wNS0xMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAg ICAgICAgQSBzZXJ2aWNlIHdvcmtlciBwcm9jZXNzIHNob3VsZCBhcHAgbmFwIHdoZW4gYWxsIGl0 cyBjbGllbnRzIGFwcCBuYXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2Vy dmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNl L3NlcnZlci9TV1NlcnZlci5jcHAKaW5kZXggOWQyZDMwNzQzNTJmNmNlNDMzNjUyYTVkMWYzYzJm MjM5YWY4ZmM0Yy4uOTdiMzBjMTViYzkwYjVmYjhiNDBjZGQxY2YyM2I3YTBkZmU4NTEwZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9TV1NlcnZlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9TV1NlcnZlci5j cHAKQEAgLTY5LDYgKzY5LDE0IEBAIFNXU2VydmVyOjp+U1dTZXJ2ZXIoKQogICAgIGF1dG8gY29u bmVjdGlvbnMgPSBXVEZNb3ZlKG1fY29ubmVjdGlvbnMpOwogICAgIGNvbm5lY3Rpb25zLmNsZWFy KCk7CiAKKyAgICBWZWN0b3I8U1dTZXJ2ZXJXb3JrZXIqPiBydW5uaW5nV29ya2VyczsKKyAgICBm b3IgKGF1dG8mIHdvcmtlciA6IG1fcnVubmluZ09yVGVybWluYXRpbmdXb3JrZXJzLnZhbHVlcygp KSB7CisgICAgICAgIGlmICh3b3JrZXItPmlzUnVubmluZygpKQorICAgICAgICAgICAgcnVubmlu Z1dvcmtlcnMuYXBwZW5kKHdvcmtlci5wdHIoKSk7CisgICAgfQorICAgIGZvciAoYXV0byYgcnVu bmluZ1dvcmtlciA6IHJ1bm5pbmdXb3JrZXJzKQorICAgICAgICB0ZXJtaW5hdGVXb3JrZXIoKnJ1 bm5pbmdXb3JrZXIpOworCiAgICAgYWxsU2VydmVycygpLnJlbW92ZSh0aGlzKTsKIH0KIApkaWZm IC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDJkNTJlMWVl NDRlMTA1OGIyOWJlZjI2ZTFlN2I1MzUxNzYxZmNlOTcuLmJmNDgyMzY5YzdlNmMzZGE2MTBhNTEy YjE0ODY1Y2FlYjg5MjY3MzggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29s cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0wNS0xMCAgWW91ZW5uIEZhYmxldCAg PHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgQSBzZXJ2aWNlIHdvcmtlciBpbnN0YW5jZSBz aG91bGQgYmUgdGVybWluYXRlZCB3aGVuIGl0cyBTV1NlcnZlciBpcyBkZXN0cm95ZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzgwMQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNTA1ODcyNzA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Nl cnZpY2VXb3JrZXJCYXNpYy5tbToKKwogMjAxOS0wNS0xMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVu bkBhcHBsZS5jb20+CiAKICAgICAgICAgQSBzZXJ2aWNlIHdvcmtlciBwcm9jZXNzIHNob3VsZCBh cHAgbmFwIHdoZW4gYWxsIGl0cyBjbGllbnRzIGFwcCBuYXAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvU2VydmljZVdvcmtlckJhc2ljLm1tIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TZXJ2aWNlV29ya2VyQmFzaWMubW0K aW5kZXggNGNkMWIzMzI4YWQwNmY4ZGZmZTk1MzRmMWQzNmYyODZhMDQxN2RmOS4uM2RkNGQ3YmNj MjY3MjRhNzIxMTU4YjRiNWZkM2I3ZmFhZjc5NjI2ZCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TZXJ2aWNlV29ya2VyQmFzaWMubW0KKysrIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9TZXJ2aWNlV29ya2VyQmFzaWMubW0K QEAgLTMyLDYgKzMyLDcgQEAKICNpbXBvcnQgPFdlYktpdC9XS1VSTFNjaGVtZUhhbmRsZXIuaD4K ICNpbXBvcnQgPFdlYktpdC9XS1VSTFNjaGVtZVRhc2tQcml2YXRlLmg+CiAjaW1wb3J0IDxXZWJL aXQvV0tXZWJWaWV3Q29uZmlndXJhdGlvblByaXZhdGUuaD4KKyNpbXBvcnQgPFdlYktpdC9XS1dl YlZpZXdQcml2YXRlLmg+CiAjaW1wb3J0IDxXZWJLaXQvV0tXZWJzaXRlRGF0YVN0b3JlUHJpdmF0 ZS5oPgogI2ltcG9ydCA8V2ViS2l0L1dLV2Vic2l0ZURhdGFTdG9yZVJlZi5oPgogI2ltcG9ydCA8 V2ViS2l0L1dlYktpdC5oPgpAQCAtMTUwMiw2ICsxNTAzLDcgQEAgVEVTVChTZXJ2aWNlV29ya2Vy cywgTm9uRGVmYXVsdFNlc3Npb25JRCkKICAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRv bmUpOwogICAgIGRvbmUgPSBmYWxzZTsKIAorICAgIFt3ZWJWaWV3IF9jbG9zZV07CiAgICAgd2Vi VmlldyA9IG51bGxwdHI7CiAKICAgICBFWFBFQ1RfVFJVRShbW05TRmlsZU1hbmFnZXIgZGVmYXVs dE1hbmFnZXJdIGZpbGVFeGlzdHNBdFBhdGg6c2VydmljZVdvcmtlcnNQYXRoLnBhdGhdKTsK