197760 2019-05-09 16:49:30 -0700 Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files 2019-05-13 14:52:43 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren beidson commit-queue darin jer.noble sihui_liu webkit-bug-importer oldest_to_newest 1534897 0 ggaren 2019-05-09 16:49:30 -0700 Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files 1534898 1 369530 ggaren 2019-05-09 16:51:32 -0700 Created attachment 369530 Patch 1535104 2 sihui_liu 2019-05-10 11:52:32 -0700 *** Bug 197789 has been marked as a duplicate of this bug. *** 1535105 3 sihui_liu 2019-05-10 11:54:45 -0700 Probably just makeSafeToUseMemoryMapForPath as we already know the reproducible case? 1535122 4 369577 ggaren 2019-05-10 12:02:54 -0700 Created attachment 369577 Patch 1535133 5 ggaren 2019-05-10 12:40:26 -0700 There seems to be continuing debate about whether makeSafeToUseMemoryMapForPath in WebKit is a sufficient fix. Let's continue to gather these logs (without crashing) to help inform that discussion. 1535194 6 ggaren 2019-05-10 14:32:02 -0700 After discussion with Sihui and Jer, I'm going to land this along with the workaround in bug 197789. 1535195 7 ggaren 2019-05-10 14:36:48 -0700 Committed r245197: <https://trac.webkit.org/changeset/245197> 1535196 8 webkit-bug-importer 2019-05-10 14:37:22 -0700 <rdar://problem/50677550> 1535372 9 darin 2019-05-11 13:03:20 -0700 (In reply to Geoffrey Garen from comment #7) > Committed r245197: <https://trac.webkit.org/changeset/245197> The patch landed (not the one reviewed) has indentation that does not match the brace structure of the if statement. The call to makeSafeToUseMemoryMapForPath is done unconditionally, not based not the result of isSafeToUseMemoryMapForPath. 1535703 10 ggaren 2019-05-13 11:43:59 -0700 Reopening to attach new patch. 1535704 11 369757 ggaren 2019-05-13 11:43:59 -0700 Created attachment 369757 Patch 1535794 12 369757 commit-queue 2019-05-13 14:52:41 -0700 Comment on attachment 369757 Patch Clearing flags on attachment: 369757 Committed r245253: <https://trac.webkit.org/changeset/245253> 1535795 13 commit-queue 2019-05-13 14:52:43 -0700 All reviewed patches have been landed. Closing bug. 369530 2019-05-09 16:51:32 -0700 2019-05-10 12:02:53 -0700 Patch bug-197760-20190509165131.patch text/plain 1664 ggaren SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NTA2MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA1LTA5ICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgRG93bmdyYWRlIFJFTEVBU0Vf QVNTRVJUIFRPIFJFTEVBU0VfTE9HX0ZBVUxUIGZvciBTUUxpdGUgQ2xhc3MgQSBmaWxlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NzYwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgaGF2ZSBhbGwg dGhlIGRhdGEgd2UgbmVlZCwgYW5kIHRoaXMgY3Jhc2ggaXMgaGFwcGVuaW5nIG1vcmUgdGhhbgor ICAgICAgICBleHBlY3RlZC4KKworICAgICAgICAqIHBsYXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFz ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTUUxpdGVEYXRhYmFzZTo6b3Blbik6CisKIDIwMTkt MDUtMDggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg SW1wbGVtZW50IGJhY2tpbmctc2hhcmluZyBpbiBjb21wb3NpdGluZyBsYXllcnMsIGFsbG93aW5n IG92ZXJsYXAgbGF5ZXJzIHRvIHBhaW50IGludG8gdGhlIGJhY2tpbmcgc3RvcmUgb2YgYW5vdGhl ciBsYXllcgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNl LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlRGF0 YWJhc2UuY3BwCShyZXZpc2lvbiAyNDUwNjEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9z cWwvU1FMaXRlRGF0YWJhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTAsOCArMTUwLDEwIEBA IGJvb2wgU1FMaXRlRGF0YWJhc2U6Om9wZW4oY29uc3QgU3RyaW5nJiAKICAgICAgICAgdXNlV0FM Sm91cm5hbE1vZGUoKTsKIAogICAgIFN0cmluZyBzaG1GaWxlTmFtZSA9IG1ha2VTdHJpbmcoZmls ZW5hbWUsICItc2htIl9zKTsKLSAgICBpZiAoRmlsZVN5c3RlbTo6ZmlsZUV4aXN0cyhzaG1GaWxl TmFtZSkpCi0gICAgICAgIFJFTEVBU0VfQVNTRVJUKEZpbGVTeXN0ZW06OmlzU2FmZVRvVXNlTWVt b3J5TWFwRm9yUGF0aChzaG1GaWxlTmFtZSkpOworICAgIGlmIChGaWxlU3lzdGVtOjpmaWxlRXhp c3RzKHNobUZpbGVOYW1lKSkgeworICAgICAgICBpZiAoIUZpbGVTeXN0ZW06OmlzU2FmZVRvVXNl TWVtb3J5TWFwRm9yUGF0aChzaG1GaWxlTmFtZSkpCisgICAgICAgICAgICBSRUxFQVNFX0xPR19G QVVMVCgiRm91bmQgYW4gU1FMaXRlIGRhdGFiYXNlIC1zaG0gZmlsZSB3aXRoIENsYXNzIEEgc3Rv cmFnZS4gVGhpcyB3aWxsIHRyaWdnZXIgYSBjcmFzaCB3aGVuIHRoZSB1c2VyIGxvY2tzIHRoZSBk ZXZpY2UuIiwgIiAoIiwgc2htRmlsZU5hbWUsICIpIik7CisgICAgfQogCiAgICAgcmV0dXJuIGlz T3BlbigpOwogfQo= 369577 2019-05-10 12:02:54 -0700 2019-05-13 11:43:57 -0700 Patch bug-197760-20190510120254.patch text/plain 1682 ggaren SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NTA2MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA1LTA5ICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgRG93bmdyYWRlIFJFTEVBU0Vf QVNTRVJUIFRPIFJFTEVBU0VfTE9HX0ZBVUxUIGZvciBTUUxpdGUgQ2xhc3MgQSBmaWxlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NzYwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgaGF2ZSBhbGwg dGhlIGRhdGEgd2UgbmVlZCwgYW5kIHRoaXMgY3Jhc2ggaXMgaGFwcGVuaW5nIG1vcmUgdGhhbgor ICAgICAgICBleHBlY3RlZC4KKworICAgICAgICAqIHBsYXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFz ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTUUxpdGVEYXRhYmFzZTo6b3Blbik6CisKIDIwMTkt MDUtMDggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg SW1wbGVtZW50IGJhY2tpbmctc2hhcmluZyBpbiBjb21wb3NpdGluZyBsYXllcnMsIGFsbG93aW5n IG92ZXJsYXAgbGF5ZXJzIHRvIHBhaW50IGludG8gdGhlIGJhY2tpbmcgc3RvcmUgb2YgYW5vdGhl ciBsYXllcgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNl LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlRGF0 YWJhc2UuY3BwCShyZXZpc2lvbiAyNDUwNjEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9z cWwvU1FMaXRlRGF0YWJhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTAsOCArMTUwLDEwIEBA IGJvb2wgU1FMaXRlRGF0YWJhc2U6Om9wZW4oY29uc3QgU3RyaW5nJiAKICAgICAgICAgdXNlV0FM Sm91cm5hbE1vZGUoKTsKIAogICAgIFN0cmluZyBzaG1GaWxlTmFtZSA9IG1ha2VTdHJpbmcoZmls ZW5hbWUsICItc2htIl9zKTsKLSAgICBpZiAoRmlsZVN5c3RlbTo6ZmlsZUV4aXN0cyhzaG1GaWxl TmFtZSkpCi0gICAgICAgIFJFTEVBU0VfQVNTRVJUKEZpbGVTeXN0ZW06OmlzU2FmZVRvVXNlTWVt b3J5TWFwRm9yUGF0aChzaG1GaWxlTmFtZSkpOworICAgIGlmIChGaWxlU3lzdGVtOjpmaWxlRXhp c3RzKHNobUZpbGVOYW1lKSkgeworICAgICAgICBpZiAoIUZpbGVTeXN0ZW06OmlzU2FmZVRvVXNl TWVtb3J5TWFwRm9yUGF0aChzaG1GaWxlTmFtZSkpCisgICAgICAgICAgICBSRUxFQVNFX0xPR19G QVVMVChTUUxEYXRhYmFzZSwgIk9wZW5lZCBhbiBTUUxpdGUgZGF0YWJhc2Ugd2l0aCBhIENsYXNz IEEgLXNobSBmaWxlLiBUaGlzIHdpbGwgdHJpZ2dlciBhIGNyYXNoIHdoZW4gdGhlIHVzZXIgbG9j a3MgdGhlIGRldmljZS4gKCVzKSIsIHNobUZpbGVOYW1lLmxhdGluMSgpLmRhdGEoKSk7CisgICAg fQogCiAgICAgcmV0dXJuIGlzT3BlbigpOwogfQo= 369757 2019-05-13 11:43:59 -0700 2019-05-13 14:52:41 -0700 Patch bug-197760-20190513114359.patch text/plain 1633 ggaren SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NTI0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA1LTEzICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgRG93bmdyYWRlIFJFTEVBU0Vf QVNTRVJUIFRPIFJFTEVBU0VfTE9HX0ZBVUxUIGZvciBTUUxpdGUgQ2xhc3MgQSBmaWxlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NzYwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT25seSBtYWtlU2Fm ZVRvVXNlTWVtb3J5TWFwRm9yUGF0aCgpIGlmIG5lZWRlZC4gKEZpeGVkIG1pc3NpbmcgYnJhY2Uu KQorCisgICAgICAgICogcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlNRTGl0ZURhdGFiYXNlOjpvcGVuKToKKwogMjAxOS0wNS0xMyAgQW50dGkgS29p dmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI0NTIwOCk6 IGNvbXBvc2l0aW5nL3NoYXJlZC1iYWNraW5nL3NoYXJpbmctYm91bmRzLW5vbi1jbGlwcGluZy1z aGFyZWQtbGF5ZXIuaHRtbCBhc3NlcnRzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9z cWwvU1FMaXRlRGF0YWJhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5jcHAJKHJldmlzaW9uIDI0NTI0MikKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE1MSw5ICsxNTEsMTAgQEAgYm9vbCBTUUxpdGVEYXRhYmFzZTo6b3Blbihjb25zdCBTdHJpbmcm IAogCiAgICAgU3RyaW5nIHNobUZpbGVOYW1lID0gbWFrZVN0cmluZyhmaWxlbmFtZSwgIi1zaG0i X3MpOwogICAgIGlmIChGaWxlU3lzdGVtOjpmaWxlRXhpc3RzKHNobUZpbGVOYW1lKSkgewotICAg ICAgICBpZiAoIUZpbGVTeXN0ZW06OmlzU2FmZVRvVXNlTWVtb3J5TWFwRm9yUGF0aChzaG1GaWxl TmFtZSkpCisgICAgICAgIGlmICghRmlsZVN5c3RlbTo6aXNTYWZlVG9Vc2VNZW1vcnlNYXBGb3JQ YXRoKHNobUZpbGVOYW1lKSkgewogICAgICAgICAgICAgUkVMRUFTRV9MT0dfRkFVTFQoU1FMRGF0 YWJhc2UsICJPcGVuZWQgYW4gU1FMaXRlIGRhdGFiYXNlIHdpdGggYSBDbGFzcyBBIC1zaG0gZmls ZS4gVGhpcyBtYXkgdHJpZ2dlciBhIGNyYXNoIHdoZW4gdGhlIHVzZXIgbG9ja3MgdGhlIGRldmlj ZS4gKCVzKSIsIHNobUZpbGVOYW1lLmxhdGluMSgpLmRhdGEoKSk7CiAgICAgICAgICAgICBGaWxl U3lzdGVtOjptYWtlU2FmZVRvVXNlTWVtb3J5TWFwRm9yUGF0aChzaG1GaWxlTmFtZSk7CisgICAg ICAgIH0KICAgICB9CiAKICAgICByZXR1cm4gaXNPcGVuKCk7Cg==