197746 2019-05-09 11:27:24 -0700 [iOS] Lazily request keyboard on first hardware keydown when a non-editable element is focused 2019-07-15 14:26:32 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build iPhone / iPad iOS 12 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=197745 https://bugs.webkit.org/show_bug.cgi?id=199807 InRadar, PlatformOnly P2 Normal --- 190571 1 dbates dbates bfulgham ews-watchlist megan_gardner pvollan thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1534791 0 dbates 2019-05-09 11:27:24 -0700 In bug #197745 we made keyboard instantiation lazy: we always create one if a hardware keyboard is attached OR a content editable element is focused. We can be even lazier! Specifically the first disjunct can be even lazier. So, I think we only need to create a keyboard if any of the following are satisfied: a. a non-editable element is focused AND we receive *one* hardware keydown event. ii. Take care to reset this on hardware keyboard availability changes. Side note, we could even reduce memory footprint here by tearing down the keyboard here when switching from attached to detached ONLY in the non-editable element case. b. an editable element is focused (obvious, right?) 1534802 1 webkit-bug-importer 2019-05-09 11:42:50 -0700 <rdar://problem/50630406> 1534822 2 369511 dbates 2019-05-09 12:26:39 -0700 Created attachment 369511 Patch 1534823 3 369511 dbates 2019-05-09 12:27:30 -0700 Comment on attachment 369511 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369511&action=review > Source/WebKit/ChangeLog:10 > + Be even lazier. We only need to create a keyboard if an editable element is focused or on > + the first hardware keydown when a non-editable element is focused. Note that we already do the former. This patch is about the latter. 1534825 4 369512 dbates 2019-05-09 12:32:34 -0700 Created attachment 369512 Patch 1534826 5 ews-watchlist 2019-05-09 12:33:42 -0700 Attachment 369512 did not pass style-queue: ERROR: Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1673: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1534829 6 369512 bfulgham 2019-05-09 12:38:32 -0700 Comment on attachment 369512 Patch r=me 1534846 7 369519 dbates 2019-05-09 13:18:06 -0700 Created attachment 369519 To Land 1534847 8 369519 dbates 2019-05-09 13:18:48 -0700 Comment on attachment 369519 To Land Clearing flags on attachment: 369519 Committed r245154: <https://trac.webkit.org/changeset/245154> 1534848 9 dbates 2019-05-09 13:18:49 -0700 All reviewed patches have been landed. Closing bug. 369511 2019-05-09 12:26:39 -0700 2019-05-09 12:32:33 -0700 Patch bug-197746-20190509122638.patch text/plain 3988 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYwM2UxMDczMWVmYzNkYjgz NGU4NDFlMGRkM2UxNWJkNmE1Njc1ZTEuLjljOGM5YTYxYTMyNGYzOTcxMjVmMzNhZjJlZDc5YTVk OTQ3MDk2OTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTktMDUtMDkgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIExhemlseSByZXF1ZXN0 IGtleWJvYXJkIG9uIGZpcnN0IGhhcmR3YXJlIGtleWRvd24gd2hlbiBhIG5vbi1lZGl0YWJsZSBl bGVtZW50IGlzIGZvY3VzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5Nzc0NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTA2MzA0MDY+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmUgZXZlbiBsYXpp ZXIuIFdlIG9ubHkgbmVlZCB0byBjcmVhdGUgYSBrZXlib2FyZCBpZiBhbiBlZGl0YWJsZSBlbGVt ZW50IGlzIGZvY3VzZWQgb3Igb24KKyAgICAgICAgdGhlIGZpcnN0IGhhcmR3YXJlIGtleWRvd24g d2hlbiBhIG5vbi1lZGl0YWJsZSBlbGVtZW50IGlzIGZvY3VzZWQuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oOgorICAgICAgICAqIFVJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRW aWV3IGNsZWFudXBJbnRlcmFjdGlvbl0pOiBSZXNldCBib29ra2VlcGluZy4KKyAgICAgICAgKC1b V0tDb250ZW50VmlldyBfcmVxdWlyZXNLZXlib2FyZFdoZW5GaXJzdFJlc3BvbmRlcl0pOiBGdXJ0 aGVyIGNvbmRpdGlvbiB0aGUgcmVzdWx0IG9uCisgICAgICAgIHdoZXRoZXIgd2UgaGF2ZSBzZWVu IGEgaGFyZHdhcmUga2V5ZG93biBldmVudCBpbiBhIG5vbi1lZGl0YWJsZSBlbGVtZW50LgorICAg ICAgICAoLVtXS0NvbnRlbnRWaWV3IF9oYW5kbGVLZXlVSUV2ZW50Ol0pOiBJZiB0aGlzIGlzIHRo ZSBmaXJzdCBoYXJkd2FyZSBrZXkgZXZlbnQgd2UndmUgc2VlbiB0aGVuCisgICAgICAgIHVwZGF0 ZSBzdGF0ZSBhbmQgY2FsbCAtcmVsb2FkSW5wdXRWaWV3LiAtcmVsb2FkSW5wdXRWaWV3IHdpbGwg Y2FsbCB1cyBiYWNrIGluIC1fcmVxdWlyZXNLZXlib2FyZFdoZW5GaXJzdFJlc3BvbmRlcgorICAg ICAgICBhbmQgd2Ugd2lsbCBub3cgcmV0dXJuIFlFUy4gU28sIGl0IHdpbGwgY3JlYXRlIHRoZSBr ZXlib2FyZC4KKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfaGFyZHdhcmVLZXlib2FyZEF2YWls YWJpbGl0eUNoYW5nZWRdKTogUmVzZXQgYm9va2tlZXBpbmcuCisKIDIwMTktMDUtMDkgIERhbmll bCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyNDE3 MzQpOiAxJSBzbG93ZXIgUExUIG9uIGlQYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaCBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaAppbmRleCA0YWVkMWE4Y2E1MjBh ZTNlYzZhODYxYzI1N2NkMzM2Y2Y1YTA4NjhlLi4wMTY0ZDJlM2JjZjNmZTBiMzEzMDJmMTUzNzJi MGE1Mjc1M2M2MjQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlld0ludGVyYWN0aW9uLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9z L1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oCkBAIC0zMjUsNiArMzI1LDcgQEAgc3RydWN0IFdL QXV0b0NvcnJlY3Rpb25EYXRhIHsKIAogI2lmIFVTRShVSUtJVF9LRVlCT0FSRF9BRERJVElPTlMp CiAgICAgQk9PTCBfY2FuZGlkYXRlVmlld05lZWRzVXBkYXRlOworICAgIEJPT0wgX3NlZW5IYXJk d2FyZUtleURvd25Jbk5vbkVkaXRhYmxlRWxlbWVudDsKICNlbmRpZgogCiAgICAgQk9PTCBfYmVj b21pbmdGaXJzdFJlc3BvbmRlcjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IGI2YzRkODU4OGQ3MjhlNDlh ZWI2YzhjNjMzYjNjMTk1OTgwNDk1YWYuLjhkNzZjOGExYWUxOWI2YjQxYzY2MDdkYzlhZmMzMTQ1 ZmU1ZDk5NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtODM1LDYgKzgzNSw3IEBAIC0gKHZvaWQpY2xl YW51cEludGVyYWN0aW9uCiAKICNpZiBVU0UoVUlLSVRfS0VZQk9BUkRfQURESVRJT05TKQogICAg IF9jYW5kaWRhdGVWaWV3TmVlZHNVcGRhdGUgPSBOTzsKKyAgICBfc2VlbkhhcmR3YXJlS2V5RG93 bkluTm9uRWRpdGFibGVFbGVtZW50ID0gTk87CiAjZW5kaWYKIAogICAgIGlmIChfaW50ZXJhY3Rp b25WaWV3c0NvbnRhaW5lclZpZXcpIHsKQEAgLTE2NDYsMTQgKzE2NDcsOCBAQCAtIChCT09MKV9k aXNhYmxlQXV0b21hdGljS2V5Ym9hcmRVSQogCiAtIChCT09MKV9yZXF1aXJlc0tleWJvYXJkV2hl bkZpcnN0UmVzcG9uZGVyCiB7Ci0gICAgLy8gRklYTUU6IE9ubHkgY3JlYXRlIGtleWJvYXJkIGlm IFtzZWxmIHNob3VsZFNob3dBdXRvbWF0aWNLZXlib2FyZFVJXSByZXR1cm5zIFlFUyBvcgotICAg IC8vIG9uIGZpcnN0IGhhcmR3YXJlIGtleWRvd24gaW4gYSBub24tZWRpdGFibGUgZWxlbWVudC4g U2VlIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NzQ2Pi4KLSNp ZiBVU0UoVUlLSVRfS0VZQk9BUkRfQURESVRJT05TKQotICAgIGlmIChHU0V2ZW50SXNIYXJkd2Fy ZUtleWJvYXJkQXR0YWNoZWQoKSkKLSAgICAgICAgcmV0dXJuIFlFUzsKLSNlbmRpZgogICAgIC8v IEZJWE1FOiBXZSBzaG91bGQgYWRkIHRoZSBsb2dpYyB0byBoYW5kbGUga2V5Ym9hcmQgdmlzaWJp bGl0eSBkdXJpbmcgZm9jdXMgcmVkaXJlY3RzLgotICAgIHJldHVybiBbc2VsZiBzaG91bGRTaG93 QXV0b21hdGljS2V5Ym9hcmRVSV07CisgICAgcmV0dXJuIFtzZWxmIHNob3VsZFNob3dBdXRvbWF0 aWNLZXlib2FyZFVJXSB8fCBfc2VlbkhhcmR3YXJlS2V5RG93bkluTm9uRWRpdGFibGVFbGVtZW50 OwogfQogCiAtIChCT09MKV9yZXF1aXJlc0tleWJvYXJkUmVzZXRPblJlbG9hZApAQCAtNDQ2MCw2 ICs0NDU1LDEwIEBAIC0gKHZvaWQpX2hhbmRsZUtleVVJRXZlbnQ6KDo6VUlFdmVudCAqKWV2ZW50 CiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAjaWYgVVNFKFVJS0lUX0tFWUJP QVJEX0FERElUSU9OUykKKyAgICAgICAgaWYgKCFfc2VlbkhhcmR3YXJlS2V5RG93bkluTm9uRWRp dGFibGVFbGVtZW50KSB7CisgICAgICAgICAgICBfc2VlbkhhcmR3YXJlS2V5RG93bkluTm9uRWRp dGFibGVFbGVtZW50ID0gWUVTOworICAgICAgICAgICAgW3NlbGYgcmVsb2FkSW5wdXRWaWV3c107 CisgICAgICAgIH0KICAgICAgICAgW3N1cGVyIF9oYW5kbGVLZXlVSUV2ZW50OmV2ZW50XTsKICNl bHNlCiAgICAgICAgIFtzZWxmIGhhbmRsZUtleUV2ZW50OmV2ZW50XTsKQEAgLTUxODQsNiArNTE4 Myw3IEBAIC0gKHZvaWQpX2VsZW1lbnREaWRCbHVyCiAKIC0gKHZvaWQpX2hhcmR3YXJlS2V5Ym9h cmRBdmFpbGFiaWxpdHlDaGFuZ2VkCiB7CisgICAgX3NlZW5IYXJkd2FyZUtleURvd25Jbk5vbkVk aXRhYmxlRWxlbWVudCA9IE5POwogICAgIFtzZWxmIHJlbG9hZElucHV0Vmlld3NdOwogfQogCg== 369512 2019-05-09 12:32:34 -0700 2019-05-09 13:18:04 -0700 Patch bug-197746-20190509123233.patch text/plain 4164 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYwM2UxMDczMWVmYzNkYjgz NGU4NDFlMGRkM2UxNWJkNmE1Njc1ZTEuLmVmYTkzYWJlNWJjODUyMjVhZGRkM2Y2YzFkMzI5YmQ4 NTVmODljNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTktMDUtMDkgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIExhemlseSByZXF1ZXN0 IGtleWJvYXJkIG9uIGZpcnN0IGhhcmR3YXJlIGtleWRvd24gd2hlbiBhIG5vbi1lZGl0YWJsZSBl bGVtZW50IGlzIGZvY3VzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5Nzc0NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTA2MzA0MDY+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmUgZXZlbiBsYXpp ZXIuIFdlIG9ubHkgbmVlZCB0byBjcmVhdGUgYSBrZXlib2FyZCBpZiBhbiBlZGl0YWJsZSBlbGVt ZW50IGlzIGZvY3VzZWQgb3Igb24KKyAgICAgICAgdGhlIGZpcnN0IGhhcmR3YXJlIGtleWRvd24g d2hlbiBhIG5vbi1lZGl0YWJsZSBlbGVtZW50IGlzIGZvY3VzZWQuIFdlIGN1cnJlbnRseSBkbyB0 aGUgZm9ybWVyLgorICAgICAgICBMZXQncyBhbHNvIGRvIHRoZSBsYXR0ZXIuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oOgorICAgICAgICAqIFVJ UHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0Nv bnRlbnRWaWV3IGNsZWFudXBJbnRlcmFjdGlvbl0pOiBSZXNldCBib29ra2VlcGluZy4KKyAgICAg ICAgKC1bV0tDb250ZW50VmlldyBfcmVxdWlyZXNLZXlib2FyZFdoZW5GaXJzdFJlc3BvbmRlcl0p OiBGdXJ0aGVyIGNvbmRpdGlvbiB0aGUgcmVzdWx0IG9uCisgICAgICAgIHdoZXRoZXIgd2UgaGF2 ZSBzZWVuIGEgaGFyZHdhcmUga2V5ZG93biBldmVudCBpbiBhIG5vbi1lZGl0YWJsZSBlbGVtZW50 LgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9oYW5kbGVLZXlVSUV2ZW50Ol0pOiBJZiB0aGlz IGlzIHRoZSBmaXJzdCBoYXJkd2FyZSBrZXkgZXZlbnQgd2UndmUgc2VlbiB0aGVuCisgICAgICAg IHVwZGF0ZSBzdGF0ZSBhbmQgY2FsbCAtcmVsb2FkSW5wdXRWaWV3LiAtcmVsb2FkSW5wdXRWaWV3 IHdpbGwgY2FsbCB1cyBiYWNrIGluIC1fcmVxdWlyZXNLZXlib2FyZFdoZW5GaXJzdFJlc3BvbmRl cgorICAgICAgICBhbmQgd2Ugd2lsbCBub3cgcmV0dXJuIFlFUy4gU28sIGl0IHdpbGwgY3JlYXRl IHRoZSBrZXlib2FyZC4KKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfaGFyZHdhcmVLZXlib2Fy ZEF2YWlsYWJpbGl0eUNoYW5nZWRdKTogUmVzZXQgYm9va2tlZXBpbmcuCisKIDIwMTktMDUtMDkg IERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04g KHIyNDE3MzQpOiAxJSBzbG93ZXIgUExUIG9uIGlQYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaCBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaAppbmRleCA0YWVkMWE4 Y2E1MjBhZTNlYzZhODYxYzI1N2NkMzM2Y2Y1YTA4NjhlLi4wMTY0ZDJlM2JjZjNmZTBiMzEzMDJm MTUzNzJiMGE1Mjc1M2M2MjQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9p b3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oCkBAIC0zMjUsNiArMzI1LDcgQEAgc3Ry dWN0IFdLQXV0b0NvcnJlY3Rpb25EYXRhIHsKIAogI2lmIFVTRShVSUtJVF9LRVlCT0FSRF9BRERJ VElPTlMpCiAgICAgQk9PTCBfY2FuZGlkYXRlVmlld05lZWRzVXBkYXRlOworICAgIEJPT0wgX3Nl ZW5IYXJkd2FyZUtleURvd25Jbk5vbkVkaXRhYmxlRWxlbWVudDsKICNlbmRpZgogCiAgICAgQk9P TCBfYmVjb21pbmdGaXJzdFJlc3BvbmRlcjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IGI2YzRkODU4OGQ3 MjhlNDlhZWI2YzhjNjMzYjNjMTk1OTgwNDk1YWYuLjcyYWM1ZjExOGQxZjY4ZjA2ODFmYzMwYjJk OTJhYjI5YzRiNjczODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9X S0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtODM1LDYgKzgzNSw3IEBAIC0gKHZv aWQpY2xlYW51cEludGVyYWN0aW9uCiAKICNpZiBVU0UoVUlLSVRfS0VZQk9BUkRfQURESVRJT05T KQogICAgIF9jYW5kaWRhdGVWaWV3TmVlZHNVcGRhdGUgPSBOTzsKKyAgICBfc2VlbkhhcmR3YXJl S2V5RG93bkluTm9uRWRpdGFibGVFbGVtZW50ID0gTk87CiAjZW5kaWYKIAogICAgIGlmIChfaW50 ZXJhY3Rpb25WaWV3c0NvbnRhaW5lclZpZXcpIHsKQEAgLTE2NDYsMTQgKzE2NDcsMTIgQEAgLSAo Qk9PTClfZGlzYWJsZUF1dG9tYXRpY0tleWJvYXJkVUkKIAogLSAoQk9PTClfcmVxdWlyZXNLZXli b2FyZFdoZW5GaXJzdFJlc3BvbmRlcgogewotICAgIC8vIEZJWE1FOiBPbmx5IGNyZWF0ZSBrZXli b2FyZCBpZiBbc2VsZiBzaG91bGRTaG93QXV0b21hdGljS2V5Ym9hcmRVSV0gcmV0dXJucyBZRVMg b3IKLSAgICAvLyBvbiBmaXJzdCBoYXJkd2FyZSBrZXlkb3duIGluIGEgbm9uLWVkaXRhYmxlIGVs ZW1lbnQuIFNlZSA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Nzc0 Nj4uCisgICAgLy8gRklYTUU6IFdlIHNob3VsZCBhZGQgdGhlIGxvZ2ljIHRvIGhhbmRsZSBrZXli b2FyZCB2aXNpYmlsaXR5IGR1cmluZyBmb2N1cyByZWRpcmVjdHMuCisgICAgcmV0dXJuIFtzZWxm IHNob3VsZFNob3dBdXRvbWF0aWNLZXlib2FyZFVJXQogI2lmIFVTRShVSUtJVF9LRVlCT0FSRF9B RERJVElPTlMpCi0gICAgaWYgKEdTRXZlbnRJc0hhcmR3YXJlS2V5Ym9hcmRBdHRhY2hlZCgpKQot ICAgICAgICByZXR1cm4gWUVTOworICAgICAgICB8fCBfc2VlbkhhcmR3YXJlS2V5RG93bkluTm9u RWRpdGFibGVFbGVtZW50CiAjZW5kaWYKLSAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGFkZCB0aGUg bG9naWMgdG8gaGFuZGxlIGtleWJvYXJkIHZpc2liaWxpdHkgZHVyaW5nIGZvY3VzIHJlZGlyZWN0 cy4KLSAgICByZXR1cm4gW3NlbGYgc2hvdWxkU2hvd0F1dG9tYXRpY0tleWJvYXJkVUldOworICAg ICAgICA7CiB9CiAKIC0gKEJPT0wpX3JlcXVpcmVzS2V5Ym9hcmRSZXNldE9uUmVsb2FkCkBAIC00 NDYwLDYgKzQ0NTksMTAgQEAgLSAodm9pZClfaGFuZGxlS2V5VUlFdmVudDooOjpVSUV2ZW50ICop ZXZlbnQKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICNpZiBVU0UoVUlLSVRf S0VZQk9BUkRfQURESVRJT05TKQorICAgICAgICBpZiAoIV9zZWVuSGFyZHdhcmVLZXlEb3duSW5O b25FZGl0YWJsZUVsZW1lbnQpIHsKKyAgICAgICAgICAgIF9zZWVuSGFyZHdhcmVLZXlEb3duSW5O b25FZGl0YWJsZUVsZW1lbnQgPSBZRVM7CisgICAgICAgICAgICBbc2VsZiByZWxvYWRJbnB1dFZp ZXdzXTsKKyAgICAgICAgfQogICAgICAgICBbc3VwZXIgX2hhbmRsZUtleVVJRXZlbnQ6ZXZlbnRd OwogI2Vsc2UKICAgICAgICAgW3NlbGYgaGFuZGxlS2V5RXZlbnQ6ZXZlbnRdOwpAQCAtNTE4NCw2 ICs1MTg3LDcgQEAgLSAodm9pZClfZWxlbWVudERpZEJsdXIKIAogLSAodm9pZClfaGFyZHdhcmVL ZXlib2FyZEF2YWlsYWJpbGl0eUNoYW5nZWQKIHsKKyAgICBfc2VlbkhhcmR3YXJlS2V5RG93bklu Tm9uRWRpdGFibGVFbGVtZW50ID0gTk87CiAgICAgW3NlbGYgcmVsb2FkSW5wdXRWaWV3c107CiB9 CiAK 369519 2019-05-09 13:18:06 -0700 2019-05-09 13:18:06 -0700 To Land bug-197746-20190509131805.patch text/plain 4206 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYwM2UxMDczMWVmYzNkYjgz NGU4NDFlMGRkM2UxNWJkNmE1Njc1ZTEuLjgwYmMxYjZiNTY0NTcwYWQyZTNiYzYyNWYxNWQ2N2Qy N2JkMmRlOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTktMDUtMDkgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIExhemlseSByZXF1ZXN0 IGtleWJvYXJkIG9uIGZpcnN0IGhhcmR3YXJlIGtleWRvd24gd2hlbiBhIG5vbi1lZGl0YWJsZSBl bGVtZW50IGlzIGZvY3VzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5Nzc0NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTA2MzA0MDY+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgQnJlbnQgRnVsZ2hhbS4KKworICAgICAgICBCZSBldmVuIGxhemll ci4gV2Ugb25seSBuZWVkIHRvIGNyZWF0ZSBhIGtleWJvYXJkIGlmIGFuIGVkaXRhYmxlIGVsZW1l bnQgaXMgZm9jdXNlZCBvciBvbgorICAgICAgICB0aGUgZmlyc3QgaGFyZHdhcmUga2V5ZG93biB3 aGVuIGEgbm9uLWVkaXRhYmxlIGVsZW1lbnQgaXMgZm9jdXNlZC4gV2UgY3VycmVudGx5IGRvIHRo ZSBmb3JtZXIuCisgICAgICAgIExldCdzIGFsc28gZG8gdGhlIGxhdHRlci4KKworICAgICAgICAq IFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmg6CisgICAgICAgICogVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29u dGVudFZpZXcgY2xlYW51cEludGVyYWN0aW9uXSk6IFJlc2V0IGJvb2trZWVwaW5nLgorICAgICAg ICAoLVtXS0NvbnRlbnRWaWV3IF9yZXF1aXJlc0tleWJvYXJkV2hlbkZpcnN0UmVzcG9uZGVyXSk6 IEZ1cnRoZXIgY29uZGl0aW9uIHRoZSByZXN1bHQgb24KKyAgICAgICAgd2hldGhlciB3ZSBoYXZl IHNlZW4gYSBoYXJkd2FyZSBrZXlkb3duIGV2ZW50IGluIGEgbm9uLWVkaXRhYmxlIGVsZW1lbnQu CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX2hhbmRsZUtleVVJRXZlbnQ6XSk6IElmIHRoaXMg aXMgdGhlIGZpcnN0IGhhcmR3YXJlIGtleSBldmVudCB3ZSd2ZSBzZWVuIHRoZW4KKyAgICAgICAg dXBkYXRlIHN0YXRlIGFuZCBjYWxsIC1yZWxvYWRJbnB1dFZpZXcuIC1yZWxvYWRJbnB1dFZpZXcg d2lsbCBjYWxsIHVzIGJhY2sgaW4gLV9yZXF1aXJlc0tleWJvYXJkV2hlbkZpcnN0UmVzcG9uZGVy CisgICAgICAgIGFuZCB3ZSB3aWxsIG5vdyByZXR1cm4gWUVTLiBTbywgaXQgd2lsbCBjcmVhdGUg dGhlIGtleWJvYXJkLgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9oYXJkd2FyZUtleWJvYXJk QXZhaWxhYmlsaXR5Q2hhbmdlZF0pOiBSZXNldCBib29ra2VlcGluZy4KKwogMjAxOS0wNS0wOSAg RGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAo cjI0MTczNCk6IDElIHNsb3dlciBQTFQgb24gaVBhZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oCmluZGV4IDRhZWQxYThj YTUyMGFlM2VjNmE4NjFjMjU3Y2QzMzZjZjVhMDg2OGUuLjAxNjRkMmUzYmNmM2ZlMGIzMTMwMmYx NTM3MmIwYTUyNzUzYzYyNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmgKQEAgLTMyNSw2ICszMjUsNyBAQCBzdHJ1 Y3QgV0tBdXRvQ29ycmVjdGlvbkRhdGEgewogCiAjaWYgVVNFKFVJS0lUX0tFWUJPQVJEX0FERElU SU9OUykKICAgICBCT09MIF9jYW5kaWRhdGVWaWV3TmVlZHNVcGRhdGU7CisgICAgQk9PTCBfc2Vl bkhhcmR3YXJlS2V5RG93bkluTm9uRWRpdGFibGVFbGVtZW50OwogI2VuZGlmCiAKICAgICBCT09M IF9iZWNvbWluZ0ZpcnN0UmVzcG9uZGVyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggYjZjNGQ4NTg4ZDcy OGU0OWFlYjZjOGM2MzNiM2MxOTU5ODA0OTVhZi4uZGIzZmYwZjEzMDE1MjMzYWQ3OWJhMTQ1ZTJj NDNkZGY5NGUyZGEyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9p b3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC04MzUsNiArODM1LDcgQEAgLSAodm9p ZCljbGVhbnVwSW50ZXJhY3Rpb24KIAogI2lmIFVTRShVSUtJVF9LRVlCT0FSRF9BRERJVElPTlMp CiAgICAgX2NhbmRpZGF0ZVZpZXdOZWVkc1VwZGF0ZSA9IE5POworICAgIF9zZWVuSGFyZHdhcmVL ZXlEb3duSW5Ob25FZGl0YWJsZUVsZW1lbnQgPSBOTzsKICNlbmRpZgogCiAgICAgaWYgKF9pbnRl cmFjdGlvblZpZXdzQ29udGFpbmVyVmlldykgewpAQCAtMTY0NiwxNCArMTY0NywxMiBAQCAtIChC T09MKV9kaXNhYmxlQXV0b21hdGljS2V5Ym9hcmRVSQogCiAtIChCT09MKV9yZXF1aXJlc0tleWJv YXJkV2hlbkZpcnN0UmVzcG9uZGVyCiB7Ci0gICAgLy8gRklYTUU6IE9ubHkgY3JlYXRlIGtleWJv YXJkIGlmIFtzZWxmIHNob3VsZFNob3dBdXRvbWF0aWNLZXlib2FyZFVJXSByZXR1cm5zIFlFUyBv cgotICAgIC8vIG9uIGZpcnN0IGhhcmR3YXJlIGtleWRvd24gaW4gYSBub24tZWRpdGFibGUgZWxl bWVudC4gU2VlIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NzQ2 Pi4KKyAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGFkZCB0aGUgbG9naWMgdG8gaGFuZGxlIGtleWJv YXJkIHZpc2liaWxpdHkgZHVyaW5nIGZvY3VzIHJlZGlyZWN0cy4KKyAgICByZXR1cm4gW3NlbGYg c2hvdWxkU2hvd0F1dG9tYXRpY0tleWJvYXJkVUldCiAjaWYgVVNFKFVJS0lUX0tFWUJPQVJEX0FE RElUSU9OUykKLSAgICBpZiAoR1NFdmVudElzSGFyZHdhcmVLZXlib2FyZEF0dGFjaGVkKCkpCi0g ICAgICAgIHJldHVybiBZRVM7CisgICAgICAgIHx8IF9zZWVuSGFyZHdhcmVLZXlEb3duSW5Ob25F ZGl0YWJsZUVsZW1lbnQKICNlbmRpZgotICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgYWRkIHRoZSBs b2dpYyB0byBoYW5kbGUga2V5Ym9hcmQgdmlzaWJpbGl0eSBkdXJpbmcgZm9jdXMgcmVkaXJlY3Rz LgotICAgIHJldHVybiBbc2VsZiBzaG91bGRTaG93QXV0b21hdGljS2V5Ym9hcmRVSV07CisgICAg ICAgIDsKIH0KIAogLSAoQk9PTClfcmVxdWlyZXNLZXlib2FyZFJlc2V0T25SZWxvYWQKQEAgLTQ0 NjAsNiArNDQ1OSwxMCBAQCAtICh2b2lkKV9oYW5kbGVLZXlVSUV2ZW50Oig6OlVJRXZlbnQgKill dmVudAogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogI2lmIFVTRShVSUtJVF9L RVlCT0FSRF9BRERJVElPTlMpCisgICAgICAgIGlmICghX3NlZW5IYXJkd2FyZUtleURvd25Jbk5v bkVkaXRhYmxlRWxlbWVudCkgeworICAgICAgICAgICAgX3NlZW5IYXJkd2FyZUtleURvd25Jbk5v bkVkaXRhYmxlRWxlbWVudCA9IFlFUzsKKyAgICAgICAgICAgIFtzZWxmIHJlbG9hZElucHV0Vmll d3NdOworICAgICAgICB9CiAgICAgICAgIFtzdXBlciBfaGFuZGxlS2V5VUlFdmVudDpldmVudF07 CiAjZWxzZQogICAgICAgICBbc2VsZiBoYW5kbGVLZXlFdmVudDpldmVudF07CkBAIC01MTg0LDYg KzUxODcsOSBAQCAtICh2b2lkKV9lbGVtZW50RGlkQmx1cgogCiAtICh2b2lkKV9oYXJkd2FyZUtl eWJvYXJkQXZhaWxhYmlsaXR5Q2hhbmdlZAogeworI2lmIFVTRShVSUtJVF9LRVlCT0FSRF9BRERJ VElPTlMpCisgICAgX3NlZW5IYXJkd2FyZUtleURvd25Jbk5vbkVkaXRhYmxlRWxlbWVudCA9IE5P OworI2VuZGlmCiAgICAgW3NlbGYgcmVsb2FkSW5wdXRWaWV3c107CiB9CiAK