197745 2019-05-09 11:15:57 -0700 REGRESSION (r241734): 1% slower PLT on iPad 2019-05-09 11:58:50 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build iPhone / iPad iOS 12 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=197746 InRadar, PlatformOnly, Regression P2 Normal --- 192824 190571 1 dbates dbates bfulgham pvollan webkit-bug-importer oldest_to_newest 1534787 0 dbates 2019-05-09 11:15:57 -0700 When building with USE(UIKIT_KEYBOARD_ADDITIONS) enabled and following r241734 we now always request a keyboard when WKContentView becomes first responder as we have one key event handling code path. As it turns out this is expensive enough the cause an ~1% slowdown in PLT on iPad. 1534792 1 dbates 2019-05-09 11:28:36 -0700 Have a patch that regains the ~1% loss by lazily requesting keyboard instantiation immediately only if we have a hardware keyboard attached. Better fix is to be even lazier: only on first hardware keydown. We'll do this in another bug to spread out the risk and because we (Apple) wants this fix sooner. See bug #197746. 1534799 2 dbates 2019-05-09 11:41:35 -0700 <rdar://problem/50457731> 1534801 3 369503 dbates 2019-05-09 11:42:24 -0700 Created attachment 369503 Patch 1534808 4 369503 pvollan 2019-05-09 11:54:51 -0700 Comment on attachment 369503 Patch Great work, Dan! R=me. 1534809 5 369503 dbates 2019-05-09 11:58:48 -0700 Comment on attachment 369503 Patch Clearing flags on attachment: 369503 Committed r245148: <https://trac.webkit.org/changeset/245148> 1534810 6 dbates 2019-05-09 11:58:50 -0700 All reviewed patches have been landed. Closing bug. 369503 2019-05-09 11:42:24 -0700 2019-05-09 11:58:48 -0700 Patch bug-197745-20190509114223.patch text/plain 3296 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU2NTIxN2I5OTZkYzE5MTYy Y2Y2YjFjNjNlNmNmNzRiNjk2YzY3OTAuLmYwM2UxMDczMWVmYzNkYjgzNGU4NDFlMGRkM2UxNWJk NmE1Njc1ZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTktMDUtMDkgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNDE3MzQp OiAxJSBzbG93ZXIgUExUIG9uIGlQYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5Nzc0NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTA0NTc3MzE+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIG5v dywgb25seSBjcmVhdGUgYSBrZXlib2FyZCB3aGVuIFdLQ29udGVudFZpZXcgYmVjb21lcyBmaXJz dCByZXNwb25kZXIgaWYgYSBoYXJkd2FyZSBrZXlib2FyZAorICAgICAgICBpcyBhdHRhY2hlZCBv ciBhbiBlZGl0YWJsZSBlbGVtZW50IGlzIGZvY3VzZWQgdG8gcmVjb3ZlciB0aGUgMSUgbG9zcyB3 aGVuIGEga2V5Ym9hcmQgaXMgbm90IGF0dGFjaGVkLgorICAgICAgICBXZSBjYW4gZG8gYmV0dGVy IGFuZCBieSB0aGF0IEkgbWVhbiBiZSBsYXppZXIuIFdlJ2xsIGRvIHRoaXMgPGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc3NDY+LgorCisgICAgICAgIEluIHIyNDE3 MzQgd2UgdW5pZmllZCB0aGUga2V5IGV2ZW50IGhhbmRsaW5nIGNvZGUgcGF0aHMgc28gd2UgdXNl IGV4YWN0bHkgb25lIGZvciBib3RoIHNvZnR3YXJlIGFuZAorICAgICAgICBoYXJkd2FyZSBrZXkg ZXZlbnRzLiBXZSB0b29rIGEgc2ltcGxlIGFwcHJvYWNoIG9mIGFsd2F5cyByZXF1ZXN0aW5nIFVJ S2l0IHRvIGNyZWF0ZSBhIGtleWJvYXJkIHdoZW4KKyAgICAgICAgdGhlIFdLQ29udGVudFZpZXcg YmVjb21lcyBmaXJzdCByZXNwb25kZXIuIFdlIGRpZCB0aGlzIHNvIHRoYXQgd2UgY291bGQgY29u dGludWUgbGlzdGVuaW5nIGZvciBoYXJkd2FyZQorICAgICAgICBrZXkgZXZlbnRzIGV2ZW4gd2hl biBhIG5vbi1lZGl0YWJsZSBlbGVtZW50IGlzIGZvY3VzZWQgYW5kIGRpc3BhdGNoIERPTSBldmVu dHMuIEFzIGl0IHR1cm5zIG91dCwgYWx3YXlzCisgICAgICAgIGNyZWF0aW5nIGEga2V5Ym9hcmQg aXMgZXhwZW5zaXZlIGFuZCBjYXVzZWQgYSB+MSUgc2xvd2Rvd24gaW4gcGFnZSBsb2FkIHRpbWUg b24gaVBhZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9yZXF1aXJlc0tleWJvYXJkV2hlbkZp cnN0UmVzcG9uZGVyXSk6IE9ubHkgY3JlYXRlIGEga2V5Ym9hcmQgaWYgYSBoYXJkd2FyZSBrZXli b2FyZCBpcworICAgICAgICBhdHRhY2hlZCBvciBhbiBlZGl0YWJsZSBlbGVtZW50IGlzIGZvY3Vz ZWQuCisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX2hhcmR3YXJlS2V5Ym9hcmRBdmFpbGFiaWxp dHlDaGFuZ2VkXSk6IFJlbG9hZCBhbGwgaW5wdXQgdmlldyAodGhpcyB3aWxsIGNhdXNlIGtleWJv YXJkCisgICAgICAgIGNyZWF0aW9uKSBpZiAtX3JlcXVpcmVzS2V5Ym9hcmRXaGVuRmlyc3RSZXNw b25kZXIgcmV0dXJucyBZRVMuCisKIDIwMTktMDUtMDggIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNA YXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFVuYWJsZSB0byBjb21taXQgc2VhcmNoIG9uIE1T Ti5jb20sIHFxLmNvbSwgb3Igc2luYS5jb20uY24gdXNpbmcgZW50ZXIga2V5IChoYXJkd2FyZSBv ciBzb2Z0d2FyZSBrZXlib2FyZCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDBkZTZlYjMxMDgzMTM2MWY4 NTU2ODI4ZDJlOTE1MDk1Yzc3MDdjZTkuLmI2YzRkODU4OGQ3MjhlNDlhZWI2YzhjNjMzYjNjMTk1 OTgwNDk1YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtMTY0NiwxMiArMTY0NiwxNCBAQCAtIChCT09M KV9kaXNhYmxlQXV0b21hdGljS2V5Ym9hcmRVSQogCiAtIChCT09MKV9yZXF1aXJlc0tleWJvYXJk V2hlbkZpcnN0UmVzcG9uZGVyCiB7CisgICAgLy8gRklYTUU6IE9ubHkgY3JlYXRlIGtleWJvYXJk IGlmIFtzZWxmIHNob3VsZFNob3dBdXRvbWF0aWNLZXlib2FyZFVJXSByZXR1cm5zIFlFUyBvcgor ICAgIC8vIG9uIGZpcnN0IGhhcmR3YXJlIGtleWRvd24gaW4gYSBub24tZWRpdGFibGUgZWxlbWVu dC4gU2VlIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk3NzQ2Pi4K ICNpZiBVU0UoVUlLSVRfS0VZQk9BUkRfQURESVRJT05TKQotICAgIHJldHVybiBZRVM7Ci0jZWxz ZQorICAgIGlmIChHU0V2ZW50SXNIYXJkd2FyZUtleWJvYXJkQXR0YWNoZWQoKSkKKyAgICAgICAg cmV0dXJuIFlFUzsKKyNlbmRpZgogICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgYWRkIHRoZSBsb2dp YyB0byBoYW5kbGUga2V5Ym9hcmQgdmlzaWJpbGl0eSBkdXJpbmcgZm9jdXMgcmVkaXJlY3RzLgog ICAgIHJldHVybiBbc2VsZiBzaG91bGRTaG93QXV0b21hdGljS2V5Ym9hcmRVSV07Ci0jZW5kaWYK IH0KIAogLSAoQk9PTClfcmVxdWlyZXNLZXlib2FyZFJlc2V0T25SZWxvYWQKQEAgLTUxODIsOCAr NTE4NCw3IEBAIC0gKHZvaWQpX2VsZW1lbnREaWRCbHVyCiAKIC0gKHZvaWQpX2hhcmR3YXJlS2V5 Ym9hcmRBdmFpbGFiaWxpdHlDaGFuZ2VkCiB7Ci0gICAgaWYgKGhhc0ZvY3VzZWRFbGVtZW50KF9m b2N1c2VkRWxlbWVudEluZm9ybWF0aW9uKSAmJiBfZm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbi5p bnB1dE1vZGUgPT0gV2ViQ29yZTo6SW5wdXRNb2RlOjpOb25lKQotICAgICAgICBbc2VsZiByZWxv YWRJbnB1dFZpZXdzXTsKKyAgICBbc2VsZiByZWxvYWRJbnB1dFZpZXdzXTsKIH0KIAogLSAodm9p ZClfZGlkVXBkYXRlSW5wdXRNb2RlOihXZWJDb3JlOjpJbnB1dE1vZGUpbW9kZQo=