197737 2019-05-09 06:02:31 -0700 [ews-build] Fix formatting issues and typos 2019-05-09 10:19:26 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain commit-queue jbedard lforschler webkit-bug-importer oldest_to_newest 1534716 0 aakash_jain 2019-05-09 06:02:31 -0700 Fix formatting issues and typos in ews-build. 1534717 1 369488 aakash_jain 2019-05-09 06:04:59 -0700 Created attachment 369488 Patch 1534739 2 369488 jbedard 2019-05-09 08:43:51 -0700 Comment on attachment 369488 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369488&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/step.py:67 > + _log.info('Saved step {} in database for build: {}'.format(step_uid, build_uid)) We're bumping up the logging level here (from 10 to 20), any reason why? 1534743 3 369488 aakash_jain 2019-05-09 09:04:40 -0700 Comment on attachment 369488 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369488&action=review >> Tools/BuildSlaveSupport/ews-app/ews/models/step.py:67 >> + _log.info('Saved step {} in database for build: {}'.format(step_uid, build_uid)) > > We're bumping up the logging level here (from 10 to 20), any reason why? Yeah, I mentioned in ChangeLog 'Changed log level to info so that it is logged in production'. Also the log level was inconsistent with similar log statement below (_log.info('Updated step {} in database for build: {}') 1534759 4 369488 commit-queue 2019-05-09 10:13:52 -0700 Comment on attachment 369488 Patch Clearing flags on attachment: 369488 Committed r245141: <https://trac.webkit.org/changeset/245141> 1534761 5 commit-queue 2019-05-09 10:13:54 -0700 All reviewed patches have been landed. Closing bug. 1534765 6 webkit-bug-importer 2019-05-09 10:19:26 -0700 <rdar://problem/50626334> 369488 2019-05-09 06:04:59 -0700 2019-05-09 10:13:52 -0700 Patch bug-197737-20190509090458.patch text/plain 3034 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NTEzMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTA1LTA5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBGaXggZm9ybWF0dGluZyBpc3N1ZXMgYW5kIHR5cG9z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc3MzcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxk U2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKENvbXBpbGVXZWJLaXQu ZXZhbHVhdGVDb21tYW5kKTogUmVtb3ZlZCBleHRyYSBlbXB0eSBsaW5lLgorICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weToKKyAgICAgICAgKFRl c3RSdW5XZWJLaXRQZXJsVGVzdHMpOiBGaXhlZCB0eXBvLgorICAgICAgICAqIEJ1aWxkU2xhdmVT dXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9zdGVwLnB5OgorICAgICAgICAoU3RlcC5zYXZlX3N0 ZXApOiBDaGFuZ2VkIGxvZyBsZXZlbCB0byBpbmZvIHNvIHRoYXQgaXQgaXMgbG9nZ2VkIGluIHBy b2R1Y3Rpb24uCisKIDIwMTktMDUtMDkgIFhhbiBMw7NwZXogIDx4YW5AaWdhbGlhLmNvbT4KIAog ICAgICAgICBbQ01ha2VdIERldGVjdCBTU0UyIGF0IGNvbXBpbGUgdGltZQpJbmRleDogVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3N0ZXAucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3N0ZXAucHkJKHJl dmlzaW9uIDI0NTEzMykKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21v ZGVscy9zdGVwLnB5CSh3b3JraW5nIGNvcHkpCkBAIC02NCw3ICs2NCw3IEBAIGNsYXNzIFN0ZXAo bW9kZWxzLk1vZGVsKToKIAogICAgICAgICAjIFNhdmUgdGhlIG5ldyBzdGVwIGRhdGEsIGUuZy46 IHN0ZXAgc3RhcnQgZXZlbnQuCiAgICAgICAgIFN0ZXAoc3RlcF91aWQsIGJ1aWxkX3VpZCwgcmVz dWx0LCBzdGF0ZV9zdHJpbmcsIHN0YXJ0ZWRfYXQsIGNvbXBsZXRlX2F0KS5zYXZlKCkKLSAgICAg ICAgX2xvZy5kZWJ1ZygnU2F2ZWQgc3RlcCB7fSBpbiBkYXRhYmFzZSBmb3IgYnVpbGQ6IHt9Jy5m b3JtYXQoc3RlcF91aWQsIGJ1aWxkX3VpZCkpCisgICAgICAgIF9sb2cuaW5mbygnU2F2ZWQgc3Rl cCB7fSBpbiBkYXRhYmFzZSBmb3IgYnVpbGQ6IHt9Jy5mb3JtYXQoc3RlcF91aWQsIGJ1aWxkX3Vp ZCkpCiAgICAgICAgIHJldHVybiBTVUNDRVNTCiAKICAgICBAY2xhc3NtZXRob2QKSW5kZXg6IFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI0NTEz MykKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2lu ZyBjb3B5KQpAQCAtNjE3LDcgKzYxNyw2IEBAIGNsYXNzIENvbXBpbGVXZWJLaXQoc2hlbGwuQ29t cGlsZSk6CiAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICBzZWxmLmJ1aWxkLmFkZFN0ZXBzQWZ0 ZXJDdXJyZW50U3RlcChbQXJjaGl2ZUJ1aWx0UHJvZHVjdCgpLCBVcGxvYWRCdWlsdFByb2R1Y3Qo KV0pCiAKLQogICAgICAgICByZXR1cm4gc3VwZXIoQ29tcGlsZVdlYktpdCwgc2VsZikuZXZhbHVh dGVDb21tYW5kKGNtZCkKIAogCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNDUxMzMpCisrKyBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcg Y29weSkKQEAgLTMxOCw3ICszMTgsNyBAQCBjbGFzcyBUZXN0UnVuQmluZGluZ3NUZXN0cyhCdWls ZFN0ZXBNaXhpCiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQogCiAKLWNsYXNzIFRlc3R1 bldlYktpdFBlcmxUZXN0cyhCdWlsZFN0ZXBNaXhpbkFkZGl0aW9ucywgdW5pdHRlc3QuVGVzdENh c2UpOgorY2xhc3MgVGVzdFJ1bldlYktpdFBlcmxUZXN0cyhCdWlsZFN0ZXBNaXhpbkFkZGl0aW9u cywgdW5pdHRlc3QuVGVzdENhc2UpOgogICAgIGRlZiBzZXRVcChzZWxmKToKICAgICAgICAgc2Vs Zi5sb25nTWVzc2FnZSA9IFRydWUKICAgICAgICAgcmV0dXJuIHNlbGYuc2V0VXBCdWlsZFN0ZXAo KQpAQCAtMTIzNCw3ICsxMjM0LDcgQEAgVGVzdGluZyBjb21wbGV0ZWQsIEV4aXQgc3RhdHVzOiAz CiAgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9RkFJTFVSRSwgc3RhdGVfc3RyaW5n PSc0IGFwaSB0ZXN0cyBmYWlsZWQgb3IgdGltZWQgb3V0IChmYWlsdXJlKScpCiAgICAgICAgIHJl dHVybiBzZWxmLnJ1blN0ZXAoKQogCi0gICAgZGVmIHRlc3RfdW5leHBlY3RlX2ZhaWx1cmUoc2Vs Zik6CisgICAgZGVmIHRlc3RfdW5leHBlY3RlZF9mYWlsdXJlKHNlbGYpOgogICAgICAgICBzZWxm LnNldHVwU3RlcChSdW5BUElUZXN0cygpKQogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdmdWxs UGxhdGZvcm0nLCAnbWFjLW1vamF2ZScpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3BsYXRm b3JtJywgJ21hYycpCg==