197653 2019-05-07 02:55:22 -0700 [GTK] Crash in webkitWebViewBaseSetEnableBackForwardNavigationGesture 2019-05-07 07:34:03 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned berto bugs-noreply ews-watchlist gustavo mcatanzaro zan oldest_to_newest 1533853 0 cgarcia 2019-05-07 02:55:22 -0700 We still need to null-check the ViewGestureController there, since it can be called with a running process but not yet attached when using a related view. #0 0x00007fe8b7b8268d in webkitWebViewBaseSetEnableBackForwardNavigationGesture(_WebKitWebViewBase*, bool) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #1 0x00007fe8b7b64387 in webkitWebViewUpdateSettings(_WebKitWebView*) [clone .part.323] () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #2 0x00007fe8b7b67a2d in webkitWebViewConstructed(_GObject*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #3 0x00007fe8b51ed6c3 in g_object_new_internal (class=class@entry=0x55e84513d160, params=params@entry=0x7ffcebc72020, n_params=n_params@entry=3) at ../gobject/gobject.c:1844 #4 0x00007fe8b51ef214 in g_object_new_valist (object_type=<optimized out>, first_property_name=<optimized out>, var_args=var_args@entry=0x7ffcebc72168) at ../gobject/gobject.c:2127 #5 0x00007fe8b51ef53c in g_object_new (object_type=<optimized out>, first_property_name=<optimized out>) at ../gobject/gobject.c:1647 #6 0x00007fe8b7b87342 in webkit_web_view_new_with_related_view () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #7 0x000055e843d2a68a in webViewCreate () #8 0x00007fe8ae4da8ee in ffi_call_unix64 () from /lib/x86_64-linux-gnu/libffi.so.6 #9 0x00007fe8ae4da2bf in ffi_call () from /lib/x86_64-linux-gnu/libffi.so.6 #10 0x00007fe8b51e85a9 in g_cclosure_marshal_generic (closure=0x55e84518e2a0, return_gvalue=0x7ffcebc725c0, n_param_values=<optimized out>, param_values=<optimized out>, invocation_hint=<optimized out>, marshal_data=<optimized out>) at ../gobject/gclosure.c:1500 #11 0x00007fe8b51e7ddd in g_closure_invoke (closure=0x55e84518e2a0, return_value=0x7ffcebc725c0, n_param_values=2, param_values=0x7ffcebc72670, invocation_hint=0x7ffcebc72610) at ../gobject/gclosure.c:810 #12 0x00007fe8b51fadb5 in signal_emit_unlocked_R (node=<optimized out>, detail=detail@entry=0, instance=instance@entry=0x55e844d7f950, emission_return=emission_return@entry=0x7ffcebc72760, instance_and_params=instance_and_params@entry=0x7ffcebc72670) at ../gobject/gsignal.c:3635 #13 0x00007fe8b5203530 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffcebc72818) at ../gobject/gsignal.c:3401 #14 0x00007fe8b52044d2 in g_signal_emit (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>) at ../gobject/gsignal.c:3447 #15 0x00007fe8b7b66a3f in webkitWebViewCreateNewPage(_WebKitWebView*, WebCore::WindowFeatures const&, _WebKitNavigationAction*) () 1533854 1 369266 cgarcia 2019-05-07 02:57:20 -0700 Created attachment 369266 Patch 1533856 2 ews-watchlist 2019-05-07 02:59:04 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1533907 3 cgarcia 2019-05-07 07:34:03 -0700 Committed r245008: <https://trac.webkit.org/changeset/245008> 369266 2019-05-07 02:57:20 -0700 2019-05-07 05:49:38 -0700 Patch wk2-gesture-crash.diff text/plain 1625 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYzNhYTc2ZTIxMDUuLjQ1MjVmMjc1OTEyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDE5LTA1LTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBDcmFzaCBpbiB3ZWJraXRXZWJWaWV3QmFzZVNldEVuYWJs ZUJhY2tGb3J3YXJkTmF2aWdhdGlvbkdlc3R1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NzY1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlIHN0aWxsIG5lZWQgdG8gbnVsbC1jaGVjayB0aGUgVmll d0dlc3R1cmVDb250cm9sbGVyIHRoZXJlLCBzaW5jZSBpdCBjYW4gYmUgY2FsbGVkIHdpdGggYSBy dW5uaW5nIHByb2Nlc3MgYnV0CisgICAgICAgIG5vdCB5ZXQgYXR0YWNoZWQgd2hlbiB1c2luZyBh IHJlbGF0ZWQgdmlldy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZp ZXdCYXNlLmNwcDoKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdCYXNlU2V0RW5hYmxlQmFja0Zvcndh cmROYXZpZ2F0aW9uR2VzdHVyZSk6CisKIDIwMTktMDUtMDQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZlcnQgcjI0NDk1MyBhbmQgcjI0 NDk1NCBiZWNhdXNlIHRoZXkgYnJva2UgaW50ZXJuYWwgYnVpbGRzLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAppbmRleCAx OWE5MGI4ZDhmMC4uZGVhNzc3MWNhNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCkBAIC0xMTk3LDggKzExOTcsOCBA QCB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlU2V0RW5hYmxlQmFja0ZvcndhcmROYXZpZ2F0aW9uR2Vz dHVyZShXZWJLaXRXZWJWaWV3QmFzZSogdwogCiAgICAgcHJpdi0+aXNCYWNrRm9yd2FyZE5hdmln YXRpb25HZXN0dXJlRW5hYmxlZCA9IGVuYWJsZWQ7CiAKLSAgICBpZiAocHJpdi0+cGFnZVByb3h5 LT5oYXNSdW5uaW5nUHJvY2VzcygpKQotICAgICAgICB3ZWJWaWV3QmFzZS0+cHJpdi0+dmlld0dl c3R1cmVDb250cm9sbGVyLT5zZXRTd2lwZUdlc3R1cmVFbmFibGVkKGVuYWJsZWQpOworICAgIGlm IChhdXRvKiBjb250cm9sbGVyID0gd2Via2l0V2ViVmlld0Jhc2VWaWV3R2VzdHVyZUNvbnRyb2xs ZXIod2ViVmlld0Jhc2UpKQorICAgICAgICBjb250cm9sbGVyLT5zZXRTd2lwZUdlc3R1cmVFbmFi bGVkKGVuYWJsZWQpOwogCiAgICAgcHJpdi0+cGFnZVByb3h5LT5zZXRTaG91bGRSZWNvcmROYXZp Z2F0aW9uU25hcHNob3RzKGVuYWJsZWQpOwogfQo=