196866 2019-04-12 10:24:24 -0700 [WinCairo] Non-unified build fails to link Tools 2019-08-16 12:43:32 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200820 InRadar P2 Normal --- 1 ross.kirsling ross.kirsling commit-queue don.olmstead fujii lforschler stephan.szabo webkit-bug-importer oldest_to_newest 1526792 0 ross.kirsling 2019-04-12 10:24:24 -0700 As mentioned in bug 196845 comment 2, building WinCairo with clang-cl / lld and -DENABLE_UNIFIED_BUILDS=OFF, we fail to link DumpRenderTree and TestRunnerInjectedBundle. > lld-link.exe: error: undefined symbol: __imp_?toJS@WebCore@@YA?AVJSValue@JSC@@PEAVExecState@3@PEAVJSDOMGlobalObject@1@AEAVTextTrackCueGeneric@1@@Z > >>> referenced by C:\GitHub\neko\WebKitBuild\Release\DerivedSources\WebCore\JSInternals.cpp:6803 > >>> WebCoreTestSupport.lib(JSInternals.cpp.obj):(?jsInternalsPrototypeFunctionCreateGenericCue@WebCore@@YA_JPEAVExecState@JSC@@@Z) > > > lld-link.exe: error: undefined symbol: ?notifyNetworkStateChange@ServiceWorkerThreadProxy@WebCore@@QEAAX_N@Z > >>> referenced by C:\GitHub\neko\WebKitBuild\Release\WTF\Headers\wtf\Function.h:102 > >>> WebCoreTestSupport.lib(ServiceWorkerInternals.cpp.obj):(?call@?$CallableWrapper@V<lambda_0>@?0??setOnline@ServiceWorkerInternals@WebCore@@QEAAX_N@Z@@?$Function@$$A6AXXZ@WTF@@UEAAXXZ) > > > lld-link.exe: error: undefined symbol: __imp_?parseHEVCCodecParameters@WebCore@@YA?AV?$Optional@UHEVCParameterSet@WebCore@@@WTF@@AEBVString@3@@Z > >>> referenced by C:\GitHub\neko\Source\WebCore\testing\Internals.cpp:4962 > >>> WebCoreTestSupport.lib(Internals.cpp.obj):(?parseHEVCCodecParameters@Internals@WebCore@@QEAA?AV?$Optional@UHEVCParameterSet@WebCore@@@WTF@@AEBVString@4@@Z) > > > lld-link.exe: error: undefined symbol: __imp_?doDispatchMessageOnFrontendPage@InspectorClient@WebCore@@SAXPEAVPage@2@AEBVString@WTF@@@Z > >>> referenced by C:\GitHub\neko\Source\WebCore\testing\Internals.cpp:372 > >>> WebCoreTestSupport.lib(Internals.cpp.obj):(?sendMessageToFrontend@InspectorStubFrontend@WebCore@@EEAAXAEBVString@WTF@@@Z) 1526800 1 don.olmstead 2019-04-12 10:27:42 -0700 (In reply to Ross Kirsling from comment #0) > As mentioned in bug 196845 comment 2, building WinCairo with clang-cl / lld > and -DENABLE_UNIFIED_BUILDS=OFF, we fail to link DumpRenderTree and > TestRunnerInjectedBundle. > > > lld-link.exe: error: undefined symbol: __imp_?toJS@WebCore@@YA?AVJSValue@JSC@@PEAVExecState@3@PEAVJSDOMGlobalObject@1@AEAVTextTrackCueGeneric@1@@Z > > >>> referenced by C:\GitHub\neko\WebKitBuild\Release\DerivedSources\WebCore\JSInternals.cpp:6803 > > >>> WebCoreTestSupport.lib(JSInternals.cpp.obj):(?jsInternalsPrototypeFunctionCreateGenericCue@WebCore@@YA_JPEAVExecState@JSC@@@Z) > > > > > > lld-link.exe: error: undefined symbol: ?notifyNetworkStateChange@ServiceWorkerThreadProxy@WebCore@@QEAAX_N@Z > > >>> referenced by C:\GitHub\neko\WebKitBuild\Release\WTF\Headers\wtf\Function.h:102 > > >>> WebCoreTestSupport.lib(ServiceWorkerInternals.cpp.obj):(?call@?$CallableWrapper@V<lambda_0>@?0??setOnline@ServiceWorkerInternals@WebCore@@QEAAX_N@Z@@?$Function@$$A6AXXZ@WTF@@UEAAXXZ) > > > > > > lld-link.exe: error: undefined symbol: __imp_?parseHEVCCodecParameters@WebCore@@YA?AV?$Optional@UHEVCParameterSet@WebCore@@@WTF@@AEBVString@3@@Z > > >>> referenced by C:\GitHub\neko\Source\WebCore\testing\Internals.cpp:4962 > > >>> WebCoreTestSupport.lib(Internals.cpp.obj):(?parseHEVCCodecParameters@Internals@WebCore@@QEAA?AV?$Optional@UHEVCParameterSet@WebCore@@@WTF@@AEBVString@4@@Z) > > > > > > lld-link.exe: error: undefined symbol: __imp_?doDispatchMessageOnFrontendPage@InspectorClient@WebCore@@SAXPEAVPage@2@AEBVString@WTF@@@Z > > >>> referenced by C:\GitHub\neko\Source\WebCore\testing\Internals.cpp:372 > > >>> WebCoreTestSupport.lib(Internals.cpp.obj):(?sendMessageToFrontend@InspectorStubFrontend@WebCore@@EEAAXAEBVString@WTF@@@Z) This is clang-cl specific right? If so update the description 1526807 2 ross.kirsling 2019-04-12 10:37:08 -0700 (In reply to Don Olmstead from comment #1) > This is clang-cl specific right? If so update the description Not sure, I can try combining regular cl with lld. The MSVC linker is unable to handle the size of WebCore.lib as mentioned in bug 196762 comment 2. 1526841 3 ross.kirsling 2019-04-12 11:25:33 -0700 (In reply to Ross Kirsling from comment #2) > (In reply to Don Olmstead from comment #1) > > This is clang-cl specific right? If so update the description > > Not sure, I can try combining regular cl with lld. > > The MSVC linker is unable to handle the size of WebCore.lib as mentioned in > bug 196762 comment 2. Confirmed that this does not require clang-cl. 1528576 4 ross.kirsling 2019-04-18 13:57:16 -0700 Evidently the issue here is that certain object files are unused when linking WK[L] and thus their symbols don't get exported. One fix for this is to add the following line to WebKit[Legacy]/PlatformWin.cmake: > set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /WHOLEARCHIVE:WebCore.lib") But Fujii-san pointed out that we can alternatively tell Cmake to build WebCore as an "object library", and it turns out this makes the non-unified build work with not only lld but also with the MSVC linker! 1528591 5 367756 ross.kirsling 2019-04-18 14:24:51 -0700 Created attachment 367756 Patch 1528677 6 367756 fujii 2019-04-18 19:01:10 -0700 Comment on attachment 367756 Patch I prefer the Object library approach to /WHOLEARCHIVE and --whole-archive switches. Looks good to me. I have some questions. Do you know the reason why GTK port doesn't have the same issue? According to the document, use need to use $<TARGET_OBJECTS:WebCore> in order to use Object Library. Do you know the reason why you don't need it actually? https://cmake.org/cmake/help/latest/command/add_library.html#object-libraries 1528689 7 ross.kirsling 2019-04-18 20:01:25 -0700 (In reply to Fujii Hironori from comment #6) > Comment on attachment 367756 [details] > Patch > > I prefer the Object library approach to /WHOLEARCHIVE and --whole-archive > switches. > Looks good to me. > > I have some questions. > > Do you know the reason why GTK port doesn't have the same issue? I'm not 100% certain. Steph suggested it could be a behavioral difference between declspec on Windows and visibility on Unix, but then --whole-archive is originally a GCC option... In fact, a whole-archived WebCore gets added to WebKitPluginProcess2, though I don't see how this would help TestRunnerInjectedBundle: https://github.com/WebKit/webkit/blob/master/Source/WebKit/PlatformGTK.cmake#L682 It's interesting that GTK is the only platform on which WebCore is added to WebKitTestRunner_LIBRARIES, but it's not added to WebKitTestRunnerInjectedBundle_LIBRARIES, so that might not matter: https://github.com/WebKit/webkit/blob/master/Tools/WebKitTestRunner/PlatformGTK.cmake#L27-L35 I now wonder whether WPE has any issues here separate from GTK... > According to the document, use need to use $<TARGET_OBJECTS:WebCore> in > order to use Object Library. Do you know the reason why you don't need it > actually? > https://cmake.org/cmake/help/latest/command/add_library.html#object-libraries I believe that syntax is only required when interpolating with the explicit list of items? Notice the second example here: https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#object-libraries 1528690 8 367756 commit-queue 2019-04-18 20:28:40 -0700 Comment on attachment 367756 Patch Clearing flags on attachment: 367756 Committed r244448: <https://trac.webkit.org/changeset/244448> 1528691 9 commit-queue 2019-04-18 20:28:42 -0700 All reviewed patches have been landed. Closing bug. 1528692 10 webkit-bug-importer 2019-04-18 20:29:17 -0700 <rdar://problem/50038638> 1528693 11 fujii 2019-04-18 20:57:46 -0700 Oh. GTK port stopped using -fvisibility=hidden in Bug 181438. All symbols are exported. 1528695 12 fujii 2019-04-18 21:16:07 -0700 (In reply to Fujii Hironori from comment #11) > Oh. GTK port stopped using -fvisibility=hidden in Bug 181438. All symbols > are exported. Err. Irrelevant. Ignore my comment. 367756 2019-04-18 14:24:51 -0700 2019-04-18 20:28:40 -0700 Patch bug-196866-20190418142449.patch text/plain 2971 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQyODY2MjM1MmJiYWFl MmQwZTIxNzI0YWI3OTdkM2RmOTgxMDUwNS4uZjI0NDYyZmQxMTQyY2ZlNDhlNTZkYjNiN2RkZDE0 YWE2YTRhMzhjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA0LTE4ICBSb3Nz IEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9d IE5vbi11bmlmaWVkIGJ1aWxkIGZhaWxzIHRvIGxpbmsgVG9vbHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Njg2NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisgICAgICAg IERyaXZlLWJ5IGZpeCAtLSBkb24ndCBkaXNhYmxlIHN0cmluZyBwb29saW5nIHdoZW4gYnVpbGRp bmcgV2ViQ29yZVRlc3RTdXBwb3J0LgorICAgICAgICAoVGhpcyBzaG91bGQgaGF2ZSBiZWVuIHBh cnQgb2YgcjIzNTIwMy4pCisKIDIwMTktMDQtMTggIFNoYXduIFJvYmVydHMgIDxzcm9iZXJ0c0Bh cHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBtYW51YWwgcm9sbG91dCBvZiByMjQ0MjQ4 IGFuZCByMjQ0NDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBi L1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IDlhNjYyNDhhNjAxNzdlYjIyMmM5 MTA3NDEyZmQ2N2Y5MmQ0YTJhN2IuLjAyZjIwMTg5MmYzZGJjMGRkNTJlOWRmODk4YjBlMTFmOGY0 MWQwMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0yMTA1LDcgKzIxMDUsNyBAQCB0YXJnZXRf bGlua19saWJyYXJpZXMoV2ViQ29yZVRlc3RTdXBwb3J0ICR7V2ViQ29yZVRlc3RTdXBwb3J0X0xJ QlJBUklFU30pCiBpZiAoV2ViQ29yZVRlc3RTdXBwb3J0X09VVFBVVF9OQU1FKQogICAgIHNldF90 YXJnZXRfcHJvcGVydGllcyhXZWJDb3JlVGVzdFN1cHBvcnQgUFJPUEVSVElFUyBPVVRQVVRfTkFN RSAke1dlYkNvcmVUZXN0U3VwcG9ydF9PVVRQVVRfTkFNRX0pCiAgICAgaWYgKE1TVkMpCi0gICAg ICAgIGFkZF9jb21waWxlX29wdGlvbnMoL0dGLSAvV1gtKQorICAgICAgICBhZGRfY29tcGlsZV9v cHRpb25zKC9XWC0pCiAgICAgZW5kaWYgKCkKIGVuZGlmICgpCiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNXaW4uY21ha2UK aW5kZXggZWM4NDRlMDcyMDQ3ZGE3ZWQ5MGNiN2Q5OTFjNDg3ZjhiZjYxZTBlMC4uMGI0Njk5MWJl ZmJjMTMzMzk3MWQ3NDM1MmZkZTdkOGJkNDVkODhjYSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtl L09wdGlvbnNXaW4uY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNXaW4uY21ha2UKQEAg LTE1Niw2ICsxNTYsMTAgQEAgc2V0KFdURl9MSUJSQVJZX1RZUEUgU0hBUkVEKQogc2V0KFBBTF9M SUJSQVJZX1RZUEUgU1RBVElDKQogc2V0KFdlYktpdExlZ2FjeV9MSUJSQVJZX1RZUEUgU0hBUkVE KQogCitpZiAoTk9UIEVOQUJMRV9VTklGSUVEX0JVSUxEUyBBTkQgV2ViQ29yZV9MSUJSQVJZX1RZ UEUgTUFUQ0hFUyBTVEFUSUMpCisgICAgc2V0KFdlYkNvcmVfTElCUkFSWV9UWVBFIE9CSkVDVCkK K2VuZGlmICgpCisKIGZpbmRfcGFja2FnZShJQ1UgUkVRVUlSRUQpCiAKICMgSWYgPHdpbnNvY2sy Lmg+IGlzIG5vdCBpbmNsdWRlZCBiZWZvcmUgPHdpbmRvd3MuaD4gcmVkZWZpbml0aW9uIGVycm9y cyBvY2N1cgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGYzYmI4YzM3 Mzg3Mjk1YTZlYWQyZWE4NzJkNjRlYjYxMTUzOTc2YzQuLjRlZTJkMmU1NGY4NWJlODYyMGQ1OGE4 MzQ0MjBkOGUwYzA3ZjRjZDUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxOCBAQAorMjAxOS0wNC0xOCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xp bmdAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBOb24tdW5pZmllZCBidWlsZCBmYWls cyB0byBsaW5rIFRvb2xzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTY4NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlOgorICAgICAgICBCdWlsZCBX ZWJDb3JlIGFzIGFuIG9iamVjdCBsaWJyYXJ5IHdoZW4gdW5pZmllZCBidWlsZHMgYXJlIGRpc2Fi bGVkCisgICAgICAgIChhbmQgd2UgaGF2ZW4ndCBleHBsaWNpdGx5IGFza2VkIHRvIGJ1aWxkIGl0 IGFzIGEgc2hhcmVkIGxpYnJhcnkpLgorICAgICAgICBUaGlzIGlzIG5lY2Vzc2FyeSBmb3IgdHdv IHJlYXNvbnM6CisgICAgICAgIC0gTm9uLXVuaWZpZWQgV2ViQ29yZS5saWIgaXMgdG9vIGxhcmdl IGZvciB0aGUgTVNWQyBsaW5rZXIgdG8gY3JlYXRlICg+NEdCKS4KKyAgICAgICAgLSBTb21lIFdl YkNvcmUgb2JqZWN0IGZpbGVzIGFyZSBub3QgYWN0dWFsbHkgdXNlZCwgYnV0IER1bXBSZW5kZXJU cmVlIGFuZCBUZXN0UnVubmVySW5qZWN0ZWRCdW5kbGUKKyAgICAgICAgICBzdGlsbCBleHBlY3Qg dGhhdCB0aGVpciBzeW1ib2xzIHdpbGwgYmUgcmUtZXhwb3J0ZWQgdmlhIFdlYktpdFtMZWdhY3ld LgorCiAyMDE5LTA0LTE3ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIEF1dG9tYXRpY2FsbHkgdXNlIGNjYWNoZSB3aGVuIGF2YWlsYWJsZSBmb3IgTWFrZWZpbGUg YnVpbGRzCg==