196650 2019-04-05 10:58:25 -0700 Clear Cache Storage structures before removing all related files 2019-04-16 15:27:17 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196467 InRadar P2 Normal --- 1 youennf youennf achristensen cdumez cgarcia commit-queue ews-watchlist webkit-bug-importer oldest_to_newest 1524756 0 youennf 2019-04-05 10:58:25 -0700 Clear Cache Storage structures before removing all related files. 1524757 1 366828 youennf 2019-04-05 11:00:29 -0700 Created attachment 366828 Patch 1525669 2 youennf 2019-04-09 10:34:47 -0700 Ping review? 1526189 3 366828 commit-queue 2019-04-10 15:59:19 -0700 Comment on attachment 366828 Patch Clearing flags on attachment: 366828 Committed r244162: <https://trac.webkit.org/changeset/244162> 1526190 4 commit-queue 2019-04-10 15:59:21 -0700 All reviewed patches have been landed. Closing bug. 1526191 5 webkit-bug-importer 2019-04-10 16:01:03 -0700 <rdar://problem/49794288> 1527900 6 366828 achristensen 2019-04-16 15:27:17 -0700 Comment on attachment 366828 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366828&action=review > Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:528 > + return; We need to call the completion handler here :( 366828 2019-04-05 11:00:29 -0700 2019-04-10 15:59:19 -0700 Patch bug-196650-20190405110034.patch text/plain 3389 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzODcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE0OTIzMTYwZjMwMDQ4MmE2 ZTJhMmUxZDAwZDRlZmZiMTU5NDNkMzguLjg3Zjc0OGJiMjA2M2U5MDFjOWYxZDlkNGFiYjNlN2M5 NGUwYmMyMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDQtMDUgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIENsZWFyIENhY2hlIFN0b3JhZ2Ug c3RydWN0dXJlcyBiZWZvcmUgcmVtb3ZpbmcgYWxsIHJlbGF0ZWQgZmlsZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjY1MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByZXZpb3VzbHksIHdlIHdlcmUg Y2xlYXJpbmcgZmlsZXMgaW4gcGFyYWxsZWwgdG8gY2xlYXJpbmcgdGhlIGludGVybmFsIENhY2hl U3RvcmFnZSBzdHJ1Y3R1cmVzLgorICAgICAgICBUbyBtYWtlIHRoaW5ncyBtb3JlIGRldGVybWlu aXN0aWMsIGNsZWFyIGZpbGVzL2ZvbGRlcnMgZGlyZWN0bHkKKyAgICAgICAgYWZ0ZXIgQ2FjaGVz U3RvcmFnZSBzdHJ1Y3R1cmVzIGhhdmUgZmluaXNoZWQgYmVpbmcgY2xlYXJlZC4KKworICAgICAg ICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL0NhY2hlU3RvcmFnZUVuZ2luZS5jcHA6CisgICAgICAg IChXZWJLaXQ6OkNhY2hlU3RvcmFnZTo6RW5naW5lOjpjbGVhckFsbENhY2hlcyk6CisgICAgICAg IChXZWJLaXQ6OkNhY2hlU3RvcmFnZTo6RW5naW5lOjpjbGVhckNhY2hlc0Zvck9yaWdpbik6CisK IDIwMTktMDQtMDQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAg IENsb3NlIHNlcnZpY2Ugd29ya2VyIGRhdGFiYXNlIG9uIG5ldHdvcmsgcHJvY2VzcyBzdXNwZW5z aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL0NhY2hl U3RvcmFnZUVuZ2luZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL0Nh Y2hlU3RvcmFnZUVuZ2luZS5jcHAKaW5kZXggZTZmOWZjOGUxZjgzODU1YjE5M2FkOTdkMzZjMzYx NjJhMmNkNDIxZi4uYjMzMzJmOWY0NzY1OTkwNTI0NzQwZTFmZGY5MDFjZjcxZDVmMmFkZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3JhZ2VF bmdpbmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvQ2FjaGVT dG9yYWdlRW5naW5lLmNwcApAQCAtNTIzLDE1ICs1MjMsMTUgQEAgdm9pZCBFbmdpbmU6OmNsZWFy QWxsQ2FjaGVzKENvbXBsZXRpb25IYW5kbGVyPHZvaWQoKT4mJiBjb21wbGV0aW9uSGFuZGxlcikK IHsKICAgICBBU1NFUlQoUnVuTG9vcDo6aXNNYWluKCkpOwogCi0gICAgYXV0byBjYWxsYmFja0Fn Z3JlZ2F0b3IgPSBDYWxsYmFja0FnZ3JlZ2F0b3I6OmNyZWF0ZShXVEZNb3ZlKGNvbXBsZXRpb25I YW5kbGVyKSk7CisgICAgYXV0byBjYWxsYmFja0FnZ3JlZ2F0b3IgPSBDYWxsYmFja0FnZ3JlZ2F0 b3I6OmNyZWF0ZShbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpLCBjb21wbGV0 aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXSgpIG11dGFibGUgeworICAg ICAgICBpZiAoIXRoaXMtPnNob3VsZFBlcnNpc3QoKSkKKyAgICAgICAgICAgIHJldHVybjsKKyAg ICAgICAgCisgICAgICAgIHRoaXMtPmNsZWFyQWxsQ2FjaGVzRnJvbURpc2soV1RGTW92ZShjb21w bGV0aW9uSGFuZGxlcikpOworICAgIH0pOwogCiAgICAgZm9yIChhdXRvJiBjYWNoZXMgOiBtX2Nh Y2hlcy52YWx1ZXMoKSkKICAgICAgICAgY2FjaGVzLT5jbGVhcihbY2FsbGJhY2tBZ2dyZWdhdG9y ID0gY2FsbGJhY2tBZ2dyZWdhdG9yLmNvcHlSZWYoKV0geyB9KTsKLQotICAgIGlmICghc2hvdWxk UGVyc2lzdCgpKQotICAgICAgICByZXR1cm47Ci0KLSAgICBjbGVhckFsbENhY2hlc0Zyb21EaXNr KFtjYWxsYmFja0FnZ3JlZ2F0b3IgPSBXVEZNb3ZlKGNhbGxiYWNrQWdncmVnYXRvcildIHsgfSk7 CiB9CiAKIHZvaWQgRW5naW5lOjpjbGVhckFsbENhY2hlc0Zyb21EaXNrKENvbXBsZXRpb25IYW5k bGVyPHZvaWQoKT4mJiBjb21wbGV0aW9uSGFuZGxlcikKQEAgLTU1MSwxNyArNTUxLDE5IEBAIHZv aWQgRW5naW5lOjpjbGVhckNhY2hlc0Zvck9yaWdpbihjb25zdCBXZWJDb3JlOjpTZWN1cml0eU9y aWdpbkRhdGEmIG9yaWdpbiwgQ29tCiB7CiAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsK IAotICAgIGF1dG8gY2FsbGJhY2tBZ2dyZWdhdG9yID0gQ2FsbGJhY2tBZ2dyZWdhdG9yOjpjcmVh dGUoV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikpOworICAgIGF1dG8gY2FsbGJhY2tBZ2dyZWdh dG9yID0gQ2FsbGJhY2tBZ2dyZWdhdG9yOjpjcmVhdGUoW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBt YWtlUmVmKCp0aGlzKSwgb3JpZ2luLCBjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxl dGlvbkhhbmRsZXIpXSgpIG11dGFibGUgeworICAgICAgICBpZiAoIXRoaXMtPnNob3VsZFBlcnNp c3QoKSkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICB0aGlzLT5jbGVhckNhY2hlc0Zv ck9yaWdpbkZyb21EaXNrKG9yaWdpbiwgW2NvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21w bGV0aW9uSGFuZGxlcildKCkgbXV0YWJsZSB7CisgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxl cigpOworICAgICAgICB9KTsKKyAgICB9KTsKIAogICAgIGZvciAoYXV0byYga2V5VmFsdWUgOiBt X2NhY2hlcykgewogICAgICAgICBpZiAoa2V5VmFsdWUua2V5LnRvcE9yaWdpbiA9PSBvcmlnaW4g fHwga2V5VmFsdWUua2V5LmNsaWVudE9yaWdpbiA9PSBvcmlnaW4pCiAgICAgICAgICAgICBrZXlW YWx1ZS52YWx1ZS0+Y2xlYXIoW2NhbGxiYWNrQWdncmVnYXRvciA9IGNhbGxiYWNrQWdncmVnYXRv ci5jb3B5UmVmKCldIHsgfSk7CiAgICAgfQotCi0gICAgaWYgKCFzaG91bGRQZXJzaXN0KCkpCi0g ICAgICAgIHJldHVybjsKLQotICAgIGNsZWFyQ2FjaGVzRm9yT3JpZ2luRnJvbURpc2sob3JpZ2lu LCBbY2FsbGJhY2tBZ2dyZWdhdG9yID0gV1RGTW92ZShjYWxsYmFja0FnZ3JlZ2F0b3IpXSB7IH0p OwogfQogCiB2b2lkIEVuZ2luZTo6Y2xlYXJDYWNoZXNGb3JPcmlnaW5Gcm9tRGlzayhjb25zdCBX ZWJDb3JlOjpTZWN1cml0eU9yaWdpbkRhdGEmIG9yaWdpbiwgQ29tcGxldGlvbkhhbmRsZXI8dm9p ZCgpPiYmIGNvbXBsZXRpb25IYW5kbGVyKQo=