196505 2019-04-02 12:02:42 -0700 [ Mac ] Layout Test accessibility/mac/press-not-work-for-disabled-menu-list.html is a flaky failure 2019-08-02 16:20:39 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193878 InRadar P2 Normal --- 1 sroberts webkit-unassigned aboxhall andresg_22 apinheiro cfleizach commit-queue dmazzoni ericliang ews-watchlist jcraig jdiggs lforschler samuel_white webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1523389 0 sroberts 2019-04-02 12:02:42 -0700 The following layout test is flaky on Mac WK1, WK2 Release and Debug accessibility/mac/press-not-work-for-disabled-menu-list.html Probable cause: Test was added in https://trac.webkit.org/changeset/241190/webkit and is a flaky failure on its entire available dashboard history for Mojave WK1, but through local testing I am able to get it to fail on Release and Debug WK2 as well, just not as consistently. Local testing for WK1 yields approximately 20 failures in 500 iterations. WK2 testing yields about 2 failures in 500 iterations. Reproduced with: run-webkit-tests accessibility/mac/press-not-work-for-disabled-menu-list.html --iterations 500 -f -1 Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fmac%2Fpress-not-work-for-disabled-menu-list.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/accessibility/mac/press-not-work-for-disabled-menu-list-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/accessibility/mac/press-not-work-for-disabled-menu-list-actual.txt @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: line 56: TypeError: undefined is not an object (evaluating 'menulist.addNotificationListener') This tests that menu lists that are disabled will not be triggered by AXPress actions. @@ -7,7 +8,7 @@ Got notification: AXPressDidFail Got notification: AXPressDidFail Got notification: AXPressDidFail -PASS successfullyParsed is true +FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined). TEST COMPLETE 1523392 1 sroberts 2019-04-02 12:10:02 -0700 Marked flaky in https://trac.webkit.org/changeset/243750/webkit while waiting for a fix. 1523441 2 webkit-bug-importer 2019-04-02 13:47:28 -0700 <rdar://problem/49532620> 1558082 3 375447 andresg_22 2019-08-02 13:25:31 -0700 Created attachment 375447 Patch 1558092 4 375447 cfleizach 2019-08-02 13:36:59 -0700 Comment on attachment 375447 Patch waiting for green bots to cq 1558198 5 375447 commit-queue 2019-08-02 16:20:38 -0700 Comment on attachment 375447 Patch Clearing flags on attachment: 375447 Committed r248189: <https://trac.webkit.org/changeset/248189> 1558199 6 commit-queue 2019-08-02 16:20:39 -0700 All reviewed patches have been landed. Closing bug. 375447 2019-08-02 13:25:31 -0700 2019-08-02 16:20:38 -0700 Patch bug-196505-20190802162529.patch text/plain 3010 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3OTA0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmM1MTE1MGYyZGE1YTBiZjI1ZWRh YjNjMjlkM2YzYjMxY2E0OGM1My4uYWE0ZWRmMGRmMDIxMTE5Yzc3NzA1ZmVhNjVmZDBjYzQ5ZTc4 NGE5MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA4LTAyICBBbmRyZXMgR29uemFsZXog IDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBbIE1hYyBdIExheW91dCBUZXN0IGFj Y2Vzc2liaWxpdHkvbWFjL3ByZXNzLW5vdC13b3JrLWZvci1kaXNhYmxlZC1tZW51LWxpc3QuaHRt bCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5NjUwNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk1MzI2MjA+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmUtd3JvdGUg dGVzdCBpbiBhIHRpbWluZyBpbmRlcGVuZGVudCB3YXkuIFRoaXMgc2hvdWxkIGZpeCB0aGUgaW50 ZXJtaXR0ZW50IGZhaWx1cmVzLgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL3ByZXNzLW5v dC13b3JrLWZvci1kaXNhYmxlZC1tZW51LWxpc3QuaHRtbDoKKwogMjAxOS0wNy0yOCAgVGltIEhv cnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW9yZ2FuaXplIFVJ U2NyaXB0Q29udHJvbGxlciBpbnRvIHBsYXRmb3JtLXNwZWNpZmljIHN1YmNsYXNzZXMKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL3ByZXNzLW5vdC13b3JrLWZvci1k aXNhYmxlZC1tZW51LWxpc3QuaHRtbCBiL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL3By ZXNzLW5vdC13b3JrLWZvci1kaXNhYmxlZC1tZW51LWxpc3QuaHRtbAppbmRleCBkYjQ0ZDM5NWJk YWQ4ZWNlNTcwYjE2OGYwMmFkYTFjMzExMjliZjgyLi40MGI3MThlMWVhNmM0YWI0MmM2YzMzODU3 ZWU0MTY4M2Y0MTBiZTEwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21h Yy9wcmVzcy1ub3Qtd29yay1mb3ItZGlzYWJsZWQtbWVudS1saXN0Lmh0bWwKKysrIGIvTGF5b3V0 VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvcHJlc3Mtbm90LXdvcmstZm9yLWRpc2FibGVkLW1lbnUt bGlzdC5odG1sCkBAIC00MiwzNCArNDIsMzMgQEAKICAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0 cyB0aGF0IG1lbnUgbGlzdHMgdGhhdCBhcmUgZGlzYWJsZWQgd2lsbCBub3QgYmUgdHJpZ2dlcmVk IGJ5IEFYUHJlc3MgYWN0aW9ucy4iKTsKIAogICAgIC8vIFdlIGRvbid0IHRlc3QgZm9yIGVuYWJs ZWQgY29udHJvbHMgYmVjYXVzZSBvcGVuaW5nIG1lbnUgbGlzdHMgd2FpdHMgb24gdGhlIFVJIHBy b2Nlc3MgdG8gZGlzcGxheSB0aGUgbWVudS4KLSAgICB2YXIgbnVtT2ZUZXN0cyA9IDMsIG5vdGlm aWNhdGlvbkNvdW50ID0gMDsKKyAgICB2YXIgdGVzdENvdW50ID0gMywgdGVzdEluZGV4ID0gMDsK ICAgICB2YXIgbGlzdHMgPSBbbnVsbCwgbnVsbCwgbnVsbF07Ci0gICAgaWYgKHdpbmRvdy5hY2Nl c3NpYmlsaXR5Q29udHJvbGxlcikgewotICAgICAgICBqc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKLSAg ICAgICAgcHJlc3NOZXh0KDApOwotICAgIH0KIAotICAgIGZ1bmN0aW9uIHByZXNzTmV4dCh0ZXN0 SWQpIHsKLSAgICAgICAgaWYgKHRlc3RJZCA+IG51bU9mVGVzdHMpCisgICAgZnVuY3Rpb24gdGVz dE5leHRMaXN0KCkgeworICAgICAgICBpZiAodGVzdEluZGV4ID49IHRlc3RDb3VudCkgeworICAg ICAgICAgICAgZmluaXNoSlNUZXN0KCk7CiAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIHZh ciBtZW51bGlzdCA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJ ZCgidGVzdCIgKyB0ZXN0SWQpOworICAgICAgICB9CisKKyAgICAgICAgdmFyIG1lbnVsaXN0ID0g YWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCJ0ZXN0IiArIHRl c3RJbmRleCk7CiAgICAgICAgIG1lbnVsaXN0LmFkZE5vdGlmaWNhdGlvbkxpc3RlbmVyKHByZXNz TGlzdGVuZXIpOwogICAgICAgICBtZW51bGlzdC5wcmVzcygpOwotICAgICAgICBsaXN0c1t0ZXN0 SWRdID0gbWVudWxpc3Q7Ci0gICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0KGZ1bmN0aW9uKCkgewot ICAgICAgICAgICAgcHJlc3NOZXh0KHRlc3RJZCArIDEpOwotICAgICAgICB9LCAwKTsKKyAgICAg ICAgbGlzdHNbdGVzdEluZGV4XSA9IG1lbnVsaXN0OwogICAgIH0KIAogICAgIGZ1bmN0aW9uIHBy ZXNzTGlzdGVuZXIobm90aWZpY2F0aW9uKSB7Ci0gICAgICAgIGlmIChub3RpZmljYXRpb24gPT0g IkFYUHJlc3NEaWRGYWlsIiB8fCBub3RpZmljYXRpb24gPT0gIkFYUHJlc3NEaWRTdWNjZWVkIikK LSAgICAgICAgICAgIG5vdGlmaWNhdGlvbkNvdW50Kys7CisgICAgICAgIGxpc3RzW3Rlc3RJbmRl eF0ucmVtb3ZlTm90aWZpY2F0aW9uTGlzdGVuZXIocHJlc3NMaXN0ZW5lcik7CiAKICAgICAgICAg ZGVidWcoIkdvdCBub3RpZmljYXRpb246ICIgKyBub3RpZmljYXRpb24pOwotICAgICAgICBsaXN0 c1tub3RpZmljYXRpb25Db3VudC0xXS5yZW1vdmVOb3RpZmljYXRpb25MaXN0ZW5lcihwcmVzc0xp c3RlbmVyKTsKLSAgICAgICAgaWYgKG5vdGlmaWNhdGlvbkNvdW50ID09IG51bU9mVGVzdHMpIHsK LSAgICAgICAgICAgIGZpbmlzaEpTVGVzdCgpOwotICAgICAgICB9CisKKyAgICAgICAgdGVzdElu ZGV4Kys7CisgICAgICAgIHRlc3ROZXh0TGlzdCgpOworICAgIH0KKworICAgIGlmICh3aW5kb3cu YWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKyAgICAgICAganNUZXN0SXNBc3luYyA9IHRydWU7 CisgICAgICAgIHRlc3ROZXh0TGlzdCgpOwogICAgIH0KIDwvc2NyaXB0PgogCg==