<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>196476</bug_id>
          
          <creation_ts>2019-04-01 18:56:33 -0700</creation_ts>
          <short_desc>Resurrect and fix layout test http/tests/adClickAttribution/store-ad-click-attribution.html</short_desc>
          <delta_ts>2019-04-03 10:24:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=194510</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alex Christensen">achristensen</reporter>
          <assigned_to name="Alex Christensen">achristensen</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wilander</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1523168</commentid>
    <comment_count>0</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-04-01 18:56:33 -0700</bug_when>
    <thetext>Resurrect and fix layout test http/tests/adClickAttribution/store-ad-click-attribution.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1523186</commentid>
    <comment_count>1</comment_count>
      <attachid>366459</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-04-01 19:51:19 -0700</bug_when>
    <thetext>Created attachment 366459
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1523187</commentid>
    <comment_count>2</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2019-04-01 19:54:34 -0700</bug_when>
    <thetext>Attachment 366459 did not pass style-queue:


ERROR: LayoutTests/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1523335</commentid>
    <comment_count>3</comment_count>
      <attachid>366459</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-04-02 09:31:09 -0700</bug_when>
    <thetext>Comment on attachment 366459
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366459&amp;action=review

&gt; Source/WebKit/WebProcess/WebPage/WebFrame.cpp:282
&gt; +        m_ignoreDestroyNavigationMessage = true;

In WebPageProxy::didDestroyNavigation(uint64_t navigationID), I had added the following code to address this issue:
    // On process-swap, the previous process tries to destroy the navigation but the provisional process is actually taking over the navigation.
    if (m_provisionalPage &amp;&amp; m_provisionalPage-&gt;navigationID() == navigationID)
        return;

Any idea why this did not suffice?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1523368</commentid>
    <comment_count>4</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-04-02 11:25:07 -0700</bug_when>
    <thetext>At that point m_provisionalPage is null because it has been set to null by WebPageProxy::commitProvisionalPage.  I think it might be a race condition between the old page finishing stopping all loads and the new page committing the provisional load.  This test reliably hits the race condition so that it asserts.  This is a bug in our PSON code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1523378</commentid>
    <comment_count>5</comment_count>
      <attachid>366459</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-04-02 11:40:19 -0700</bug_when>
    <thetext>Comment on attachment 366459
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366459&amp;action=review

&gt;&gt; Source/WebKit/WebProcess/WebPage/WebFrame.cpp:282
&gt;&gt; +        m_ignoreDestroyNavigationMessage = true;
&gt; 
&gt; In WebPageProxy::didDestroyNavigation(uint64_t navigationID), I had added the following code to address this issue:
&gt;     // On process-swap, the previous process tries to destroy the navigation but the provisional process is actually taking over the navigation.
&gt;     if (m_provisionalPage &amp;&amp; m_provisionalPage-&gt;navigationID() == navigationID)
&gt;         return;
&gt; 
&gt; Any idea why this did not suffice?

We should probably drop my UI-side code at the same time then if your way is better / more robust.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1523381</commentid>
    <comment_count>6</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-04-02 11:43:37 -0700</bug_when>
    <thetext>I put the part of this that is specific to the PSON bug in https://bugs.webkit.org/show_bug.cgi?id=196503 and I&apos;ll add the code back to WebPageProxy::didCommitLoadForFrame and update the test expectations in a separate patch after that has landed to give that the possibility of being merged onto a branch without including pieces of unused features.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1523509</commentid>
    <comment_count>7</comment_count>
      <attachid>366546</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2019-04-02 16:22:00 -0700</bug_when>
    <thetext>Created attachment 366546
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1523522</commentid>
    <comment_count>8</comment_count>
      <attachid>366546</attachid>
    <who name="John Wilander">wilander</who>
    <bug_when>2019-04-02 16:44:31 -0700</bug_when>
    <thetext>Comment on attachment 366546
Patch

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1523759</commentid>
    <comment_count>9</comment_count>
    <who name="John Wilander">wilander</who>
    <bug_when>2019-04-03 10:02:44 -0700</bug_when>
    <thetext>Chris, looks good to you too?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1523767</commentid>
    <comment_count>10</comment_count>
      <attachid>366546</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2019-04-03 10:09:30 -0700</bug_when>
    <thetext>Comment on attachment 366546
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1523772</commentid>
    <comment_count>11</comment_count>
      <attachid>366546</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-04-03 10:23:39 -0700</bug_when>
    <thetext>Comment on attachment 366546
Patch

Clearing flags on attachment: 366546

Committed r243809: &lt;https://trac.webkit.org/changeset/243809&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1523773</commentid>
    <comment_count>12</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-04-03 10:23:40 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1523774</commentid>
    <comment_count>13</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-04-03 10:24:22 -0700</bug_when>
    <thetext>&lt;rdar://problem/49562994&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>366459</attachid>
            <date>2019-04-01 19:51:19 -0700</date>
            <delta_ts>2019-04-02 16:21:59 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-196476-20190401195118.patch</filename>
            <type>text/plain</type>
            <size>6342</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDM3MDkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE5LTA0LTAxICBBbGV4IENocmlz
dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVzdXJyZWN0IGFu
ZCBmaXggbGF5b3V0IHRlc3QgaHR0cC90ZXN0cy9hZENsaWNrQXR0cmlidXRpb24vc3RvcmUtYWQt
Y2xpY2stYXR0cmlidXRpb24uaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTk2NDc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgV2hlbiB3ZSByZXNwb25kIHRvIERlY2lkZVBvbGljeUZvck5hdmlnYXRp
b25BY3Rpb24gd2l0aCBTdG9wQWxsTG9hZHMsIGFuIGV4Y2Vzc2l2ZSBhbW91bnQgb2YgZGVzdHJ1
Y3Rpb24gZW5zdWVzOgorICAgICAgICBGcmFtZUxvYWRlcjo6Y29udGludWVMb2FkQWZ0ZXJOYXZp
Z2F0aW9uUG9saWN5IGNhbGxzIEZyYW1lTG9hZGVyOjpzdG9wQWxsTG9hZGVycywgd2hpY2ggY2Fs
bHMgc2V0UHJvdmlzaW9uYWxEb2N1bWVudExvYWRlcihudWxscHRyKTsKKyAgICAgICAgd2hpY2gg
Y2FsbHMgV2ViRG9jdW1lbnRMb2FkZXI6OmRldGFjaEZyb21GcmFtZSwgd2hpY2ggY2FsbHMgV2Vi
RnJhbWU6OmRvY3VtZW50TG9hZGVyRGV0YWNoZWQsIHdoaWNoIHNlbmRzIGEgbWVzc2FnZSB0byB0
aGUgVUlQcm9jZXNzCisgICAgICAgIHRlbGxpbmcgaXQgdG8gZGVzdHJveSB0aGUgbmF2aWdhdGlv
bi4gIFdlIHVzdWFsbHkgd291bGQgd2FudCB0byBkZXN0cm95IHRoZSBuYXZpZ2F0aW9uIGlmIHRo
ZSBsb2FkZXIgYW5kIGZyYW1lIGFyZSBkZXRhY2hpbmcgZXhjZXB0CisgICAgICAgIGlmIHdlIGp1
c3QgdG9sZCBpdCB0byBzdG9wIGFsbCBsb2FkcyBiZWNhdXNlIHdlIGFyZSBjb250aW51aW5nIG5h
dmlnYXRpb24gaW4gYSBuZXcgcHJvY2Vzcy4gIEluIHRoaXMgY2FzZSwgd2Ugd2FudCB0byBub3Qg
ZGVzdHJveSB0aGUKKyAgICAgICAgbmF2aWdhdGlvbiwgb3RoZXJ3aXNlIHdlIGdldCBtYW55IGFz
c2VydGlvbnMgc2F5aW5nICJUaGlzIG5hdmlnYXRpb24gaGFzIG15c3RlcmlvdXNseSBkaXNhcHBl
YXJlZCwiIGVzcGVjaWFsbHkgZnJvbSB0aGlzIHRlc3QuCisKKyAgICAgICAgQSBzZWNvbmQgcHJv
YmxlbSBoYXMgYmVlbiBmaXhlZCBzaW5jZSBJIHJldmVydGVkIHNvbWUgY29kZSBpbiByMjQxNzU0
LiAgVGhhdCBjb2RlIG5vdyBuZWVkcyB0byBiZSBjYWxsZWQgYWZ0ZXIgV2ViRnJhbWVQcm94eTo6
ZGlkQ29tbWl0TG9hZAorICAgICAgICBiZWNhdXNlIGl0IG5lZWRzIHRvIHVzZSB0aGUgVVJMIGJl
aW5nIG5hdmlnYXRlZCB0byBhbmQgYmVmb3JlIHRoYXQgY2FsbCB0aGUgV2ViRnJhbWVQcm94eSdz
IFVSTCBpcyB0aGUgVVJMIGJlaW5nIG5hdmlnYXRlZCBmcm9tLgorCisgICAgICAgICogVUlQcm9j
ZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6ZGlk
Q29tbWl0TG9hZEZvckZyYW1lKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViRnJh
bWUuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZTo6ZGlkUmVjZWl2ZVBvbGljeURlY2lz
aW9uKToKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWU6OmRvY3VtZW50TG9hZGVyRGV0YWNoZWQp
OgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJGcmFtZS5oOgorCiAyMDE5LTA0LTAx
ICBQYXRyaWNrIEdyaWZmaXMgIDxwZ3JpZmZpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtd
W1dQRV0gQWRkIG1vcmUgd2Vic2l0ZWRhdGFzdG9yZSBkaXJlY3RvcmllcyB0byB3ZWIgcHJvY2Vz
cyBzYW5kYm94CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJ
KHJldmlzaW9uIDI0MzU2NikKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94
eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQxNTAsNiArNDE1MCwxMyBAQCB2b2lkIFdlYlBhZ2VQ
cm94eTo6ZGlkQ29tbWl0TG9hZEZvckZyYW1lCiAKICAgICBmcmFtZS0+ZGlkQ29tbWl0TG9hZCht
aW1lVHlwZSwgd2ViQ2VydGlmaWNhdGVJbmZvLCBjb250YWluc1BsdWdpbkRvY3VtZW50KTsKIAor
ICAgIGlmIChuYXZpZ2F0aW9uICYmIGZyYW1lLT5pc01haW5GcmFtZSgpKSB7CisgICAgICAgIGlm
IChhdXRvJiBhZENsaWNrQXR0cmlidXRpb24gPSBuYXZpZ2F0aW9uLT5hZENsaWNrQXR0cmlidXRp
b24oKSkgeworICAgICAgICAgICAgaWYgKGFkQ2xpY2tBdHRyaWJ1dGlvbi0+ZGVzdGluYXRpb24o
KS5tYXRjaGVzKGZyYW1lLT51cmwoKSkpCisgICAgICAgICAgICAgICAgbV9wcm9jZXNzLT5wcm9j
ZXNzUG9vbCgpLnNlbmRUb05ldHdvcmtpbmdQcm9jZXNzKE1lc3NhZ2VzOjpOZXR3b3JrUHJvY2Vz
czo6U3RvcmVBZENsaWNrQXR0cmlidXRpb24obV93ZWJzaXRlRGF0YVN0b3JlLT5zZXNzaW9uSUQo
KSwgKmFkQ2xpY2tBdHRyaWJ1dGlvbikpOworICAgICAgICB9CisgICAgfQorCiAgICAgaWYgKGZy
YW1lLT5pc01haW5GcmFtZSgpKSB7CiAgICAgICAgIG1fbWFpbkZyYW1lSGFzQ3VzdG9tQ29udGVu
dFByb3ZpZGVyID0gZnJhbWVIYXNDdXN0b21Db250ZW50UHJvdmlkZXI7CiAKSW5kZXg6IFNvdXJj
ZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNwcAo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT
b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJGcmFtZS5jcHAJKHJldmlzaW9uIDI0
MzU2NikKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1lLmNwcAko
d29ya2luZyBjb3B5KQpAQCAtMjc4LDYgKzI3OCw5IEBAIHZvaWQgV2ViRnJhbWU6OmRpZFJlY2Vp
dmVQb2xpY3lEZWNpc2lvbigKICAgICAgICAgICAgIGRvY3VtZW50TG9hZGVyLT5zZXROYXZpZ2F0
aW9uSUQobmF2aWdhdGlvbklEKTsKICAgICB9CiAKKyAgICBpZiAoYWN0aW9uID09IFBvbGljeUFj
dGlvbjo6U3RvcEFsbExvYWRzKQorICAgICAgICBtX2lnbm9yZURlc3Ryb3lOYXZpZ2F0aW9uTWVz
c2FnZSA9IHRydWU7CisgICAgCiAgICAgZnVuY3Rpb24oYWN0aW9uLCBpZGVudGlmaWVyKTsKIH0K
IApAQCAtODEyLDcgKzgxNSw5IEBAIHZvaWQgV2ViRnJhbWU6OnNldFRleHREaXJlY3Rpb24oY29u
c3QgU3QKIAogdm9pZCBXZWJGcmFtZTo6ZG9jdW1lbnRMb2FkZXJEZXRhY2hlZCh1aW50NjRfdCBu
YXZpZ2F0aW9uSUQpCiB7Ci0gICAgaWYgKGF1dG8gKiBwYWdlID0gdGhpcy0+cGFnZSgpKQorICAg
IGlmIChtX2lnbm9yZURlc3Ryb3lOYXZpZ2F0aW9uTWVzc2FnZSkKKyAgICAgICAgcmV0dXJuOwor
ICAgIGlmIChhdXRvKiBwYWdlID0gdGhpcy0+cGFnZSgpKQogICAgICAgICBwYWdlLT5zZW5kKE1l
c3NhZ2VzOjpXZWJQYWdlUHJveHk6OkRpZERlc3Ryb3lOYXZpZ2F0aW9uKG5hdmlnYXRpb25JRCkp
OwogfQogCkluZGV4OiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJGcmFtZS5o
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkZyYW1l
LmgJKHJldmlzaW9uIDI0MzU2NikKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdl
L1dlYkZyYW1lLmgJKHdvcmtpbmcgY29weSkKQEAgLTE4OCw2ICsxODgsNyBAQCBwcml2YXRlOgog
ICAgIExvYWRMaXN0ZW5lciogbV9sb2FkTGlzdGVuZXIgeyBudWxscHRyIH07CiAgICAgCiAgICAg
dWludDY0X3QgbV9mcmFtZUlEIHsgMCB9OworICAgIGJvb2wgbV9pZ25vcmVEZXN0cm95TmF2aWdh
dGlvbk1lc3NhZ2UgeyBmYWxzZSB9OwogCiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKICAgICB1
aW50NjRfdCBtX2ZpcnN0TGF5ZXJUcmVlVHJhbnNhY3Rpb25JREFmdGVyRGlkQ29tbWl0TG9hZCB7
IDAgfTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU
ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0MzY1NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA0LTAxICBBbGV4IENocmlz
dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVzdXJyZWN0IGFu
ZCBmaXggbGF5b3V0IHRlc3QgaHR0cC90ZXN0cy9hZENsaWNrQXR0cmlidXRpb24vc3RvcmUtYWQt
Y2xpY2stYXR0cmlidXRpb24uaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTk2NDc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL2FkQ2xpY2tBdHRyaWJ1dGlvbi9zdG9yZS1hZC1j
bGljay1hdHRyaWJ1dGlvbi5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL3drMi9UZXN0RXhwZWN0
YXRpb25zCisgICAgICAgIFVuc2tpcCB0aGUgdGVzdCBJIHNraXBwZWQgaW4gMjQxNzU1IG5vdyB0
aGF0IGl0IHBhc3Nlcy4KKwogMjAxOS0wMy0yOSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3Rl
bnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdGVzdCBnYXJkZW5pbmcgZm9y
IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMveGhyL3NlbmQtcmVkaXJlY3QtcG9zdC11
cGxvYWQuaHRtCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2FkQ2xpY2tBdHRyaWJ1dGlv
bi9zdG9yZS1hZC1jbGljay1hdHRyaWJ1dGlvbi5odG1sCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl
c3RzL2h0dHAvdGVzdHMvYWRDbGlja0F0dHJpYnV0aW9uL3N0b3JlLWFkLWNsaWNrLWF0dHJpYnV0
aW9uLmh0bWwJKHJldmlzaW9uIDI0MzY1NCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYWRD
bGlja0F0dHJpYnV0aW9uL3N0b3JlLWFkLWNsaWNrLWF0dHJpYnV0aW9uLmh0bWwJKHdvcmtpbmcg
Y29weSkKQEAgLTEsNCArMSw0IEBACi08IURPQ1RZUEUgaHRtbD4gPCEtLSB3ZWJraXQtdGVzdC1y
dW5uZXIgWyB1c2VGbGV4aWJsZVZpZXdwb3J0PXRydWUsIGludGVybmFsOkFkQ2xpY2tBdHRyaWJ1
dGlvbkVuYWJsZWQ9dHJ1ZSBdIC0tPgorPCFET0NUWVBFIGh0bWw+IDwhLS0gd2Via2l0LXRlc3Qt
cnVubmVyIFsgdXNlRmxleGlibGVWaWV3cG9ydD10cnVlIGludGVybmFsOkFkQ2xpY2tBdHRyaWJ1
dGlvbkVuYWJsZWQ9dHJ1ZSBdIC0tPgogPGh0bWwgbGFuZz0iZW4iPgogPGhlYWQ+CiAgICAgPG1l
dGEgY2hhcnNldD0iVVRGLTgiPgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RF
eHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RF
eHBlY3RhdGlvbnMJKHJldmlzaW9uIDI0MzY1NCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dr
Mi9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC03NTEsNyArNzUxLDYgQEAgc3Rv
cmFnZS9pbmRleGVkZGIvSURCT2JqZWN0LWxlYWsuaHRtbCBbIAogZmFzdC9mb3Jtcy9jYWxsLXRl
eHQtZGlkLWNoYW5nZS1pbi10ZXh0LWZpZWxkLXdoZW4tdHlwaW5nLmh0bWwgWyBQYXNzIF0KIAog
aHR0cC90ZXN0cy9hZENsaWNrQXR0cmlidXRpb24gWyBQYXNzIF0KLWh0dHAvdGVzdHMvYWRDbGlj
a0F0dHJpYnV0aW9uL3N0b3JlLWFkLWNsaWNrLWF0dHJpYnV0aW9uLmh0bWwgWyBTa2lwIF0KIAog
IyMjIEVORCBPRiAoNSkgUHJvZ3Jlc3Npb25zLCBleHBlY3RlZCBzdWNjZXNzZXMgdGhhdCBhcmUg
ZXhwZWN0ZWQgZmFpbHVyZXMgaW4gV2ViS2l0MS4KICMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj
IyMjIyMjIyMjIyMjIyMK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>366546</attachid>
            <date>2019-04-02 16:22:00 -0700</date>
            <delta_ts>2019-04-03 10:23:39 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-196476-20190402162201.patch</filename>
            <type>text/plain</type>
            <size>2962</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDM3NjcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTAyICBBbGV4IENocmlz
dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVzdXJyZWN0IGFu
ZCBmaXggbGF5b3V0IHRlc3QgaHR0cC90ZXN0cy9hZENsaWNrQXR0cmlidXRpb24vc3RvcmUtYWQt
Y2xpY2stYXR0cmlidXRpb24uaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTk2NDc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgUmUtYXBwbHkgYSBjaGFuZ2UgSSByZXZlcnRlZCBpbiByMjQxNzU0IG5v
dyB0aGF0IGl0J3Mgc2FmZSB0byBkbyBzby4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdl
UHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmRpZENvbW1pdExvYWRG
b3JGcmFtZSk6CisKIDIwMTktMDQtMDIgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A
d2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggYXNzZXJ0aW9uIGluIGh0dHAvdGVzdHMvYWRDbGlj
a0F0dHJpYnV0aW9uL3N0b3JlLWFkLWNsaWNrLWF0dHJpYnV0aW9uLmh0bWwKSW5kZXg6IFNvdXJj
ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl
L1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNpb24gMjQzNzY3KQorKysg
U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpA
QCAtNDE0NSw2ICs0MTQ1LDEzIEBAIHZvaWQgV2ViUGFnZVByb3h5OjpkaWRDb21taXRMb2FkRm9y
RnJhbWUKIAogICAgIGZyYW1lLT5kaWRDb21taXRMb2FkKG1pbWVUeXBlLCB3ZWJDZXJ0aWZpY2F0
ZUluZm8sIGNvbnRhaW5zUGx1Z2luRG9jdW1lbnQpOwogCisgICAgaWYgKG5hdmlnYXRpb24gJiYg
ZnJhbWUtPmlzTWFpbkZyYW1lKCkpIHsKKyAgICAgICAgaWYgKGF1dG8mIGFkQ2xpY2tBdHRyaWJ1
dGlvbiA9IG5hdmlnYXRpb24tPmFkQ2xpY2tBdHRyaWJ1dGlvbigpKSB7CisgICAgICAgICAgICBp
ZiAoYWRDbGlja0F0dHJpYnV0aW9uLT5kZXN0aW5hdGlvbigpLm1hdGNoZXMoZnJhbWUtPnVybCgp
KSkKKyAgICAgICAgICAgICAgICBtX3Byb2Nlc3MtPnByb2Nlc3NQb29sKCkuc2VuZFRvTmV0d29y
a2luZ1Byb2Nlc3MoTWVzc2FnZXM6Ok5ldHdvcmtQcm9jZXNzOjpTdG9yZUFkQ2xpY2tBdHRyaWJ1
dGlvbihtX3dlYnNpdGVEYXRhU3RvcmUtPnNlc3Npb25JRCgpLCAqYWRDbGlja0F0dHJpYnV0aW9u
KSk7CisgICAgICAgIH0KKyAgICB9CisKICAgICBpZiAoZnJhbWUtPmlzTWFpbkZyYW1lKCkpIHsK
ICAgICAgICAgbV9tYWluRnJhbWVIYXNDdXN0b21Db250ZW50UHJvdmlkZXIgPSBmcmFtZUhhc0N1
c3RvbUNvbnRlbnRQcm92aWRlcjsKIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjQzNzY3KQorKysgTGF5
b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTkt
MDQtMDIgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAg
ICAgICBSZXN1cnJlY3QgYW5kIGZpeCBsYXlvdXQgdGVzdCBodHRwL3Rlc3RzL2FkQ2xpY2tBdHRy
aWJ1dGlvbi9zdG9yZS1hZC1jbGljay1hdHRyaWJ1dGlvbi5odG1sCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY0NzYKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvYWRDbGlja0F0dHJp
YnV0aW9uL3N0b3JlLWFkLWNsaWNrLWF0dHJpYnV0aW9uLWV4cGVjdGVkLnR4dDoKKwogMjAxOS0w
NC0wMiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAg
ICAgIEZpeCBhc3NlcnRpb24gaW4gaHR0cC90ZXN0cy9hZENsaWNrQXR0cmlidXRpb24vc3RvcmUt
YWQtY2xpY2stYXR0cmlidXRpb24uaHRtbApJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9h
ZENsaWNrQXR0cmlidXRpb24vc3RvcmUtYWQtY2xpY2stYXR0cmlidXRpb24tZXhwZWN0ZWQudHh0
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYWRDbGlja0F0dHJpYnV0aW9u
L3N0b3JlLWFkLWNsaWNrLWF0dHJpYnV0aW9uLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMjQzNzY3
KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hZENsaWNrQXR0cmlidXRpb24vc3RvcmUtYWQt
Y2xpY2stYXR0cmlidXRpb24tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEs
OCBAQAogVGVzdHMgc3RvcmFnZSBvZiBhZCBjbGljayBhdHRyaWJ1dGlvbi4KIAogCi1ObyBzdG9y
ZWQgQWQgQ2xpY2sgQXR0cmlidXRpb24gZGF0YS4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxl
CitXZWJDb3JlOjpBZENsaWNrQXR0cmlidXRpb24gMQorU291cmNlOiAxMjcuMC4wLjEKK0Rlc3Rp
bmF0aW9uOiBsb2NhbGhvc3QKK0NhbXBhaWduIElEOiAzCitObyBjb252ZXJzaW9uIGRhdGEuCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>