196391 2019-03-28 23:45:11 -0700 [Win][WebKit] MiniBrowser should support high DPI display 2019-03-31 18:39:23 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham don.olmstead ews-watchlist lforschler pvollan ross.kirsling webkit-bug-importer oldest_to_newest 1522386 0 fujii 2019-03-28 23:45:11 -0700 [Win][WebKit] MiniBrowser should support high DPI display MiniBrowser shows tiny texts in high DPI display at the moment. In WebKitLegacy Windows port and WebKit other ports, high DPI is supported by WebView, not by applications. I tried this approach in Bug 196339. It seems it makes thinks complicated for Windows because Windows window coordinated system differs from other ports. In contrast, it seems easy to implement in the application side just by changing the default page zoom factor. 1522388 1 366253 fujii 2019-03-28 23:58:36 -0700 Created attachment 366253 Patch 1522389 2 ews-watchlist 2019-03-29 00:01:32 -0700 Attachment 366253 did not pass style-queue: ERROR: Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:40: Use the class HWndDC instead of calling GetDC to avoid potential memory leaks. [runtime/leaky_pattern] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1522392 3 366255 fujii 2019-03-29 00:10:55 -0700 Created attachment 366255 Patch 1522845 4 366255 fujii 2019-03-31 18:38:36 -0700 Comment on attachment 366255 Patch Clearing flags on attachment: 366255 Committed r243685: <https://trac.webkit.org/changeset/243685> 1522846 5 fujii 2019-03-31 18:38:39 -0700 All reviewed patches have been landed. Closing bug. 1522847 6 webkit-bug-importer 2019-03-31 18:39:23 -0700 <rdar://problem/49464798> 366253 2019-03-28 23:58:36 -0700 2019-03-29 00:10:29 -0700 Patch a.diff text/plain 2074 fujii ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyMGIz YmM4MDMzNi4uNzEwYmU1MzAxZWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0wMy0yOCAgRnVqaWkgSGlyb25v cmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KKworICAgICAgICBbV2luXVtXZWJLaXRdIE1p bmlCcm93c2VyIHNob3VsZCBzdXBwb3J0IGhpZ2ggRFBJIGRpc3BsYXkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjM5MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvd2luL1dlYktp dEJyb3dzZXJXaW5kb3cuY3BwOgorICAgICAgICAoZGV2aWNlU2NhbGVGYWN0b3JGb3JXaW5kb3cp OiBBZGRlZC4KKyAgICAgICAgKFdlYktpdEJyb3dzZXJXaW5kb3c6OldlYktpdEJyb3dzZXJXaW5k b3cpOiBDYWxsIHJlc2V0Wm9vbSB0byBzZXQgdGhlIHBhZ2Ugem9vbSBmYWN0b3IuCisgICAgICAg IChXZWJLaXRCcm93c2VyV2luZG93OjpyZXNldFpvb20pOiBDaGFuZ2VkIHRoZSBkZWZhdWx0IHBh Z2Ugem9vbSBmYWN0b3IgZnJvbSAxIHRvIHRoZSBkZXZpY2Ugc2NhbGUgZmFjdG9yLgorCiAyMDE5 LTAzLTI4ICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJl c291cmNlIExvYWQgU3RhdGlzdGljczogSVBDIHRvIHRoZSBXZWJzaXRlRGF0YVN0b3JlIGluIHRo ZSBVSSBwcm9jZXNzIGZyb20gTmV0d29ya1Byb2Nlc3M6OmRlbGV0ZVdlYnNpdGVEYXRhRm9yUmVn aXN0cmFibGVEb21haW5zKCkKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9XZWJL aXRCcm93c2VyV2luZG93LmNwcCBiL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9XZWJLaXRCcm93c2Vy V2luZG93LmNwcAppbmRleCBhYTUyYWUzZmY3OC4uYTllNTU2NTA4Y2MgMTAwNjQ0Ci0tLSBhL1Rv b2xzL01pbmlCcm93c2VyL3dpbi9XZWJLaXRCcm93c2VyV2luZG93LmNwcAorKysgYi9Ub29scy9N aW5pQnJvd3Nlci93aW4vV2ViS2l0QnJvd3NlcldpbmRvdy5jcHAKQEAgLTM1LDYgKzM1LDE0IEBA CiAjaW5jbHVkZSA8V2ViS2l0L1dLV2Vic2l0ZURhdGFTdG9yZVJlZkN1cmwuaD4KICNpbmNsdWRl IDx2ZWN0b3I+CiAKK3N0YXRpYyBmbG9hdCBkZXZpY2VTY2FsZUZhY3RvckZvcldpbmRvdyhIV05E IHdpbmRvdykKK3sKKyAgICBIREMgZGMgPSBHZXREQyh3aW5kb3cpOworICAgIGZsb2F0IHNjYWxl ID0gR2V0RGV2aWNlQ2FwcyhkYywgTE9HUElYRUxTWCkgLyA5Ni4wOworICAgIFJlbGVhc2VEQyh3 aW5kb3csIGRjKTsKKyAgICByZXR1cm4gc2NhbGU7Cit9CisKIHN0ZDo6d3N0cmluZyBjcmVhdGVT dHJpbmcoV0tTdHJpbmdSZWYgd2tTdHJpbmcpCiB7CiAgICAgc2l6ZV90IG1heFNpemUgPSBXS1N0 cmluZ0dldExlbmd0aCh3a1N0cmluZyk7CkBAIC0xMTksNiArMTI3LDcgQEAgV2ViS2l0QnJvd3Nl cldpbmRvdzo6V2ViS2l0QnJvd3NlcldpbmRvdyhXS1BhZ2VDb25maWd1cmF0aW9uUmVmIGNvbmYs IEhXTkQgbWFpblcKICAgICBXS1BhZ2VTZXRQYWdlVUlDbGllbnQocGFnZSwgJnVpQ2xpZW50LmJh c2UpOwogCiAgICAgdXBkYXRlUHJveHlTZXR0aW5ncygpOworICAgIHJlc2V0Wm9vbSgpOwogfQog CiB2b2lkIFdlYktpdEJyb3dzZXJXaW5kb3c6OnVwZGF0ZVByb3h5U2V0dGluZ3MoKQpAQCAtMjQy LDcgKzI1MSw3IEBAIHZvaWQgV2ViS2l0QnJvd3NlcldpbmRvdzo6dXBkYXRlU3RhdGlzdGljcyhI V05EIGhEbGcpCiB2b2lkIFdlYktpdEJyb3dzZXJXaW5kb3c6OnJlc2V0Wm9vbSgpCiB7CiAgICAg YXV0byBwYWdlID0gV0tWaWV3R2V0UGFnZShtX3ZpZXcuZ2V0KCkpOwotICAgIFdLUGFnZVNldFBh Z2Vab29tRmFjdG9yKHBhZ2UsIDEpOworICAgIFdLUGFnZVNldFBhZ2Vab29tRmFjdG9yKHBhZ2Us IGRldmljZVNjYWxlRmFjdG9yRm9yV2luZG93KGh3bmQoKSkpOwogfQogCiB2b2lkIFdlYktpdEJy b3dzZXJXaW5kb3c6Onpvb21JbigpCg== 366255 2019-03-29 00:10:55 -0700 2019-03-31 18:38:36 -0700 Patch bug-196391-20190329161054.patch text/plain 2443 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNjQyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjBiM2JjODAzMzYzZDA5ZTI1MDQyYzU5ZTA4MDNkZGJj ODRjY2UwYy4uMzE0MTBmNjJmMmQ5NWEyZjcxMmU0N2I3NzMzYzEyZmVmNjc3ZWJiMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTAzLTI4ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dW1dlYktpdF0gTWluaUJyb3dzZXIgc2hvdWxkIHN1cHBvcnQgaGln aCBEUEkgZGlzcGxheQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk2MzkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBNaW5pQnJvd3Nlci93aW4vV2ViS2l0QnJvd3NlcldpbmRvdy5jcHA6CisgICAgICAg IChXZWJLaXRCcm93c2VyV2luZG93OjpXZWJLaXRCcm93c2VyV2luZG93KTogQ2FsbCByZXNldFpv b20gdG8gc2V0IHRoZSBwYWdlIHpvb20gZmFjdG9yLgorICAgICAgICAoV2ViS2l0QnJvd3Nlcldp bmRvdzo6cmVzZXRab29tKTogQ2hhbmdlZCB0aGUgZGVmYXVsdCBwYWdlIHpvb20gZmFjdG9yIGZy b20gMSB0byB0aGUgZGV2aWNlIHNjYWxlIGZhY3Rvci4KKyAgICAgICAgKiBNaW5pQnJvd3Nlci93 aW4vc3RkYWZ4Lmg6IERlZmluZSBXRUJDT1JFX0VYUE9SVC4KKwogMjAxOS0wMy0yOCAgSm9obiBX aWxhbmRlciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXNvdXJjZSBMb2FkIFN0 YXRpc3RpY3M6IElQQyB0byB0aGUgV2Vic2l0ZURhdGFTdG9yZSBpbiB0aGUgVUkgcHJvY2VzcyBm cm9tIE5ldHdvcmtQcm9jZXNzOjpkZWxldGVXZWJzaXRlRGF0YUZvclJlZ2lzdHJhYmxlRG9tYWlu cygpCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci93aW4vV2ViS2l0QnJvd3NlcldpbmRv dy5jcHAgYi9Ub29scy9NaW5pQnJvd3Nlci93aW4vV2ViS2l0QnJvd3NlcldpbmRvdy5jcHAKaW5k ZXggYWE1MmFlM2ZmNzg1NDA1OTFjMzA1MDAyMjllMmJlYTI0YTA1Mzc2ZC4uMTAyMmM0YTg3NzFm ZDJlY2YyNGY4YjRlOWY3ZTAyZTY0NWQzOWQ5MCAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dz ZXIvd2luL1dlYktpdEJyb3dzZXJXaW5kb3cuY3BwCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL3dp bi9XZWJLaXRCcm93c2VyV2luZG93LmNwcApAQCAtMjcsNiArMjcsNyBAQAogCiAjaW5jbHVkZSAi TWluaUJyb3dzZXJMaWJSZXNvdXJjZS5oIgogI2luY2x1ZGUgImNvbW1vbi5oIgorI2luY2x1ZGUg PFdlYkNvcmUvR0RJVXRpbGl0aWVzLmg+CiAjaW5jbHVkZSA8V2ViS2l0L1dLQXV0aGVudGljYXRp b25DaGFsbGVuZ2UuaD4KICNpbmNsdWRlIDxXZWJLaXQvV0tBdXRoZW50aWNhdGlvbkRlY2lzaW9u TGlzdGVuZXIuaD4KICNpbmNsdWRlIDxXZWJLaXQvV0tDcmVkZW50aWFsLmg+CkBAIC0xMTksNiAr MTIwLDcgQEAgV2ViS2l0QnJvd3NlcldpbmRvdzo6V2ViS2l0QnJvd3NlcldpbmRvdyhXS1BhZ2VD b25maWd1cmF0aW9uUmVmIGNvbmYsIEhXTkQgbWFpblcKICAgICBXS1BhZ2VTZXRQYWdlVUlDbGll bnQocGFnZSwgJnVpQ2xpZW50LmJhc2UpOwogCiAgICAgdXBkYXRlUHJveHlTZXR0aW5ncygpOwor ICAgIHJlc2V0Wm9vbSgpOwogfQogCiB2b2lkIFdlYktpdEJyb3dzZXJXaW5kb3c6OnVwZGF0ZVBy b3h5U2V0dGluZ3MoKQpAQCAtMjQyLDcgKzI0NCw3IEBAIHZvaWQgV2ViS2l0QnJvd3NlcldpbmRv dzo6dXBkYXRlU3RhdGlzdGljcyhIV05EIGhEbGcpCiB2b2lkIFdlYktpdEJyb3dzZXJXaW5kb3c6 OnJlc2V0Wm9vbSgpCiB7CiAgICAgYXV0byBwYWdlID0gV0tWaWV3R2V0UGFnZShtX3ZpZXcuZ2V0 KCkpOwotICAgIFdLUGFnZVNldFBhZ2Vab29tRmFjdG9yKHBhZ2UsIDEpOworICAgIFdLUGFnZVNl dFBhZ2Vab29tRmFjdG9yKHBhZ2UsIFdlYkNvcmU6OmRldmljZVNjYWxlRmFjdG9yRm9yV2luZG93 KGh3bmQoKSkpOwogfQogCiB2b2lkIFdlYktpdEJyb3dzZXJXaW5kb3c6Onpvb21JbigpCmRpZmYg LS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci93aW4vc3RkYWZ4LmggYi9Ub29scy9NaW5pQnJvd3Nl ci93aW4vc3RkYWZ4LmgKaW5kZXggYzc4ZDRjMWU1YjhmYjUyMjZmZGFlZmFlM2ZlNjNjMmI2ZmJm NWZjYS4uMDRmMGEzZjhmNjk5ODE4NTQ0ZDA4MzExNzhkOWQ3ZmFkYjdlOWU5YSAxMDA2NDQKLS0t IGEvVG9vbHMvTWluaUJyb3dzZXIvd2luL3N0ZGFmeC5oCisrKyBiL1Rvb2xzL01pbmlCcm93c2Vy L3dpbi9zdGRhZnguaApAQCAtNjgsMyArNjgsNSBAQAogI2luY2x1ZGUgPGNydGRiZy5oPgogI2Vu ZGlmCiAjZW5kaWYKKworI2RlZmluZSBXRUJDT1JFX0VYUE9SVCBXVEZfSU1QT1JUCg==