196390 2019-03-28 22:14:26 -0700 Pasting a table from Confluence strip of table cell content 2019-03-29 11:39:53 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa koivisto simon.fraser wenson_hsieh oldest_to_newest 1522374 0 rniwa 2019-03-28 22:14:26 -0700 Copying & pasting a table from Atlassian's Confluence causes table's content to be stripped away. <rdar://problem/47365649> 1522375 1 rniwa 2019-03-28 22:15:02 -0700 This is because TextIterator is skipping the rendered text because it think it’s fully clipped due to a div that contains table in the markup below. This is in turn due to createPageForSanitizingWebContent creating a 0px by 0px FrameView. 1522382 2 366252 rniwa 2019-03-28 22:38:03 -0700 Created attachment 366252 Fixes the bug 1522513 3 rniwa 2019-03-29 11:39:53 -0700 Committed r243653: <https://trac.webkit.org/changeset/243653> 366252 2019-03-28 22:38:03 -0700 2019-03-29 00:10:58 -0700 Fixes the bug bug-196390-20190328223803.patch text/plain 6456 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0MzY0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE5LTAzLTI4ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFBhc3RpbmcgYSB0YWJsZSBmcm9t IENvbmZsdWVuY2Ugc3RyaXAgb2YgdGFibGUgY2VsbCBjb250ZW50CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYzOTAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYnVnIHdhcyB1bHRpbWF0ZWx5IGNh dXNlZCBieSBGcmFtZVZpZXcgb2YgdGhlIGRvY3VtZW50IHdlIHVzZSB0byBzYW5pdGl6ZSB0aGUg cGFzdGVib2FyZCBjb250ZW50CisgICAgICAgIGhhdmluZyAwcHggYnkgMHB4IGRpbWVuc2lvbi4g VGhpcyBjYXVzZWQgZGl2IHdpdGggYG92ZXJmbG93LXg6IGF1dG9gIHN1cnJvdW5kaW5nIGEgdGFi bGUgdG8gaGF2ZQorICAgICAgICB0aGUgaGVpZ2h0IG9mIDBweC4gQmVjYXVzZSBTdHlsZWRNYXJr dXBBY2N1bXVsYXRvcjo6cmVuZGVyZWRUZXh0UmVzcGVjdGluZ1JhbmdlIHVzZXMgVGV4dEl0ZXJh dG9yCisgICAgICAgIHRvIHNlcmlhbGl6ZSBhIHRleHQgbm9kZSBhbmQgdGhpcyBkaXYgd2FzIGFu IGFuY2VzdG9yIG9mIHRoZSB0ZXh0IG5vZGUsIFRleHRJdGVyYXRvcjo6aGFuZGxlVGV4dE5vZGUK KyAgICAgICAgZW5kZWQgdXAgZXhpdGluZyBlYXJseS4KKworICAgICAgICBGaXhlZCB0aGUgYnVn IGJ5IGdpdmluZyBGcmFtZVZpZXcsIHdoaWNoIGlzIHVzZWQgdG8gc2FuaXRpemUgdGhlIGNvbnRl bnQsIGEgZGltZW5zaW9uIG9mIDgwMHB4IGJ5IDYwMHB4LgorCisgICAgICAgIFVzaW5nIFRleHRJ dGVyYXRvcklnbm9yZXNTdHlsZVZpc2liaWxpdHkgaXMgbm90IGEgZ3JlYXQgYWx0ZXJuYXRpdmUg c2luY2UgcmVtb3ZpbmcgaW52aXNpYmxlIGNvbnRlbnQKKyAgICAgICAgZHVyaW5nIHBhc3RlIGlz IGFuIGltcG9ydGFudCBwcml2YWN5IGZlYXR1cmUuCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9w YXN0ZWJvYXJkL3Bhc3RlLWNvbnRlbnQtd2l0aC1vdmVyZmxvdy1hdXRvLXBhcmVudC1hY3Jvc3Mt b3JpZ2luLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvbWFya3VwLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OmNyZWF0ZVBhZ2VGb3JTYW5pdGl6aW5nV2ViQ29udGVudCk6CisKIDIwMTktMDMtMjgg IENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTdXBwb3J0IDxvYmpl Y3Q+LmNvbnRlbnRXaW5kb3cKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAJKHJldmlz aW9uIDI0MzYzNCkKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTgzLDcgKzE4Myw3IEBAIHN0ZDo6dW5pcXVlX3B0cjxQYWdlPiBjcmVhdGVQ YWdlRm9yU2FuaXQKICAgICBwYWdlLT5zZXR0aW5ncygpLnNldEFjY2VsZXJhdGVkQ29tcG9zaXRp bmdFbmFibGVkKGZhbHNlKTsKIAogICAgIEZyYW1lJiBmcmFtZSA9IHBhZ2UtPm1haW5GcmFtZSgp OwotICAgIGZyYW1lLnNldFZpZXcoRnJhbWVWaWV3OjpjcmVhdGUoZnJhbWUpKTsKKyAgICBmcmFt ZS5zZXRWaWV3KEZyYW1lVmlldzo6Y3JlYXRlKGZyYW1lLCBJbnRTaXplIHsgODAwLCA2MDAgfSkp OwogICAgIGZyYW1lLmluaXQoKTsKIAogICAgIEZyYW1lTG9hZGVyJiBsb2FkZXIgPSBmcmFtZS5s b2FkZXIoKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0MzYzNSkKKysrIExheW91dFRlc3RzL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAzLTI5ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFBhc3RpbmcgYSB0YWJsZSBmcm9t IENvbmZsdWVuY2Ugc3RyaXAgb2YgdGFibGUgY2VsbCBjb250ZW50CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYzOTAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhIHJlZ3Jlc3Npb24gdGVzdC4K KworICAgICAgICAqIGVkaXRpbmcvcGFzdGVib2FyZC9wYXN0ZS1jb250ZW50LXdpdGgtb3ZlcmZs b3ctYXV0by1wYXJlbnQtYWNyb3NzLW9yaWdpbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGVkaXRpbmcvcGFzdGVib2FyZC9wYXN0ZS1jb250ZW50LXdpdGgtb3ZlcmZsb3ctYXV0by1w YXJlbnQtYWNyb3NzLW9yaWdpbi5odG1sOiBBZGRlZC4KKwogMjAxOS0wMy0yOCAgUnlvc3VrZSBO aXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBnZXRCb3VuZGluZ0NsaWVudFJlY3Qg YWx3YXlzIHJldHVybnMgZW1wdHkgcmVjdCBvbiBhIGNvbGxhcHNlZCByYW5nZQpJbmRleDogTGF5 b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL3Bhc3RlLWNvbnRlbnQtd2l0aC1vdmVyZmxvdy1h dXRvLXBhcmVudC1hY3Jvc3Mtb3JpZ2luLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvcGFzdGUtY29udGVudC13aXRoLW92ZXJmbG93LWF1 dG8tcGFyZW50LWFjcm9zcy1vcmlnaW4tZXhwZWN0ZWQudHh0CShub25leGlzdGVudCkKKysrIExh eW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9wYXN0ZS1jb250ZW50LXdpdGgtb3ZlcmZsb3ct YXV0by1wYXJlbnQtYWNyb3NzLW9yaWdpbi1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAg LTAsMCArMSwxNiBAQAorVGhpcyB0ZXN0cyBjb3B5aW5nIGFuZCBwYXN0aW5nIGNvbnRlbnQgd2l0 aCAib3ZlcmZsb3c6IGF1dG8iIHdvdWxkIG5vdCBzdHJpcCBpdHMgY29udGVudC4KKworT24gc3Vj Y2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQg YnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgbWFya3VwLmluY2x1ZGVzKCJzZWNyZXQiKSBp cyBmYWxzZQorUEFTUyBtYXJrdXAuaW5jbHVkZXMoIlN0YXJ0PC9kaXY+IikgaXMgdHJ1ZQorUEFT UyBtYXJrdXAuaW5jbHVkZXMoIkNvbnRlbnQ8L3A+IikgaXMgdHJ1ZQorUEFTUyBtYXJrdXAuaW5j bHVkZXMoIkVuZDwvc3Bhbj4iKSBpcyB0cnVlCitQQVNTIGVkaXRvci5xdWVyeVNlbGVjdG9yKCJk aXYiKS50ZXh0Q29udGVudCBpcyAiU3RhcnQiCitQQVNTIGVkaXRvci5xdWVyeVNlbGVjdG9yKCJw IikudGV4dENvbnRlbnQgaXMgIkNvbnRlbnQiCitQQVNTIGVkaXRvci5xdWVyeVNlbGVjdG9yKCJz cGFuIikudGV4dENvbnRlbnQgaXMgIkVuZCIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRy dWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9h cmQvcGFzdGUtY29udGVudC13aXRoLW92ZXJmbG93LWF1dG8tcGFyZW50LWFjcm9zcy1vcmlnaW4u aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvcGFzdGUt Y29udGVudC13aXRoLW92ZXJmbG93LWF1dG8tcGFyZW50LWFjcm9zcy1vcmlnaW4uaHRtbAkobm9u ZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvcGFzdGUtY29udGVu dC13aXRoLW92ZXJmbG93LWF1dG8tcGFyZW50LWFjcm9zcy1vcmlnaW4uaHRtbAkod29ya2luZyBj b3B5KQpAQCAtMCwwICsxLDYzIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8 c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlw dD4KKworZGVzY3JpcHRpb24oJ1RoaXMgdGVzdHMgY29weWluZyBhbmQgcGFzdGluZyBjb250ZW50 IHdpdGggIm92ZXJmbG93OiBhdXRvIiB3b3VsZCBub3Qgc3RyaXAgaXRzIGNvbnRlbnQuJyk7CisK K2Z1bmN0aW9uIHN0YXJ0VGVzdCgpIHsKKyAgICBjb25zdCBpZnJhbWUgPSBkb2N1bWVudC5jcmVh dGVFbGVtZW50KCdpZnJhbWUnKTsKKyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGlmcmFt ZSk7CisgICAgaWZyYW1lLnNyYyA9IGBkYXRhOnRleHQvaHRtbDtjaGFyc2V0PXV0Zi04LDwhRE9D VFlQRSBodG1sPgorICAgIDxib2R5PjxidXR0b24gb25jbGljaz0iZG9jdW1lbnQuZXhlY0NvbW1h bmQoJ3NlbGVjdEFsbCcpOyBkb2N1bWVudC5leGVjQ29tbWFuZCgnY29weScpOyBnZXRTZWxlY3Rp b24oKS5yZW1vdmVBbGxSYW5nZXMoKTsiPlN0YXJ0PC9idXR0b24+CisgICAgPHNjcmlwdD4KKyAg ICBkb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCdjb3B5JywgKCkgPT4geworICAgICAgICBldmVu dC5wcmV2ZW50RGVmYXVsdCgpOworICAgICAgICBldmVudC5jbGlwYm9hcmREYXRhLnNldERhdGEo J3RleHQvaHRtbCcsICc8ZGl2PlN0YXJ0PC9kaXY+PGRpdiBzdHlsZT0iaGVpZ2h0OiAxMDAwcHg7 Ij48L2Rpdj48IS0tIHNlY3JldCAtLT4nCisgICAgICAgICAgICArICc8ZGl2IHN0eWxlPSJ2aXNp YmlsaXR5OiBoaWRkZW47Ij5zZWNyZXQ8L2Rpdj48cCBzdHlsZT0ib3ZlcmZsb3c6IGF1dG87Ij5D b250ZW50PC9wPjxkaXYgc3R5bGU9ImhlaWdodDogMTAwMHB4OyI+PC9kaXY+PHNwYW4gaWQ9ImVu ZCI+RW5kPC9zcGFuPicpOworICAgICAgICB3aW5kb3cucGFyZW50LnBvc3RNZXNzYWdlKHt9LCAn KicpOworICAgIH0pOworICAgIHdpbmRvdy5vbmxvYWQgPSAoKSA9PiB7CisgICAgICAgIGRvY3Vt ZW50LmV4ZWNDb21tYW5kKCdzZWxlY3RBbGwnKTsKKyAgICAgICAgZG9jdW1lbnQuZXhlY0NvbW1h bmQoJ2NvcHknKTsKKyAgICB9CisgICAgPC9zY2AgKyBgcmlwdD4KKyAgICA8L2JvZHk+YDsKK30K KworCitmdW5jdGlvbiBjb250aW51ZVRlc3QoKSB7CisgICAgZWRpdG9yLmZvY3VzKCk7CisgICAg ZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ3NlbGVjdEFsbCcpOworICAgIGlmICh3aW5kb3cudGVzdFJ1 bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5leGVjQ29tbWFuZCgncGFzdGUnKTsKK30KKworZnVu Y3Rpb24gZGlkUGFzdGUoZXZlbnQpIHsKKyAgICB3aW5kb3cubWFya3VwID0gZXZlbnQuY2xpcGJv YXJkRGF0YS5nZXREYXRhKCd0ZXh0L2h0bWwnKTsKKyAgICBzaG91bGRCZUZhbHNlKCdtYXJrdXAu aW5jbHVkZXMoInNlY3JldCIpJyk7CisgICAgc2hvdWxkQmVUcnVlKCdtYXJrdXAuaW5jbHVkZXMo IlN0YXJ0PC9kaXY+IiknKTsKKyAgICBzaG91bGRCZVRydWUoJ21hcmt1cC5pbmNsdWRlcygiQ29u dGVudDwvcD4iKScpOworICAgIHNob3VsZEJlVHJ1ZSgnbWFya3VwLmluY2x1ZGVzKCJFbmQ8L3Nw YW4+IiknKTsKKworICAgIHNldFRpbWVvdXQoKCkgPT4geworICAgICAgICBzaG91bGRCZUVxdWFs VG9TdHJpbmcoJ2VkaXRvci5xdWVyeVNlbGVjdG9yKCJkaXYiKS50ZXh0Q29udGVudCcsICdTdGFy dCcpOworICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2VkaXRvci5xdWVyeVNlbGVjdG9y KCJwIikudGV4dENvbnRlbnQnLCAnQ29udGVudCcpOworICAgICAgICBzaG91bGRCZUVxdWFsVG9T dHJpbmcoJ2VkaXRvci5xdWVyeVNlbGVjdG9yKCJzcGFuIikudGV4dENvbnRlbnQnLCAnRW5kJyk7 CisgICAgICAgIGVkaXRvci50ZXh0Q29udGVudCA9IGVkaXRvci5pbm5lckhUTUw7CisgICAgICAg IGVkaXRvci5jb250ZW50RWRpdGFibGUgPSBmYWxzZTsKKyAgICAgICAgaWYgKHdpbmRvdy50ZXN0 UnVubmVyKQorICAgICAgICAgICAgZWRpdG9yLnN0eWxlLmRpc3BsYXkgPSAnbm9uZSc7CisgICAg ICAgIGZpbmlzaEpTVGVzdCgpOworICAgIH0sIDApOworfQorCitvbmxvYWQgPSBzdGFydFRlc3Q7 Citvbm1lc3NhZ2UgPSBjb250aW51ZVRlc3Q7Citqc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKKworPC9z Y3JpcHQ+Cis8ZGl2IGlkPSJlZGl0b3IiIG9ucGFzdGU9ImRpZFBhc3RlKGV2ZW50KSIgY29udGVu dGVkaXRhYmxlPlBhc3RlIG5vdzwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUg YXQgZW5kIG9mIGZpbGUK