19623 2008-06-17 16:25:16 -0700 [Transforms] Incomplete repaint adding scale transform to element 2008-11-20 17:58:08 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED HasReduction P2 Normal --- 21942 1 dev+webkit simon.fraser mitz simon.fraser oldest_to_newest 83659 0 dev+webkit 2008-06-17 16:25:16 -0700 If an element has no -webkit-transform specified, adding it later on to scale it will result in severe underpainting. Happens in both Safari 3.1.1 and ToT. 83660 1 21774 dev+webkit 2008-06-17 16:25:34 -0700 Created attachment 21774 reduction 99571 2 25326 simon.fraser 2008-11-20 17:53:54 -0800 Created attachment 25326 Patch, testcase, changelog 99572 3 simon.fraser 2008-11-20 17:58:08 -0800 Committed r38651 M WebCore/ChangeLog M WebCore/rendering/RenderObject.cpp A LayoutTests/platform/mac/fast/repaint/change-transform-expected.png A LayoutTests/platform/mac/fast/repaint/change-transform-expected.txt A LayoutTests/platform/mac/fast/repaint/change-transform-expected.checksum M LayoutTests/ChangeLog A LayoutTests/fast/repaint/change-transform.html r38651 = 1dffe8ff6fe257f4ed56ef33ea027dac44e9ef0a (trunk) 21774 2008-06-17 16:25:34 -0700 2008-06-17 16:25:34 -0700 reduction repaint.html text/html 320 dev+webkit PHNjcmlwdD4KICAgIGZ1bmN0aW9uIHNocmluaygpCiAgICB7CiAgICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoInNxdWFyZSIpLnN0eWxlWyctd2Via2l0LXRyYW5zZm9ybSddID0gInNjYWxl KDAuNSwgMC41KSI7CiAgICB9Cjwvc2NyaXB0PgoKVGhlIHNxdWFyZSBiZWxvdyBzaG91bGQgY2xl YW5seSByZXBhaW50IGFmdGVyIHByZXNzaW5nIDxidXR0b24gb25jbGljaz0ic2hyaW5rKCkiPnNo cmluazwvYnV0dG9uPgo8ZGl2IGlkPSJzcXVhcmUiIHN0eWxlPSJ3aWR0aDogMTAwcHg7IGhlaWdo dDogMTAwcHg7IGJhY2tncm91bmQ6IHJlZDsiPjwvZGl2Pgo= 25326 2008-11-20 17:53:54 -0800 2008-11-20 17:55:45 -0800 Patch, testcase, changelog 19623_patch.txt text/plain 6650 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5ZmUzMTgzLi4xNjI5YjE3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMDgtMTEt MjAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5NjIzCisgICAgICAgIAorICAgICAgICBUZXN0IGZvciBjb3Jy ZWN0IHJlcGFpbnQgd2hlbiBhbiBvYmplY3QgZ2FpbnMKKyAgICAgICAgYSBsYXllciB3aXRoIGEg dHJhbnNmb3JtIHRoYXQgaXMgc21hbGxlciB0aGFuIHRoZQorICAgICAgICBvbGQgYm91bmRzIG9m IHRoZSBvYmplY3QuCisKKyAgICAgICAgKiBmYXN0L3JlcGFpbnQvY2hhbmdlLXRyYW5zZm9ybS5o dG1sOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50L2NoYW5nZS10 cmFuc2Zvcm0tZXhwZWN0ZWQuY2hlY2tzdW06IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21h Yy9mYXN0L3JlcGFpbnQvY2hhbmdlLXRyYW5zZm9ybS1leHBlY3RlZC5wbmc6IEFkZGVkLgorICAg ICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvY2hhbmdlLXRyYW5zZm9ybS1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorCiAyMDA4LTExLTIwICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0bwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9yZXBhaW50L2NoYW5nZS10cmFuc2Zvcm0uaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvcmVwYWludC9jaGFuZ2UtdHJhbnNmb3JtLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMC4uNzkzMjFmMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvcmVwYWludC9jaGFuZ2UtdHJhbnNmb3JtLmh0bWwKQEAgLTAsMCArMSwzNyBAQAorPGh0bWw+ Cis8aGVhZD4KKyAgPHNjcmlwdCBzcmM9InJlcGFpbnQuanMiPjwvc2NyaXB0PgorICA8c2NyaXB0 IHR5cGU9InRleHQvamF2YXNjcmlwdCIgY2hhcnNldD0idXRmLTgiPgorICAgIGZ1bmN0aW9uIHJl cGFpbnRUZXN0KCkKKyAgICB7CisgICAgICAgIHZhciB0YXJnZXQgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgic3F1YXJlIik7CisgICAgICAgIHRhcmdldC5zdHlsZS53ZWJraXRUcmFuc2Zvcm0g PSAic2NhbGUoMC41LCAwLjUpIjsKKyAgICB9CisgIDwvc2NyaXB0PgorICA8c3R5bGUgdHlwZT0i dGV4dC9jc3MiIG1lZGlhPSJzY3JlZW4iPgorICAgIGJvZHkgeworICAgICAgbWFyZ2luOiAxMHB4 OworICAgIH0KKyAgICAjc3F1YXJlIHsKKyAgICAgIHdpZHRoOiAxMDBweDsKKyAgICAgIGhlaWdo dDogMTAwcHg7CisgICAgICBiYWNrZ3JvdW5kOiByZWQ7CisgICAgfQorICAgICNvdmVybGF5IHsK KyAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAgIGxlZnQ6IDM1cHg7CisgICAgICB0b3A6 IDM1cHg7CisgICAgICB3aWR0aDogNTBweDsKKyAgICAgIGhlaWdodDogNTBweDsKKyAgICAgIGJh Y2tncm91bmQ6IGdyZWVuCisgICAgfQorICA8L3N0eWxlPgorPC9oZWFkPgorPGJvZHkgb25sb2Fk PSJydW5SZXBhaW50VGVzdCgpIj4KKzxkaXYgaWQ9InNxdWFyZSI+PC9kaXY+Cis8ZGl2IGlkPSJv dmVybGF5Ij48L2Rpdj4KKworPHA+PGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5NjIzIj5odHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk2MjM8L2E+PC9wPgorPHA+VGVzdCBmb3IgaW5jb21wbGV0ZSByZXBhaW50IHdoZW4gYSBu b24tbGF5ZXIgb2JqZWN0IGdhaW5zIGEgdHJhbnNmb3JtLiBZb3Ugc2hvdWxkIHNlZSBhIGdyZWVu IHNxdWFyZSBhYm92ZS4gSWYgeW91IHNlZSBhbnkgcmVkLCB0aGUgdGVzdCBoYXMgZmFpbGVkLjwv cD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9mYXN0L3JlcGFpbnQvY2hhbmdlLXRyYW5zZm9ybS1leHBlY3RlZC5jaGVja3N1bSBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvY2hhbmdlLXRyYW5zZm9ybS1leHBlY3Rl ZC5jaGVja3N1bQpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4xZTNkN2Y1Ci0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC9j aGFuZ2UtdHJhbnNmb3JtLWV4cGVjdGVkLmNoZWNrc3VtCkBAIC0wLDAgKzEgQEAKK2YwYWYwMmEw MWYxMDdjNjZiMjg4M2E4YmUyMWY5MmE5ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC9jaGFuZ2UtdHJh bnNmb3JtLWV4cGVjdGVkLnBuZyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFp bnQvY2hhbmdlLXRyYW5zZm9ybS1leHBlY3RlZC5wbmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMC4uNGM3Mzk2NApCaW5hcnkgZmlsZXMgL2Rldi9udWxsIGFuZCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvY2hhbmdlLXRyYW5zZm9ybS1leHBlY3RlZC5w bmcgZGlmZmVyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9yZXBh aW50L2NoYW5nZS10cmFuc2Zvcm0tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL2Zhc3QvcmVwYWludC9jaGFuZ2UtdHJhbnNmb3JtLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4zYWEzNWI2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC9jaGFuZ2UtdHJhbnNmb3JtLWV4cGVj dGVkLnR4dApAQCAtMCwwICsxLDE3IEBACitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAg UmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAw eDYwMAorICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgICAgUmVu ZGVyQm9keSB7Qk9EWX0gYXQgKDEwLDEwKSBzaXplIDc4MHg1NzQKKyAgICAgIFJlbmRlckJsb2Nr IHtQfSBhdCAoMCwxMTYpIHNpemUgNzgweDE4CisgICAgICAgIFJlbmRlcklubGluZSB7QX0gYXQg KDAsMCkgc2l6ZSAzMDV4MTggW2NvbG9yPSMwMDAwRUVdCisgICAgICAgICAgUmVuZGVyVGV4dCB7 I3RleHR9IGF0ICgwLDApIHNpemUgMzA1eDE4CisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCww KSB3aWR0aCAzMDU6ICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2 MjMiCisgICAgICBSZW5kZXJCbG9jayB7UH0gYXQgKDAsMTUwKSBzaXplIDc4MHgzNgorICAgICAg ICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSA3Nzd4MzYKKyAgICAgICAgICB0ZXh0 IHJ1biBhdCAoMCwwKSB3aWR0aCA3Nzc6ICJUZXN0IGZvciBpbmNvbXBsZXRlIHJlcGFpbnQgd2hl biBhIG5vbi1sYXllciBvYmplY3QgZ2FpbnMgYSB0cmFuc2Zvcm0uIFlvdSBzaG91bGQgc2VlIGEg Z3JlZW4gc3F1YXJlIGFib3ZlLiBJZiB5b3Ugc2VlIGFueSIKKyAgICAgICAgICB0ZXh0IHJ1biBh dCAoMCwxOCkgd2lkdGggMTQwOiAicmVkLCB0aGUgdGVzdCBoYXMgZmFpbGVkLiIKK2xheWVyIGF0 ICgxMCwxMCkgc2l6ZSAxMDB4MTAwCisgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDApIHNpemUg MTAweDEwMCBbYmdjb2xvcj0jRkYwMDAwXQorbGF5ZXIgYXQgKDM1LDM1KSBzaXplIDUweDUwCisg IFJlbmRlckJsb2NrIChwb3NpdGlvbmVkKSB7RElWfSBhdCAoMzUsMzUpIHNpemUgNTB4NTAgW2Jn Y29sb3I9IzAwODAwMF0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggMGZkNDcxYi4uYjRiOGI5MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOC0xMS0y MCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTk2MjMKKyAgICAgICAgCisgICAgICAgIFdoZW4gYW4gbm9uLWxh eWVyIG9iamVjdCBnYWluZWQgYSB0cmFuc2Zvcm0sIGl0IHdvdWxkIG9ubHkgcmVwYWludAorICAg ICAgICB0aGUgYm91bmRzIG9mIHRoZSBuZXcgbGF5ZXIsIHdoaWNoIGNvdWxkIHJlc3VsdCBpbiBy ZWRyYXcgYXJ0aWZhY3RzCisgICAgICAgIGlmIHRoZSBuZXcgbGF5ZXIgd2FzIHNtYWxsZXIuIFNv IGlmIHdlJ3JlIGdhaW5pbmcgYSB0cmFuc2Zvcm0sIHdlCisgICAgICAgIHJlcGFpbnQuCisgICAg ICAgIAorICAgICAgICBUZXN0OiBmYXN0L3JlcGFpbnQvY2hhbmdlLXRyYW5zZm9ybS5odG1sCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlck9iamVjdDo6c3R5bGVXaWxsQ2hhbmdlKToKKwogMjAwOC0xMS0yMCAgRGVhbiBKYWNr c29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50dGkgS29pdmlz dG8KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAgYi9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCmluZGV4IGZjNzEzNGQuLjYxZjdiZDggMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKKysrIGIvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcApAQCAtMjI3NCwxNyArMjI3NCwyNCBAQCB2b2lk IFJlbmRlck9iamVjdDo6c3R5bGVXaWxsQ2hhbmdlKFJlbmRlclN0eWxlOjpEaWZmIGRpZmYsIGNv bnN0IFJlbmRlclN0eWxlKiBuZQogICAgICAgICAgICAgICAgIHJlcGFpbnQoKTsKICAgICAgICAg fQogCi0gICAgICAgIC8vIFdoZW4gYSBsYXlvdXQgaGludCBoYXBwZW5zLCB3ZSBnbyBhaGVhZCBh bmQgZG8gYSByZXBhaW50IG9mIHRoZSBsYXllciwgc2luY2UgdGhlIGxheWVyIGNvdWxkCi0gICAg ICAgIC8vIGVuZCB1cCBiZWluZyBkZXN0cm95ZWQuCi0gICAgICAgIGlmIChkaWZmID09IFJlbmRl clN0eWxlOjpMYXlvdXQgJiYgaGFzTGF5ZXIoKSAmJgorICAgICAgICBpZiAoZGlmZiA9PSBSZW5k ZXJTdHlsZTo6TGF5b3V0KSB7CisgICAgICAgICAgICAvLyBXaGVuIGEgbGF5b3V0IGhpbnQgaGFw cGVucywgd2UgZ28gYWhlYWQgYW5kIGRvIGEgcmVwYWludCBvZiB0aGUgbGF5ZXIsIHNpbmNlIHRo ZSBsYXllciBjb3VsZAorICAgICAgICAgICAgLy8gZW5kIHVwIGJlaW5nIGRlc3Ryb3llZC4KKyAg ICAgICAgICAgIGlmIChoYXNMYXllcigpICYmCiAgICAgICAgICAgICAgICAgKG1fc3R5bGUtPnBv c2l0aW9uKCkgIT0gbmV3U3R5bGUtPnBvc2l0aW9uKCkgfHwKICAgICAgICAgICAgICAgICAgbV9z dHlsZS0+ekluZGV4KCkgIT0gbmV3U3R5bGUtPnpJbmRleCgpIHx8CiAgICAgICAgICAgICAgICAg IG1fc3R5bGUtPmhhc0F1dG9aSW5kZXgoKSAhPSBuZXdTdHlsZS0+aGFzQXV0b1pJbmRleCgpIHx8 CiAgICAgICAgICAgICAgICAgICEobV9zdHlsZS0+Y2xpcCgpID09IG5ld1N0eWxlLT5jbGlwKCkp IHx8CiAgICAgICAgICAgICAgICAgIG1fc3R5bGUtPmhhc0NsaXAoKSAhPSBuZXdTdHlsZS0+aGFz Q2xpcCgpIHx8CiAgICAgICAgICAgICAgICAgIG1fc3R5bGUtPm9wYWNpdHkoKSAhPSBuZXdTdHls ZS0+b3BhY2l0eSgpKSkKLSAgICAgICAgICAgIGxheWVyKCktPnJlcGFpbnRJbmNsdWRpbmdEZXNj ZW5kYW50cygpOwotCisgICAgICAgICAgICAgICAgbGF5ZXIoKS0+cmVwYWludEluY2x1ZGluZ0Rl c2NlbmRhbnRzKCk7CisgICAgICAgICAgICBlbHNlIGlmIChtX3N0eWxlLT50cmFuc2Zvcm0oKSAh PSBuZXdTdHlsZS0+dHJhbnNmb3JtKCkpIHsKKyAgICAgICAgICAgICAgICAvLyBJZiB3ZSBkb24n dCBoYXZlIGEgbGF5ZXIgeWV0LCBidXQgd2UgYXJlIGdvaW5nIHRvIGdldCBvbmUgYmVjYXVzZSBv ZiBhIHRyYW5zZm9ybSBjaGFuZ2UsIHRoZW4KKyAgICAgICAgICAgICAgICAvLyB3ZSBuZWVkIHRv IHJlcGFpbnQgdGhlIG9sZCBwb3NpdGlvbiBvZiB0aGUgb2JqZWN0CisgICAgICAgICAgICAgICAg cmVwYWludCgpOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgICAgIAogICAgICAgICAv LyBXaGVuIGEgbGF5b3V0IGhpbnQgaGFwcGVucyBhbmQgYW4gb2JqZWN0J3MgcG9zaXRpb24gc3R5 bGUgY2hhbmdlcywgd2UgaGF2ZSB0byBkbyBhIGxheW91dAogICAgICAgICAvLyB0byBkaXJ0eSB0 aGUgcmVuZGVyIHRyZWUgdXNpbmcgdGhlIG9sZCBwb3NpdGlvbiB2YWx1ZSBub3cuCiAgICAgICAg IGlmIChkaWZmID09IFJlbmRlclN0eWxlOjpMYXlvdXQgJiYgbV9wYXJlbnQgJiYgbV9zdHlsZS0+ cG9zaXRpb24oKSAhPSBuZXdTdHlsZS0+cG9zaXRpb24oKSkgewo=