196229 2019-03-25 16:51:26 -0700 [ews-build] Use PostgreSQL for ews-build database 2021-01-13 06:34:50 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220589 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dewei_zhu jbedard lforschler webkit-bug-importer oldest_to_newest 1521116 0 aakash_jain 2019-03-25 16:51:26 -0700 Use PostgreSQL for ews-build database since it's much better than the default sqlite. 1521119 1 365920 aakash_jain 2019-03-25 16:52:32 -0700 Created attachment 365920 Patch 1521314 2 365920 lforschler 2019-03-26 09:50:17 -0700 Comment on attachment 365920 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365920&action=review > Tools/BuildSlaveSupport/ews-build/master.cfg:31 > + password = os.getenv('DB_PASSWORD', None) I'd stick with your convention above and call these db_username and db_password > Tools/BuildSlaveSupport/ews-build/master.cfg:32 > + if db_url is None or db_name is None or password is None or username is None: I find long comparisons like this clunky... how about something like: if None in [db_url, db_name, db_username, db_password]: 1521318 3 365920 lforschler 2019-03-26 09:56:20 -0700 Comment on attachment 365920 Patch r+ with above changes. 1521362 4 aakash_jain 2019-03-26 11:20:25 -0700 Committed r243509: <https://trac.webkit.org/changeset/243509> 1521363 5 webkit-bug-importer 2019-03-26 11:21:26 -0700 <rdar://problem/49282338> 365920 2019-03-25 16:52:32 -0700 2019-03-26 09:56:20 -0700 Patch bug-196229-20190325195308.patch text/plain 1944 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MzQ3MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTAzLTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBVc2UgUG9zdGdyZVNRTCBmb3IgZXdzLWJ1aWxkIGRh dGFiYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTYyMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9tYXN0ZXIuY2ZnOgorCiAyMDE5LTAzLTI1ICBD b21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMjQzNDY1LgpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWJ1aWxkL21hc3Rlci5jZmcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvZXdzLWJ1aWxkL21hc3Rlci5jZmcJKHJldmlzaW9uIDI0MzQ3MikKKysrIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1idWlsZC9tYXN0ZXIuY2ZnCSh3b3JraW5nIGNvcHkpCkBAIC0xOSwx MCArMTksMjQgQEAgY1sncHJvdG9jb2xzJ10gPSB7J3BiJzogeydwb3J0JzogMTcwMDB9fQogCiBj Wydwcm9qZWN0TmFtZSddID0gJ1dlYktpdCBFV1MnCiBjWydwcm9qZWN0VVJMJ10gPSAnaHR0cHM6 Ly9ld3MtYnVpbGQud2Via2l0Lm9yZy8nCi1jWydidWlsZGJvdFVSTCddID0gJ2h0dHBzOi8vZXdz LWJ1aWxkLndlYmtpdC5vcmcvJwogCi1jWydsb2dDb21wcmVzc2lvbk1ldGhvZCddID0gJ2x6NCcK K2lmIGlzX3Rlc3RfbW9kZV9lbmFibGVkOgorICAgIGNbJ2J1aWxkYm90VVJMJ10gPSAnaHR0cDov L2xvY2FsaG9zdDo4MDEwLycKKyAgICBjWydkYl91cmwnXSA9ICdzcWxpdGU6Ly8vc3RhdGUuc3Fs aXRlP3NlcmlhbGl6ZV9hY2Nlc3M9MScKK2Vsc2U6CisgICAgY1snYnVpbGRib3RVUkwnXSA9ICdo dHRwczovL2V3cy1idWlsZC53ZWJraXQub3JnLycKKyAgICBkYl91cmwgPSBvcy5nZXRlbnYoJ0RC X1VSTCcsIE5vbmUpCisgICAgZGJfbmFtZSA9IG9zLmdldGVudignREJfTkFNRScsIE5vbmUpCisg ICAgdXNlcm5hbWUgPSBvcy5nZXRlbnYoJ0RCX1VTRVJOQU1FJywgTm9uZSkKKyAgICBwYXNzd29y ZCA9IG9zLmdldGVudignREJfUEFTU1dPUkQnLCBOb25lKQorICAgIGlmIGRiX3VybCBpcyBOb25l IG9yIGRiX25hbWUgaXMgTm9uZSBvciBwYXNzd29yZCBpcyBOb25lIG9yIHVzZXJuYW1lIGlzIE5v bmU6CisgICAgICAgIHByaW50KCdFbnZpcm9ubWVudCB2YXJpYWJsZXMgZm9yIERCIG5vdCBmb3Vu ZC4gUGxlYXNlIGVuc3VyZSB0aGVzZSB2YXJpYWJsZXMgYXJlIHNldC4nKQorICAgICAgICBzeXMu ZXhpdCgxKQorICAgICMgU2VlIGh0dHBzOi8vZG9jcy5idWlsZGJvdC5uZXQvMS44LjAvbWFudWFs L2NvbmZpZ3VyYXRpb24vZ2xvYmFsLmh0bWwjZGF0YWJhc2Utc3BlY2lmaWNhdGlvbgorICAgIGNb J2RiX3VybCddID0gJ3Bvc3RncmVzcWw6Ly97fTp7fUB7fS97fScuZm9ybWF0KHVzZXJuYW1lLCBw YXNzd29yZCwgZGJfdXJsLCBkYl9uYW1lKQorCiAKK2NbJ2xvZ0NvbXByZXNzaW9uTWV0aG9kJ10g PSAnbHo0JwogY1snYnVpbGRib3ROZXRVc2FnZURhdGEnXSA9IE5vbmUKIAogbG9hZENvbmZpZy5s b2FkQnVpbGRlckNvbmZpZyhjLCBpc190ZXN0X21vZGVfZW5hYmxlZD1pc190ZXN0X21vZGVfZW5h YmxlZCkK