196205 2019-03-25 09:26:10 -0700 Regression(r242369) Trying to change profile picture on linked in shows file picker, not the image picker 2019-03-26 12:22:15 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196265 https://html.spec.whatwg.org/multipage/input.html#attr-input-accept InRadar P2 Normal --- 1 cdumez cdumez aestes commit-queue conrad_shultz ggaren thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1520872 0 cdumez 2019-03-25 09:26:10 -0700 Trying to change profile picture on linked in shows file picker, not the image picker since r242369. 1520873 1 cdumez 2019-03-25 09:26:33 -0700 <rdar://problem/49083324> 1520875 2 365867 cdumez 2019-03-25 09:28:49 -0700 Created attachment 365867 Patch 1520889 3 365872 cdumez 2019-03-25 09:59:49 -0700 Created attachment 365872 Patch 1520964 4 365872 ggaren 2019-03-25 13:03:45 -0700 Comment on attachment 365872 Patch r=me Can we regression test this? If opening the panel is an issue, maybe use a low-level API test? 1520973 5 cdumez 2019-03-25 13:21:59 -0700 (In reply to Geoffrey Garen from comment #4) > Comment on attachment 365872 [details] > Patch > > r=me > > Can we regression test this? If opening the panel is an issue, maybe use a > low-level API test? I discussed it with Wenson and it does not seem that proper automated testing would be practical at the moment. However, we can probably write a low-level API test. 1521033 6 cdumez 2019-03-25 14:36:16 -0700 Looks like I can write a layout test for this, almost there... 1521192 7 365872 cdumez 2019-03-25 21:17:48 -0700 Comment on attachment 365872 Patch Will follow up for the test, it is taking longer than I hoped. 1521203 8 365872 commit-queue 2019-03-25 21:45:32 -0700 Comment on attachment 365872 Patch Rejecting attachment 365872 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 365872, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=365872&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=196205&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 365872 from bug 196205. Fetching: https://bugs.webkit.org/attachment.cgi?id=365872 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: 444c0eb48870e7ca29baa97530aecb1ec213e12f and refs/remotes/origin/master differ, using rebase: :040000 040000 506332e0ce534159bb852cdf943d208e004c5868 951cfcaa2cada3ce5d92e403825aefbe1dcfae66 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebKit/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date W: 444c0eb48870e7ca29baa97530aecb1ec213e12f and refs/remotes/origin/master differ, using rebase: :040000 040000 506332e0ce534159bb852cdf943d208e004c5868 951cfcaa2cada3ce5d92e403825aefbe1dcfae66 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: https://webkit-queues.webkit.org/results/11668782 1521216 9 365872 commit-queue 2019-03-25 22:48:14 -0700 Comment on attachment 365872 Patch Clearing flags on attachment: 365872 Committed r243485: <https://trac.webkit.org/changeset/243485> 1521217 10 commit-queue 2019-03-25 22:48:15 -0700 All reviewed patches have been landed. Closing bug. 365867 2019-03-25 09:28:49 -0700 2019-03-25 09:59:48 -0700 Patch bug-196205-20190325092848.patch text/plain 2379 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM0ZDVhM2ZmMjE2NTJiYjBj ZTA0OWNiMjkxZTZhNWY5MTRkZGRjMDcuLmZhNTdjOWVjMTBjOWNhMTQ1Zjg1ZTQzYjc1YTA5YjUw MjY5ZTJiZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDMtMjUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyNDIzNjkpIFRy eWluZyB0byBjaGFuZ2UgcHJvZmlsZSBwaWN0dXJlIG9uIGxpbmtlZCBpbiBzaG93cyBmaWxlIHBp Y2tlciwgbm90IHRoZSBpbWFnZSBwaWNrZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5NjIwNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDkwODMz MjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBk YXRlIG91ciBGaWxlVXBsb2FkUGFuZWwgY29kZSBvbiBpT1MgdG8gcHJvcGVybHkgZGVhbCB3aXRo IHRoZSBNSU1FIHR5cGVzIGNvbnRhaW5pbmcKKyAgICAgICAgd2lsZCBjYXJkcyAoZS5nLiAiaW1h Z2UvKiIpIHRoYXQgYXJlIGRlZmluZWQgaW4gdGhlIEhUTUwgc3BlY2lmaWNhdGlvbjoKKyAgICAg ICAgLSBodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9pbnB1dC5odG1sI2F0 dHItaW5wdXQtYWNjZXB0CisKKyAgICAgICAgUHJldmlvdXNseSwgd2Ugd291bGQgZmFpbCB0byBj b252ZXJ0IHRob3NlIHRvIFVUSXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Zvcm1zL1dL RmlsZVVwbG9hZFBhbmVsLm1tOgorCiAyMDE5LTAzLTI1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdGlueSBmaXggYWZ0ZXIgcjI0MzM4OCB0 byBhZGRyZXNzIEFQSSB0ZXN0IGZhaWx1cmVzIG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tCmluZGV4IDJlYTA5 ZDM1MmEwY2RiNTQyZmQwMDdlMTVlN2RjZDQzMTg1ODcyOTUuLjQxOGQwNGZjMzdhYmI2MmIxMjg0 MDRlNzRkODYwN2NlYzgyNzA4YmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW0KQEAgLTMxOCw5ICszMTgsMTcgQEAg c3RhdGljIE5TU2V0PE5TU3RyaW5nICo+ICpVVElzRm9yTUlNRVR5cGVzKE5TQXJyYXkgKm1pbWVU eXBlcykKIHsKICAgICBOU011dGFibGVTZXQgKm1lZGlhVHlwZXMgPSBbTlNNdXRhYmxlU2V0IHNl dF07CiAgICAgZm9yIChOU1N0cmluZyAqbWltZVR5cGUgaW4gbWltZVR5cGVzKSB7Ci0gICAgICAg IGF1dG8gdXRpID0gV2ViQ29yZTo6VVRJRnJvbU1JTUVUeXBlKG1pbWVUeXBlKTsKLSAgICAgICAg aWYgKCF1dGkuaXNFbXB0eSgpKQotICAgICAgICAgICAgW21lZGlhVHlwZXMgYWRkT2JqZWN0Oihf X2JyaWRnZSBOU1N0cmluZyAqKXV0aV07CisgICAgICAgIGlmIChbbWltZVR5cGUgY2FzZUluc2Vu c2l0aXZlQ29tcGFyZTpAImltYWdlLyoiXSA9PSBOU09yZGVyZWRTYW1lKQorICAgICAgICAgICAg W21lZGlhVHlwZXMgYWRkT2JqZWN0OihOU1N0cmluZyAqKWtVVFR5cGVJbWFnZV07CisgICAgICAg IGVsc2UgaWYgKFttaW1lVHlwZSBjYXNlSW5zZW5zaXRpdmVDb21wYXJlOkAidmlkZW8vKiJdID09 IE5TT3JkZXJlZFNhbWUpCisgICAgICAgICAgICBbbWVkaWFUeXBlcyBhZGRPYmplY3Q6KE5TU3Ry aW5nICopa1VUVHlwZU1vdmllXTsKKyAgICAgICAgZWxzZSBpZiAoW21pbWVUeXBlIGNhc2VJbnNl bnNpdGl2ZUNvbXBhcmU6QCJhdWRpby8qIl0gPT0gTlNPcmRlcmVkU2FtZSkKKyAgICAgICAgICAg IFttZWRpYVR5cGVzIGFkZE9iamVjdDooTlNTdHJpbmcgKilrVVRUeXBlQXVkaW9dOworICAgICAg ICBlbHNlIHsKKyAgICAgICAgICAgIGF1dG8gdXRpID0gV2ViQ29yZTo6VVRJRnJvbU1JTUVUeXBl KG1pbWVUeXBlKTsKKyAgICAgICAgICAgIGlmICghdXRpLmlzRW1wdHkoKSkKKyAgICAgICAgICAg ICAgICBbbWVkaWFUeXBlcyBhZGRPYmplY3Q6KF9fYnJpZGdlIE5TU3RyaW5nICopdXRpXTsKKyAg ICAgICAgfQogICAgIH0KICAgICByZXR1cm4gbWVkaWFUeXBlczsKIH0K 365872 2019-03-25 09:59:49 -0700 2019-03-25 22:48:14 -0700 Patch bug-196205-20190325095948.patch text/plain 2406 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM0ZDVhM2ZmMjE2NTJiYjBj ZTA0OWNiMjkxZTZhNWY5MTRkZGRjMDcuLmZhNTdjOWVjMTBjOWNhMTQ1Zjg1ZTQzYjc1YTA5YjUw MjY5ZTJiZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDMtMjUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyNDIzNjkpIFRy eWluZyB0byBjaGFuZ2UgcHJvZmlsZSBwaWN0dXJlIG9uIGxpbmtlZCBpbiBzaG93cyBmaWxlIHBp Y2tlciwgbm90IHRoZSBpbWFnZSBwaWNrZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5NjIwNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDkwODMz MjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBk YXRlIG91ciBGaWxlVXBsb2FkUGFuZWwgY29kZSBvbiBpT1MgdG8gcHJvcGVybHkgZGVhbCB3aXRo IHRoZSBNSU1FIHR5cGVzIGNvbnRhaW5pbmcKKyAgICAgICAgd2lsZCBjYXJkcyAoZS5nLiAiaW1h Z2UvKiIpIHRoYXQgYXJlIGRlZmluZWQgaW4gdGhlIEhUTUwgc3BlY2lmaWNhdGlvbjoKKyAgICAg ICAgLSBodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9pbnB1dC5odG1sI2F0 dHItaW5wdXQtYWNjZXB0CisKKyAgICAgICAgUHJldmlvdXNseSwgd2Ugd291bGQgZmFpbCB0byBj b252ZXJ0IHRob3NlIHRvIFVUSXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Zvcm1zL1dL RmlsZVVwbG9hZFBhbmVsLm1tOgorCiAyMDE5LTAzLTI1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdGlueSBmaXggYWZ0ZXIgcjI0MzM4OCB0 byBhZGRyZXNzIEFQSSB0ZXN0IGZhaWx1cmVzIG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tCmluZGV4IDJlYTA5 ZDM1MmEwY2RiNTQyZmQwMDdlMTVlN2RjZDQzMTg1ODcyOTUuLjFlOTRiOGQxMmI4YzcwNWIyYWFh NmQyMDM5MTMzNzIwMGY2NTZkOGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW0KQEAgLTMxOCw5ICszMTgsMTcgQEAg c3RhdGljIE5TU2V0PE5TU3RyaW5nICo+ICpVVElzRm9yTUlNRVR5cGVzKE5TQXJyYXkgKm1pbWVU eXBlcykKIHsKICAgICBOU011dGFibGVTZXQgKm1lZGlhVHlwZXMgPSBbTlNNdXRhYmxlU2V0IHNl dF07CiAgICAgZm9yIChOU1N0cmluZyAqbWltZVR5cGUgaW4gbWltZVR5cGVzKSB7Ci0gICAgICAg IGF1dG8gdXRpID0gV2ViQ29yZTo6VVRJRnJvbU1JTUVUeXBlKG1pbWVUeXBlKTsKLSAgICAgICAg aWYgKCF1dGkuaXNFbXB0eSgpKQotICAgICAgICAgICAgW21lZGlhVHlwZXMgYWRkT2JqZWN0Oihf X2JyaWRnZSBOU1N0cmluZyAqKXV0aV07CisgICAgICAgIGlmIChbbWltZVR5cGUgY2FzZUluc2Vu c2l0aXZlQ29tcGFyZTpAImltYWdlLyoiXSA9PSBOU09yZGVyZWRTYW1lKQorICAgICAgICAgICAg W21lZGlhVHlwZXMgYWRkT2JqZWN0OihfX2JyaWRnZSBOU1N0cmluZyAqKWtVVFR5cGVJbWFnZV07 CisgICAgICAgIGVsc2UgaWYgKFttaW1lVHlwZSBjYXNlSW5zZW5zaXRpdmVDb21wYXJlOkAidmlk ZW8vKiJdID09IE5TT3JkZXJlZFNhbWUpCisgICAgICAgICAgICBbbWVkaWFUeXBlcyBhZGRPYmpl Y3Q6KF9fYnJpZGdlIE5TU3RyaW5nICopa1VUVHlwZU1vdmllXTsKKyAgICAgICAgZWxzZSBpZiAo W21pbWVUeXBlIGNhc2VJbnNlbnNpdGl2ZUNvbXBhcmU6QCJhdWRpby8qIl0gPT0gTlNPcmRlcmVk U2FtZSkKKyAgICAgICAgICAgIFttZWRpYVR5cGVzIGFkZE9iamVjdDooX19icmlkZ2UgTlNTdHJp bmcgKilrVVRUeXBlQXVkaW9dOworICAgICAgICBlbHNlIHsKKyAgICAgICAgICAgIGF1dG8gdXRp ID0gV2ViQ29yZTo6VVRJRnJvbU1JTUVUeXBlKG1pbWVUeXBlKTsKKyAgICAgICAgICAgIGlmICgh dXRpLmlzRW1wdHkoKSkKKyAgICAgICAgICAgICAgICBbbWVkaWFUeXBlcyBhZGRPYmplY3Q6KF9f YnJpZGdlIE5TU3RyaW5nICopdXRpXTsKKyAgICAgICAgfQogICAgIH0KICAgICByZXR1cm4gbWVk aWFUeXBlczsKIH0K