196031 2019-03-20 13:56:49 -0700 REGRESSION (r243153): [iPhone] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing 2019-03-20 15:48:11 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build iPhone / iPad iOS 12 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195820 InRadar, PlatformOnly, Regression P2 Normal --- 195820 1 ryanhaddad dbates bfulgham dbates thorton webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1519158 0 ryanhaddad 2019-03-20 13:56:49 -0700 The following API test is failing on iOS bots: TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:100 Value of: [webView stringByEvaluatingJavaScript:@"document.activeElement == document.querySelector('select')"].boolValue Actual: true Expected: false https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/3212/steps/run-api-tests/logs/stdio 1519160 1 ryanhaddad 2019-03-20 13:57:45 -0700 This appears to have started with: "[iOS] Focus not preserved when switching between tabs" https://trac.webkit.org/changeset/243153/webkit Dan, would you please take a look? 1519167 2 webkit-bug-importer 2019-03-20 14:13:29 -0700 <rdar://problem/49078172> 1519188 3 dbates 2019-03-20 14:36:19 -0700 (In reply to Ryan Haddad from comment #0) > The following API test is failing on iOS bots: > > > TestWebKitAPI.FocusPreservationTests. > ChangingFocusedNodeResetsFocusPreservationState > > > /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/ > ios/FocusPreservationTests.mm:100 > Value of: [webView > stringByEvaluatingJavaScript:@"document.activeElement == > document.querySelector('select')"].boolValue > Actual: true > Expected: false > > https://build.webkit.org/builders/ > Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/3212/steps/ > run-api-tests/logs/stdio Progression. Will update test. 1519199 4 dbates 2019-03-20 14:47:17 -0700 (In reply to Daniel Bates from comment #3) > (In reply to Ryan Haddad from comment #0) > > The following API test is failing on iOS bots: > > > > > > TestWebKitAPI.FocusPreservationTests. > > ChangingFocusedNodeResetsFocusPreservationState > > > > > > /Volumes/Data/slave/ios-simulator-12-release/build/Tools/TestWebKitAPI/Tests/ > > ios/FocusPreservationTests.mm:100 > > Value of: [webView > > stringByEvaluatingJavaScript:@"document.activeElement == > > document.querySelector('select')"].boolValue > > Actual: true > > Expected: false > > > > https://build.webkit.org/builders/ > > Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/3212/steps/ > > run-api-tests/logs/stdio > > Progression. Will update test. This would be a progression on iPad, but these tests are run using an iPhone I think so this is a regression. 1519217 5 dbates 2019-03-20 14:59:47 -0700 Test needs to be updated. It was written with blackbox knowledge of the fact that -[WKWebView resignFirstResponder] is what is called when the <select> picker is dismissed when the Done button is pressed. The test wants to press the Done button, but does it in an indirect way. Need to fix test to do what it actually wants to do. 1519236 6 365411 dbates 2019-03-20 15:28:38 -0700 Created attachment 365411 Patch 1519253 7 dbates 2019-03-20 15:48:11 -0700 Committed r243248: <https://trac.webkit.org/changeset/243248> 365411 2019-03-20 15:28:38 -0700 2019-03-20 15:32:51 -0700 Patch bug-196031-20190320152837.patch text/plain 2008 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzMjQxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzliYmIwODA0MTQyZWQzYzJiN2E4OTRlNzQ0ZDYzNTBm NzJiNDgxMS4uMWViOTdjMjExNmFmOTRjMzc5ZDA0NjM5OWVmMGMxZmNiZmE5NWZjOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE5LTAzLTIwICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBSRUdSRVNTSU9OIChyMjQzMTUzKTogW2lPU10gVGVzdFdlYktpdEFQSS5Gb2N1c1ByZXNl cnZhdGlvblRlc3RzLkNoYW5naW5nRm9jdXNlZE5vZGVSZXNldHNGb2N1c1ByZXNlcnZhdGlvblN0 YXRlIGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5NjAzMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDkwNzgxNzI+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRlc3QgaW5jb3Jy ZWN0bHkgYXNzdW1lcyB0aGF0IGNhbGxpbmcgLVtXS1dlYlZpZXcgcmVzaWduRmlyc3RSZXNwb25k ZXJdIGlzIGlkZW50aWNhbCB0byBkaXNtaXNzaW5nIHRoZQorICAgICAgICA8c2VsZWN0PiBwaWNr ZXIuIFRoaXMgaXMgbm8gbG9uZ2VyIHRoZSBjYXNlIGZvbGxvd2luZyByMjQzMTM1LiBJbnN0ZWFk IHVzZSB0ZXN0aW5nIFNQSSB0aGF0IGludm9rZXMgdGhhdAorICAgICAgICBzYW1lIGNvZGUgcGF0 aCB1c2VkIHdoZW4gdGhlIERvbmUgYnV0dG9uIGlzIHByZXNzZWQgdG8gZGlzbWlzcyB0aGUgPHNl bGVjdD4gcGlja2VyLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvRm9jdXNQ cmVzZXJ2YXRpb25UZXN0cy5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAy MDE5LTAzLTIwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUmVn cmVzc2lvbihQU09OKTogVmlld0dlc3R1cmVDb250cm9sbGVyIGlzIG5vdCBwcm9wZXJseSBub3Rp ZmllZCBvZiBwcm9jZXNzIHN3YXBzIG9uIGlPUwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9pb3MvRm9jdXNQcmVzZXJ2YXRpb25UZXN0cy5tbSBiL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvaW9zL0ZvY3VzUHJlc2VydmF0aW9uVGVzdHMubW0KaW5kZXggYWNkYjA0YTgw NTBjNjAxMDIwYjZkZDRkYmFhMGJkODVmOTgxMDAzMy4uYTU4NTI0NTYzMjA0N2M2MDljNzc0Nzhi YjM5ODNkYjFlODUxZjkxYSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9p b3MvRm9jdXNQcmVzZXJ2YXRpb25UZXN0cy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL2lvcy9Gb2N1c1ByZXNlcnZhdGlvblRlc3RzLm1tCkBAIC05Niw3ICs5Niw3IEBAIFRFU1Qo Rm9jdXNQcmVzZXJ2YXRpb25UZXN0cywgQ2hhbmdpbmdGb2N1c2VkTm9kZVJlc2V0c0ZvY3VzUHJl c2VydmF0aW9uU3RhdGUpCiAKICAgICBFWFBFQ1RfTk9UX05VTEwod2ViVmlldy50ZXh0SW5wdXRD b250ZW50Vmlldy5pbnB1dFZpZXcpOwogICAgIFt3ZWJWaWV3IHNlbGVjdEZvcm1BY2Nlc3NvcnlQ aWNrZXJSb3c6MV07Ci0gICAgRVhQRUNUX1RSVUUoW3dlYlZpZXcgcmVzaWduRmlyc3RSZXNwb25k ZXJdKTsKKyAgICBbd2ViVmlldyBkaXNtaXNzRm9ybUFjY2Vzc29yeVZpZXddOwogICAgIEVYUEVD VF9GQUxTRShbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZG9jdW1lbnQu YWN0aXZlRWxlbWVudCA9PSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdzZWxlY3QnKSJdLmJvb2xW YWx1ZSk7CiAgICAgRVhQRUNUX0VRKDEsIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFT Y3JpcHQ6QCJkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdzZWxlY3QnKS5zZWxlY3RlZEluZGV4Il0u aW50VmFsdWUpOwogCg==