195557 2019-03-11 08:25:06 -0700 [ews-build] unit-tests fail when passwords.json is missing 2019-03-11 09:39:23 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=180390 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue lforschler webkit-bug-importer oldest_to_newest 1514771 0 aakash_jain 2019-03-11 08:25:06 -0700 unit-tests in loadConfig_unittest.py fail when passwords.json is missing. This file is not checked-in to the repository. So the unit-tests should be able to run without this file. Exception: [~/OpenSource/Tools/BuildSlaveSupport/ews-build]$python runUnittests.py ......................................................E.................... ====================================================================== ERROR: test_configuration (loadConfig_unittest.ConfigDotJSONTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/jain/code/OpenSource/Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py", line 36, in test_configuration loadConfig.loadBuilderConfig({}, master_prefix_path=cwd) File "/Users/jain/code/OpenSource/Tools/BuildSlaveSupport/ews-build/loadConfig.py", line 42, in loadBuilderConfig passwords = json.load(open(os.path.join(master_prefix_path, 'passwords.json'))) IOError: [Errno 2] No such file or directory: 'passwords.json' 1514775 1 364253 aakash_jain 2019-03-11 08:29:34 -0700 Created attachment 364253 Proposed patch 1514807 2 364253 commit-queue 2019-03-11 09:38:11 -0700 Comment on attachment 364253 Proposed patch Clearing flags on attachment: 364253 Committed r242707: <https://trac.webkit.org/changeset/242707> 1514808 3 commit-queue 2019-03-11 09:38:13 -0700 All reviewed patches have been landed. Closing bug. 1514810 4 webkit-bug-importer 2019-03-11 09:39:23 -0700 <rdar://problem/48769818> 364253 2019-03-11 08:29:34 -0700 2019-03-11 09:38:11 -0700 Proposed patch passwords-json-missing.patch text/plain 3134 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MjcwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTAzLTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSB1bml0LXRlc3RzIGZhaWwgd2hlbiBwYXNzd29yZHMu anNvbiBpcyBtaXNzaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTU1NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnLnB5OgorICAg ICAgICAobG9hZEJ1aWxkZXJDb25maWcpOgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3 cy1idWlsZC9sb2FkQ29uZmlnX3VuaXR0ZXN0LnB5OgorICAgICAgICAoQ29uZmlnRG90SlNPTlRl c3QudGVzdF9jb25maWd1cmF0aW9uKToKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3Mt YnVpbGQvbWFzdGVyLmNmZzoKKwogMjAxOS0wMy0xMSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQu b3JnPgogCiAgICAgICAgIEFkZCB1dGlsaXR5IGZ1bmN0aW9uIHRvIGFsbG93IGVhc3kgcmV2ZXJz ZSByYW5nZS1iYXNlZCBpdGVyYXRpb24gb2YgYSBjb250YWluZXIKSW5kZXg6IFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnLnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnLnB5CShyZXZpc2lvbiAyNDI3 MDEpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvbG9hZENvbmZpZy5weQko d29ya2luZyBjb3B5KQpAQCAtMzcsOSArMzcsMTQgQEAgQlVJTERFUl9OQU1FX0xFTkdUSF9MSU1J VCA9IDcwCiBTVEVQX05BTUVfTEVOR1RIX0xJTUlUID0gNTAKIAogCi1kZWYgbG9hZEJ1aWxkZXJD b25maWcoYywgdXNlX2xvY2FsaG9zdF93b3JrZXI9RmFsc2UsIG1hc3Rlcl9wcmVmaXhfcGF0aD0n Li8nKToKK2RlZiBsb2FkQnVpbGRlckNvbmZpZyhjLCBpc190ZXN0X21vZGVfZW5hYmxlZD1GYWxz ZSwgbWFzdGVyX3ByZWZpeF9wYXRoPScuLycpOgogICAgIGNvbmZpZyA9IGpzb24ubG9hZChvcGVu KG9zLnBhdGguam9pbihtYXN0ZXJfcHJlZml4X3BhdGgsICdjb25maWcuanNvbicpKSkKLSAgICBw YXNzd29yZHMgPSBqc29uLmxvYWQob3Blbihvcy5wYXRoLmpvaW4obWFzdGVyX3ByZWZpeF9wYXRo LCAncGFzc3dvcmRzLmpzb24nKSkpCisgICAgdXNlX2xvY2FsaG9zdF93b3JrZXIgPSBpc190ZXN0 X21vZGVfZW5hYmxlZAorICAgIGlmIGlzX3Rlc3RfbW9kZV9lbmFibGVkOgorICAgICAgICBwYXNz d29yZHMgPSB7fQorICAgIGVsc2U6CisgICAgICAgIHBhc3N3b3JkcyA9IGpzb24ubG9hZChvcGVu KG9zLnBhdGguam9pbihtYXN0ZXJfcHJlZml4X3BhdGgsICdwYXNzd29yZHMuanNvbicpKSkKKwog ICAgIGNoZWNrV29ya2Vyc0FuZEJ1aWxkZXJzRm9yQ29uc2lzdGVuY3koY29uZmlnLCBjb25maWdb J3dvcmtlcnMnXSwgY29uZmlnWydidWlsZGVycyddKQogICAgIGNoZWNrVmFsaWRTY2hlZHVsZXJz KGNvbmZpZywgY29uZmlnWydzY2hlZHVsZXJzJ10pCiAKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnX3VuaXR0ZXN0LnB5CShy ZXZpc2lvbiAyNDI3MDEpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvbG9h ZENvbmZpZ191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMzMsNyArMzMsNyBAQCBpbXBv cnQgbG9hZENvbmZpZwogY2xhc3MgQ29uZmlnRG90SlNPTlRlc3QodW5pdHRlc3QuVGVzdENhc2Up OgogICAgIGRlZiB0ZXN0X2NvbmZpZ3VyYXRpb24oc2VsZik6CiAgICAgICAgIGN3ZCA9IG9zLnBh dGguZGlybmFtZShvcy5wYXRoLmFic3BhdGgoX19maWxlX18pKQotICAgICAgICBsb2FkQ29uZmln LmxvYWRCdWlsZGVyQ29uZmlnKHt9LCBtYXN0ZXJfcHJlZml4X3BhdGg9Y3dkKQorICAgICAgICBs b2FkQ29uZmlnLmxvYWRCdWlsZGVyQ29uZmlnKHt9LCBpc190ZXN0X21vZGVfZW5hYmxlZD1UcnVl LCBtYXN0ZXJfcHJlZml4X3BhdGg9Y3dkKQogCiAgICAgZGVmIHRlc3RfYnVpbGRlcl9rZXlzKHNl bGYpOgogICAgICAgICBjd2QgPSBvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5hYnNwYXRoKF9fZmls ZV9fKSkKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9tYXN0ZXIuY2Zn Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9tYXN0ZXIu Y2ZnCShyZXZpc2lvbiAyNDI3MDEpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvbWFzdGVyLmNmZwkod29ya2luZyBjb3B5KQpAQCAtMjQsNyArMjQsNyBAQCBjWydidWlsZGJv dFVSTCddID0gJ2h0dHBzOi8vZXdzLWJ1aWxkLndlCiAKIGNbJ2J1aWxkYm90TmV0VXNhZ2VEYXRh J10gPSBOb25lCiAKLWxvYWRDb25maWcubG9hZEJ1aWxkZXJDb25maWcoYywgdXNlX2xvY2FsaG9z dF93b3JrZXI9aXNfdGVzdF9tb2RlX2VuYWJsZWQpCitsb2FkQ29uZmlnLmxvYWRCdWlsZGVyQ29u ZmlnKGMsIGlzX3Rlc3RfbW9kZV9lbmFibGVkPWlzX3Rlc3RfbW9kZV9lbmFibGVkKQogCiBldmVu dF9yZXBvcnRlciA9IEV2ZW50cyhtYXN0ZXJfaG9zdG5hbWU9J2V3cy1idWlsZC53ZWJraXQub3Jn JywgdHlwZV9wcmVmaXg9J2V3cycpCiBjWydzZXJ2aWNlcyddID0gW2V2ZW50X3JlcG9ydGVyXQo=