195435 2019-03-07 14:28:09 -0800 Make sure an empty host matches the internal representation "nullOrigin" in WebCore::RegistrableDomain::matches() 2019-03-11 11:23:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195301 InRadar P2 Normal --- 1 wilander wilander bfulgham commit-queue darin ryanhaddad simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1513715 0 wilander 2019-03-07 14:28:09 -0800 WebCore::RegistrableDomain::matches() is a quick way to compare a RegistrableDomain with a URL. Since RegistrableDomain represents the empty host as "nullOrigin," a URL with an empty host needs to match that representation in WebCore::RegistrableDomain::matches(). This omission caused debug assertions in fast/ layout tests after https://trac.webkit.org/changeset/242603/webkit. 1513718 1 363929 wilander 2019-03-07 14:31:57 -0800 Created attachment 363929 Patch 1513765 2 363929 bfulgham 2019-03-07 15:56:53 -0800 Comment on attachment 363929 Patch r=me 1513790 3 363929 commit-queue 2019-03-07 16:23:57 -0800 Comment on attachment 363929 Patch Clearing flags on attachment: 363929 Committed r242620: <https://trac.webkit.org/changeset/242620> 1513791 4 commit-queue 2019-03-07 16:23:58 -0800 All reviewed patches have been landed. Closing bug. 1513792 5 webkit-bug-importer 2019-03-07 16:25:15 -0800 <rdar://problem/48695077> 1514138 6 363929 darin 2019-03-08 12:54:54 -0800 Comment on attachment 363929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363929&action=review > Source/WebCore/platform/RegistrableDomain.h:62 > + if (host.isEmpty() && m_registrableDomain == "nullOrigin"_s) Using _s with == doesn’t optimize things; I think in fact it just makes them slower. This _s should be omitted. 1514140 7 363929 darin 2019-03-08 12:55:29 -0800 Comment on attachment 363929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363929&action=review >> Source/WebCore/platform/RegistrableDomain.h:62 >> + if (host.isEmpty() && m_registrableDomain == "nullOrigin"_s) > > Using _s with == doesn’t optimize things; I think in fact it just makes them slower. This _s should be omitted. Or we could fix WTF::String so it at least doesn’t make things slower and then leave this alone. 1514144 8 wilander 2019-03-08 13:02:59 -0800 (In reply to Darin Adler from comment #6) > Comment on attachment 363929 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=363929&action=review > > > Source/WebCore/platform/RegistrableDomain.h:62 > > + if (host.isEmpty() && m_registrableDomain == "nullOrigin"_s) > > Using _s with == doesn’t optimize things; I think in fact it just makes them > slower. This _s should be omitted. Thanks! Did not know that. 1514538 9 simon.fraser 2019-03-10 09:50:35 -0700 Still lots of asserts in iOS sim: https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20%28Tests%29?numbuilds=100 1514559 10 wilander 2019-03-10 12:14:57 -0700 (In reply to Simon Fraser (smfr) from comment #9) > Still lots of asserts in iOS sim: > https://build.webkit.org/builders/ > Apple%20iOS%2012%20Simulator%20Debug%20WK2%20%28Tests%29?numbuilds=100 Sorry about that. I will have a look tomorrow morning. It’s probably best to restructure the check before the IPC call. The reason for all of this is that I don’t want to do IPC for useless cases, only to drop them on the other side. 1514850 11 wilander 2019-03-11 10:22:17 -0700 Looking at this now. 1514880 12 wilander 2019-03-11 11:19:43 -0700 These assertion failures seem unrelated. The problem seems to be in WebKit::RemoteLayerBackingStoreCollection::backingStoreWillBeDisplayed(). Or did you see my code causing this, Simon? ASSERTION FAILED: m_inLayerFlush /Volumes/Data/slave/ios-simulator-12-debug/build/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm(92) : bool WebKit::RemoteLayerBackingStoreCollection::backingStoreWillBeDisplayed(WebKit::RemoteLayerBackingStore &) 1514885 13 wilander 2019-03-11 11:23:06 -0700 I was not able to repro with ToT on my machine, executing: run-webkit-tests --ios-simulator animations/animation-controller-drt-api.html --no-retry-failures 363929 2019-03-07 14:31:57 -0800 2019-03-07 16:23:57 -0800 Patch bug-195435-20190307143157.patch text/plain 1909 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyNjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmM5NjU3NjIxZTBhY2Vk YWNhNzgzZTBjOTJiODcwZGUwNjZlNGU4MC4uOTg1ZmVjNGM5NmVhMGFlYWUxZDNjZmM3MDAzMzE2 NjNiYWJlN2E1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTAzLTA3ICBKb2hu IFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2Ugc3VyZSBhbiBl bXB0eSBob3N0IG1hdGNoZXMgdGhlIGludGVybmFsIHJlcHJlc2VudGF0aW9uICJudWxsT3JpZ2lu IiBpbiBXZWJDb3JlOjpSZWdpc3RyYWJsZURvbWFpbjo6bWF0Y2hlcygpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTU0MzUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRlc3RzIGFy ZSBjdXJyZW50bHkgZmFpbGluZyBhbmQgd2lsbCBwYXNzIGFnYWluIHdpdGgKKyAgICAgICAgdGhp cyBwYXRjaC4KKworICAgICAgICBXZWJDb3JlOjpSZWdpc3RyYWJsZURvbWFpbjo6bWF0Y2hlcygp IGlzIGEgcXVpY2sgd2F5IHRvIGNvbXBhcmUgYQorICAgICAgICBSZWdpc3RyYWJsZURvbWFpbiB3 aXRoIGEgVVJMLiBTaW5jZSBSZWdpc3RyYWJsZURvbWFpbiByZXByZXNlbnRzIHRoZQorICAgICAg ICBlbXB0eSBob3N0IGFzICJudWxsT3JpZ2luLCIgYSBVUkwgd2l0aCBhbiBlbXB0eSBob3N0IG5l ZWRzIHRvIG1hdGNoCisgICAgICAgIHRoYXQgcmVwcmVzZW50YXRpb24gaW4gV2ViQ29yZTo6UmVn aXN0cmFibGVEb21haW46Om1hdGNoZXMoKS4KKyAgICAgICAgRmFpbHVyZSB0byBkbyBzbyBjYXVz ZWQgZGVidWcgYXNzZXJ0aW9ucyBpbiBmYXN0LyBsYXlvdXQgdGVzdHMgYWZ0ZXIKKyAgICAgICAg aHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzI0MjYwMy93ZWJraXQuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9SZWdpc3RyYWJsZURvbWFpbi5oOgorICAgICAgICAoV2ViQ29yZTo6UmVn aXN0cmFibGVEb21haW46Om1hdGNoZXMgY29uc3QpOgorCiAyMDE5LTAzLTA3ICBDb21taXQgUXVl dWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xs aW5nIG91dCByMjQyMjk3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUmVn aXN0cmFibGVEb21haW4uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1JlZ2lzdHJhYmxlRG9t YWluLmgKaW5kZXggZjQ1OGVhNWU1YmQxMDM2YTM4ZTM4YjZiYWM2ZDg2YjgwOTY1YjA3Yy4uYjM4 NjczMGRhNjE3YjJkYjhkODA4NWRmMDVjZTdkOWU1NGJkMzUxZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vUmVnaXN0cmFibGVEb21haW4uaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9SZWdpc3RyYWJsZURvbWFpbi5oCkBAIC01OSw2ICs1OSw4IEBAIHB1YmxpYzoK ICAgICBib29sIG1hdGNoZXMoY29uc3QgVVJMJiB1cmwpIGNvbnN0CiAgICAgewogICAgICAgICBh dXRvIGhvc3QgPSB1cmwuaG9zdCgpOworICAgICAgICBpZiAoaG9zdC5pc0VtcHR5KCkgJiYgbV9y ZWdpc3RyYWJsZURvbWFpbiA9PSAibnVsbE9yaWdpbiJfcykKKyAgICAgICAgICAgIHJldHVybiB0 cnVlOwogICAgICAgICBpZiAoIWhvc3QuZW5kc1dpdGgobV9yZWdpc3RyYWJsZURvbWFpbikpCiAg ICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIGlmIChob3N0Lmxlbmd0aCgpID09IG1f cmVnaXN0cmFibGVEb21haW4ubGVuZ3RoKCkpCg==