195425 2019-03-07 11:09:55 -0800 [ iOS Sim ] REGRESSION (r242277) Layout Test http/tests/cookies/same-site/lax-samesite-cookie-after-cross-site-history-load.php is a flaky timeout 2019-03-27 13:47:59 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 194023 1 sroberts cdumez achristensen beidson cdumez commit-queue ggaren lforschler rniwa webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1513608 0 sroberts 2019-03-07 11:09:55 -0800 The following layout test a timeout on iOS Simulator http/tests/cookies/same-site/lax-samesite-cookie-after-cross-site-history-load.php Probable cause: Test will timeout when it runs after any layout test in the http/tests/cookies/same-site/* directory Then pass on the re-try Prior to r242277 this test case is passing Reproduced with: run-webkit-tests http/tests/cookies/same-site/ --child-processes 1 --ios-simulator Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fcookies%2Fsame-site%2Flax-samesite-cookie-after-cross-site-history-load.php 1513609 1 webkit-bug-importer 2019-03-07 11:10:33 -0800 <rdar://problem/48682403> 1514039 2 sroberts 2019-03-08 09:58:07 -0800 Additional repro steps: Test first showed on the dashboard for iOS Sim / iOS Debug around r242280 Was unable to reproduce locally running just the test by itself using: run-webkit-tests http/tests/cookies/same-site/lax-samesite-cookie-after-cross-site-history-load.php --iterations 500 - f --ios-simulator Looked at build log for Apple iOS 12 Simulator Release WK2 (Tests) Build #3027 and pulled the worker test list that included this test using Layout test failure analysis website. Created a test list file from this worker list, and found test failed when running with this test list, then through bisection removed tests preceding this test until I found when running any test in the "http/tests/cookies/same-site/" caused this test to fail. Searched on trac and found the test change to this test was r241070 and used this as a bisecting point. Tested with the following revisions using this command "run-webkit-tests http/tests/cookies/same-site/ --child-processes 1 --ios-simulator" 242623 Timeout 242435 Timeout 242336 Timeout 242285 Timeout 242280 Timeout 242277 Timeout 242276 Passed 242275 Passed 242260 Passed 242234 Passed 241847 Passed 241070 Passed 1519982 3 cdumez 2019-03-21 15:28:52 -0700 Seems very unlikely http://trac.webkit.org/changeset/242277/webkit is the cause but ok. 1519988 4 cdumez 2019-03-21 15:44:28 -0700 Seems to reproduce like so: run-webkit-tests LayoutTests/http/tests/cookies/same-site/fetch-in-same-origin-worker.html LayoutTests/http/tests/cookies/same-site/lax-samesite-cookie-after-cross-site-history-load.php --child-processes 1 --ios-simulator --no-build 1521799 5 366097 cdumez 2019-03-27 13:10:14 -0700 Created attachment 366097 Patch 1521820 6 366097 commit-queue 2019-03-27 13:47:58 -0700 Comment on attachment 366097 Patch Clearing flags on attachment: 366097 Committed r243562: <https://trac.webkit.org/changeset/243562> 1521821 7 commit-queue 2019-03-27 13:47:59 -0700 All reviewed patches have been landed. Closing bug. 366097 2019-03-27 13:10:14 -0700 2019-03-27 13:47:58 -0700 Patch bug-195425-20190327131014.patch text/plain 3552 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzNTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNlYjcxNTdiYjA1YTU5NTdi MmI5OTQ3NDkyZjg1NWFjMmJkZjEzZmMuLjRjNWE0OTM1NTEyNzc1OGNjNzhkYmRiOGFkMmJhOWFm NDliMTliNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDMtMjcgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBbIGlPUyBTaW0gXSBSRUdSRVNTSU9O IChyMjQyMjc3KSBMYXlvdXQgVGVzdCBodHRwL3Rlc3RzL2Nvb2tpZXMvc2FtZS1zaXRlL2xheC1z YW1lc2l0ZS1jb29raWUtYWZ0ZXItY3Jvc3Mtc2l0ZS1oaXN0b3J5LWxvYWQucGhwIGlzIGEgZmxh a3kgdGltZW91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk1NDI1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80ODY4MjQwMz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHByb2Nlc3Mtc3dhcHBp bmcgb24gaGlzdG9yeSBuYXZpZ2F0aW9uLCB3ZSBsb29rdXAgdGhlIFdlYlByb2Nlc3NQcm94eSB3 ZSdkIGxpa2UgdG8gdXNlIGZyb20gdGhlCisgICAgICAgIHByb2Nlc3MgaWRlbnRpZmllciB0aGF0 IGlzIHNhdmVkIG9uIHRoZSBXZWJCYWNrRm9yd2FyZExpc3RJdGVtLCB0byB0cnkgYW5kIGxvYWQg dGhlIGl0ZW0gaW4gdGhlIHByb2Nlc3MKKyAgICAgICAgaW4gd2hpY2ggaXQgd2FzIHByZXZpb3Vz bHkgbG9hZGVkLiBIb3dldmVyLCB3ZSB3ZXJlIGZhaWxpbmcgdG8gY2hlY2sgaWYgdGhlIFdlYlBy b2Nlc3MgaW4gcXVlc3Rpb24gd2FzCisgICAgICAgIHN0aWxsIHJ1bm5pbmcgc28gd2UgY291bGQg cG90ZW50aWFsbHkgdHJ5IHRvIHVzZSBhIHByb2Nlc3MgdGhhdCdzIGFscmVhZHkgZXhpdGVkLgor CisgICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViUHJvY2Vzc1Bvb2w6OnByb2Nlc3NGb3JOYXZpZ2F0aW9uSW50ZXJuYWwpOgorCiAyMDE5 LTAzLTI3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAg IEZpeCBzb21lIG1vcmUgZGVwcmVjYXRpb24gd2FybmluZ3MgaW4gV0tEcmF3aW5nVmlldwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCmluZGV4IDk4YmQ0OTY4NTE0 ZGU4YjhiZjBjNDFlNTBmZWQ2YThkZDJlNmM2MWYuLjRjM2YxZTc0YWFjZTM0YTVhNzRmZTViODcy ZGY1MGM1MjQ3YTlhYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBy b2Nlc3NQb29sLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9v bC5jcHAKQEAgLTIyODcsMTggKzIyODcsMjAgQEAgdm9pZCBXZWJQcm9jZXNzUG9vbDo6cHJvY2Vz c0Zvck5hdmlnYXRpb25JbnRlcm5hbChXZWJQYWdlUHJveHkmIHBhZ2UsIGNvbnN0IEFQSToKICAg ICAgICAgfQogCiAgICAgICAgIGlmIChSZWZQdHI8V2ViUHJvY2Vzc1Byb3h5PiBwcm9jZXNzID0g V2ViUHJvY2Vzc1Byb3h5Ojpwcm9jZXNzRm9ySWRlbnRpZmllcih0YXJnZXRJdGVtLT5sYXN0UHJv Y2Vzc0lkZW50aWZpZXIoKSkpIHsKLSAgICAgICAgICAgIC8vIEZJWE1FOiBBcmNoaXRlY3R1cmFs bHkgd2UgZG8gbm90IGN1cnJlbnRseSBzdXBwb3J0IG11bHRpcGxlIFdlYlBhZ2UncyB3aXRoIHRo ZSBzYW1lIElEIGluIGEgZ2l2ZW4gV2ViUHJvY2Vzcy4KLSAgICAgICAgICAgIC8vIEluIHRoZSBj YXNlIHdoZXJlIHRoaXMgV2ViUHJvY2VzcyBoYXMgYSBTdXNwZW5kZWRQYWdlUHJveHkgZm9yIHRo aXMgV2ViUGFnZSwgd2UgY2FuIHRocm93IGl0IGF3YXkgdG8gc3VwcG9ydAotICAgICAgICAgICAg Ly8gV2ViUHJvY2VzcyByZS11c2UuCi0gICAgICAgICAgICByZW1vdmVBbGxTdXNwZW5kZWRQYWdl c0ZvclBhZ2UocGFnZSwgcHJvY2Vzcy5nZXQoKSk7Ci0KLSAgICAgICAgICAgIC8vIE1ha2Ugc3Vy ZSB3ZSByZW1vdmUgdGhlIHByb2Nlc3MgZnJvbSB0aGUgY2FjaGUgaWYgaXQgaXMgaW4gdGhlcmUg c2luY2Ugd2UncmUgYWJvdXQgdG8gdXNlIGl0LgotICAgICAgICAgICAgaWYgKHByb2Nlc3MtPmlz SW5Qcm9jZXNzQ2FjaGUoKSkgewotICAgICAgICAgICAgICAgIHdlYlByb2Nlc3NDYWNoZSgpLnJl bW92ZVByb2Nlc3MoKnByb2Nlc3MsIFdlYlByb2Nlc3NDYWNoZTo6U2hvdWxkU2h1dERvd25Qcm9j ZXNzOjpObyk7Ci0gICAgICAgICAgICAgICAgQVNTRVJUKCFwcm9jZXNzLT5pc0luUHJvY2Vzc0Nh Y2hlKCkpOwotICAgICAgICAgICAgfQorICAgICAgICAgICAgaWYgKHByb2Nlc3MtPnN0YXRlKCkg IT0gV2ViUHJvY2Vzc1Byb3h5OjpTdGF0ZTo6VGVybWluYXRlZCkgeworICAgICAgICAgICAgICAg IC8vIEZJWE1FOiBBcmNoaXRlY3R1cmFsbHkgd2UgZG8gbm90IGN1cnJlbnRseSBzdXBwb3J0IG11 bHRpcGxlIFdlYlBhZ2UncyB3aXRoIHRoZSBzYW1lIElEIGluIGEgZ2l2ZW4gV2ViUHJvY2Vzcy4K KyAgICAgICAgICAgICAgICAvLyBJbiB0aGUgY2FzZSB3aGVyZSB0aGlzIFdlYlByb2Nlc3MgaGFz IGEgU3VzcGVuZGVkUGFnZVByb3h5IGZvciB0aGlzIFdlYlBhZ2UsIHdlIGNhbiB0aHJvdyBpdCBh d2F5IHRvIHN1cHBvcnQKKyAgICAgICAgICAgICAgICAvLyBXZWJQcm9jZXNzIHJlLXVzZS4KKyAg ICAgICAgICAgICAgICByZW1vdmVBbGxTdXNwZW5kZWRQYWdlc0ZvclBhZ2UocGFnZSwgcHJvY2Vz cy5nZXQoKSk7CisKKyAgICAgICAgICAgICAgICAvLyBNYWtlIHN1cmUgd2UgcmVtb3ZlIHRoZSBw cm9jZXNzIGZyb20gdGhlIGNhY2hlIGlmIGl0IGlzIGluIHRoZXJlIHNpbmNlIHdlJ3JlIGFib3V0 IHRvIHVzZSBpdC4KKyAgICAgICAgICAgICAgICBpZiAocHJvY2Vzcy0+aXNJblByb2Nlc3NDYWNo ZSgpKSB7CisgICAgICAgICAgICAgICAgICAgIHdlYlByb2Nlc3NDYWNoZSgpLnJlbW92ZVByb2Nl c3MoKnByb2Nlc3MsIFdlYlByb2Nlc3NDYWNoZTo6U2hvdWxkU2h1dERvd25Qcm9jZXNzOjpObyk7 CisgICAgICAgICAgICAgICAgICAgIEFTU0VSVCghcHJvY2Vzcy0+aXNJblByb2Nlc3NDYWNoZSgp KTsKKyAgICAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAgIHJldHVybiBjb21wbGV0aW9uSGFu ZGxlcihwcm9jZXNzLnJlbGVhc2VOb25OdWxsKCksIG51bGxwdHIsICJVc2luZyB0YXJnZXQgYmFj ay9mb3J3YXJkIGl0ZW0ncyBwcm9jZXNzIl9zKTsKKyAgICAgICAgICAgICAgICByZXR1cm4gY29t cGxldGlvbkhhbmRsZXIocHJvY2Vzcy5yZWxlYXNlTm9uTnVsbCgpLCBudWxscHRyLCAiVXNpbmcg dGFyZ2V0IGJhY2svZm9yd2FyZCBpdGVtJ3MgcHJvY2VzcyJfcyk7CisgICAgICAgICAgICB9CiAg ICAgICAgIH0KICAgICB9CiAK