195331 2019-03-05 09:40:55 -0800 Update WPT tests for the canvas element 2019-03-06 02:47:20 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/1599 https://github.com/web-platform-tests/wpt/pull/15685 P2 Normal --- 194770 1 fred.wang fred.wang ap jbedard Ms2ger webkit-bug-importer youennf oldest_to_newest 1512672 0 fred.wang 2019-03-05 09:40:55 -0800 Update WPT tests for the canvas element 1512673 1 363646 fred.wang 2019-03-05 09:41:29 -0800 Created attachment 363646 Patch 1512686 2 fred.wang 2019-03-05 10:20:50 -0800 > 19:16:51 - youenn: fredw: this is probably one deficiency of svn-apply. Some others have been identified but I cannot find any trace for this one, maybe a new bug should be filed. I cced Jonathan on the bug and r+ed the patch. Maybe you can comment you plan to land this patch manually soon. As discussed with Youenn on IRC, this patch does not apply, probably because of a bug with svn-apply. It works for me with git apply. I also checked that the modified test still passes on GTK / macOS / iOS sim. If nobody opposes to that, I'll land the patch tomorrow morning (Paris time) and watch the bot. 1512702 3 363646 jbedard 2019-03-05 10:57:02 -0800 Comment on attachment 363646 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=363646&action=review > LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.whitespace.html:16 > + 100" height=" Bit unclear what has actually changed here. (even looking at the patch in Sublime, I can't see a difference between the removed line and added line) This line, by the way, is what's broken svn-apply. I wonder is this change were reverted, if this patch would work. 1512708 4 fred.wang 2019-03-05 11:07:32 -0800 (In reply to Jonathan Bedard from comment #3) > Bit unclear what has actually changed here. (even looking at the patch in > Sublime, I can't see a difference between the removed line and added line) > This line, by the way, is what's broken svn-apply. I wonder is this change > were reverted, if this patch would work. This file is auto-generated upstream. I have not check the details, but I suspect this whitespace change was done on purpose, so I'm not sure it's right to revert it. 1512723 5 ap 2019-03-05 11:25:53 -0800 This file needs to be marked as binary, there is no way source control would nicely preserve LF, CR and FF characters in weird order. Not sure if the change is even intentional, as the lines were and remain broken, just in different ways. Quite possible that upstream messed them up too. So I don't think that this is a bug in svn-apply. Seems like a deeper investigation is necessary to figure out what the intention was, and the file likely needs to be marked as binary upstream. 1512731 6 fred.wang 2019-03-05 11:36:16 -0800 (In reply to Alexey Proskuryakov from comment #5) > This file needs to be marked as binary, there is no way source control would > nicely preserve LF, CR and FF characters in weird order. OK thanks for the info. > > Not sure if the change is even intentional, as the lines were and remain > broken, just in different ways. Quite possible that upstream messed them up > too. By "broken" you mean "line breaking" not that something is wrong in the content?. Checking the patch in emacs, I see that the only the windows's newline characters had been removed. > So I don't think that this is a bug in svn-apply. Seems like a deeper > investigation is necessary to figure out what the intention was, and the > file likely needs to be marked as binary upstream. OK, it seems to be https://github.com/web-platform-tests/wpt/pull/1599 ; reviewers suggested to use "&#xD;" but that was not done. I'll see if I can fix that upstream tomorrow. 1512737 7 ap 2019-03-05 11:46:47 -0800 Thank you for finding the change! It kind of looks incorrect - deleting a character that needed to be tested just because of source control limitations seems like a bad idea. 1513014 8 fred.wang 2019-03-06 02:31:35 -0800 Committed r242533: <https://trac.webkit.org/changeset/242533> 1513016 9 fred.wang 2019-03-06 02:47:16 -0800 (In reply to Alexey Proskuryakov from comment #7) > Thank you for finding the change! It kind of looks incorrect - deleting a > character that needed to be tested just because of source control > limitations seems like a bad idea. The reason was not about source control limitation but because of HTML parsing rules ( https://github.com/web-platform-tests/wpt/pull/1599#issuecomment-72433595 ) ; as I said the patch was initially landed without following the suggestion of reviewer to use &xD;. This is now done in the follow-up https://github.com/web-platform-tests/wpt/pull/15685 (In reply to Frédéric Wang (:fredw) from comment #8) > Committed r242533: <https://trac.webkit.org/changeset/242533> I landed the latest version. This file still has the special space characters causing issues with SVN apply but I didn't change the file to binary because: (1) It will prevent us to properly see and control any diff in future import, even when they don't touch the space characters. (2) Probably it makes sense to test space characters without using escape notation, when they don't need this workaround for proper HTML parsing. For (2), asking WPT people to change python script because of WebKit/SVN's source limitation is probably a weak argument but I guess we can try if we really want to. 363646 2019-03-05 09:41:29 -0800 2019-03-05 10:15:09 -0800 Patch bug-195331-20190305184127.patch text/plain 5272 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyNDY4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpp bmRleCA4MDFkOThlNGFjYjZkY2YyMTgyYjlmMDAwZWE3NDlhMzAyNTI1M2EzLi5jOGRlNWM1ODQ5 NzUzZmM2NDczMmQyZTczNGVkMDE3ZWNkZTY2ZTA5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOS0wMy0wNSAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5n QGlnYWxpYS5jb20+CisKKyAgICAgICAgVXBkYXRlIFdQVCB0ZXN0cyBmb3IgdGhlIGNhbnZhcyBl bGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTUzMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHJlc291cmNlcy9pbXBvcnQtZXhwZWN0YXRpb25zLmpzb246CisgICAgICAgICogd2ViLXBsYXRm b3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2VtYmVkZGVkLWNvbnRlbnQvdGhlLWNhbnZhcy1lbGVt ZW50L3NpemUuYXR0cmlidXRlcy5wYXJzZS53aGl0ZXNwYWNlLmh0bWw6CisgICAgICAgICogd2Vi LXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2VtYmVkZGVkLWNvbnRlbnQvdGhlLWNhbnZh cy1lbGVtZW50L3czYy1pbXBvcnQubG9nOgorCiAyMDE5LTAzLTAyICBEYXJpbiBBZGxlciAgPGRh cmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXRpcmUgbGVnYWN5IGR0b2EgZnVuY3Rpb24gYW5k IERlY2ltYWxOdW1iZXIgY2xhc3MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy9yZXNvdXJjZXMvaW1wb3J0LWV4cGVjdGF0aW9ucy5qc29uIGIvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3Jlc291cmNlcy9pbXBvcnQtZXhwZWN0YXRpb25zLmpzb24KaW5kZXggNzBhZGVhNWNl YTdhMGM2ZTNlNTcwYjBiZmE4ZjkyYmUzMDU3MDBlOC4uNDczNmRhOGIwZTk1NTQ2MGE5MGIzYjU1 OGEwYzMxNThlYWUxZTIyZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3Jl c291cmNlcy9pbXBvcnQtZXhwZWN0YXRpb25zLmpzb24KKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3Jlc291cmNlcy9pbXBvcnQtZXhwZWN0YXRpb25zLmpzb24KQEAgLTIxNSw2ICsyMTUs NyBAQAogICAgICJ3ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRkZWQtY29u dGVudC9tZWRpYS1lbGVtZW50cy92aWRlb19sb29wX2Jhc2UuaHRtbCI6ICJza2lwIiwgCiAgICAg IndlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9lbWJlZGRlZC1jb250ZW50L3RoZS1h cmVhLWVsZW1lbnQvYXJlYV9ub2hyZWYueGh0bWwiOiAic2tpcCIsIAogICAgICJ3ZWItcGxhdGZv cm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRkZWQtY29udGVudC90aGUtYXJlYS1lbGVtZW50 L3Rlc3QtYXJlYS54aHRtbCI6ICJza2lwIiwgCisgICAgIndlYi1wbGF0Zm9ybS10ZXN0cy9odG1s L3NlbWFudGljcy9lbWJlZGRlZC1jb250ZW50L3RoZS1jYW52YXMtZWxlbWVudCI6ICJpbXBvcnQi LCAKICAgICAid2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2VtYmVkZGVkLWNvbnRl bnQvdGhlLWNhbnZhcy1lbGVtZW50L3NpemUuYXR0cmlidXRlcy5wYXJzZS53aGl0ZXNwYWNlLmh0 bWwiOiAic2tpcCIsIAogICAgICJ3ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1i ZWRkZWQtY29udGVudC90aGUtZW1iZWQtZWxlbWVudC9lbWJlZC1yZXByZXNlbnQtbm90aGluZy0w NC5odG1sIjogInNraXAiLCAKICAgICAid2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNz L2VtYmVkZGVkLWNvbnRlbnQvdGhlLWlmcmFtZS1lbGVtZW50IjogImltcG9ydCIsIApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3Nl bWFudGljcy9lbWJlZGRlZC1jb250ZW50L3RoZS1jYW52YXMtZWxlbWVudC9zaXplLmF0dHJpYnV0 ZXMucGFyc2Uud2hpdGVzcGFjZS5odG1sIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9lbWJlZGRlZC1jb250ZW50L3RoZS1jYW52YXMt ZWxlbWVudC9zaXplLmF0dHJpYnV0ZXMucGFyc2Uud2hpdGVzcGFjZS5odG1sCmluZGV4IDZjOTY5 ZjQ1Y2Y0MGJhODE1OGY1YjhjZWE5MDQwOTdiODY4NjhlZjkuLmY0NjYyYjQ1Zjk0MDQ2OTNlMDE2 YmE5OTMwMmJlOTZjY2JjMTUwYTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRkZWQtY29udGVudC90aGUt Y2FudmFzLWVsZW1lbnQvc2l6ZS5hdHRyaWJ1dGVzLnBhcnNlLndoaXRlc3BhY2UuaHRtbAorKysg Yi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50 aWNzL2VtYmVkZGVkLWNvbnRlbnQvdGhlLWNhbnZhcy1lbGVtZW50L3NpemUuYXR0cmlidXRlcy5w YXJzZS53aGl0ZXNwYWNlLmh0bWwKQEAgLTEsNSArMSw1IEBACiA8IURPQ1RZUEUgaHRtbD4KLTwh LS0gIERPIE5PVCBFRElUISBUaGlzIHRlc3QgaGFzIGJlZW4gZ2VuZXJhdGVkIGJ5IHRvb2xzL2dl bnRlc3QucHkuICAtLT4KKzwhLS0gRE8gTk9UIEVESVQhIFRoaXMgdGVzdCBoYXMgYmVlbiBnZW5l cmF0ZWQgYnkgdG9vbHMvZ2VudGVzdC5weS4gLS0+CiA8dGl0bGU+Q2FudmFzIHRlc3Q6IHNpemUu YXR0cmlidXRlcy5wYXJzZS53aGl0ZXNwYWNlPC90aXRsZT4KIDxzY3JpcHQgc3JjPSIvcmVzb3Vy Y2VzL3Rlc3RoYXJuZXNzLmpzIj48L3NjcmlwdD4KIDxzY3JpcHQgc3JjPSIvcmVzb3VyY2VzL3Rl c3RoYXJuZXNzcmVwb3J0LmpzIj48L3NjcmlwdD4KQEAgLTEyLDggKzEyLDggQEAKIAogCiA8cCBj bGFzcz0ib3V0cHV0Ij5BY3R1YWwgb3V0cHV0OjwvcD4KLTxjYW52YXMgaWQ9ImMiIGNsYXNzPSJv dXRwdXQiIHdpZHRoPSINCi0JDDEwMCIgaGVpZ2h0PSINCis8Y2FudmFzIGlkPSJjIiBjbGFzcz0i b3V0cHV0IiB3aWR0aD0iCisJDDEwMCIgaGVpZ2h0PSIKIAkMMTAwIj48cCBjbGFzcz0iZmFsbGJh Y2siPkZBSUwgKGZhbGxiYWNrIGNvbnRlbnQpPC9wPjwvY2FudmFzPgogPHAgY2xhc3M9Im91dHB1 dCBleHBlY3RlZHRleHQiPkV4cGVjdGVkIG91dHB1dDo8cD48aW1nIHNyYz0ic2l6ZS5hdHRyaWJ1 dGVzLnBhcnNlLndoaXRlc3BhY2UucG5nIiBjbGFzcz0ib3V0cHV0IGV4cGVjdGVkIiBpZD0iZXhw ZWN0ZWQiIGFsdD0iIj4KIDx1bCBpZD0iZCI+PC91bD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRkZWQt Y29udGVudC90aGUtY2FudmFzLWVsZW1lbnQvdzNjLWltcG9ydC5sb2cgYi9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2VtYmVkZGVkLWNv bnRlbnQvdGhlLWNhbnZhcy1lbGVtZW50L3czYy1pbXBvcnQubG9nCmluZGV4IGFhMWI1OGJkNTFm OTE0YzczMWUxOTI2NDVmYmRlODUwMjIwNDk5MjAuLmI1MjA2MWY0MjdlMDMzNGJlZTY2ODQ4MjNm YzViOTlkNjEwNzc5MWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRkZWQtY29udGVudC90aGUtY2FudmFz LWVsZW1lbnQvdzNjLWltcG9ydC5sb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9lbWJlZGRlZC1jb250ZW50L3RoZS1jYW52 YXMtZWxlbWVudC93M2MtaW1wb3J0LmxvZwpAQCAtMSw3ICsxLDcgQEAKIFRoZSB0ZXN0cyBpbiB0 aGlzIGRpcmVjdG9yeSB3ZXJlIGltcG9ydGVkIGZyb20gdGhlIFczQyByZXBvc2l0b3J5LgogRG8g Tk9UIG1vZGlmeSB0aGVzZSB0ZXN0cyBkaXJlY3RseSBpbiBXZWJLaXQuCiBJbnN0ZWFkLCBjcmVh dGUgYSBwdWxsIHJlcXVlc3Qgb24gdGhlIFdQVCBnaXRodWI6Ci0JaHR0cHM6Ly9naXRodWIuY29t L3czYy93ZWItcGxhdGZvcm0tdGVzdHMKKwlodHRwczovL2dpdGh1Yi5jb20vd2ViLXBsYXRmb3Jt LXRlc3RzL3dwdAogCiBUaGVuIHJ1biB0aGUgVG9vbHMvU2NyaXB0cy9pbXBvcnQtdzNjLXRlc3Rz IGluIFdlYktpdCB0byByZWltcG9ydAogCkBAIC0xMDIsNiArMTAyLDcgQEAgTGlzdCBvZiBmaWxl czoKIC9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2Vt YW50aWNzL2VtYmVkZGVkLWNvbnRlbnQvdGhlLWNhbnZhcy1lbGVtZW50L3NpemUuYXR0cmlidXRl cy5wYXJzZS5zcGFjZS5wbmcKIC9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2h0bWwvc2VtYW50aWNzL2VtYmVkZGVkLWNvbnRlbnQvdGhlLWNhbnZhcy1lbGVtZW50 L3NpemUuYXR0cmlidXRlcy5wYXJzZS50cmFpbGluZ2p1bmsuaHRtbAogL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRkZWQtY29u dGVudC90aGUtY2FudmFzLWVsZW1lbnQvc2l6ZS5hdHRyaWJ1dGVzLnBhcnNlLnRyYWlsaW5nanVu ay5wbmcKKy9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwv c2VtYW50aWNzL2VtYmVkZGVkLWNvbnRlbnQvdGhlLWNhbnZhcy1lbGVtZW50L3NpemUuYXR0cmli dXRlcy5wYXJzZS53aGl0ZXNwYWNlLmh0bWwKIC9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2VtYmVkZGVkLWNvbnRlbnQvdGhlLWNhbnZh cy1lbGVtZW50L3NpemUuYXR0cmlidXRlcy5wYXJzZS53aGl0ZXNwYWNlLnBuZwogL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRk ZWQtY29udGVudC90aGUtY2FudmFzLWVsZW1lbnQvc2l6ZS5hdHRyaWJ1dGVzLnBhcnNlLnplcm8u aHRtbAogL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9z ZW1hbnRpY3MvZW1iZWRkZWQtY29udGVudC90aGUtY2FudmFzLWVsZW1lbnQvc2l6ZS5hdHRyaWJ1 dGVzLnJlZmxlY3Quc2V0Y29udGVudC5odG1sCg==