195210 2019-03-01 09:01:03 -0800 REGRESSION: (r242189): Seven Layout Tests in storage/indexeddb/ are crashing after r242189 2019-03-04 08:58:13 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195141 InRadar P2 Normal --- 1 tsavell webkit-unassigned calvaris darin jlewis3 lforschler ryanhaddad webkit-bug-importer oldest_to_newest 1511407 0 tsavell 2019-03-01 09:01:03 -0800 The following layout tests are crashing on Mac Debug WK1 storage/indexeddb/intversion-open-in-upgradeneeded-private.html storage/indexeddb/intversion-open-in-upgradeneeded.html storage/indexeddb/modern/abort-requests-cancelled-private.html storage/indexeddb/modern/abort-requests-cancelled.html storage/indexeddb/modern/blocked-open-db-requests-private.html storage/indexeddb/odd-strings-private.html Probable cause: These tests began crashing after the rollout of https://trac.webkit.org/changeset/242014/webkit in https://trac.webkit.org/changeset/242189/webkit. Possibly some change was made that was dependent on 242014 before it was rolled out. Currently these tests are slowing down WK1 EWS. These tests are reproducible locally by just running these tests on a checkout of r242189. This is related to https://bugs.webkit.org/show_bug.cgi?id=195141 Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fintversion-open-in-upgradeneeded-private.html%20storage%2Findexeddb%2Fintversion-open-in-upgradeneeded.html%20storage%2Findexeddb%2Fmodern%2Fabort-requests-cancelled-private.html%20storage%2Findexeddb%2Fmodern%2Fabort-requests-cancelled.html%20storage%2Findexeddb%2Fmodern%2Fblocked-open-db-requests-private.html%20storage%2Findexeddb%2Fodd-strings-private.html 1511412 1 tsavell 2019-03-01 09:09:03 -0800 Marked tests skip while investigating and to get EWS caught up: https://trac.webkit.org/changeset/242264/webkit 1511553 2 tsavell 2019-03-01 12:56:33 -0800 This additional test appears to be crashing often on EWS alone storage/indexeddb/modern/blocked-open-db-requests.html https://webkit-queues.webkit.org/results/11334458 This is continuing to slow EWS 1511556 3 tsavell 2019-03-01 13:00:50 -0800 Skipped in: https://trac.webkit.org/changeset/242282/webkit 1511607 4 tsavell 2019-03-01 14:09:29 -0800 Crash: https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/r242199%20(8015)/storage/indexeddb/intversion-open-in-upgradeneeded-private-crash-log.txt 1511618 5 webkit-bug-importer 2019-03-01 14:28:44 -0800 <rdar://problem/48523172> 1511634 6 tsavell 2019-03-01 15:06:58 -0800 It appears that after skipping some tests others begin to crash. I have not been able to narrow down which test is at fault for the crashes later in the test runner. 1511673 7 tsavell 2019-03-01 16:17:25 -0800 I talked with sihui and she found that https://trac.webkit.org/changeset/242075/webkit is calling a function from r242014 and is crashing due to the rollout. Looks like we will need to roll this change out too to resolve the crashing tests. 1512109 8 calvaris 2019-03-04 03:30:46 -0800 (In reply to Truitt Savell from comment #7) > I talked with sihui and she found that > https://trac.webkit.org/changeset/242075/webkit is calling a function from > r242014 and is crashing due to the rollout. Looks like we will need to roll > this change out too to resolve the crashing tests. No, you can't roll out my change. I didn't touch that function per-se. I just unveiled a hidden bug. 1512124 9 calvaris 2019-03-04 04:13:25 -0800 Besides I don't know if this is still valid as it looks like there's r242308 landing that part of r242014 1512125 10 calvaris 2019-03-04 04:18:49 -0800 And the link to the flakiness dashboard says they are green now, so I'd say we're cool here now. 1512126 11 calvaris 2019-03-04 04:19:23 -0800 It was Darin, btw, who landed r242308. 1512188 12 tsavell 2019-03-04 08:58:07 -0800 Issue does appear to be resolved by r242308. I unskipped the tests in: https://trac.webkit.org/changeset/242358/webkit