195205 2019-03-01 03:02:51 -0800 Fix debug builds with GCC 2019-03-01 05:38:09 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dominik.infuehr webkit-unassigned commit-queue csaavedra ews-watchlist fred.wang keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1511357 0 dominik.infuehr 2019-03-01 03:02:51 -0800 Fix debug builds with GCC 1511358 1 363319 dominik.infuehr 2019-03-01 03:04:14 -0800 Created attachment 363319 Patch 1511368 2 363319 commit-queue 2019-03-01 03:43:38 -0800 Comment on attachment 363319 Patch Clearing flags on attachment: 363319 Committed r242262: <https://trac.webkit.org/changeset/242262> 1511369 3 commit-queue 2019-03-01 03:43:39 -0800 All reviewed patches have been landed. Closing bug. 1511370 4 webkit-bug-importer 2019-03-01 03:44:16 -0800 <rdar://problem/48506653> 1511371 5 csaavedra 2019-03-01 03:46:48 -0800 Why not add a ASSERT_NOT_REACHED_UNDER_CONSTEXPR that would expand to ASSERT_UNDER_CONSTEXPR(false) instead? Removing the constexpr you're dropping its benefits for all builds, just for the sake of the few that expand the macro (debug builds). 1511372 6 dominik.infuehr 2019-03-01 04:04:12 -0800 I would have preferred that solution as well: But using ASSERT_UNDER_CONSTEXPR_CONTEXT(false) failed to build for me as well. The macro invokes WTFReportAssertionFailure which isn't constexpr. Since Saam recommended to remove the constexpr keyword in https://bugs.webkit.org/show_bug.cgi?id=194912 I used this solution to get the build working again. 1511377 7 csaavedra 2019-03-01 05:02:35 -0800 +fredw > The macro invokes WTFReportAssertionFailure which isn't constexpr. Isn't that then a bug in ASSERT_UNDER_CONSTEXPR_CONTEXT()? 1511380 8 fred.wang 2019-03-01 05:19:49 -0800 (In reply to Claudio Saavedra from comment #7) > +fredw > > > The macro invokes WTFReportAssertionFailure which isn't constexpr. > > Isn't that then a bug in ASSERT_UNDER_CONSTEXPR_CONTEXT()? I think this is expected, as the name indicates it only works under a constexpr context. cc'in Yusuke since he is the one who initially introduced this. 1511385 9 csaavedra 2019-03-01 05:38:09 -0800 (In reply to Frédéric Wang (:fredw) from comment #8) > (In reply to Claudio Saavedra from comment #7) > > +fredw > > > > > The macro invokes WTFReportAssertionFailure which isn't constexpr. > > > > Isn't that then a bug in ASSERT_UNDER_CONSTEXPR_CONTEXT()? > > I think this is expected, as the name indicates it only works under a > constexpr context. cc'in Yusuke since he is the one who initially introduced > this. But it's ASSERT_UNDER_CONSTEXPR_CONTEXT() that ends up calling WTFReportAssertionFailure(), which is not constexpr. I understood that the idea of ASSERT_UNDER_CONSTEXPR_CONTEXT() was to allow for assertions when the calling methods are constexpr, but it won't work. Unless I'm understanding it completely wrong, of course :) 363319 2019-03-01 03:04:14 -0800 2019-03-01 03:43:38 -0800 Patch bug-195205-20190301120412.patch text/plain 1350 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMjYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk MjZmNTQ2YWQyMmQ3N2RhYzU1MmEzODA4OTcyN2JlYTVlMmM4ODFmLi45YzdmYWNjOGEwYTE0YTkx YjI5YTA2ZDJkOGFlNzNiNmUwOGUwNzcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOS0wMy0wMSAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh LmNvbT4KKworICAgICAgICBGaXggZGVidWcgYnVpbGRzIHdpdGggR0NDCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTUyMDUKKworICAgICAgICBVbnJl dmlld2VkLiBGaXggZGVidWcgYnVpbGRzIGluIEdDQyBieSByZW1vdmluZworICAgICAgICB0aGUg Y29uc3RleHByLWtleXdvcmQgZm9yIHRoaXMgZnVuY3Rpb24uCisKKyAgICAgICAgKiBydW50aW1l L0NhY2hlZFR5cGVzLmNwcDoKKyAgICAgICAgKEpTQzo6dGFnRnJvbVNvdXJjZUNvZGVUeXBlKToK KwogMjAxOS0wMy0wMSAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbQVJNXSBGaXggYXNzZW1ibGVyIHdhcm5pbmdzIGluIGN0aU1hc21Qcm9iZVRyYW1w b2xpbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NhY2hlZFR5 cGVzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NhY2hlZFR5cGVzLmNwcApp bmRleCBhOGVlYWEzNTM0MGVkNTYyNzRkNDM5N2MxMWU1NTBiZGZhNGE1MmNlLi5lODc0YWI3YjY5 NWY0NDQ1NTY3ZTFhMmJhMzY3MDFjZjRiOTU0OGY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9DYWNoZWRUeXBlcy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwCkBAIC0xODEyLDcgKzE4MTIsNyBAQCBlbnVtIENh Y2hlZENvZGVCbG9ja1RhZyB7CiAgICAgQ2FjaGVkRXZhbENvZGVCbG9ja1RhZywKIH07CiAKLXN0 YXRpYyBjb25zdGV4cHIgQ2FjaGVkQ29kZUJsb2NrVGFnIHRhZ0Zyb21Tb3VyY2VDb2RlVHlwZShT b3VyY2VDb2RlVHlwZSB0eXBlKQorc3RhdGljIENhY2hlZENvZGVCbG9ja1RhZyB0YWdGcm9tU291 cmNlQ29kZVR5cGUoU291cmNlQ29kZVR5cGUgdHlwZSkKIHsKICAgICBzd2l0Y2ggKHR5cGUpIHsK ICAgICBjYXNlIFNvdXJjZUNvZGVUeXBlOjpQcm9ncmFtVHlwZToK