195192 2019-02-28 16:23:16 -0800 Web Inspector: Timelines: don't show the auto-stop UI when not inspecting a page 2019-02-28 17:19:58 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 194956 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1511185 0 hi 2019-02-28 16:23:16 -0800 e.g. everything non `WI.DebuggableType.Web` 1511186 1 363272 hi 2019-02-28 16:24:57 -0800 Created attachment 363272 Patch 1511196 2 363272 joepeck 2019-02-28 16:44:56 -0800 Comment on attachment 363272 Patch r=me 1511217 3 363272 commit-queue 2019-02-28 17:12:01 -0800 Comment on attachment 363272 Patch Clearing flags on attachment: 363272 Committed r242244: <https://trac.webkit.org/changeset/242244> 1511218 4 commit-queue 2019-02-28 17:12:03 -0800 All reviewed patches have been landed. Closing bug. 1511222 5 webkit-bug-importer 2019-02-28 17:19:58 -0800 <rdar://problem/48495347> 363272 2019-02-28 16:24:57 -0800 2019-02-28 17:12:01 -0800 Patch 195192.diff text/plain 3654 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE5ZjJmMTFlYjkzLi41MDg0OGRmYjkzMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDItMjggIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRp bWVsaW5lczogZG9uJ3Qgc2hvdyB0aGUgYXV0by1zdG9wIFVJIHdoZW4gbm90IGluc3BlY3Rpbmcg YSBwYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTUxOTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qczoKKyAg ICAgICAgKFdJLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcpOgorICAgICAgICAoV0kuVGlt ZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5wcm90b3R5cGUuZ2V0IG5hdmlnYXRpb25JdGVtcyk6 CisKIDIwMTktMDItMjggIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogU3R5bGVzOiBDb250cm9sLVNwYWNlIHNob3VsZCBmb3Jj ZSBjb21wbGV0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmll dy5qcwppbmRleCBkNTBiZTYwMjI1Yy4uOWFkYjc5N2NhMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVu dFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcwpAQCAtNTYsMTEgKzU2LDEzIEBAIFdJLlRp bWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcgPSBjbGFzcyBUaW1lbGluZVJlY29yZGluZ0NvbnRl bnRWaWV3IGV4dGVuZHMgV0kuCiAgICAgICAgIHRoaXMuX3RpbWVsaW5lQ29udGVudEJyb3dzZXIu bmF2aWdhdGlvbkJhci5hZGROYXZpZ2F0aW9uSXRlbSh0aGlzLl9maWx0ZXJCYXJOYXZpZ2F0aW9u SXRlbSk7CiAgICAgICAgIHRoaXMuYWRkU3Vidmlldyh0aGlzLl90aW1lbGluZUNvbnRlbnRCcm93 c2VyKTsKIAotICAgICAgICB0aGlzLl9hdXRvU3RvcENoZWNrYm94TmF2aWdhdGlvbkl0ZW0gPSBu ZXcgV0kuQ2hlY2tib3hOYXZpZ2F0aW9uSXRlbSgiYXV0by1zdG9wLXJlY29yZGluZyIsIFdJLlVJ U3RyaW5nKCJTdG9wIHJlY29yZGluZyBvbmNlIHBhZ2UgbG9hZHMiKSwgV0kuc2V0dGluZ3MudGlt ZWxpbmVzQXV0b1N0b3AudmFsdWUpOwotICAgICAgICB0aGlzLl9hdXRvU3RvcENoZWNrYm94TmF2 aWdhdGlvbkl0ZW0udmlzaWJpbGl0eVByaW9yaXR5ID0gV0kuTmF2aWdhdGlvbkl0ZW0uVmlzaWJp bGl0eVByaW9yaXR5LkxvdzsKLSAgICAgICAgdGhpcy5fYXV0b1N0b3BDaGVja2JveE5hdmlnYXRp b25JdGVtLmFkZEV2ZW50TGlzdGVuZXIoV0kuQ2hlY2tib3hOYXZpZ2F0aW9uSXRlbS5FdmVudC5D aGVja2VkRGlkQ2hhbmdlLCB0aGlzLl9oYW5kbGVBdXRvU3RvcENoZWNrYm94Q2hlY2tlZERpZENo YW5nZSwgdGhpcyk7CisgICAgICAgIGlmIChXSS5zaGFyZWRBcHAuZGVidWdnYWJsZVR5cGUgPT09 IFdJLkRlYnVnZ2FibGVUeXBlLldlYikgeworICAgICAgICAgICAgdGhpcy5fYXV0b1N0b3BDaGVj a2JveE5hdmlnYXRpb25JdGVtID0gbmV3IFdJLkNoZWNrYm94TmF2aWdhdGlvbkl0ZW0oImF1dG8t c3RvcC1yZWNvcmRpbmciLCBXSS5VSVN0cmluZygiU3RvcCByZWNvcmRpbmcgb25jZSBwYWdlIGxv YWRzIiksIFdJLnNldHRpbmdzLnRpbWVsaW5lc0F1dG9TdG9wLnZhbHVlKTsKKyAgICAgICAgICAg IHRoaXMuX2F1dG9TdG9wQ2hlY2tib3hOYXZpZ2F0aW9uSXRlbS52aXNpYmlsaXR5UHJpb3JpdHkg PSBXSS5OYXZpZ2F0aW9uSXRlbS5WaXNpYmlsaXR5UHJpb3JpdHkuTG93OworICAgICAgICAgICAg dGhpcy5fYXV0b1N0b3BDaGVja2JveE5hdmlnYXRpb25JdGVtLmFkZEV2ZW50TGlzdGVuZXIoV0ku Q2hlY2tib3hOYXZpZ2F0aW9uSXRlbS5FdmVudC5DaGVja2VkRGlkQ2hhbmdlLCB0aGlzLl9oYW5k bGVBdXRvU3RvcENoZWNrYm94Q2hlY2tlZERpZENoYW5nZSwgdGhpcyk7CiAKLSAgICAgICAgV0ku c2V0dGluZ3MudGltZWxpbmVzQXV0b1N0b3AuYWRkRXZlbnRMaXN0ZW5lcihXSS5TZXR0aW5nLkV2 ZW50LkNoYW5nZWQsIHRoaXMuX2hhbmRsZVRpbWVsaW5lc0F1dG9TdG9wU2V0dGluZ0NoYW5nZWQs IHRoaXMpOworICAgICAgICAgICAgV0kuc2V0dGluZ3MudGltZWxpbmVzQXV0b1N0b3AuYWRkRXZl bnRMaXN0ZW5lcihXSS5TZXR0aW5nLkV2ZW50LkNoYW5nZWQsIHRoaXMuX2hhbmRsZVRpbWVsaW5l c0F1dG9TdG9wU2V0dGluZ0NoYW5nZWQsIHRoaXMpOworICAgICAgICB9CiAKICAgICAgICAgdGhp cy5fY2xlYXJUaW1lbGluZU5hdmlnYXRpb25JdGVtID0gbmV3IFdJLkJ1dHRvbk5hdmlnYXRpb25J dGVtKCJjbGVhci10aW1lbGluZSIsIFdJLlVJU3RyaW5nKCJDbGVhciBUaW1lbGluZSAoJXMpIiku Zm9ybWF0KFdJLmNsZWFyS2V5Ym9hcmRTaG9ydGN1dC5kaXNwbGF5TmFtZSksICJJbWFnZXMvTmF2 aWdhdGlvbkl0ZW1UcmFzaC5zdmciLCAxNSwgMTUpOwogICAgICAgICB0aGlzLl9jbGVhclRpbWVs aW5lTmF2aWdhdGlvbkl0ZW0udmlzaWJpbGl0eVByaW9yaXR5ID0gV0kuTmF2aWdhdGlvbkl0ZW0u VmlzaWJpbGl0eVByaW9yaXR5LkxvdzsKQEAgLTE2MSwxMSArMTYzLDEyIEBAIFdJLlRpbWVsaW5l UmVjb3JkaW5nQ29udGVudFZpZXcgPSBjbGFzcyBUaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3 IGV4dGVuZHMgV0kuCiAKICAgICBnZXQgbmF2aWdhdGlvbkl0ZW1zKCkKICAgICB7Ci0gICAgICAg IHJldHVybiBbCi0gICAgICAgICAgICB0aGlzLl9hdXRvU3RvcENoZWNrYm94TmF2aWdhdGlvbkl0 ZW0sCi0gICAgICAgICAgICBuZXcgV0kuRGl2aWRlck5hdmlnYXRpb25JdGVtLAotICAgICAgICAg ICAgdGhpcy5fY2xlYXJUaW1lbGluZU5hdmlnYXRpb25JdGVtLAotICAgICAgICBdOworICAgICAg ICBsZXQgbmF2aWdhdGlvbkl0ZW1zID0gW107CisgICAgICAgIGlmICh0aGlzLl9hdXRvU3RvcENo ZWNrYm94TmF2aWdhdGlvbkl0ZW0pCisgICAgICAgICAgICBuYXZpZ2F0aW9uSXRlbXMucHVzaCh0 aGlzLl9hdXRvU3RvcENoZWNrYm94TmF2aWdhdGlvbkl0ZW0pOworICAgICAgICBuYXZpZ2F0aW9u SXRlbXMucHVzaChuZXcgV0kuRGl2aWRlck5hdmlnYXRpb25JdGVtKTsKKyAgICAgICAgbmF2aWdh dGlvbkl0ZW1zLnB1c2godGhpcy5fY2xlYXJUaW1lbGluZU5hdmlnYXRpb25JdGVtKTsKKyAgICAg ICAgcmV0dXJuIG5hdmlnYXRpb25JdGVtczsKICAgICB9CiAKICAgICBnZXQgaGFuZGxlQ29weUV2 ZW50KCkK