194953 2019-02-22 11:28:18 -0800 DFGBytecodeParser should not declare that a node won't clobberExit if DFGFixupPhase can later declare it does clobberExit 2019-02-22 16:05:18 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmorisset rmorisset commit-queue ews-watchlist keith_miller mark.lam msaboff saam oldest_to_newest 1509078 0 rmorisset 2019-02-22 11:28:18 -0800 Or we fairly naturally hit validation errors out of DFGFixupPhase.. There is already such a rule for GetByVal, but we must also be conservative for other nodes that: - (a) may or may not clobberExit depending on their arrayMode - (b) and get their arrayMode from profiling information in DFGBytecodeParser - (c) and can have their arrayMode refined by DFGFixupPhase. 1509085 1 rmorisset 2019-02-22 11:43:34 -0800 <rdar://problem/47595253> 1509090 2 362738 rmorisset 2019-02-22 11:52:33 -0800 Created attachment 362738 Patch 1509094 3 362738 saam 2019-02-22 12:00:54 -0800 Comment on attachment 362738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362738&action=review r=me > Source/JavaScriptCore/ChangeLog:14 > + Otherwise we are likely to hit validation failure after fixup. instead of "likely" I think you should describe precisely when/why this happens. > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:7216 > + m_exitOK = false; // PutByVal and PutByValDirect must be treated as if they clobber exit state, since FixupPhase may make them generic. This one isn't actually needed since PutByVal always clobbers exit unless it's in ForceOSR exit mode. And if it's in that mode, I don't think we can ever refine it to be wider? I'm ok with keeping this here conservatively, but this isn't the right comment to have. 1509106 4 rmorisset 2019-02-22 12:13:28 -0800 (In reply to Saam Barati from comment #3) > Comment on attachment 362738 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=362738&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:14 > > + Otherwise we are likely to hit validation failure after fixup. > > instead of "likely" I think you should describe precisely when/why this > happens. OK, I am replacing this line by the following: "Otherwise we will hit a validation failure after fixup if the next node was marked ExitValid and exits to the same semantic origin." > > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:7216 > > + m_exitOK = false; // PutByVal and PutByValDirect must be treated as if they clobber exit state, since FixupPhase may make them generic. > > This one isn't actually needed since PutByVal always clobbers exit unless > it's in ForceOSR exit mode. And if it's in that mode, I don't think we can > ever refine it to be wider? I'm ok with keeping this here conservatively, > but this isn't the right comment to have. I am not entirely sure whether or not we can refine it to be wider. Looking at ArrayMode::refine, it will be widened to Generic whenever "base && index && !isInt32Speculation(index)". I cannot tell if this is likely to ever happen or not, but it is not blatantly impossible. 1509152 5 362758 rmorisset 2019-02-22 13:29:09 -0800 Created attachment 362758 Patch Improved a sentence in the Changelog, per Saam's suggestion. 1509214 6 362758 commit-queue 2019-02-22 16:05:16 -0800 Comment on attachment 362758 Patch Clearing flags on attachment: 362758 Committed r241968: <https://trac.webkit.org/changeset/241968> 1509215 7 commit-queue 2019-02-22 16:05:18 -0800 All reviewed patches have been landed. Closing bug. 362738 2019-02-22 11:52:33 -0800 2019-02-22 13:29:09 -0800 Patch patch194953 text/plain 4490 rmorisset SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDE5NTUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTIyICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBh cHBsZS5jb20+CisKKyAgICAgICAgREZHQnl0ZWNvZGVQYXJzZXIgc2hvdWxkIG5vdCBkZWNsYXJl IHRoYXQgYSBub2RlIHdvbid0IGNsb2JiZXJFeGl0IGlmIERGR0ZpeHVwUGhhc2UgY2FuIGxhdGVy IGRlY2xhcmUgaXQgZG9lcyBjbG9iYmVyRXhpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0OTUzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzU5 NTI1Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ IGNvdWxkIG5vdCBtYWtlIHRoaXMgd29yayB3aXRob3V0IHRoZSBpbmZpbml0ZSBsb29wLCBzbyBJ IGFtIHVzaW5nIGEgd2F0Y2hkb2cgdG8gYmUgYWJsZSB0byB1c2UgaXQgYXMgYSByZWdyZXNzaW9u IHRlc3QuCisKKyAgICAgICAgKiBzdHJlc3MvaGFzLWluZGV4ZWQtcHJvcGVydHktd2l0aC13b3Jz ZW5pbmctYXJyYXktbW9kZS5qczogQWRkZWQuCisKIDIwMTktMDItMTkgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbXByb3Zl IEVTNiBDbGFzcyBpbnN0YW5jZXMgaW4gSGVhcCBTbmFwc2hvdCBpbnN0YW5jZXMgdmlldwpJbmRl eDogSlNUZXN0cy9zdHJlc3MvaGFzLWluZGV4ZWQtcHJvcGVydHktd2l0aC13b3JzZW5pbmctYXJy YXktbW9kZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9oYXMtaW5kZXhlZC1wcm9w ZXJ0eS13aXRoLXdvcnNlbmluZy1hcnJheS1tb2RlLmpzCShub25leGlzdGVudCkKKysrIEpTVGVz dHMvc3RyZXNzL2hhcy1pbmRleGVkLXByb3BlcnR5LXdpdGgtd29yc2VuaW5nLWFycmF5LW1vZGUu anMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw2IEBACisvL0AgcmVxdWlyZU9wdGlvbnMoIi0t d2F0Y2hkb2c9MTAwMCIsICItLXdhdGNoZG9nLWV4Y2VwdGlvbi1vayIsICItLXVzZU1heGltYWxG bHVzaEluc2VydGlvblBoYXNlPTEiKQorLy8gVGhpcyB0ZXN0IG9ubHkgc2VlbXMgdG8gcmVwcm9k dWNlIHRoZSBpc3N1ZSB3aGVuIGl0IHJ1bnMgaW4gYW4gaW5maW5pdGUgbG9vcC4gU28gd2UgdXNl IHRoZSB3YXRjaGRvZyB0byB0aW1lIGl0IG91dC4KK2ZvciAobGV0IHggaW4gWzBdKSB7CisgIGJy ZWFrCit9Cit3aGlsZSgxKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24g MjQxOTU1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDQwIEBACisyMDE5LTAyLTIyICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3Nl dEBhcHBsZS5jb20+CisKKyAgICAgICAgREZHQnl0ZWNvZGVQYXJzZXIgc2hvdWxkIG5vdCBkZWNs YXJlIHRoYXQgYSBub2RlIHdvbid0IGNsb2JiZXJFeGl0IGlmIERGR0ZpeHVwUGhhc2UgY2FuIGxh dGVyIGRlY2xhcmUgaXQgZG9lcyBjbG9iYmVyRXhpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0OTUzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80 NzU5NTI1Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGb3IgZWFjaCBub2RlIHRoYXQKKyAgICAgICAgKGEpIG1heSBvciBtYXkgbm90IGNsb2JiZXJF eGl0IGRlcGVuZGluZyBvbiB0aGVpciBhcnJheU1vZGUKKyAgICAgICAgKGIpIGFuZCBnZXQgdGhl aXIgYXJyYXlNb2RlIGZyb20gcHJvZmlsaW5nIGluZm9ybWF0aW9uIGluIERGR0J5dGVjb2RlUGFy c2VyCisgICAgICAgIChjKSBhbmQgY2FuIGhhdmUgdGhlaXIgYXJyYXlNb2RlIHJlZmluZWQgYnkg REZHRml4dXBQaGFzZSwKKyAgICAgICAgV2UgbXVzdCBtYWtlIHN1cmUgdG8gYmUgY29uc2VydmF0 aXZlIGluIHRoZSBERkdCeXRlY29kZVBhcnNlciBhbmQgdHJlYXQgaXQgYXMgaWYgaXQgdW5jb25k aXRpb25uYWxseSBjbG9iYmVyZWQgdGhlIGV4aXQuCisgICAgICAgIE90aGVyd2lzZSB3ZSBhcmUg bGlrZWx5IHRvIGhpdCB2YWxpZGF0aW9uIGZhaWx1cmUgYWZ0ZXIgZml4dXAuCisKKyAgICAgICAg VGhlIGxpc3Qgb2Ygbm9kZXMgdGhhdCBmaXQgKGEpIGlzOgorICAgICAgICAtIFN0cmluZ0NoYXJB dAorICAgICAgICAtIEhhc0luZGV4UHJvcGVydHkKKyAgICAgICAgLSBHZXRCeVZhbAorICAgICAg ICAtIFB1dEJ5VmFsRGlyZWN0CisgICAgICAgIC0gUHV0QnlWYWwKKyAgICAgICAgLSBQdXRCeVZh bEFsaWFzCisgICAgICAgIC0gR2V0SW5kZXhlZFByb3BlcnR5U3RvcmFnZQorCisgICAgICAgIE91 dCBvZiB0aGVzZSwgdGhlIGZvbGxvd2luZyBhbHNvIGZpdCAoYikgYW5kIChjKToKKyAgICAgICAg LSBIYXNJbmRleGVkUHJvcGVydHkKKyAgICAgICAgLSBHZXRCeVZhbAorICAgICAgICAtIFB1dEJ5 VmFsRGlyZWN0CisgICAgICAgIC0gUHV0QnlWYWwKKworICAgICAgICBHZXRCeVZhbCBhbHJlYWR5 IGhhZCAibV9leGl0T0sgPSBmYWxzZTsgLy8gR2V0QnlWYWwgbXVzdCBiZSB0cmVhdGVkIGFzIGlm IGl0IGNsb2JiZXJzIGV4aXQgc3RhdGUsIHNpbmNlIEZpeHVwUGhhc2UgbWF5IG1ha2UgaXQgZ2Vu ZXJpYy4iCisgICAgICAgIFNvIHdlIGp1c3QgaGF2ZSB0byBmaXggdGhlIG90aGVyIHRocmVlIHRo ZSBzYW1lIHdheS4KKworICAgICAgICAqIGRmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHA6CisgICAg ICAgIChKU0M6OkRGRzo6Qnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2spOgorICAgICAgICAoSlND OjpERkc6OkJ5dGVDb2RlUGFyc2VyOjpoYW5kbGVQdXRCeVZhbCk6CisKIDIwMTktMDItMjIgIFl1 c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBi dWlsZCBmaXggYWZ0ZXIgcjI0MTk1NApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdCeXRlQ29kZVBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAJKHJldmlzaW9uIDI0MTk1NSkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC02ODM0LDYgKzY4MzQsNyBAQAogICAgICAgICAgICAgYWRkVmFyQXJnQ2hpbGQocHJvcGVydHkp OwogICAgICAgICAgICAgYWRkVmFyQXJnQ2hpbGQobnVsbHB0cik7CiAgICAgICAgICAgICBOb2Rl KiBoYXNJdGVyYWJsZVByb3BlcnR5ID0gYWRkVG9HcmFwaChOb2RlOjpWYXJBcmcsIEhhc0luZGV4 ZWRQcm9wZXJ0eSwgT3BJbmZvKGFycmF5TW9kZS5hc1dvcmQoKSksIE9wSW5mbyhzdGF0aWNfY2Fz dDx1aW50MzJfdD4oUHJvcGVydHlTbG90OjpJbnRlcm5hbE1ldGhvZFR5cGU6OkdldE93blByb3Bl cnR5KSkpOworICAgICAgICAgICAgbV9leGl0T0sgPSBmYWxzZTsgLy8gSGFzSW5kZXhlZFByb3Bl cnR5IG11c3QgYmUgdHJlYXRlZCBhcyBpZiBpdCBjbG9iYmVycyBleGl0IHN0YXRlLCBzaW5jZSBG aXh1cFBoYXNlIG1heSBtYWtlIGl0IGdlbmVyaWMuCiAgICAgICAgICAgICBzZXQoYnl0ZWNvZGUu bV9kc3QsIGhhc0l0ZXJhYmxlUHJvcGVydHkpOwogICAgICAgICAgICAgTkVYVF9PUENPREUob3Bf aGFzX2luZGV4ZWRfcHJvcGVydHkpOwogICAgICAgICB9CkBAIC03MjEyLDYgKzcyMTMsNyBAQAog ICAgICAgICBhZGRWYXJBcmdDaGlsZCgwKTsgLy8gTGVhdmUgcm9vbSBmb3IgcHJvcGVydHkgc3Rv cmFnZS4KICAgICAgICAgYWRkVmFyQXJnQ2hpbGQoMCk7IC8vIExlYXZlIHJvb20gZm9yIGxlbmd0 aC4KICAgICAgICAgYWRkVG9HcmFwaChOb2RlOjpWYXJBcmcsIGlzRGlyZWN0ID8gUHV0QnlWYWxE aXJlY3QgOiBQdXRCeVZhbCwgT3BJbmZvKGFycmF5TW9kZS5hc1dvcmQoKSksIE9wSW5mbygwKSk7 CisgICAgICAgIG1fZXhpdE9LID0gZmFsc2U7IC8vIFB1dEJ5VmFsIGFuZCBQdXRCeVZhbERpcmVj dCBtdXN0IGJlIHRyZWF0ZWQgYXMgaWYgdGhleSBjbG9iYmVyIGV4aXQgc3RhdGUsIHNpbmNlIEZp eHVwUGhhc2UgbWF5IG1ha2UgdGhlbSBnZW5lcmljLgogICAgIH0KIH0KIAo= 362758 2019-02-22 13:29:09 -0800 2019-02-22 16:05:16 -0800 Patch patch194953 text/plain 4553 rmorisset SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDE5NTUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTIyICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBh cHBsZS5jb20+CisKKyAgICAgICAgREZHQnl0ZWNvZGVQYXJzZXIgc2hvdWxkIG5vdCBkZWNsYXJl IHRoYXQgYSBub2RlIHdvbid0IGNsb2JiZXJFeGl0IGlmIERGR0ZpeHVwUGhhc2UgY2FuIGxhdGVy IGRlY2xhcmUgaXQgZG9lcyBjbG9iYmVyRXhpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0OTUzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzU5 NTI1Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBTYWFtIEJhcmF0aS4KKworICAgICAgICBJIGNv dWxkIG5vdCBtYWtlIHRoaXMgd29yayB3aXRob3V0IHRoZSBpbmZpbml0ZSBsb29wLCBzbyBJIGFt IHVzaW5nIGEgd2F0Y2hkb2cgdG8gYmUgYWJsZSB0byB1c2UgaXQgYXMgYSByZWdyZXNzaW9uIHRl c3QuCisKKyAgICAgICAgKiBzdHJlc3MvaGFzLWluZGV4ZWQtcHJvcGVydHktd2l0aC13b3JzZW5p bmctYXJyYXktbW9kZS5qczogQWRkZWQuCisKIDIwMTktMDItMTkgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbXByb3ZlIEVT NiBDbGFzcyBpbnN0YW5jZXMgaW4gSGVhcCBTbmFwc2hvdCBpbnN0YW5jZXMgdmlldwpJbmRleDog SlNUZXN0cy9zdHJlc3MvaGFzLWluZGV4ZWQtcHJvcGVydHktd2l0aC13b3JzZW5pbmctYXJyYXkt bW9kZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9oYXMtaW5kZXhlZC1wcm9wZXJ0 eS13aXRoLXdvcnNlbmluZy1hcnJheS1tb2RlLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMv c3RyZXNzL2hhcy1pbmRleGVkLXByb3BlcnR5LXdpdGgtd29yc2VuaW5nLWFycmF5LW1vZGUuanMJ KHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw2IEBACisvL0AgcmVxdWlyZU9wdGlvbnMoIi0td2F0 Y2hkb2c9MTAwMCIsICItLXdhdGNoZG9nLWV4Y2VwdGlvbi1vayIsICItLXVzZU1heGltYWxGbHVz aEluc2VydGlvblBoYXNlPTEiKQorLy8gVGhpcyB0ZXN0IG9ubHkgc2VlbXMgdG8gcmVwcm9kdWNl IHRoZSBpc3N1ZSB3aGVuIGl0IHJ1bnMgaW4gYW4gaW5maW5pdGUgbG9vcC4gU28gd2UgdXNlIHRo ZSB3YXRjaGRvZyB0byB0aW1lIGl0IG91dC4KK2ZvciAobGV0IHggaW4gWzBdKSB7CisgIGJyZWFr Cit9Cit3aGlsZSgxKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQx OTU1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDQwIEBACisyMDE5LTAyLTIyICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBh cHBsZS5jb20+CisKKyAgICAgICAgREZHQnl0ZWNvZGVQYXJzZXIgc2hvdWxkIG5vdCBkZWNsYXJl IHRoYXQgYSBub2RlIHdvbid0IGNsb2JiZXJFeGl0IGlmIERGR0ZpeHVwUGhhc2UgY2FuIGxhdGVy IGRlY2xhcmUgaXQgZG9lcyBjbG9iYmVyRXhpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0OTUzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzU5 NTI1Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBTYWFtIEJhcmF0aS4KKworICAgICAgICBGb3Ig ZWFjaCBub2RlIHRoYXQKKyAgICAgICAgKGEpIG1heSBvciBtYXkgbm90IGNsb2JiZXJFeGl0IGRl cGVuZGluZyBvbiB0aGVpciBhcnJheU1vZGUKKyAgICAgICAgKGIpIGFuZCBnZXQgdGhlaXIgYXJy YXlNb2RlIGZyb20gcHJvZmlsaW5nIGluZm9ybWF0aW9uIGluIERGR0J5dGVjb2RlUGFyc2VyCisg ICAgICAgIChjKSBhbmQgY2FuIGhhdmUgdGhlaXIgYXJyYXlNb2RlIHJlZmluZWQgYnkgREZHRml4 dXBQaGFzZSwKKyAgICAgICAgV2UgbXVzdCBtYWtlIHN1cmUgdG8gYmUgY29uc2VydmF0aXZlIGlu IHRoZSBERkdCeXRlY29kZVBhcnNlciBhbmQgdHJlYXQgaXQgYXMgaWYgaXQgdW5jb25kaXRpb25u YWxseSBjbG9iYmVyZWQgdGhlIGV4aXQuCisgICAgICAgIE90aGVyd2lzZSB3ZSB3aWxsIGhpdCBh IHZhbGlkYXRpb24gZmFpbHVyZSBhZnRlciBmaXh1cCBpZiB0aGUgbmV4dCBub2RlIHdhcyBtYXJr ZWQgRXhpdFZhbGlkIGFuZCBleGl0cyB0byB0aGUgc2FtZSBzZW1hbnRpYyBvcmlnaW4uCisKKyAg ICAgICAgVGhlIGxpc3Qgb2Ygbm9kZXMgdGhhdCBmaXQgKGEpIGlzOgorICAgICAgICAtIFN0cmlu Z0NoYXJBdAorICAgICAgICAtIEhhc0luZGV4UHJvcGVydHkKKyAgICAgICAgLSBHZXRCeVZhbAor ICAgICAgICAtIFB1dEJ5VmFsRGlyZWN0CisgICAgICAgIC0gUHV0QnlWYWwKKyAgICAgICAgLSBQ dXRCeVZhbEFsaWFzCisgICAgICAgIC0gR2V0SW5kZXhlZFByb3BlcnR5U3RvcmFnZQorCisgICAg ICAgIE91dCBvZiB0aGVzZSwgdGhlIGZvbGxvd2luZyBhbHNvIGZpdCAoYikgYW5kIChjKToKKyAg ICAgICAgLSBIYXNJbmRleGVkUHJvcGVydHkKKyAgICAgICAgLSBHZXRCeVZhbAorICAgICAgICAt IFB1dEJ5VmFsRGlyZWN0CisgICAgICAgIC0gUHV0QnlWYWwKKworICAgICAgICBHZXRCeVZhbCBh bHJlYWR5IGhhZCAibV9leGl0T0sgPSBmYWxzZTsgLy8gR2V0QnlWYWwgbXVzdCBiZSB0cmVhdGVk IGFzIGlmIGl0IGNsb2JiZXJzIGV4aXQgc3RhdGUsIHNpbmNlIEZpeHVwUGhhc2UgbWF5IG1ha2Ug aXQgZ2VuZXJpYy4iCisgICAgICAgIFNvIHdlIGp1c3QgaGF2ZSB0byBmaXggdGhlIG90aGVyIHRo cmVlIHRoZSBzYW1lIHdheS4KKworICAgICAgICAqIGRmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHA6 CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2spOgorICAgICAg ICAoSlNDOjpERkc6OkJ5dGVDb2RlUGFyc2VyOjpoYW5kbGVQdXRCeVZhbCk6CisKIDIwMTktMDIt MjIgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCBidWlsZCBmaXggYWZ0ZXIgcjI0MTk1NApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAJKHJldmlzaW9uIDI0MTk1NSkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC02ODM0LDYgKzY4MzQsNyBAQAogICAgICAgICAgICAgYWRkVmFyQXJnQ2hpbGQocHJv cGVydHkpOwogICAgICAgICAgICAgYWRkVmFyQXJnQ2hpbGQobnVsbHB0cik7CiAgICAgICAgICAg ICBOb2RlKiBoYXNJdGVyYWJsZVByb3BlcnR5ID0gYWRkVG9HcmFwaChOb2RlOjpWYXJBcmcsIEhh c0luZGV4ZWRQcm9wZXJ0eSwgT3BJbmZvKGFycmF5TW9kZS5hc1dvcmQoKSksIE9wSW5mbyhzdGF0 aWNfY2FzdDx1aW50MzJfdD4oUHJvcGVydHlTbG90OjpJbnRlcm5hbE1ldGhvZFR5cGU6OkdldE93 blByb3BlcnR5KSkpOworICAgICAgICAgICAgbV9leGl0T0sgPSBmYWxzZTsgLy8gSGFzSW5kZXhl ZFByb3BlcnR5IG11c3QgYmUgdHJlYXRlZCBhcyBpZiBpdCBjbG9iYmVycyBleGl0IHN0YXRlLCBz aW5jZSBGaXh1cFBoYXNlIG1heSBtYWtlIGl0IGdlbmVyaWMuCiAgICAgICAgICAgICBzZXQoYnl0 ZWNvZGUubV9kc3QsIGhhc0l0ZXJhYmxlUHJvcGVydHkpOwogICAgICAgICAgICAgTkVYVF9PUENP REUob3BfaGFzX2luZGV4ZWRfcHJvcGVydHkpOwogICAgICAgICB9CkBAIC03MjEyLDYgKzcyMTMs NyBAQAogICAgICAgICBhZGRWYXJBcmdDaGlsZCgwKTsgLy8gTGVhdmUgcm9vbSBmb3IgcHJvcGVy dHkgc3RvcmFnZS4KICAgICAgICAgYWRkVmFyQXJnQ2hpbGQoMCk7IC8vIExlYXZlIHJvb20gZm9y IGxlbmd0aC4KICAgICAgICAgYWRkVG9HcmFwaChOb2RlOjpWYXJBcmcsIGlzRGlyZWN0ID8gUHV0 QnlWYWxEaXJlY3QgOiBQdXRCeVZhbCwgT3BJbmZvKGFycmF5TW9kZS5hc1dvcmQoKSksIE9wSW5m bygwKSk7CisgICAgICAgIG1fZXhpdE9LID0gZmFsc2U7IC8vIFB1dEJ5VmFsIGFuZCBQdXRCeVZh bERpcmVjdCBtdXN0IGJlIHRyZWF0ZWQgYXMgaWYgdGhleSBjbG9iYmVyIGV4aXQgc3RhdGUsIHNp bmNlIEZpeHVwUGhhc2UgbWF5IG1ha2UgdGhlbSBnZW5lcmljLgogICAgIH0KIH0KIAo=