194950 2019-02-22 10:33:21 -0800 Web Inspector: Canvas: if no auto-capture value is specified, don't force the input to have "0" as the value 2019-02-26 00:11:44 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 175485 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1509039 0 hi 2019-02-22 10:33:21 -0800 # STEPS TO REPRODUCE 1. inspect any page 2. go to the Canvas tab 3. delete the existing text from the "[ ] Record <input> frame(s)" input => the <input> automatically sets the content to "0" if there is no other content (e.g. empty) When typing after this, there's now a leading "0" (e.g. "01"). 1509040 1 hi 2019-02-22 10:33:32 -0800 <rdar://problem/48276798> 1509047 2 362730 hi 2019-02-22 10:42:59 -0800 Created attachment 362730 Patch 1509967 3 362730 joepeck 2019-02-25 23:30:11 -0800 Comment on attachment 362730 Patch rs=me, Seems a little messy to use a private getter/setter here instead of just methods. 1509973 4 362730 hi 2019-02-25 23:45:42 -0800 Comment on attachment 362730 Patch (In reply to Joseph Pecoraro from comment #3) > rs=me, Seems a little messy to use a private getter/setter here instead of just methods. I intentionally named the getter/setter so that it would be almost the same as if we used the <input> directly (`_recordingAutoCaptureFrameCountInputElementValue` vs `_recordingAutoCaptureFrameCountInputElement.value`). 1509980 5 362730 commit-queue 2019-02-26 00:11:43 -0800 Comment on attachment 362730 Patch Clearing flags on attachment: 362730 Committed r242079: <https://trac.webkit.org/changeset/242079> 1509981 6 commit-queue 2019-02-26 00:11:44 -0800 All reviewed patches have been landed. Closing bug. 362730 2019-02-22 10:42:59 -0800 2019-02-26 00:11:43 -0800 Patch bug-194950-20190222104259.patch text/plain 6767 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZjZTdhM2U4NmI5NDMxNzAzNzUyNzE4OTc3MDc0 MmE0Mzk2OTg4ODEuLjFjZjA0YzczMjkzNDUyZWEyYWIwMjE3MjFiMGNkOTVhMWRjNGNiMzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE5LTAyLTIyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD YW52YXM6IGlmIG5vIGF1dG8tY2FwdHVyZSB2YWx1ZSBpcyBzcGVjaWZpZWQsIGRvbid0IGZvcmNl IHRoZSBpbnB1dCB0byBoYXZlICIwIiBhcyB0aGUgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDk1MAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNDgyNzY3OTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ3JlYXRlIGEgZ2V0dGVyL3NldHRlciBmb3IgdGhlIHZhbHVlIG9mIHRoZSBhdXRvLWNh cHR1cmUgZnJhbWUgY291bnQgPGlucHV0PiBzbyB0aGF0IGFsbAorICAgICAgICBjb2RlIGZvbGxv d3MgdGhlIHNhbWUgcGF0aC4KKworICAgICAgICBJZiB0aGUgPGlucHV0PiBjdXJyZW50bHkgaGFz IG5vIGNvbnRlbnQgYW5kIHRoZSBmcmFtZSBjb3VudCBpcyAwLCBvbmx5IHNldCB0aGUgcGxhY2Vo b2xkZXIuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc092ZXJ2aWV3Q29u dGVudFZpZXcuanM6CisgICAgICAgIChXSS5DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3KToKKyAg ICAgICAgKFdJLkNhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcucHJvdG90eXBlLl9zZXRSZWNvcmRp bmdBdXRvQ2FwdHVyZUZyYW1lQ291bnQpOgorICAgICAgICAoV0kuQ2FudmFzT3ZlcnZpZXdDb250 ZW50Vmlldy5wcm90b3R5cGUuX3VwZGF0ZVJlY29yZGluZ0F1dG9DYXB0dXJlQ2hlY2tib3hMYWJl bCk6CisgICAgICAgIChXSS5DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3LnByb3RvdHlwZS5nZXQg X3JlY29yZGluZ0F1dG9DYXB0dXJlRnJhbWVDb3VudElucHV0RWxlbWVudFZhbHVlKTogQWRkZWQu CisgICAgICAgIChXSS5DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3LnByb3RvdHlwZS5zZXQgX3Jl Y29yZGluZ0F1dG9DYXB0dXJlRnJhbWVDb3VudElucHV0RWxlbWVudFZhbHVlKTogQWRkZWQuCisg ICAgICAgIChXSS5DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3LnByb3RvdHlwZS5fdXBkYXRlUmVj b3JkaW5nQXV0b0NhcHR1cmVJbnB1dEVsZW1lbnRTaXplKToKKyAgICAgICAgKFdJLkNhbnZhc092 ZXJ2aWV3Q29udGVudFZpZXcucHJvdG90eXBlLl9oYW5kbGVDYW52YXNSZWNvcmRpbmdBdXRvQ2Fw dHVyZUZyYW1lQ291bnRDaGFuZ2VkKToKKwogMjAxOS0wMi0yMSAgRGV2aW4gUm91c3NvICA8ZHJv dXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FudmFzOiByZWNvcmRp bmdzIHdpdGggYSBzaW5nbGUgZnJhbWUgc29tZXRpbWVzIG1pc3NpbmcgVHJlZUVsZW1lbnQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZh c092ZXJ2aWV3Q29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3LmpzCmluZGV4IDk0MmI0NGYyZjcx NTJhZjY4M2IyMGI1MDQ0N2MxOGUwM2ZhODI5NTguLjI0MmZkMTM3YjQzNWE3NWE1MTE2NDBiMmJh ZDdiNGYzZjM1NWE1OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0NhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzT3ZlcnZpZXdDb250ZW50Vmll dy5qcwpAQCAtNDgsOCArNDgsOCBAQCBXSS5DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3ID0gY2xh c3MgQ2FudmFzT3ZlcnZpZXdDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbGxlYwogICAgICAgICAg ICAgdGhpcy5fcmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50SW5wdXRFbGVtZW50ID0gZG9j dW1lbnQuY3JlYXRlRWxlbWVudCgiaW5wdXQiKTsKICAgICAgICAgICAgIHRoaXMuX3JlY29yZGlu Z0F1dG9DYXB0dXJlRnJhbWVDb3VudElucHV0RWxlbWVudC50eXBlID0gIm51bWJlciI7CiAgICAg ICAgICAgICB0aGlzLl9yZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnRJbnB1dEVsZW1lbnQu bWluID0gMDsKLSAgICAgICAgICAgIHRoaXMuX3JlY29yZGluZ0F1dG9DYXB0dXJlRnJhbWVDb3Vu dElucHV0RWxlbWVudC52YWx1ZSA9IFdJLnNldHRpbmdzLmNhbnZhc1JlY29yZGluZ0F1dG9DYXB0 dXJlRnJhbWVDb3VudC52YWx1ZTsKICAgICAgICAgICAgIHRoaXMuX3JlY29yZGluZ0F1dG9DYXB0 dXJlRnJhbWVDb3VudElucHV0RWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJpbnB1dCIsIHRoaXMu X2hhbmRsZVJlY29yZGluZ0F1dG9DYXB0dXJlSW5wdXQuYmluZCh0aGlzKSk7CisgICAgICAgICAg ICB0aGlzLl9yZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnRJbnB1dEVsZW1lbnRWYWx1ZSA9 IFdJLnNldHRpbmdzLmNhbnZhc1JlY29yZGluZ0F1dG9DYXB0dXJlRnJhbWVDb3VudC52YWx1ZTsK IAogICAgICAgICAgICAgY29uc3QgbGFiZWwgPSBudWxsOwogICAgICAgICAgICAgdGhpcy5fcmVj b3JkaW5nQXV0b0NhcHR1cmVOYXZpZ2F0aW9uSXRlbSA9IG5ldyBXSS5DaGVja2JveE5hdmlnYXRp b25JdGVtKCJjYW52YXMtcmVjb3JkaW5nLWF1dG8tY2FwdHVyZSIsIGxhYmVsLCAhIVdJLnNldHRp bmdzLmNhbnZhc1JlY29yZGluZ0F1dG9DYXB0dXJlRW5hYmxlZC52YWx1ZSk7CkBAIC0xOTAsNyAr MTkwLDcgQEAgV0kuQ2FudmFzT3ZlcnZpZXdDb250ZW50VmlldyA9IGNsYXNzIENhbnZhc092ZXJ2 aWV3Q29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db2xsZWMKICAgICBfc2V0UmVjb3JkaW5nQXV0b0Nh cHR1cmVGcmFtZUNvdW50KGZyYW1lQ291bnQpCiAgICAgewogICAgICAgICBpZiAoaXNOYU4oZnJh bWVDb3VudCkpCi0gICAgICAgICAgICBmcmFtZUNvdW50ID0gcGFyc2VJbnQodGhpcy5fcmVjb3Jk aW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50SW5wdXRFbGVtZW50LnZhbHVlKTsKKyAgICAgICAgICAg IGZyYW1lQ291bnQgPSB0aGlzLl9yZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnRJbnB1dEVs ZW1lbnRWYWx1ZTsKIAogICAgICAgICBjb25zb2xlLmFzc2VydCghaXNOYU4oZnJhbWVDb3VudCkg JiYgZnJhbWVDb3VudCA+PSAwKTsKIApAQCAtMjA1LDcgKzIwNSw3IEBAIFdJLkNhbnZhc092ZXJ2 aWV3Q29udGVudFZpZXcgPSBjbGFzcyBDYW52YXNPdmVydmlld0NvbnRlbnRWaWV3IGV4dGVuZHMg V0kuQ29sbGVjCiAgICAgX3VwZGF0ZVJlY29yZGluZ0F1dG9DYXB0dXJlQ2hlY2tib3hMYWJlbChm cmFtZUNvdW50KQogICAgIHsKICAgICAgICAgaWYgKGlzTmFOKGZyYW1lQ291bnQpKQotICAgICAg ICAgICAgZnJhbWVDb3VudCA9IHBhcnNlSW50KHRoaXMuX3JlY29yZGluZ0F1dG9DYXB0dXJlRnJh bWVDb3VudElucHV0RWxlbWVudC52YWx1ZSk7CisgICAgICAgICAgICBmcmFtZUNvdW50ID0gdGhp cy5fcmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50SW5wdXRFbGVtZW50VmFsdWU7CiAKICAg ICAgICAgbGV0IGxhYmVsID0gZnJhbWVDb3VudCA9PT0gMSA/IFdJLlVJU3RyaW5nKCJSZWNvcmQg Zmlyc3QgJXMgZnJhbWUiKSA6IFdJLlVJU3RyaW5nKCJSZWNvcmQgZmlyc3QgJXMgZnJhbWVzIik7 CiAKQEAgLTIyOSwxMiArMjI5LDI1IEBAIFdJLkNhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcgPSBj bGFzcyBDYW52YXNPdmVydmlld0NvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29sbGVjCiAgICAgICAg IH0KICAgICB9CiAKKyAgICBnZXQgX3JlY29yZGluZ0F1dG9DYXB0dXJlRnJhbWVDb3VudElucHV0 RWxlbWVudFZhbHVlKCkKKyAgICB7CisgICAgICAgIHJldHVybiBwYXJzZUludCh0aGlzLl9yZWNv cmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnRJbnB1dEVsZW1lbnQudmFsdWUpOworICAgIH0KKwor ICAgIHNldCBfcmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50SW5wdXRFbGVtZW50VmFsdWUo ZnJhbWVDb3VudCkKKyAgICB7CisgICAgICAgIGlmICh0aGlzLl9yZWNvcmRpbmdBdXRvQ2FwdHVy ZUZyYW1lQ291bnRJbnB1dEVsZW1lbnQudmFsdWUgfHwgZnJhbWVDb3VudCkKKyAgICAgICAgICAg IHRoaXMuX3JlY29yZGluZ0F1dG9DYXB0dXJlRnJhbWVDb3VudElucHV0RWxlbWVudC52YWx1ZSA9 IGZyYW1lQ291bnQ7CisKKyAgICAgICAgdGhpcy5fcmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNv dW50SW5wdXRFbGVtZW50LnBsYWNlaG9sZGVyID0gZnJhbWVDb3VudDsKKyAgICB9CisKICAgICBf dXBkYXRlUmVjb3JkaW5nQXV0b0NhcHR1cmVJbnB1dEVsZW1lbnRTaXplKCkKICAgICB7Ci0gICAg ICAgIGxldCBmcmFtZUNvdW50ID0gcGFyc2VJbnQodGhpcy5fcmVjb3JkaW5nQXV0b0NhcHR1cmVG cmFtZUNvdW50SW5wdXRFbGVtZW50LnZhbHVlKTsKKyAgICAgICAgbGV0IGZyYW1lQ291bnQgPSB0 aGlzLl9yZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnRJbnB1dEVsZW1lbnRWYWx1ZTsKICAg ICAgICAgaWYgKGlzTmFOKGZyYW1lQ291bnQpIHx8IGZyYW1lQ291bnQgPCAwKSB7CiAgICAgICAg ICAgICBmcmFtZUNvdW50ID0gMDsKLSAgICAgICAgICAgIHRoaXMuX3JlY29yZGluZ0F1dG9DYXB0 dXJlRnJhbWVDb3VudElucHV0RWxlbWVudC52YWx1ZSA9IGZyYW1lQ291bnQ7CisgICAgICAgICAg ICB0aGlzLl9yZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnRJbnB1dEVsZW1lbnRWYWx1ZSA9 IGZyYW1lQ291bnQ7CiAgICAgICAgIH0KIAogICAgICAgICBXSS5JbWFnZVV0aWxpdGllcy5zY3Jh dGNoQ2FudmFzQ29udGV4dDJEKChjb250ZXh0KSA9PiB7CkBAIC0yNDYsNyArMjU5LDcgQEAgV0ku Q2FudmFzT3ZlcnZpZXdDb250ZW50VmlldyA9IGNsYXNzIENhbnZhc092ZXJ2aWV3Q29udGVudFZp ZXcgZXh0ZW5kcyBXSS5Db2xsZWMKICAgICAgICAgICAgIGNvbnN0IHJlY29yZGluZ0F1dG9DYXB0 dXJlSW5wdXRNYXJnaW4gPSA4OyAvLyBLZWVwIHRoaXMgaW4gc3luYyB3aXRoIGAtLXJlY29yZGlu Zy1hdXRvLWNhcHR1cmUtaW5wdXQtbWFyZ2luYC4KIAogICAgICAgICAgICAgY29udGV4dC5mb250 ID0gdGhpcy5fcmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50SW5wdXRFbGVtZW50Ll9fY2Fj aGVkRm9udDsKLSAgICAgICAgICAgIGxldCB0ZXh0TWV0cmljcyA9IGNvbnRleHQubWVhc3VyZVRl eHQodGhpcy5fcmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50SW5wdXRFbGVtZW50LnZhbHVl KTsKKyAgICAgICAgICAgIGxldCB0ZXh0TWV0cmljcyA9IGNvbnRleHQubWVhc3VyZVRleHQodGhp cy5fcmVjb3JkaW5nQXV0b0NhcHR1cmVGcmFtZUNvdW50SW5wdXRFbGVtZW50LnZhbHVlIHx8IHRo aXMuX3JlY29yZGluZ0F1dG9DYXB0dXJlRnJhbWVDb3VudElucHV0RWxlbWVudC5wbGFjZWhvbGRl cik7CiAgICAgICAgICAgICB0aGlzLl9yZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnRJbnB1 dEVsZW1lbnQuc3R5bGUuc2V0UHJvcGVydHkoIndpZHRoIiwgKHRleHRNZXRyaWNzLndpZHRoICsg cmVjb3JkaW5nQXV0b0NhcHR1cmVJbnB1dE1hcmdpbikgKyAicHgiKTsKICAgICAgICAgfSk7CiAK QEAgLTI3NCw4ICsyODcsOCBAQCBXSS5DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3ID0gY2xhc3Mg Q2FudmFzT3ZlcnZpZXdDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbGxlYwogICAgIF9oYW5kbGVD YW52YXNSZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnRDaGFuZ2VkKGV2ZW50KQogICAgIHsK ICAgICAgICAgLy8gT25seSB1cGRhdGUgdGhlIHZhbHVlIGlmIGl0IGlzIGRpZmZlcmVudCB0byBw cmV2ZW50IG1hbmdsaW5nIHRoZSBzZWxlY3Rpb24uCi0gICAgICAgIGlmIChwYXJzZUludCh0aGlz Ll9yZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnRJbnB1dEVsZW1lbnQudmFsdWUpICE9PSBX SS5zZXR0aW5ncy5jYW52YXNSZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnQudmFsdWUpCi0g ICAgICAgICAgICB0aGlzLl9yZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnRJbnB1dEVsZW1l bnQudmFsdWUgPSBXSS5zZXR0aW5ncy5jYW52YXNSZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291 bnQudmFsdWU7CisgICAgICAgIGlmICh0aGlzLl9yZWNvcmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291 bnRJbnB1dEVsZW1lbnRWYWx1ZSAhPT0gV0kuc2V0dGluZ3MuY2FudmFzUmVjb3JkaW5nQXV0b0Nh cHR1cmVGcmFtZUNvdW50LnZhbHVlKQorICAgICAgICAgICAgdGhpcy5fcmVjb3JkaW5nQXV0b0Nh cHR1cmVGcmFtZUNvdW50SW5wdXRFbGVtZW50VmFsdWUgPSBXSS5zZXR0aW5ncy5jYW52YXNSZWNv cmRpbmdBdXRvQ2FwdHVyZUZyYW1lQ291bnQudmFsdWU7CiAKICAgICAgICAgdGhpcy5fdXBkYXRl UmVjb3JkaW5nQXV0b0NhcHR1cmVDaGVja2JveExhYmVsKFdJLnNldHRpbmdzLmNhbnZhc1JlY29y ZGluZ0F1dG9DYXB0dXJlRnJhbWVDb3VudC52YWx1ZSk7CiAgICAgfQo=