194943 2019-02-22 05:30:10 -0800 [GTK] Navigation gesture improvements 2019-02-22 10:46:32 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alicem webkit-unassigned bugs-noreply commit-queue mcatanzaro oldest_to_newest 1508976 0 alicem 2019-02-22 05:30:10 -0800 Address some feedback for bug 193919. 1508977 1 362717 alicem 2019-02-22 05:31:38 -0800 Created attachment 362717 Patch 1509051 2 362717 commit-queue 2019-02-22 10:46:30 -0800 Comment on attachment 362717 Patch Clearing flags on attachment: 362717 Committed r241952: <https://trac.webkit.org/changeset/241952> 1509052 3 commit-queue 2019-02-22 10:46:32 -0800 All reviewed patches have been landed. Closing bug. 362717 2019-02-22 05:31:38 -0800 2019-02-22 10:46:30 -0800 Patch bug-194943-20190222183136.patch text/plain 7050 alicem U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxOTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI4NmQwNTVjMzlkOGVkYTZi MzQyNzAwMzYyNmY5NWQ5MDIxYmEzMmQuLmYwYTM0ODM0MmFkMWQwZmNiNmQ3NGY0ZDViZjA1Nzgx YTk4NWQ5ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTktMDItMjIgIEFsZXhhbmRl ciBNaWtoYXlsZW5rbyAgPGV4YWxtNzY1OUBnbWFpbC5jb20+CisKKyAgICAgICAgW0dUS10gTmF2 aWdhdGlvbiBnZXN0dXJlIGltcHJvdmVtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0OTQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2FuY2VsIHRoZSBnZXN0dXJlIGlmIHByb2dyZXNzIGlzIGxl c3MgdGhhbiAwLjUgYW5kIHZlbG9jaXR5IGlzIG5vdCBoaWdoIGVub3VnaC4KKworICAgICAgICBB bGxvdyB0byBjb250aW51ZSB0aGUgZ2VzdHVyZSBkdXJpbmcgYW5pbWF0aW9uLiBJbnRyb2R1Y2Ug ZmluaXNoZWQgc3RhdGUgdG8gYmUgdXNlZAorICAgICAgICB3aGVuIHNob3dpbmcgc25hcHNob3Qg YWZ0ZXIgdGhlIGFuaW1hdGlvbiBlbmRzLgorCisgICAgICAgIEZpeCBkdXJhdGlvbiBjYWxjdWxh dGlvbiwgYWxzbyBzbG93IGl0IGRvd24gc28gdGhhdCB0aGUgaW5pdGlhbCB2ZWxvY2l0eSBtYXRj aGVzCisgICAgICAgIHdoYXQgaXQgd2FzIGR1cmluZyB0aGUgZ2VzdHVyZS4KKworICAgICAgICAq IFVJUHJvY2Vzcy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIuaDogQWRkIHNob3VsZENhbmNlbCgpIGFu ZCBTdGF0ZTo6RmluaXNoaW5nIHRvIFN3aXBlUHJvZ3Jlc3NUcmFja2VyLgorICAgICAgICAqIFVJ UHJvY2Vzcy9ndGsvVmlld0dlc3R1cmVDb250cm9sbGVyR3RrLmNwcDoKKyAgICAgICAgKFdlYktp dDo6Vmlld0dlc3R1cmVDb250cm9sbGVyOjpTd2lwZVByb2dyZXNzVHJhY2tlcjo6aGFuZGxlRXZl bnQpOgorICAgICAgICBGaXggdmVsb2NpdHkgY2FsY3VsYXRpb24sIGFsbG93IHNjcm9sbGluZyBk dXJpbmcgU3RhdGU6OkFuaW1hdGluZy4KKyAgICAgICAgKFdlYktpdDo6Vmlld0dlc3R1cmVDb250 cm9sbGVyOjpTd2lwZVByb2dyZXNzVHJhY2tlcjo6c2hvdWxkQ2FuY2VsKTogQWRkZWQuCisgICAg ICAgIChXZWJLaXQ6OlZpZXdHZXN0dXJlQ29udHJvbGxlcjo6U3dpcGVQcm9ncmVzc1RyYWNrZXI6 OnN0YXJ0QW5pbWF0aW9uKTogVXNlIHNob3VsZENhbmNlbCgpIGFuZCBmaXggZHVyYXRpb24gY2Fs Y3VsYXRpb24uCisgICAgICAgIChXZWJLaXQ6OlZpZXdHZXN0dXJlQ29udHJvbGxlcjo6U3dpcGVQ cm9ncmVzc1RyYWNrZXI6OmVuZEFuaW1hdGlvbik6IFNldCBzdGF0ZSB0byBTdGF0ZTo6RmluaXNo aW5nIHdoZW4gdGhlIGFuaW1hdGlvbiBlbmRzLgorCiAyMDE5LTAyLTIxICBBZHJpYW4gUGVyZXog ZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV1bR1RLXSBObyBB UEkgZG9jdW1lbnRhdGlvbiBnZW5lcmF0ZWQgZm9yIFdlYktpdFVzZXJDb250ZW50RmlsdGVyU3Rv cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1ZpZXdHZXN0dXJlQ29udHJv bGxlci5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvVmlld0dlc3R1cmVDb250cm9sbGVyLmgK aW5kZXggYjU0MTFiYjk1YWY1YmRmODI2MGM1MzM4NzMzNWJiMzI2NTAwNDY5Yy4uNDMxYzI3NjZk MDgyNjFlNTJjZWZiMjA2ZDZjZDI5OWIxMmNmMTM5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvVmlld0dlc3R1cmVDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvVmlld0dlc3R1cmVDb250cm9sbGVyLmgKQEAgLTM3NCw5ICszNzQsMTIgQEAgcHJp dmF0ZToKICAgICAgICAgICAgIE5vbmUsCiAgICAgICAgICAgICBQZW5kaW5nLAogICAgICAgICAg ICAgU2Nyb2xsaW5nLAotICAgICAgICAgICAgQW5pbWF0aW5nCisgICAgICAgICAgICBBbmltYXRp bmcsCisgICAgICAgICAgICBGaW5pc2hpbmcKICAgICAgICAgfTsKIAorICAgICAgICBib29sIHNo b3VsZENhbmNlbCgpOworCiAgICAgICAgIHZvaWQgc3RhcnRBbmltYXRpb24oKTsKICAgICAgICAg Z2Jvb2xlYW4gb25BbmltYXRpb25UaWNrKEdka0ZyYW1lQ2xvY2sqKTsKICAgICAgICAgdm9pZCBl bmRBbmltYXRpb24oKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9W aWV3R2VzdHVyZUNvbnRyb2xsZXJHdGsuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3Rr L1ZpZXdHZXN0dXJlQ29udHJvbGxlckd0ay5jcHAKaW5kZXggNGFmNmVmMGI1NzE2ZDZlOTlkYWY2 ZDc5NTIyZGNkOGUyZDVmYmU3Ny4uNDg0ZmJlNWI4YjUwYjZlMTY4OWYyMjkzNWVlYWFlNGI3ZjA2 NmRjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL1ZpZXdHZXN0dXJl Q29udHJvbGxlckd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL1ZpZXdH ZXN0dXJlQ29udHJvbGxlckd0ay5jcHAKQEAgLTM1LDYgKzM1LDEyIEBAIHVzaW5nIG5hbWVzcGFj ZSBXZWJDb3JlOwogc3RhdGljIGNvbnN0IFNlY29uZHMgc3dpcGVNaW5BbmltYXRpb25EdXJhdGlv biA9IDEwMF9tczsKIHN0YXRpYyBjb25zdCBTZWNvbmRzIHN3aXBlTWF4QW5pbWF0aW9uRHVyYXRp b24gPSA0MDBfbXM7CiAKKy8vIFRoaXMgaXMgZGVyaXZhdGl2ZSBvZiB0aGUgZWFzaW5nIGZ1bmN0 aW9uIGF0IHQ9MAorc3RhdGljIGNvbnN0IGRvdWJsZSBzd2lwZUFuaW1hdGlvbkR1cmF0aW9uTXVs dGlwbGllciA9IDM7CisKK3N0YXRpYyBjb25zdCBkb3VibGUgc3dpcGVDYW5jZWxBcmVhID0gMC41 Oworc3RhdGljIGNvbnN0IGRvdWJsZSBzd2lwZUNhbmNlbFZlbG9jaXR5VGhyZXNob2xkID0gMC4w MDE7CisKIHN0YXRpYyBjb25zdCBkb3VibGUgc3dpcGVPdmVybGF5U2hhZG93T3BhY2l0eSA9IDAu MDY7CiBzdGF0aWMgY29uc3QgZG91YmxlIHN3aXBlT3ZlcmxheURpbW1pbmdPcGFjaXR5ID0gMC4x MjsKIHN0YXRpYyBjb25zdCBkb3VibGUgc3dpcGVPdmVybGF5U2hhZG93V2lkdGggPSA4MTsKQEAg LTEzNSwxNSArMTQxLDI1IEBAIHZvaWQgVmlld0dlc3R1cmVDb250cm9sbGVyOjpTd2lwZVByb2dy ZXNzVHJhY2tlcjo6cmVzZXQoKQogCiBib29sIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6U3dpcGVQ cm9ncmVzc1RyYWNrZXI6OmhhbmRsZUV2ZW50KEdka0V2ZW50U2Nyb2xsKiBldmVudCkKIHsKKyAg ICAvLyBEb24ndCBhbGxvdyBzY3JvbGxpbmcgd2hpbGUgdGhlIG5leHQgcGFnZSBpcyBsb2FkaW5n CisgICAgaWYgKG1fc3RhdGUgPT0gU3RhdGU6OkZpbmlzaGluZykKKyAgICAgICAgcmV0dXJuIHRy dWU7CisKKyAgICAvLyBTdG9wIGN1cnJlbnQgYW5pbWF0aW9uLCBpZiBhbnkKKyAgICBpZiAobV9z dGF0ZSA9PSBTdGF0ZTo6QW5pbWF0aW5nKSB7CisgICAgICAgIEd0a1dpZGdldCogd2lkZ2V0ID0g bV93ZWJQYWdlUHJveHkudmlld1dpZGdldCgpOworICAgICAgICBndGtfd2lkZ2V0X3JlbW92ZV90 aWNrX2NhbGxiYWNrKHdpZGdldCwgbV90aWNrQ2FsbGJhY2tJRCk7CisgICAgICAgIG1fdGlja0Nh bGxiYWNrSUQgPSAwOworCisgICAgICAgIG1fY2FuY2VsbGVkID0gZmFsc2U7CisgICAgICAgIG1f c3RhdGUgPSBTdGF0ZTo6UGVuZGluZzsKKyAgICB9CisKICAgICBpZiAobV9zdGF0ZSA9PSBTdGF0 ZTo6UGVuZGluZykgewogICAgICAgICBtX3ZpZXdHZXN0dXJlQ29udHJvbGxlci5iZWdpblN3aXBl R2VzdHVyZShtX3RhcmdldEl0ZW0uZ2V0KCksIG1fZGlyZWN0aW9uKTsKICAgICAgICAgbV9zdGF0 ZSA9IFN0YXRlOjpTY3JvbGxpbmc7CiAgICAgfQogCi0gICAgLy8gRG9uJ3QgYWxsb3cgc2Nyb2xs aW5nIGR1cmluZyBhbmltYXRpb24KLSAgICBpZiAobV9zdGF0ZSA9PSBTdGF0ZTo6QW5pbWF0aW5n KQotICAgICAgICByZXR1cm4gdHJ1ZTsKLQogICAgIGlmIChtX3N0YXRlICE9IFN0YXRlOjpTY3Jv bGxpbmcpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIApAQCAtMTUyLDExICsxNjgsMTQgQEAgYm9v bCBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OlN3aXBlUHJvZ3Jlc3NUcmFja2VyOjpoYW5kbGVFdmVu dChHZGtFdmVudFNjcm9sbCogZXYKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAorICAg IGRvdWJsZSBkZWx0YVggPSAtZXZlbnQtPmRlbHRhX3ggLyBTY3JvbGxiYXI6OnBpeGVsc1Blckxp bmVTdGVwKCk7CisKICAgICBTZWNvbmRzIHRpbWUgPSBTZWNvbmRzOjpmcm9tTWlsbGlzZWNvbmRz KGV2ZW50LT50aW1lKTsKLSAgICBtX3ZlbG9jaXR5ID0gLWV2ZW50LT5kZWx0YV94IC8gKHRpbWUg LSBtX3ByZXZUaW1lKS5taWxsaXNlY29uZHMoKTsKKyAgICBpZiAodGltZSAhPSBtX3ByZXZUaW1l KQorICAgICAgICBtX3ZlbG9jaXR5ID0gZGVsdGFYIC8gKHRpbWUgLSBtX3ByZXZUaW1lKS5taWxs aXNlY29uZHMoKTsKIAogICAgIG1fcHJldlRpbWUgPSB0aW1lOwotICAgIG1fcHJvZ3Jlc3MgLT0g ZXZlbnQtPmRlbHRhX3ggLyBTY3JvbGxiYXI6OnBpeGVsc1BlckxpbmVTdGVwKCk7CisgICAgbV9w cm9ncmVzcyArPSBkZWx0YVg7CiAKICAgICBib29sIHN3aXBpbmdMZWZ0ID0gbV92aWV3R2VzdHVy ZUNvbnRyb2xsZXIuaXNQaHlzaWNhbGx5U3dpcGluZ0xlZnQobV9kaXJlY3Rpb24pOwogICAgIGZs b2F0IG1heFByb2dyZXNzID0gc3dpcGluZ0xlZnQgPyAxIDogMDsKQEAgLTE2OCwxMCArMTg3LDIy IEBAIGJvb2wgVmlld0dlc3R1cmVDb250cm9sbGVyOjpTd2lwZVByb2dyZXNzVHJhY2tlcjo6aGFu ZGxlRXZlbnQoR2RrRXZlbnRTY3JvbGwqIGV2CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKLXZvaWQg Vmlld0dlc3R1cmVDb250cm9sbGVyOjpTd2lwZVByb2dyZXNzVHJhY2tlcjo6c3RhcnRBbmltYXRp b24oKQorYm9vbCBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OlN3aXBlUHJvZ3Jlc3NUcmFja2VyOjpz aG91bGRDYW5jZWwoKQogewogICAgIGJvb2wgc3dpcGluZ0xlZnQgPSBtX3ZpZXdHZXN0dXJlQ29u dHJvbGxlci5pc1BoeXNpY2FsbHlTd2lwaW5nTGVmdChtX2RpcmVjdGlvbik7Ci0gICAgbV9jYW5j ZWxsZWQgPSBzd2lwaW5nTGVmdCA/IChtX3ZlbG9jaXR5IDw9IDApIDogKG1fdmVsb2NpdHkgPj0g MCk7CisKKyAgICBpZiAoc3dpcGluZ0xlZnQgJiYgbV92ZWxvY2l0eSA8IDApCisgICAgICAgIHJl dHVybiB0cnVlOworCisgICAgaWYgKCFzd2lwaW5nTGVmdCAmJiBtX3ZlbG9jaXR5ID4gMCkKKyAg ICAgICAgcmV0dXJuIHRydWU7CisKKyAgICByZXR1cm4gKGFicyhtX3Byb2dyZXNzKSA8IHN3aXBl Q2FuY2VsQXJlYSAmJiBhYnMobV92ZWxvY2l0eSkgPCBzd2lwZUNhbmNlbFZlbG9jaXR5VGhyZXNo b2xkKTsKK30KKwordm9pZCBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OlN3aXBlUHJvZ3Jlc3NUcmFj a2VyOjpzdGFydEFuaW1hdGlvbigpCit7CisgICAgbV9jYW5jZWxsZWQgPSBzaG91bGRDYW5jZWwo KTsKIAogICAgIG1fc3RhdGUgPSBTdGF0ZTo6QW5pbWF0aW5nOwogICAgIG1fdmlld0dlc3R1cmVD b250cm9sbGVyLndpbGxFbmRTd2lwZUdlc3R1cmUoKm1fdGFyZ2V0SXRlbSwgbV9jYW5jZWxsZWQp OwpAQCAtMTgwLDEwICsyMTEsMTMgQEAgdm9pZCBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OlN3aXBl UHJvZ3Jlc3NUcmFja2VyOjpzdGFydEFuaW1hdGlvbigpCiAgICAgaWYgKG1fY2FuY2VsbGVkKQog ICAgICAgICBtX2VuZFByb2dyZXNzID0gMDsKICAgICBlbHNlCi0gICAgICAgIG1fZW5kUHJvZ3Jl c3MgPSBzd2lwaW5nTGVmdCA/IDEgOiAtMTsKKyAgICAgICAgbV9lbmRQcm9ncmVzcyA9IG1fdmll d0dlc3R1cmVDb250cm9sbGVyLmlzUGh5c2ljYWxseVN3aXBpbmdMZWZ0KG1fZGlyZWN0aW9uKSA/ IDEgOiAtMTsKIAotICAgIFNlY29uZHMgZHVyYXRpb24gPSBTZWNvbmRzOjpmcm9tTWlsbGlzZWNv bmRzKHN0ZDo6YWJzKChtX3Byb2dyZXNzIC0gbV9lbmRQcm9ncmVzcykgLyBtX3ZlbG9jaXR5KSAq IFNjcm9sbGJhcjo6cGl4ZWxzUGVyTGluZVN0ZXAoKSk7Ci0gICAgZHVyYXRpb24gPSBzdGQ6Om1p bihzdGQ6Om1heChkdXJhdGlvbiwgc3dpcGVNaW5BbmltYXRpb25EdXJhdGlvbiksIHN3aXBlTWF4 QW5pbWF0aW9uRHVyYXRpb24pOworICAgIFNlY29uZHMgZHVyYXRpb24gPSBzd2lwZU1heEFuaW1h dGlvbkR1cmF0aW9uOworICAgIGlmICgobV9lbmRQcm9ncmVzcyAtIG1fcHJvZ3Jlc3MpICogbV92 ZWxvY2l0eSA+IDApIHsKKyAgICAgICAgZHVyYXRpb24gPSBTZWNvbmRzOjpmcm9tTWlsbGlzZWNv bmRzKHN0ZDo6YWJzKChtX3Byb2dyZXNzIC0gbV9lbmRQcm9ncmVzcykgLyBtX3ZlbG9jaXR5ICog c3dpcGVBbmltYXRpb25EdXJhdGlvbk11bHRpcGxpZXIpKTsKKyAgICAgICAgZHVyYXRpb24gPSBj bGFtcFRvPFdURjo6U2Vjb25kcz4oZHVyYXRpb24sIHN3aXBlTWluQW5pbWF0aW9uRHVyYXRpb24s IHN3aXBlTWF4QW5pbWF0aW9uRHVyYXRpb24pOworICAgIH0KIAogICAgIEd0a1dpZGdldCogd2lk Z2V0ID0gbV93ZWJQYWdlUHJveHkudmlld1dpZGdldCgpOwogICAgIG1fc3RhcnRUaW1lID0gU2Vj b25kczo6ZnJvbU1pY3Jvc2Vjb25kcyhnZGtfZnJhbWVfY2xvY2tfZ2V0X2ZyYW1lX3RpbWUoZ3Rr X3dpZGdldF9nZXRfZnJhbWVfY2xvY2sod2lkZ2V0KSkpOwpAQCAtMjI2LDYgKzI2MCw3IEBAIGdi b29sZWFuIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6U3dpcGVQcm9ncmVzc1RyYWNrZXI6Om9uQW5p bWF0aW9uVGljayhHZGtGcmFtZUNsCiAKIHZvaWQgVmlld0dlc3R1cmVDb250cm9sbGVyOjpTd2lw ZVByb2dyZXNzVHJhY2tlcjo6ZW5kQW5pbWF0aW9uKCkKIHsKKyAgICBtX3N0YXRlID0gU3RhdGU6 OkZpbmlzaGluZzsKICAgICBtX3ZpZXdHZXN0dXJlQ29udHJvbGxlci5lbmRTd2lwZUdlc3R1cmUo bV90YXJnZXRJdGVtLmdldCgpLCBtX2NhbmNlbGxlZCk7CiB9CiAK