194940 2019-02-22 01:38:22 -0800 Fix unitless usage of mathsize 2019-03-04 01:21:58 -0800 1 1 1 Unclassified WebKit MathML Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis commit-queue darin dbarton ews-watchlist fred.wang webkit-bug-importer oldest_to_newest 1508943 0 rbuis 2019-02-22 01:38:22 -0800 Computation of unitless values for mathsize is wrong, causing these tests to fail: * http://www.w3c-test.org/mathml/relations/css-styling/lengths-1.html * http://www.w3c-test.org/mathml/relations/css-styling/lengths-3.html 1508947 1 362708 rbuis 2019-02-22 01:40:31 -0800 Created attachment 362708 Patch 1508950 2 362708 fred.wang 2019-02-22 01:51:11 -0800 Comment on attachment 362708 Patch Great thanks. I guess it's a bit hacky and I think Gecko has similar hacks. Probably nonzero unitless values should not be supported. 1508959 3 362708 commit-queue 2019-02-22 02:42:49 -0800 Comment on attachment 362708 Patch Clearing flags on attachment: 362708 Committed r241942: <https://trac.webkit.org/changeset/241942> 1508960 4 commit-queue 2019-02-22 02:42:50 -0800 All reviewed patches have been landed. Closing bug. 1508962 5 webkit-bug-importer 2019-02-22 02:43:22 -0800 <rdar://problem/48306931> 1509027 6 darin 2019-02-22 09:58:06 -0800 Oh, no! Don’t add more uses of String::format! 1509029 7 fred.wang 2019-02-22 10:06:43 -0800 (In reply to Frédéric Wang (:fredw) from comment #2) > Comment on attachment 362708 [details] > Patch > > Great thanks. I guess it's a bit hacky and I think Gecko has similar hacks. > Probably nonzero unitless values should not be supported. Let's ask the MathML CG to remove these special parsing so that we don't need these hacks anymore: https://github.com/mathml-refresh/mathml/issues/24 https://github.com/mathml-refresh/mathml/issues/7 1509064 8 362708 fred.wang 2019-02-22 10:54:44 -0800 Comment on attachment 362708 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362708&action=review > Source/WebCore/mathml/MathMLElement.cpp:105 > + return String::format("%.3f%%", unitlessValue * 100.0); I suspect this is not super reliable. I seems to get rounding errors with my local build. 1509080 9 rbuis 2019-02-22 11:35:08 -0800 (In reply to Darin Adler from comment #6) > Oh, no! Don’t add more uses of String::format! Oops, I was not aware of https://bugs.webkit.org/show_bug.cgi?id=194752! Maybe it could be renamed to deprecatedFormat. I am happy to fix it in a follow up though. 1509562 10 rbuis 2019-02-25 00:32:14 -0800 Reopening to attach new patch. 1509563 11 362888 rbuis 2019-02-25 00:32:16 -0800 Created attachment 362888 Patch 1509564 12 rbuis 2019-02-25 00:48:34 -0800 Already fixed. 1509574 13 rbuis 2019-02-25 02:06:29 -0800 Reopening to attach new patch. 1509575 14 362890 rbuis 2019-02-25 02:06:31 -0800 Created attachment 362890 Patch 1511921 15 darin 2019-03-03 00:32:10 -0800 Well, I re-landed my patch that fixes it. You are welcome to refine further. 1512093 16 rbuis 2019-03-04 01:21:58 -0800 Hi Darin, (In reply to Darin Adler from comment #15) > Well, I re-landed my patch that fixes it. You are welcome to refine further. Thanks for the heads up. We are happy with the change so I will close this bug. Note that we are still evaluating usage of unitless values in mathsize for the next version of the MathML spec, but if we drop support we will likely do it in a new bug. 362708 2019-02-22 01:40:31 -0800 2019-02-25 00:32:10 -0800 Patch bug-194940-20190222104030.patch text/plain 4064 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxOTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzhkOGZiODA5NGE4Mjkz MjNmNzVhZDZlMDYxYTk0NDI2MGVmMzcyYy4uODlmMTdhM2NhZDJkOGRmZDkyNjhiOTk3ZDZiZTlm MGE2MjQyZGM3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTAyLTIyICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IHVuaXRsZXNzIHVzYWdlIG9m IG1hdGhzaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTQ5NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDb252ZXJ0IHVuaXRsZXNzIGxlbmd0aHMgdG8gcGVyY2VudGFnZSB2YWx1ZXMgdG8gY29ycmVj dCB0aGUgY29tcHV0ZWQKKyAgICAgICAgZm9udCBzaXplLgorCisgICAgICAgICogbWF0aG1sL01h dGhNTEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y29udmVydFRvUGVyY2VudGFnZUlm TmVlZGVkKToKKyAgICAgICAgKFdlYkNvcmU6Ok1hdGhNTEVsZW1lbnQ6OmNvbGxlY3RTdHlsZUZv clByZXNlbnRhdGlvbkF0dHJpYnV0ZSk6CisKIDIwMTktMDItMjEgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgSGFyZGNvZGUgVmlzdWFsIFZpZXdwb3J0 cyBvbiBldmVyeXdoZXJlIGV4Y2VwdCBpT1MgV0sxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9tYXRobWwvTWF0aE1MRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9tYXRobWwvTWF0aE1M RWxlbWVudC5jcHAKaW5kZXggNWZmYTIzZjI0MWUwMGFkNDAzZmVjNjc4MWQxNzYzODEwMzYyOGQ3 ZC4uZDhjYjFjNGRhYjNkNTc4YWNkZDU1MTRkY2Y0MjAzMDM5ODkyZWRhOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvbWF0aG1sL01hdGhNTEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL21hdGhtbC9NYXRoTUxFbGVtZW50LmNwcApAQCAtOTcsNiArOTcsMTUgQEAgYm9vbCBNYXRo TUxFbGVtZW50Ojppc1ByZXNlbnRhdGlvbkF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJiBu YW1lKSBjb25zdAogICAgIHJldHVybiBTdHlsZWRFbGVtZW50Ojppc1ByZXNlbnRhdGlvbkF0dHJp YnV0ZShuYW1lKTsKIH0KIAorc3RhdGljIFN0cmluZyBjb252ZXJ0VG9QZXJjZW50YWdlSWZOZWVk ZWQoY29uc3QgQXRvbWljU3RyaW5nJiB2YWx1ZSkKK3sKKyAgICBib29sIG9rID0gZmFsc2U7Cisg ICAgZmxvYXQgdW5pdGxlc3NWYWx1ZSA9IHZhbHVlLnRvRmxvYXQoJm9rKTsKKyAgICBpZiAob2sp CisgICAgICAgIHJldHVybiBTdHJpbmc6OmZvcm1hdCgiJS4zZiUlIiwgdW5pdGxlc3NWYWx1ZSAq IDEwMC4wKTsKKyAgICByZXR1cm4gdmFsdWU7Cit9CisKIHZvaWQgTWF0aE1MRWxlbWVudDo6Y29s bGVjdFN0eWxlRm9yUHJlc2VudGF0aW9uQXR0cmlidXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmIG5h bWUsIGNvbnN0IEF0b21pY1N0cmluZyYgdmFsdWUsIE11dGFibGVTdHlsZVByb3BlcnRpZXMmIHN0 eWxlKQogewogICAgIGlmIChuYW1lID09IG1hdGhiYWNrZ3JvdW5kQXR0cikKQEAgLTEwNCw3ICsx MTMsNyBAQCB2b2lkIE1hdGhNTEVsZW1lbnQ6OmNvbGxlY3RTdHlsZUZvclByZXNlbnRhdGlvbkF0 dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJiBuYQogICAgIGVsc2UgaWYgKG5hbWUgPT0gbWF0 aHNpemVBdHRyKSB7CiAgICAgICAgIC8vIFRoZSBmb2xsb3dpbmcgdGhyZWUgdmFsdWVzIG9mIG1h dGhzaXplIGFyZSBoYW5kbGVkIGluIFdlYkNvcmUvY3NzL21hdGhtbC5jc3MKICAgICAgICAgaWYg KHZhbHVlICE9ICJub3JtYWwiICYmIHZhbHVlICE9ICJzbWFsbCIgJiYgdmFsdWUgIT0gImJpZyIp Ci0gICAgICAgICAgICBhZGRQcm9wZXJ0eVRvUHJlc2VudGF0aW9uQXR0cmlidXRlU3R5bGUoc3R5 bGUsIENTU1Byb3BlcnR5Rm9udFNpemUsIHZhbHVlKTsKKyAgICAgICAgICAgIGFkZFByb3BlcnR5 VG9QcmVzZW50YXRpb25BdHRyaWJ1dGVTdHlsZShzdHlsZSwgQ1NTUHJvcGVydHlGb250U2l6ZSwg Y29udmVydFRvUGVyY2VudGFnZUlmTmVlZGVkKHZhbHVlKSk7CiAgICAgfSBlbHNlIGlmIChuYW1l ID09IG1hdGhjb2xvckF0dHIpCiAgICAgICAgIGFkZFByb3BlcnR5VG9QcmVzZW50YXRpb25BdHRy aWJ1dGVTdHlsZShzdHlsZSwgQ1NTUHJvcGVydHlDb2xvciwgdmFsdWUpOwogICAgIC8vIEZJWE1F OiBkZXByZWNhdGVkIGF0dHJpYnV0ZXMgdGhhdCBzaG91bGQgbG9vc2UgaW4gYSBjb25mbGljdCB3 aXRoIGEgbm9uIGRlcHJlY2F0ZWQgYXR0cmlidXRlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODJiMzg4MmQ4NWQ5MzZhNjI2 YjZkZWRhNGQ3MWY2NGQ1YzU1Yzc5Ni4uYmI1M2FmY2JkYmI4NTdmMmZiMjViZmM4ZmE3OTc5M2Y2 YjQ0MjA0YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTAyLTIyICBSb2IgQnVpcyAgPHJi dWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IHVuaXRsZXNzIHVzYWdlIG9mIG1hdGhzaXpl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ5NDAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0cyBs ZW5ndGhzLTEuaHRtbCBhbmQgbGVuZ3RoLTMuaHRtbCBub3cgcGFzcy4KKworICAgICAgICAqIFRl c3RFeHBlY3RhdGlvbnM6CisKIDIwMTktMDItMjEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNl ckBhcHBsZS5jb20+CiAKICAgICAgICAgSGFyZGNvZGUgVmlzdWFsIFZpZXdwb3J0cyBvbiBldmVy eXdoZXJlIGV4Y2VwdCBpT1MgV0sxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0 YXRpb25zIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA4NzhmYWFlYjRmMzVj M2FlNGE5NDViNDQwMjAwODg4ZTkyNDI2YWQ5Li4yOTgxN2RlYjM2MGQ5MjM2ZTJkZWFhMzIzMzIw ZGQxZWI2MGVkMzUzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCisr KyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTcxOSw5ICs3MTksNyBAQCBpbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvYnJvd3NlcnMvd2luZG93cy9uZXN0ZWQt YnJvd3NpbmctY29udGV4dHMvZgogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1s L2Jyb3dzZXJzL3dpbmRvd3MvdGFyZ2V0aW5nLWNyb3NzLW9yaWdpbi1uZXN0ZWQtYnJvd3Npbmct Y29udGV4dHMuc3ViLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCiAjIFRoZXNlIE1hdGhNTCBXUFQg dGVzdHMgZmFpbC4KLXdlYmtpdC5vcmcvYi8xODAwMTMgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9tYXRobWwvcmVsYXRpb25zL2Nzcy1zdHlsaW5nL2xlbmd0aHMtMS5odG1sIFsgSW1h Z2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTgwMDEzIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvbWF0aG1sL3JlbGF0aW9ucy9jc3Mtc3R5bGluZy9sZW5ndGhzLTIuaHRtbCBb IEltYWdlT25seUZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE4MDAxMyBpbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL21hdGhtbC9yZWxhdGlvbnMvY3NzLXN0eWxpbmcvbGVuZ3Rocy0zLmh0 bWwgWyBGYWlsdXJlIF0KIAogIyBUaGVzZSB3ZWJtZXNzYWdpbmcgV1BUIHRlc3RzIHRpbWUgb3V0 Lgogd2Via2l0Lm9yZy9iLzE4NzAzNCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dl Ym1lc3NhZ2luZy9NZXNzYWdlRXZlbnRfb25tZXNzYWdlX3Bvc3RNZXNzYWdlX2luZmluaXRlX2xv b3AuaHRtbCBbIFNraXAgXQo= 362888 2019-02-25 00:32:16 -0800 2019-02-25 02:06:25 -0800 Patch bug-194940-20190225093215.patch text/plain 1621 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxOTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzdiODFjZTA1ZjYwNjc4 NzJjNDNkNTE2MTI0ZWFjNjlmZjZiZjM5OC4uNmEzNTJmOTYxZjY2YTAyMzBiM2FjM2M5NTY2NTMw ODk5ZTZjMjgxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAyLTI1ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IHVuaXRsZXNzIHVzYWdlIG9m IG1hdGhzaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTQ5NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbiByMzYyNzA4IEkgYWRkZWQgYSBTdHJpbmc6OmZvcm1hdCB1c2FnZSwgd2hpY2ggaXMgYmVp bmcKKyAgICAgICAgZGVwcmVjYXRlZCwgc28gdXNlIG1ha2VTdHJpbmcgKyBGb3JtYXR0ZWROdW1i ZXIgaW5zdGVhZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGZ1bmN0aW9uYWwgY2hhbmdl LgorCisgICAgICAgICogbWF0aG1sL01hdGhNTEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Y29udmVydFRvUGVyY2VudGFnZUlmTmVlZGVkKToKKwogMjAxOS0wMi0yMiAgRXJpYyBDYXJs c29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgc29tZSBtZWRp YSBsb2dnaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9tYXRobWwvTWF0aE1MRWxlbWVu dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9tYXRobWwvTWF0aE1MRWxlbWVudC5jcHAKaW5kZXggZDhj YjFjNGRhYjNkNTc4YWNkZDU1MTRkY2Y0MjAzMDM5ODkyZWRhOC4uMzAyM2RmODcyMDM2YzBiOTZk NjMxMmQ0ZmRjNTZjMmYxMGE5ZWE4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbWF0aG1s L01hdGhNTEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL21hdGhtbC9NYXRoTUxFbGVt ZW50LmNwcApAQCAtMzksNiArMzksNyBAQAogI2luY2x1ZGUgIk1vdXNlRXZlbnQuaCIKICNpbmNs dWRlICJSZW5kZXJUYWJsZUNlbGwuaCIKICNpbmNsdWRlIDx3dGYvSXNvTWFsbG9jSW5saW5lcy5o PgorI2luY2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0NvbmNhdGVuYXRlTnVtYmVycy5oPgogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKQEAgLTEwMiw3ICsxMDMsNyBAQCBzdGF0aWMgU3RyaW5nIGNvbnZl cnRUb1BlcmNlbnRhZ2VJZk5lZWRlZChjb25zdCBBdG9taWNTdHJpbmcmIHZhbHVlKQogICAgIGJv b2wgb2sgPSBmYWxzZTsKICAgICBmbG9hdCB1bml0bGVzc1ZhbHVlID0gdmFsdWUudG9GbG9hdCgm b2spOwogICAgIGlmIChvaykKLSAgICAgICAgcmV0dXJuIFN0cmluZzo6Zm9ybWF0KCIlLjNmJSUi LCB1bml0bGVzc1ZhbHVlICogMTAwLjApOworICAgICAgICByZXR1cm4gbWFrZVN0cmluZyhGb3Jt YXR0ZWROdW1iZXI6OmZpeGVkUHJlY2lzaW9uKHVuaXRsZXNzVmFsdWUgKiAxMDAuMCksICIlIik7 CiAgICAgcmV0dXJuIHZhbHVlOwogfQogCg== 362890 2019-02-25 02:06:31 -0800 2019-02-25 02:06:31 -0800 Patch bug-194940-20190225110631.patch text/plain 1815 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzIwMThmM2UwMWY1NTY2 MjAxNmE1MmU0NWRhMGM1YTRiNmJkMTBlMi4uMDEyNDAzMmIwZjNlNzdhZTY3Y2IxZDZmM2ZjYTM1 MDI4NTVhNmUzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTAyLTI1ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IHVuaXRsZXNzIHVzYWdlIG9m IG1hdGhzaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTQ5NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTaW5jZSByb3VuZGluZyBlcnJvcnMgd2VyZSByZXBvcnRlZCwgdXNlIGRvdWJsZSB3aXRoIGRl ZmF1bHQKKyAgICAgICAgcHJlY2lzaW9uIG9mIGZpeGVkUHJlY2lzaW9uLgorCisgICAgICAgICog bWF0aG1sL01hdGhNTEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y29udmVydFRvUGVy Y2VudGFnZUlmTmVlZGVkKToKKwogMjAxOS0wMi0yNCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBw bGUuY29tPgogCiAgICAgICAgIEludHJvZHVjZSBDb250ZW50Q2hhbmdlT2JzZXJ2ZXIgY2xhc3MK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL21hdGhtbC9NYXRoTUxFbGVtZW50LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL21hdGhtbC9NYXRoTUxFbGVtZW50LmNwcAppbmRleCA5OWIxNmJjMzkyYzA0 MWQ1YzMyOGI3OTM5MmE5ZWExZDIxMTAzZDM5Li41MDI3ZmU3OGU5ODU5NjE1OGJiYjgzMDA5NTFh NDdmNjAyOWU3YTE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9tYXRobWwvTWF0aE1MRWxl bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbWF0aG1sL01hdGhNTEVsZW1lbnQuY3BwCkBA IC0xMDAsMTMgKzEwMCwxMSBAQCBib29sIE1hdGhNTEVsZW1lbnQ6OmlzUHJlc2VudGF0aW9uQXR0 cmlidXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmIG5hbWUpIGNvbnN0CiAKIHN0YXRpYyBTdHJpbmcg Y29udmVydFRvUGVyY2VudGFnZUlmTmVlZGVkKGNvbnN0IEF0b21pY1N0cmluZyYgdmFsdWUpCiB7 Ci0gICAgLy8gRklYTUU6IE1pZ2h0IGJlIGJldHRlciB0byB1c2UgZG91YmxlIHRoYW4gZmxvYXQu Ci0gICAgLy8gRklYTUU6IE1pZ2h0IGJlIGJldHRlciB0byB1c2UgInNob3J0ZXN0IiBudW1lcmlj IGZvcm1hdHRpbmcgaW5zdGVhZCBvZiBmaXhlZCB3aWR0aC4KICAgICBib29sIG9rID0gZmFsc2U7 Ci0gICAgZmxvYXQgdW5pdGxlc3NWYWx1ZSA9IHZhbHVlLnRvRmxvYXQoJm9rKTsKKyAgICBkb3Vi bGUgdW5pdGxlc3NWYWx1ZSA9IHZhbHVlLnRvRG91YmxlKCZvayk7CiAgICAgaWYgKCFvaykKICAg ICAgICAgcmV0dXJuIHZhbHVlOwotICAgIHJldHVybiBtYWtlU3RyaW5nKEZvcm1hdHRlZE51bWJl cjo6Zml4ZWRXaWR0aCh1bml0bGVzc1ZhbHVlICogMTAwLCAzKSwgJyUnKTsKKyAgICByZXR1cm4g bWFrZVN0cmluZyhGb3JtYXR0ZWROdW1iZXI6OmZpeGVkUHJlY2lzaW9uKHVuaXRsZXNzVmFsdWUg KiAxMDApLCAnJScpOwogfQogCiB2b2lkIE1hdGhNTEVsZW1lbnQ6OmNvbGxlY3RTdHlsZUZvclBy ZXNlbnRhdGlvbkF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lLCBjb25zdCBBdG9t aWNTdHJpbmcmIHZhbHVlLCBNdXRhYmxlU3R5bGVQcm9wZXJ0aWVzJiBzdHlsZSkK