194937 2019-02-22 00:53:55 -0800 Avoid hashing CompactVariableEnvironment when decoding CompactVariableMap::Handle 2019-02-25 12:16:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 194706 1 tzagallo tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1508930 0 tzagallo 2019-02-22 00:53:55 -0800 Per Saam's suggestion in https://bugs.webkit.org/show_bug.cgi?id=194706, hashing the CompactVariableEnvironment is expensive and we could avoid it when decoding multiple handles to the same environment. 1508931 1 362705 tzagallo 2019-02-22 00:59:26 -0800 Created attachment 362705 Patch 1509665 2 362908 tzagallo 2019-02-25 10:16:54 -0800 Created attachment 362908 Patch Rebase 1509717 3 362908 saam 2019-02-25 11:27:52 -0800 Comment on attachment 362908 Patch r=me 1509743 4 362908 commit-queue 2019-02-25 12:15:59 -0800 Comment on attachment 362908 Patch Clearing flags on attachment: 362908 Committed r242054: <https://trac.webkit.org/changeset/242054> 1509744 5 commit-queue 2019-02-25 12:16:00 -0800 All reviewed patches have been landed. Closing bug. 1509745 6 webkit-bug-importer 2019-02-25 12:16:34 -0800 <rdar://problem/48372417> 362705 2019-02-22 00:59:26 -0800 2019-02-25 10:16:43 -0800 Patch bug-194937-20190222095847.patch text/plain 3054 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxOTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy YzIxMmRkODg1MjQyMWYwZGFkYjZjOGI4YjZlOWRlNWEyYTBmZGQ0Li5kOWI4YTgxYjYwMmMwYzZi YjlkNjEyOTNkNWI1ZWNhMDJiZmZhYmMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOS0wMi0yMiAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBBdm9pZCBoYXNoaW5nIENvbXBhY3RWYXJpYWJsZUVudmlyb25tZW50IHdo ZW4gZGVjb2RpbmcgQ29tcGFjdFZhcmlhYmxlTWFwOjpIYW5kbGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDkzNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhc2hpbmcgdGhlIENvbXBhY3RWYXJpYWJs ZUVudmlyb25tZW50IGlzIGV4cGVuc2l2ZSBhbmQgd2UgY291bGQgYXZvaWQgaXQKKyAgICAgICAg d2hlbiBkZWNvZGluZyBtdWx0aXBsZSBoYW5kbGVzIHRvIHRoZSBzYW1lIGVudmlyb25tZW50LiBU aGlzIGlzIHNvdW5kIGJlY2F1c2UKKyAgICAgICAgYSBwb2ludGVyIHRvIHRoZSBzYW1lIENvbXBh Y3RWYXJpYWJsZUVudmlyb25tZW50IHdpbGwgaGFzaCB0aGUgc2FtZS4KKworICAgICAgICAqIHJ1 bnRpbWUvQ2FjaGVkVHlwZXMuY3BwOgorICAgICAgICAoSlNDOjpEZWNvZGVyOjpoYW5kbGVGb3JF bnZpcm9ubWVudCBjb25zdCk6CisgICAgICAgIChKU0M6OkRlY29kZXI6OnNldEhhbmRsZUZvckVu dmlyb25tZW50KToKKyAgICAgICAgKEpTQzo6Q2FjaGVkQ29tcGFjdFZhcmlhYmxlTWFwSGFuZGxl OjpkZWNvZGUgY29uc3QpOgorCiAyMDE5LTAyLTIyICBUYWRldSBaYWdhbGxvICA8dHphZ2FsbG9A YXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBXVEY6OiBwcmVmaXhlcyBp biBDYWNoZWRUeXBlcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv Q2FjaGVkVHlwZXMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ2FjaGVkVHlw ZXMuY3BwCmluZGV4IGE4N2FkYzdjY2I3ZWM0NjA3MDYxYzc2M2YzYjQzMzIyMGZkMDQ0MzEuLjk5 NDI5OTM0NTFmYjFmOTFmMDE0ZmY0NjJjMDAzMzIwNWIyMTU3Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NhY2hlZFR5cGVzLmNwcAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9DYWNoZWRUeXBlcy5jcHAKQEAgLTI1OSw2ICsyNTksMTkgQEAg cHVibGljOgogICAgICAgICBtX2ZpbmFsaXplcnMuYXBwZW5kKGZpbmFsaXplcik7CiAgICAgfQog CisgICAgQ29tcGFjdFZhcmlhYmxlTWFwOjpIYW5kbGUgaGFuZGxlRm9yRW52aXJvbm1lbnQoQ29t cGFjdFZhcmlhYmxlRW52aXJvbm1lbnQqIGVudmlyb25tZW50KSBjb25zdAorICAgIHsKKyAgICAg ICAgYXV0byBpdCA9IG1fZW52aXJvbm1lbnRUb0hhbmRsZU1hcC5maW5kKGVudmlyb25tZW50KTsK KyAgICAgICAgQVNTRVJUKGl0ICE9IG1fZW52aXJvbm1lbnRUb0hhbmRsZU1hcC5lbmQoKSk7Cisg ICAgICAgIHJldHVybiBpdC0+dmFsdWU7CisgICAgfQorCisgICAgdm9pZCBzZXRIYW5kbGVGb3JF bnZpcm9ubWVudChDb21wYWN0VmFyaWFibGVFbnZpcm9ubWVudCogZW52aXJvbm1lbnQsIGNvbnN0 IENvbXBhY3RWYXJpYWJsZU1hcDo6SGFuZGxlJiBoYW5kbGUpCisgICAgeworICAgICAgICBhdXRv IGFkZFJlc3VsdCA9IG1fZW52aXJvbm1lbnRUb0hhbmRsZU1hcC5hZGQoZW52aXJvbm1lbnQsIGhh bmRsZSk7CisgICAgICAgIEFTU0VSVF9VTlVTRUQoYWRkUmVzdWx0LCBhZGRSZXN1bHQuaXNOZXdF bnRyeSk7CisgICAgfQorCiBwcml2YXRlOgogICAgIFZNJiBtX3ZtOwogICAgIGNvbnN0IHVpbnQ4 X3QqIG1fYmFzZUFkZHJlc3M7CkBAIC0yNjcsNiArMjgwLDcgQEAgcHJpdmF0ZToKICNlbmRpZgog ICAgIEhhc2hNYXA8cHRyZGlmZl90LCB2b2lkKj4gbV9vZmZzZXRUb1B0ck1hcDsKICAgICBWZWN0 b3I8c3RkOjpmdW5jdGlvbjx2b2lkKCk+PiBtX2ZpbmFsaXplcnM7CisgICAgSGFzaE1hcDxDb21w YWN0VmFyaWFibGVFbnZpcm9ubWVudCosIENvbXBhY3RWYXJpYWJsZU1hcDo6SGFuZGxlPiBtX2Vu dmlyb25tZW50VG9IYW5kbGVNYXA7CiB9OwogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgpAQCAtOTM4 LDE1ICs5NTIsMTYgQEAgcHVibGljOgogICAgIHsKICAgICAgICAgYm9vbCBpc05ld0FsbG9jYXRp b247CiAgICAgICAgIENvbXBhY3RWYXJpYWJsZUVudmlyb25tZW50KiBlbnZpcm9ubWVudCA9IG1f ZW52aXJvbm1lbnQuZGVjb2RlKGRlY29kZXIsIGlzTmV3QWxsb2NhdGlvbik7CisgICAgICAgIGlm ICghaXNOZXdBbGxvY2F0aW9uKQorICAgICAgICAgICAgcmV0dXJuIGRlY29kZXIuaGFuZGxlRm9y RW52aXJvbm1lbnQoZW52aXJvbm1lbnQpOwogICAgICAgICBib29sIGlzTmV3RW50cnk7CiAgICAg ICAgIENvbXBhY3RWYXJpYWJsZU1hcDo6SGFuZGxlIGhhbmRsZSA9IGRlY29kZXIudm0oKS5tX2Nv bXBhY3RWYXJpYWJsZU1hcC0+Z2V0KGVudmlyb25tZW50LCBpc05ld0VudHJ5KTsKLSAgICAgICAg aWYgKCFpc05ld0FsbG9jYXRpb24pCi0gICAgICAgICAgICBBU1NFUlQoIWlzTmV3RW50cnkpOwot ICAgICAgICBlbHNlIGlmICghaXNOZXdFbnRyeSkgeworICAgICAgICBpZiAoIWlzTmV3RW50cnkp IHsKICAgICAgICAgICAgIGRlY29kZXIuYWRkRmluYWxpemVyKFs9XSB7CiAgICAgICAgICAgICAg ICAgZGVsZXRlIGVudmlyb25tZW50OwogICAgICAgICAgICAgfSk7CiAgICAgICAgIH0KKyAgICAg ICAgZGVjb2Rlci5zZXRIYW5kbGVGb3JFbnZpcm9ubWVudChlbnZpcm9ubWVudCwgaGFuZGxlKTsK ICAgICAgICAgcmV0dXJuIGhhbmRsZTsKICAgICB9CiAK 362908 2019-02-25 10:16:54 -0800 2019-02-25 12:15:59 -0800 Patch bug-194937-20190225191611.patch text/plain 3079 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQyMDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 MDJmOWQyYmM2YTFjY2JkOWU1YTMzYThiOWEyMzBlMGIzOWFhMWFmLi5jNzg0NTBmMGQ5MTM4ZmYx N2Q1MTJiNmI5M2FjZWQwZmVmYzQ5ZDc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOS0wMi0yMiAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBBdm9pZCBoYXNoaW5nIENvbXBhY3RWYXJpYWJsZUVudmlyb25tZW50IHdo ZW4gZGVjb2RpbmcgQ29tcGFjdFZhcmlhYmxlTWFwOjpIYW5kbGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDkzNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhc2hpbmcgdGhlIENvbXBhY3RWYXJpYWJs ZUVudmlyb25tZW50IGlzIGV4cGVuc2l2ZSBhbmQgd2UgY291bGQgYXZvaWQgaXQKKyAgICAgICAg d2hlbiBkZWNvZGluZyBtdWx0aXBsZSBoYW5kbGVzIHRvIHRoZSBzYW1lIGVudmlyb25tZW50LiBU aGlzIGlzIHNvdW5kIGJlY2F1c2UKKyAgICAgICAgYSBwb2ludGVyIHRvIHRoZSBzYW1lIENvbXBh Y3RWYXJpYWJsZUVudmlyb25tZW50IHdpbGwgaGFzaCB0aGUgc2FtZS4KKworICAgICAgICAqIHJ1 bnRpbWUvQ2FjaGVkVHlwZXMuY3BwOgorICAgICAgICAoSlNDOjpEZWNvZGVyOjpoYW5kbGVGb3JF bnZpcm9ubWVudCBjb25zdCk6CisgICAgICAgIChKU0M6OkRlY29kZXI6OnNldEhhbmRsZUZvckVu dmlyb25tZW50KToKKyAgICAgICAgKEpTQzo6Q2FjaGVkQ29tcGFjdFZhcmlhYmxlTWFwSGFuZGxl OjpkZWNvZGUgY29uc3QpOgorCiAyMDE5LTAyLTI0ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBDaGFuZ2UgdGhlIEluc3BlY3Rvck92 ZXJsYXkgdG8gdXNlIG5hdGl2ZSByYXRoZXIgdGhhbiBjYW52YXMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NhY2hlZFR5cGVzLmNwcCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0NhY2hlZFR5cGVzLmNwcAppbmRleCAwNjNlZmE5ZDBlYWJlZjJkNjI4 MDQxMDBkODA5MWM2NGY1NWExNGRkLi5jZGU4MjU4Y2NkMmE3YTI3YzZiNWFmMTI2ZTM2MmRiYWE0 OWQzODNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9DYWNoZWRU eXBlcy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ2FjaGVkVHlwZXMu Y3BwCkBAIC0yNTksNiArMjU5LDE5IEBAIHB1YmxpYzoKICAgICAgICAgbV9maW5hbGl6ZXJzLmFw cGVuZChmaW5hbGl6ZXIpOwogICAgIH0KIAorICAgIENvbXBhY3RWYXJpYWJsZU1hcDo6SGFuZGxl IGhhbmRsZUZvckVudmlyb25tZW50KENvbXBhY3RWYXJpYWJsZUVudmlyb25tZW50KiBlbnZpcm9u bWVudCkgY29uc3QKKyAgICB7CisgICAgICAgIGF1dG8gaXQgPSBtX2Vudmlyb25tZW50VG9IYW5k bGVNYXAuZmluZChlbnZpcm9ubWVudCk7CisgICAgICAgIEFTU0VSVChpdCAhPSBtX2Vudmlyb25t ZW50VG9IYW5kbGVNYXAuZW5kKCkpOworICAgICAgICByZXR1cm4gaXQtPnZhbHVlOworICAgIH0K KworICAgIHZvaWQgc2V0SGFuZGxlRm9yRW52aXJvbm1lbnQoQ29tcGFjdFZhcmlhYmxlRW52aXJv bm1lbnQqIGVudmlyb25tZW50LCBjb25zdCBDb21wYWN0VmFyaWFibGVNYXA6OkhhbmRsZSYgaGFu ZGxlKQorICAgIHsKKyAgICAgICAgYXV0byBhZGRSZXN1bHQgPSBtX2Vudmlyb25tZW50VG9IYW5k bGVNYXAuYWRkKGVudmlyb25tZW50LCBoYW5kbGUpOworICAgICAgICBBU1NFUlRfVU5VU0VEKGFk ZFJlc3VsdCwgYWRkUmVzdWx0LmlzTmV3RW50cnkpOworICAgIH0KKwogcHJpdmF0ZToKICAgICBW TSYgbV92bTsKICAgICBjb25zdCB1aW50OF90KiBtX2Jhc2VBZGRyZXNzOwpAQCAtMjY3LDYgKzI4 MCw3IEBAIHByaXZhdGU6CiAjZW5kaWYKICAgICBIYXNoTWFwPHB0cmRpZmZfdCwgdm9pZCo+IG1f b2Zmc2V0VG9QdHJNYXA7CiAgICAgVmVjdG9yPHN0ZDo6ZnVuY3Rpb248dm9pZCgpPj4gbV9maW5h bGl6ZXJzOworICAgIEhhc2hNYXA8Q29tcGFjdFZhcmlhYmxlRW52aXJvbm1lbnQqLCBDb21wYWN0 VmFyaWFibGVNYXA6OkhhbmRsZT4gbV9lbnZpcm9ubWVudFRvSGFuZGxlTWFwOwogfTsKIAogdGVt cGxhdGU8dHlwZW5hbWUgVD4KQEAgLTkzOCwxNSArOTUyLDE2IEBAIHB1YmxpYzoKICAgICB7CiAg ICAgICAgIGJvb2wgaXNOZXdBbGxvY2F0aW9uOwogICAgICAgICBDb21wYWN0VmFyaWFibGVFbnZp cm9ubWVudCogZW52aXJvbm1lbnQgPSBtX2Vudmlyb25tZW50LmRlY29kZShkZWNvZGVyLCBpc05l d0FsbG9jYXRpb24pOworICAgICAgICBpZiAoIWlzTmV3QWxsb2NhdGlvbikKKyAgICAgICAgICAg IHJldHVybiBkZWNvZGVyLmhhbmRsZUZvckVudmlyb25tZW50KGVudmlyb25tZW50KTsKICAgICAg ICAgYm9vbCBpc05ld0VudHJ5OwogICAgICAgICBDb21wYWN0VmFyaWFibGVNYXA6OkhhbmRsZSBo YW5kbGUgPSBkZWNvZGVyLnZtKCkubV9jb21wYWN0VmFyaWFibGVNYXAtPmdldChlbnZpcm9ubWVu dCwgaXNOZXdFbnRyeSk7Ci0gICAgICAgIGlmICghaXNOZXdBbGxvY2F0aW9uKQotICAgICAgICAg ICAgQVNTRVJUKCFpc05ld0VudHJ5KTsKLSAgICAgICAgZWxzZSBpZiAoIWlzTmV3RW50cnkpIHsK KyAgICAgICAgaWYgKCFpc05ld0VudHJ5KSB7CiAgICAgICAgICAgICBkZWNvZGVyLmFkZEZpbmFs aXplcihbPV0gewogICAgICAgICAgICAgICAgIGRlbGV0ZSBlbnZpcm9ubWVudDsKICAgICAgICAg ICAgIH0pOwogICAgICAgICB9CisgICAgICAgIGRlY29kZXIuc2V0SGFuZGxlRm9yRW52aXJvbm1l bnQoZW52aXJvbm1lbnQsIGhhbmRsZSk7CiAgICAgICAgIHJldHVybiBoYW5kbGU7CiAgICAgfQog Cg==