194931 2019-02-21 20:45:00 -0800 Web Inspector: Remove unused Timeline record selection code path 2019-02-22 10:49:59 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1508864 0 joepeck 2019-02-21 20:45:00 -0800 Remove unused Timeline record selection code path `userSelectRecord` / `timelineOverviewUserSelectedRecord` / `userSelectedRecordFromOverview` are never used. 1508865 1 362690 joepeck 2019-02-21 20:45:27 -0800 Created attachment 362690 [PATCH] Proposed Fix 1509032 2 362690 hi 2019-02-22 10:20:59 -0800 Comment on attachment 362690 [PATCH] Proposed Fix rs=me 1509053 3 362690 commit-queue 2019-02-22 10:46:39 -0800 Comment on attachment 362690 [PATCH] Proposed Fix Clearing flags on attachment: 362690 Committed r241953: <https://trac.webkit.org/changeset/241953> 1509054 4 commit-queue 2019-02-22 10:46:40 -0800 All reviewed patches have been landed. Closing bug. 1509057 5 webkit-bug-importer 2019-02-22 10:49:59 -0800 <rdar://problem/48316393> 362690 2019-02-21 20:45:27 -0800 2019-02-22 10:46:39 -0800 [PATCH] Proposed Fix unused-1.patch text/plain 4986 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGU2NjI5YWEzYzdlLi44NWIwZDg0ODczOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDItMjEgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBSZW1vdmUgdW51c2VkIFRpbWVsaW5lIHJlY29yZCBzZWxlY3Rpb24gY29kZSBwYXRoCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ5MzEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvVmlld3MvVGltZWxpbmVPdmVydmlldy5qczoKKyAgICAgICAgKFdJLlRpbWVsaW5lT3ZlcnZp ZXcpOgorICAgICAgICAoV0kuVGltZWxpbmVPdmVydmlldy5wcm90b3R5cGUudXNlclNlbGVjdGVk UmVjb3JkKTogRGVsZXRlZC4KKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5l UmVjb3JkaW5nQ29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5UaW1lbGluZVJlY29yZGluZ0Nv bnRlbnRWaWV3KToKKyAgICAgICAgKFdJLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcucHJv dG90eXBlLnRpbWVsaW5lT3ZlcnZpZXdVc2VyU2VsZWN0ZWRSZWNvcmQpOiBEZWxldGVkLgorICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVWaWV3LmpzOgorICAgICAgICAoV0ku VGltZWxpbmVWaWV3LnByb3RvdHlwZS51c2VyU2VsZWN0ZWRSZWNvcmRGcm9tT3ZlcnZpZXcpOiBE ZWxldGVkLgorCiAyMDE5LTAyLTE4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ1BVIFVzYWdlIFRpbWVsaW5lIC0gVGhyZWFk IEJyZWFrZG93bgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVGltZWxpbmVPdmVydmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lT3ZlcnZpZXcuanMKaW5kZXggNWM3OWM2MDhlMzcuLjFj OGI3MDVhZWQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lT3ZlcnZpZXcuanMKQEAgLTI1LDcgKzI1LDcgQEAK IAogV0kuVGltZWxpbmVPdmVydmlldyA9IGNsYXNzIFRpbWVsaW5lT3ZlcnZpZXcgZXh0ZW5kcyBX SS5WaWV3CiB7Ci0gICAgY29uc3RydWN0b3IodGltZWxpbmVSZWNvcmRpbmcsIGRlbGVnYXRlKQor ICAgIGNvbnN0cnVjdG9yKHRpbWVsaW5lUmVjb3JkaW5nKQogICAgIHsKICAgICAgICAgc3VwZXIo KTsKIApAQCAtNDYsOCArNDYsNiBAQCBXSS5UaW1lbGluZU92ZXJ2aWV3ID0gY2xhc3MgVGltZWxp bmVPdmVydmlldyBleHRlbmRzIFdJLlZpZXcKICAgICAgICAgdGhpcy5fcmVjb3JkaW5nLmFkZEV2 ZW50TGlzdGVuZXIoV0kuVGltZWxpbmVSZWNvcmRpbmcuRXZlbnQuTWFya2VyQWRkZWQsIHRoaXMu X21hcmtlckFkZGVkLCB0aGlzKTsKICAgICAgICAgdGhpcy5fcmVjb3JkaW5nLmFkZEV2ZW50TGlz dGVuZXIoV0kuVGltZWxpbmVSZWNvcmRpbmcuRXZlbnQuUmVzZXQsIHRoaXMuX3JlY29yZGluZ1Jl c2V0LCB0aGlzKTsKIAotICAgICAgICB0aGlzLl9kZWxlZ2F0ZSA9IGRlbGVnYXRlOwotCiAgICAg ICAgIHRoaXMuZWxlbWVudC5jbGFzc0xpc3QuYWRkKCJ0aW1lbGluZS1vdmVydmlldyIpOwogICAg ICAgICB0aGlzLl91cGRhdGVXaGVlbEFuZEdlc3R1cmVIYW5kbGVycygpOwogCkBAIC00MTEsMTIg KzQwOSw2IEBAIFdJLlRpbWVsaW5lT3ZlcnZpZXcgPSBjbGFzcyBUaW1lbGluZU92ZXJ2aWV3IGV4 dGVuZHMgV0kuVmlldwogICAgICAgICBvdmVydmlld0dyYXBoLnNlbGVjdGVkUmVjb3JkID0gcmVj b3JkOwogICAgIH0KIAotICAgIHVzZXJTZWxlY3RlZFJlY29yZChyZWNvcmQpCi0gICAgewotICAg ICAgICBpZiAodGhpcy5fZGVsZWdhdGUgJiYgdGhpcy5fZGVsZWdhdGUudGltZWxpbmVPdmVydmll d1VzZXJTZWxlY3RlZFJlY29yZCkKLSAgICAgICAgICAgIHRoaXMuX2RlbGVnYXRlLnRpbWVsaW5l T3ZlcnZpZXdVc2VyU2VsZWN0ZWRSZWNvcmQodGhpcywgcmVjb3JkKTsKLSAgICB9Ci0KICAgICB1 cGRhdGVMYXlvdXRJZk5lZWRlZChsYXlvdXRSZWFzb24pCiAgICAgewogICAgICAgICBpZiAodGhp cy5sYXlvdXRQZW5kaW5nKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250 ZW50Vmlldy5qcwppbmRleCA0YzcwNTA1OTI2Yi4uYTZkMTA2NmE5MzMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5n Q29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcwpAQCAtMzQsNyArMzQsNyBAQCBX SS5UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3ID0gY2xhc3MgVGltZWxpbmVSZWNvcmRpbmdD b250ZW50VmlldyBleHRlbmRzIFdJLgogCiAgICAgICAgIHRoaXMuZWxlbWVudC5jbGFzc0xpc3Qu YWRkKCJ0aW1lbGluZS1yZWNvcmRpbmciKTsKIAotICAgICAgICB0aGlzLl90aW1lbGluZU92ZXJ2 aWV3ID0gbmV3IFdJLlRpbWVsaW5lT3ZlcnZpZXcodGhpcy5fcmVjb3JkaW5nLCB0aGlzKTsKKyAg ICAgICAgdGhpcy5fdGltZWxpbmVPdmVydmlldyA9IG5ldyBXSS5UaW1lbGluZU92ZXJ2aWV3KHRo aXMuX3JlY29yZGluZyk7CiAgICAgICAgIHRoaXMuX3RpbWVsaW5lT3ZlcnZpZXcuYWRkRXZlbnRM aXN0ZW5lcihXSS5UaW1lbGluZU92ZXJ2aWV3LkV2ZW50LlRpbWVSYW5nZVNlbGVjdGlvbkNoYW5n ZWQsIHRoaXMuX3RpbWVSYW5nZVNlbGVjdGlvbkNoYW5nZWQsIHRoaXMpOwogICAgICAgICB0aGlz Ll90aW1lbGluZU92ZXJ2aWV3LmFkZEV2ZW50TGlzdGVuZXIoV0kuVGltZWxpbmVPdmVydmlldy5F dmVudC5SZWNvcmRTZWxlY3RlZCwgdGhpcy5fcmVjb3JkU2VsZWN0ZWQsIHRoaXMpOwogICAgICAg ICB0aGlzLl90aW1lbGluZU92ZXJ2aWV3LmFkZEV2ZW50TGlzdGVuZXIoV0kuVGltZWxpbmVPdmVy dmlldy5FdmVudC5UaW1lbGluZVNlbGVjdGVkLCB0aGlzLl90aW1lbGluZVNlbGVjdGVkLCB0aGlz KTsKQEAgLTI2MiwyNSArMjYyLDYgQEAgV0kuVGltZWxpbmVSZWNvcmRpbmdDb250ZW50VmlldyA9 IGNsYXNzIFRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcgZXh0ZW5kcyBXSS4KICAgICAgICAg cmV0dXJuIG5ldyBXSS5HZW5lcmFsVHJlZUVsZW1lbnQoaWNvbkNsYXNzTmFtZSwgdGl0bGUsIHJl cHJlc2VudGVkT2JqZWN0LCBoYXNDaGlsZHJlbik7CiAgICAgfQogCi0gICAgLy8gVGltZWxpbmVP dmVydmlldyBkZWxlZ2F0ZQotCi0gICAgdGltZWxpbmVPdmVydmlld1VzZXJTZWxlY3RlZFJlY29y ZCh0aW1lbGluZU92ZXJ2aWV3LCB0aW1lbGluZVJlY29yZCkKLSAgICB7Ci0gICAgICAgIGxldCB0 aW1lbGluZVZpZXdGb3JSZWNvcmQgPSBudWxsOwotICAgICAgICBmb3IgKGxldCB0aW1lbGluZVZp ZXcgb2YgdGhpcy5fdGltZWxpbmVWaWV3TWFwLnZhbHVlcygpKSB7Ci0gICAgICAgICAgICBpZiAo dGltZWxpbmVWaWV3LnJlcHJlc2VudGVkT2JqZWN0LnR5cGUgPT09IHRpbWVsaW5lUmVjb3JkLnR5 cGUpIHsKLSAgICAgICAgICAgICAgICB0aW1lbGluZVZpZXdGb3JSZWNvcmQgPSB0aW1lbGluZVZp ZXc7Ci0gICAgICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KLQot ICAgICAgICBpZiAoIXRpbWVsaW5lVmlld0ZvclJlY29yZCkKLSAgICAgICAgICAgIHJldHVybjsK LQotICAgICAgICB0aGlzLl90aW1lbGluZUNvbnRlbnRCcm93c2VyLnNob3dDb250ZW50Vmlldyh0 aW1lbGluZVZpZXdGb3JSZWNvcmQpOwotICAgICAgICB0aW1lbGluZVZpZXdGb3JSZWNvcmQudXNl clNlbGVjdGVkUmVjb3JkRnJvbU92ZXJ2aWV3KHRpbWVsaW5lUmVjb3JkKTsKLSAgICB9Ci0KICAg ICAvLyBQcml2YXRlCiAKICAgICBfY3VycmVudENvbnRlbnRWaWV3RGlkQ2hhbmdlKGV2ZW50KQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGlt ZWxpbmVWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGltZWxpbmVWaWV3LmpzCmluZGV4IDk3Yjg4OGM3MzlkLi4yMzg0MmYyYzA4NSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVWaWV3 LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVs aW5lVmlldy5qcwpAQCAtMjk1LDExICsyOTUsNiBAQCBXSS5UaW1lbGluZVZpZXcgPSBjbGFzcyBU aW1lbGluZVZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogCiAgICAgLy8gUHJvdGVjdGVkCiAK LSAgICB1c2VyU2VsZWN0ZWRSZWNvcmRGcm9tT3ZlcnZpZXcodGltZWxpbmVSZWNvcmQpCi0gICAg ewotICAgICAgICAvLyBJbXBsZW1lbnRlZCBieSBzdWItY2xhc3NlcyBpZiBuZWVkZWQuCi0gICAg fQotCiAgICAgZmlsdGVyRGlkQ2hhbmdlKCkKICAgICB7CiAgICAgICAgIC8vIEltcGxlbWVudGVk IGJ5IHN1Yi1jbGFzc2VzIGlmIG5lZWRlZC4K