194919 2019-02-21 14:11:57 -0800 webkitpy: Forward HOME to XPC processes 2019-03-07 14:14:56 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 1 jbedard jbedard ap ews-watchlist glenn lforschler oldest_to_newest 1508662 0 jbedard 2019-02-21 14:11:57 -0800 I think we should be forwarding the HOME environment variable child XPC processes, although I need to do a bit more testing to verify. 1508663 1 jbedard 2019-02-21 14:12:41 -0800 <rdar://problem/48135951> 1508665 2 362643 jbedard 2019-02-21 14:15:55 -0800 Created attachment 362643 Patch 1508702 3 362643 ap 2019-02-21 15:30:52 -0800 Comment on attachment 362643 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362643&action=review > Tools/Scripts/webkitpy/port/driver.py:415 > + environment['__XPC_HOME'] = environment.get('HOME') I don't understand why this became necessary now. Did you reproduce the problem, and see it fixed with this change? Even if so, we probably need better understanding of the problem than what I saw documented yet. 1508747 4 jbedard 2019-02-21 16:40:13 -0800 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 362643 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=362643&action=review > > > Tools/Scripts/webkitpy/port/driver.py:415 > > + environment['__XPC_HOME'] = environment.get('HOME') > > I don't understand why this became necessary now. > > Did you reproduce the problem, and see it fixed with this change? Even if > so, we probably need better understanding of the problem than what I saw > documented yet. Sorry, no, I have not yet been able to reproduce the problem. I just wanted to draft the patch, I didn't intend to put it up for review yet, actually. 1513708 5 jbedard 2019-03-07 14:14:37 -0800 Upon further investigation, this change is not needed. Closing this bug. 362643 2019-02-21 14:15:55 -0800 2019-02-21 16:39:35 -0800 Patch bug-194919-20190221141554.patch text/plain 1395 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MTkwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAyLTIxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogRm9yd2FyZCBIT01FIHRvIFhQQyBwcm9jZXNzZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDkxOQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNDgxMzU5NTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5 OgorICAgICAgICAoRHJpdmVyLl9zZXR1cF9lbnZpcm9uX2Zvcl9kcml2ZXIpOiBFeHBvcnQgSE9N RSB0byBYUEMgcHJvY2Vzc2VzCisKIDIwMTktMDItMjEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hv cnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggdW5kZXIgUmVtb3RlTGF5ZXJUcmVlUHJv cGVydHlBcHBsaWVyOjphcHBseVByb3BlcnRpZXMgd2hlbiByZWF0dGFjaGluZyB0byBvbGQgcHJv Y2VzcwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlci5weQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5CShyZXZpc2lvbiAy NDE4NzUpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5CSh3b3JraW5n IGNvcHkpCkBAIC00MTIsNiArNDEyLDggQEAgY2xhc3MgRHJpdmVyKG9iamVjdCk6CiAgICAgICAg IGVudmlyb25tZW50WydTUUxJVEVfRVhFTVBUX1BBVEhfRlJPTV9WTk9ERV9HVUFSRFMnXSA9IG9z LnBhdGgucmVhbHBhdGgoZW52aXJvbm1lbnRbJ0RVTVBSRU5ERVJUUkVFX1RFTVAnXSkKICAgICAg ICAgZW52aXJvbm1lbnRbJ19fWFBDX1NRTElURV9FWEVNUFRfUEFUSF9GUk9NX1ZOT0RFX0dVQVJE UyddID0gZW52aXJvbm1lbnRbJ1NRTElURV9FWEVNUFRfUEFUSF9GUk9NX1ZOT0RFX0dVQVJEUydd CiAKKyAgICAgICAgZW52aXJvbm1lbnRbJ19fWFBDX0hPTUUnXSA9IGVudmlyb25tZW50LmdldCgn SE9NRScpCisKICAgICAgICAgaWYgc2VsZi5fcHJvZmlsZXI6CiAgICAgICAgICAgICBlbnZpcm9u bWVudCA9IHNlbGYuX3Byb2ZpbGVyLmFkanVzdGVkX2Vudmlyb25tZW50KGVudmlyb25tZW50KQog ICAgICAgICByZXR1cm4gZW52aXJvbm1lbnQK