194918 2019-02-21 13:55:49 -0800 Web Inspector: REGRESSION: TreeElement or Table row selected using the keyboard should always be revealed 2019-02-25 14:23:03 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1508655 0 mattbaker 2019-02-21 13:55:49 -0800 Summary: TreeElement or Table row selected using the keyboard should always be revealed. Steps to Reproduce: 1. Inspect a site with Cookies 2. Open Storage tab 3. Vertically resize Web Inspector (docked or undocked) such that some cookies are scrolled outside the view 4. Select the first cookie 5. Repeatedly press down arrow key, until the selection moves outside the view Expected: => Selection scrolls into view Actual: => Selected item is outside the view 1508656 1 webkit-bug-importer 2019-02-21 13:56:19 -0800 <rdar://problem/48289314> 1508657 2 362641 mattbaker 2019-02-21 13:57:20 -0800 Created attachment 362641 Patch 1509775 3 362641 hi 2019-02-25 13:57:20 -0800 Comment on attachment 362641 Patch r=me 1509781 4 362641 commit-queue 2019-02-25 14:23:01 -0800 Comment on attachment 362641 Patch Clearing flags on attachment: 362641 Committed r242057: <https://trac.webkit.org/changeset/242057> 1509782 5 commit-queue 2019-02-25 14:23:03 -0800 All reviewed patches have been landed. Closing bug. 362641 2019-02-21 13:57:20 -0800 2019-02-25 14:23:01 -0800 Patch bug-194918-20190221135720.patch text/plain 2626 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxODc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm Y2U3YTNlODZiOTQzMTcwMzc1MjcxODk3NzA3NDJhNDM5Njk4ODgxLi4zMmM5ZDQ5ZDhkZTA0MDBk ZmRlNTVmYTQ5ZWE0MTUzNGVjZTE0MDE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wMi0yMSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTjogVHJlZUVsZW1lbnQgb3IgVGFi bGUgcm93IHNlbGVjdGVkIHVzaW5nIHRoZSBrZXlib2FyZCBzaG91bGQgYWx3YXlzIGJlIHJldmVh bGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ5 MTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4Mjg5MzE0PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJs ZS5qczoKKyAgICAgICAgKFdJLlRhYmxlLnByb3RvdHlwZS5zZWxlY3Rpb25Db250cm9sbGVyU2Vs ZWN0aW9uRGlkQ2hhbmdlKToKKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVHJlZU91 dGxpbmUuanM6CisgICAgICAgIChXSS5UcmVlT3V0bGluZS5wcm90b3R5cGUuX3RyZWVLZXlEb3du KToKKwogMjAxOS0wMi0yMSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogQ2FudmFzOiByZWNvcmRpbmdzIHdpdGggYSBzaW5nbGUgZnJh bWUgc29tZXRpbWVzIG1pc3NpbmcgVHJlZUVsZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanMKaW5kZXggMDYyOGY0ODEzZDkxNTQ1 ZmNmNWMyODM3OGE4NTRmMWEzMTE0YzU0Ny4uNjhkZjkzNWI3ZGM0ZDMyMzM2YTlmYTM5ZWEyNjE5 OWFmN2UwNTlkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVGFibGUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVGFibGUuanMKQEAgLTYxOSwxMCArNjE5LDkgQEAgV0kuVGFibGUgPSBjbGFzcyBU YWJsZSBleHRlbmRzIFdJLlZpZXcKICAgICAgICAgICAgICAgICByb3cuY2xhc3NMaXN0LnRvZ2ds ZSgic2VsZWN0ZWQiLCB0cnVlKTsKICAgICAgICAgfQogCi0gICAgICAgIGlmIChzZWxlY3RlZEl0 ZW1zLnNpemUgPT09IDEpIHsKLSAgICAgICAgICAgIGxldCByb3dJbmRleCA9IHRoaXMuX2luZGV4 Rm9yUmVwcmVzZW50ZWRPYmplY3Qoc2VsZWN0ZWRJdGVtcy5maXJzdFZhbHVlKTsKLSAgICAgICAg ICAgIGlmICghdGhpcy5faXNSb3dWaXNpYmxlKHJvd0luZGV4KSkKLSAgICAgICAgICAgICAgICB0 aGlzLnJldmVhbFJvdyhyb3dJbmRleCk7CisgICAgICAgIGlmICh0aGlzLl9zZWxlY3Rpb25Db250 cm9sbGVyLmxhc3RTZWxlY3RlZEl0ZW0pIHsKKyAgICAgICAgICAgIGxldCByb3dJbmRleCA9IHRo aXMuX2luZGV4Rm9yUmVwcmVzZW50ZWRPYmplY3QodGhpcy5fc2VsZWN0aW9uQ29udHJvbGxlci5s YXN0U2VsZWN0ZWRJdGVtKTsKKyAgICAgICAgICAgIHRoaXMucmV2ZWFsUm93KHJvd0luZGV4KTsK ICAgICAgICAgfQogCiAgICAgICAgIGlmICh0aGlzLl9kZWxlZ2F0ZS50YWJsZVNlbGVjdGlvbkRp ZENoYW5nZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RyZWVPdXRsaW5lLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVHJlZU91dGxpbmUuanMKaW5kZXggOTgxNTllNzljYzk3NzJlMjIyYjBmNWQ4OGUx MmJmZjE2NWViYWMzMC4uMzQ0Y2NiMjk4MzVlMWIxYmFiYjczYmIyNGU3ZjI2YmVhYTM1MjBhYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVHJl ZU91dGxpbmUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVHJlZU91dGxpbmUuanMKQEAgLTY2MCw2ICs2NjAsOSBAQCBXSS5UcmVlT3V0bGluZSA9IGNs YXNzIFRyZWVPdXRsaW5lIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAgICB0aGlzLl9pdGVt V2FzU2VsZWN0ZWRCeVVzZXIgPSB0cnVlOwogICAgICAgICAgICAgaGFuZGxlZCA9IHRoaXMuX3Nl bGVjdGlvbkNvbnRyb2xsZXIuaGFuZGxlS2V5RG93bihldmVudCk7CiAgICAgICAgICAgICB0aGlz Ll9pdGVtV2FzU2VsZWN0ZWRCeVVzZXIgPSBmYWxzZTsKKworICAgICAgICAgICAgaWYgKGhhbmRs ZWQpCisgICAgICAgICAgICAgICAgbmV4dFNlbGVjdGVkRWxlbWVudCA9IHRoaXMuc2VsZWN0ZWRU cmVlRWxlbWVudDsKICAgICAgICAgfQogCiAgICAgICAgIGlmIChuZXh0U2VsZWN0ZWRFbGVtZW50 KSB7Cg==