194917 2019-02-21 13:54:19 -0800 build-dumprendertree, build-webkittestrunner: Build WebCore test support libraries 2022-02-09 10:14:42 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 jbedard jbedard ap dbates lforschler webkit-bug-importer oldest_to_newest 1508651 0 jbedard 2019-02-21 13:54:19 -0800 build-dumprendertree and build-webkittestrunner should both build WebCore test support libraries. 1508653 1 jbedard 2019-02-21 13:55:02 -0800 <rdar://problem/48278600> 1508654 2 362640 jbedard 2019-02-21 13:55:46 -0800 Created attachment 362640 Patch 1508755 3 dbates 2019-02-21 16:52:13 -0800 Patch doesn’t look right. Why only for Cocoa platforms? Why doing it after we build drt or wktr? 1508756 4 dbates 2019-02-21 16:53:15 -0800 Why change directories? 1508757 5 ap 2019-02-21 16:54:35 -0800 Why is this useful? As these libraries are built together with WebCore, I expect them to always be present. I’m probably missing some context here. 1508775 6 jbedard 2019-02-21 17:12:39 -0800 (In reply to Daniel Bates from comment #3) > Patch doesn’t look right. Why only for Cocoa platforms? Why doing it after > we build drt or wktr? Read the whole file. Other platforms, to quote the existing comment, "# GTK+, WPE, PlayStation, and Windows build everything in one shot. No need to build anything here." 1508817 7 dbates 2019-02-21 18:59:31 -0800 (In reply to Daniel Bates from comment #3) > Why only for Cocoa platforms? By comment 6. > Why doing it after we build drt or wktr? Still unanswered. 1508818 8 dbates 2019-02-21 19:00:30 -0800 (In reply to Daniel Bates from comment #4) > Why change directories? Okay, read more of the existing code. Answer, that’s how it’s done. The build...() seems to assume you’re in the same directory as the Xcode project. 1508820 9 dbates 2019-02-21 19:01:03 -0800 (In reply to Alexey Proskuryakov from comment #5) > Why is this useful? As these libraries are built together with WebCore, I > expect them to always be present. > > I’m probably missing some context here. Read radar. 1508821 10 dbates 2019-02-21 19:03:02 -0800 Actually Alexy’s question adds to my feeling that this patch doesn’t look right because this problem is only hit for Apple engineers hence the radar description. So, this fix seems misplaced. 1508999 11 jbedard 2019-02-22 08:31:59 -0800 So, either something very similar to this patch is the fix, or this isn't a bug. We run build-webkittestrunner right before running tests, by default. We don't make an attempt to build the entire WebKit stack, we never have nor should we (A no-op build of WebKit through build-webkit actually takes ~30 seconds-1 minute). Apparently there is a workflow where WebCore can be built without building the WebCore test support libraries. 1509006 12 dbates 2019-02-22 08:54:51 -0800 (In reply to Jonathan Bedard from comment #11) > So, either something very similar to this patch is the fix, or this isn't a > bug. > > We run build-webkittestrunner right before running tests, by default. We > don't make an attempt to build the entire WebKit stack, we never have nor > should we (A no-op build of WebKit through build-webkit actually takes ~30 > seconds-1 minute). > Apparently there is a workflow where WebCore can be built > without building the WebCore test support libraries. This is the bug! It’s an Apple Internal thing. Fix this! 1509007 13 dbates 2019-02-22 08:56:52 -0800 This Bugzilla bug is invalid. The radar bug is valid. 1509008 14 362724 jbedard 2019-02-22 08:57:54 -0800 Created attachment 362724 Patch 362640 2019-02-21 13:55:46 -0800 2019-02-22 08:57:53 -0800 Patch bug-194917-20190221135545.patch text/plain 2459 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MTkwMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAyLTIxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBidWlsZC1kdW1wcmVuZGVydHJlZSwgYnVpbGQtd2Via2l0dGVzdHJ1bm5l cjogQnVpbGQgV2ViQ29yZSB0ZXN0IHN1cHBvcnQgbGlicmFyaWVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ5MTcKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQ4Mjc4NjAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogU2NyaXB0cy9idWlsZC1kdW1wcmVuZGVydHJlZTogQnVpbGQgV2ViQ29yZVRl c3RTdXBwb3J0IGFuZCBXZWJDb3JlVGVzdFNoaW0uCisgICAgICAgICogU2NyaXB0cy9idWlsZC13 ZWJraXR0ZXN0cnVubmVyOiBEaXR0by4KKwogMjAxOS0wMi0yMSAgVGltIEhvcnRvbiAgPHRpbW90 aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaCB1bmRlciBSZW1vdGVMYXllclRy ZWVQcm9wZXJ0eUFwcGxpZXI6OmFwcGx5UHJvcGVydGllcyB3aGVuIHJlYXR0YWNoaW5nIHRvIG9s ZCBwcm9jZXNzCkluZGV4OiBUb29scy9TY3JpcHRzL2J1aWxkLWR1bXByZW5kZXJ0cmVlCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvYnVpbGQtZHVtcHJlbmRlcnRyZWUJKHJldmlzaW9uIDI0 MTg3NSkKKysrIFRvb2xzL1NjcmlwdHMvYnVpbGQtZHVtcHJlbmRlcnRyZWUJKHdvcmtpbmcgY29w eSkKQEAgLTY2LDYgKzY2LDEwIEBAIGNoZGlyIEZpbGU6OlNwZWMtPmNhdGRpcigiVG9vbHMiLCAi RHVtcFIKIG15ICRyZXN1bHQ7CiBpZiAoaXNBcHBsZUNvY29hV2ViS2l0KCkpIHsKICAgICAkcmVz dWx0ID0gYnVpbGRYQ29kZVByb2plY3QoIkR1bXBSZW5kZXJUcmVlIiwgJGNsZWFuLCBYY29kZU9w dGlvbnMoKSwgQEFSR1YpOworICAgIGV4aXQgZXhpdFN0YXR1cygkcmVzdWx0KSBpZiAoZXhpdFN0 YXR1cygkcmVzdWx0KSk7CisKKyAgICBjaGRpciBGaWxlOjpTcGVjLT5jYXRkaXIoIi4uIiwgIi4u IiwgIlNvdXJjZSIsICJXZWJDb3JlIikgb3IgZGllOworICAgICRyZXN1bHQgPSBidWlsZFhDb2Rl UHJvamVjdCgiV2ViQ29yZSIsICRjbGVhbiwgWGNvZGVPcHRpb25zKCksIChAQVJHViwgIi10YXJn ZXQiLCAiV2ViQ29yZVRlc3RTdXBwb3J0IiwgIi10YXJnZXQiLCAiV2ViQ29yZVRlc3RTaGltIikp OwogfSBlbHNpZiAoaXNHdGsoKSB8fCBpc1dQRSgpIHx8IGlzQW55V2luZG93cygpKSB7CiAgICAg IyBHVEssIFdQRSBhbmQgV2luZG93cyBidWlsZCBldmVyeXRoaW5nIGluIG9uZSBzaG90LiBObyBu ZWVkIHRvIGJ1aWxkIGFueXRoaW5nIGhlcmUuCiAgICAgJHJlc3VsdCA9IDA7CkluZGV4OiBUb29s cy9TY3JpcHRzL2J1aWxkLXdlYmtpdHRlc3RydW5uZXIKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2Ny aXB0cy9idWlsZC13ZWJraXR0ZXN0cnVubmVyCShyZXZpc2lvbiAyNDE4NzUpCisrKyBUb29scy9T Y3JpcHRzL2J1aWxkLXdlYmtpdHRlc3RydW5uZXIJKHdvcmtpbmcgY29weSkKQEAgLTYyLDYgKzYy LDEwIEBAIGNoZGlyICJUb29scy9XZWJLaXRUZXN0UnVubmVyIiBvciBkaWU7CiBteSAkcmVzdWx0 OwogaWYgKGlzQXBwbGVDb2NvYVdlYktpdCgpKSB7CiAgICAgJHJlc3VsdCA9IGJ1aWxkWENvZGVQ cm9qZWN0KCJXZWJLaXRUZXN0UnVubmVyIiwgJGNsZWFuLCBYY29kZU9wdGlvbnMoKSwgQEFSR1Yp OworICAgIGV4aXQgZXhpdFN0YXR1cygkcmVzdWx0KSBpZiAoZXhpdFN0YXR1cygkcmVzdWx0KSk7 CisKKyAgICBjaGRpciBGaWxlOjpTcGVjLT5jYXRkaXIoIi4uIiwgIi4uIiwgIlNvdXJjZSIsICJX ZWJDb3JlIikgb3IgZGllOworICAgICRyZXN1bHQgPSBidWlsZFhDb2RlUHJvamVjdCgiV2ViQ29y ZSIsICRjbGVhbiwgWGNvZGVPcHRpb25zKCksIChAQVJHViwgIi10YXJnZXQiLCAiV2ViQ29yZVRl c3RTdXBwb3J0IiwgIi10YXJnZXQiLCAiV2ViQ29yZVRlc3RTaGltIikpOwogfSBlbHNpZiAoaXNH dGsoKSB8fCBpc1dQRSgpIHx8IGlzUGxheVN0YXRpb24oKSB8fCBpc0FueVdpbmRvd3MoKSkgewog ICAgICMgR1RLKywgV1BFLCBQbGF5U3RhdGlvbiwgYW5kIFdpbmRvd3MgYnVpbGQgZXZlcnl0aGlu ZyBpbiBvbmUgc2hvdC4gTm8gbmVlZCB0byBidWlsZCBhbnl0aGluZyBoZXJlLgogICAgICRyZXN1 bHQgPSAwOwo= 362724 2019-02-22 08:57:54 -0800 2019-02-22 08:59:47 -0800 Patch bug-194917-20190222085754.patch text/plain 2709 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MTkyNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAyLTIxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBidWlsZC1kdW1wcmVuZGVydHJlZSwgYnVpbGQtd2Via2l0dGVzdHJ1bm5l cjogQnVpbGQgV2ViQ29yZSB0ZXN0IHN1cHBvcnQgbGlicmFyaWVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ5MTcKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQ4Mjc4NjAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogU2NyaXB0cy9idWlsZC1kdW1wcmVuZGVydHJlZTogQnVpbGQgV2ViQ29yZVRl c3RTdXBwb3J0IGFuZCBXZWJDb3JlVGVzdFNoaW0uCisgICAgICAgICogU2NyaXB0cy9idWlsZC13 ZWJraXR0ZXN0cnVubmVyOiBEaXR0by4KKwogMjAxOS0wMi0yMSAgRGF2aWQgS2lsemVyICA8ZGRr aWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIExlYWsgb2YgQ0ZFcnJvclJlZiBvYmplY3RzICgx LjkyIEtieXRlcykgaW4gY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LkRldmVsb3BtZW50IHJ1 bm5pbmcgV2ViS2l0IGxheW91dCB0ZXN0cyBvbiBpT1MgU2ltdWxhdG9yCkluZGV4OiBUb29scy9T Y3JpcHRzL2J1aWxkLWR1bXByZW5kZXJ0cmVlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMv YnVpbGQtZHVtcHJlbmRlcnRyZWUJKHJldmlzaW9uIDI0MTkyNCkKKysrIFRvb2xzL1NjcmlwdHMv YnVpbGQtZHVtcHJlbmRlcnRyZWUJKHdvcmtpbmcgY29weSkKQEAgLTYxLDExICs2MSwxMSBAQCBz ZXRDb25maWd1cmF0aW9uKCk7CiBjaGRpcldlYktpdCgpOwogCiAjIEJ1aWxkCi1jaGRpciBGaWxl OjpTcGVjLT5jYXRkaXIoIlRvb2xzIiwgIkR1bXBSZW5kZXJUcmVlIikgb3IgZGllOwotCiBteSAk cmVzdWx0OwogaWYgKGlzQXBwbGVDb2NvYVdlYktpdCgpKSB7Ci0gICAgJHJlc3VsdCA9IGJ1aWxk WENvZGVQcm9qZWN0KCJEdW1wUmVuZGVyVHJlZSIsICRjbGVhbiwgWGNvZGVPcHRpb25zKCksIEBB UkdWKTsKKyAgICAkcmVzdWx0ID0gYnVpbGRYQ29kZVByb2plY3QoIlNvdXJjZS9XZWJDb3JlL1dl YkNvcmUiLCAkY2xlYW4sIFhjb2RlT3B0aW9ucygpLCAoQEFSR1YsICItdGFyZ2V0IiwgIldlYkNv cmVUZXN0U3VwcG9ydCIsICItdGFyZ2V0IiwgIldlYkNvcmVUZXN0U2hpbSIpKTsKKyAgICBleGl0 IGV4aXRTdGF0dXMoJHJlc3VsdCkgaWYgKGV4aXRTdGF0dXMoJHJlc3VsdCkpOworICAgICRyZXN1 bHQgPSBidWlsZFhDb2RlUHJvamVjdCgiVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRy ZWUiLCAkY2xlYW4sIFhjb2RlT3B0aW9ucygpLCBAQVJHVik7CiB9IGVsc2lmIChpc0d0aygpIHx8 IGlzV1BFKCkgfHwgaXNBbnlXaW5kb3dzKCkpIHsKICAgICAjIEdUSywgV1BFIGFuZCBXaW5kb3dz IGJ1aWxkIGV2ZXJ5dGhpbmcgaW4gb25lIHNob3QuIE5vIG5lZWQgdG8gYnVpbGQgYW55dGhpbmcg aGVyZS4KICAgICAkcmVzdWx0ID0gMDsKSW5kZXg6IFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0 dGVzdHJ1bm5lcgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdHRlc3Ry dW5uZXIJKHJldmlzaW9uIDI0MTkyNCkKKysrIFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0dGVz dHJ1bm5lcgkod29ya2luZyBjb3B5KQpAQCAtNTcsMTEgKzU3LDExIEBAIHNldENvbmZpZ3VyYXRp b24oKTsKIGNoZGlyV2ViS2l0KCk7CiAKICMgQnVpbGQKLWNoZGlyICJUb29scy9XZWJLaXRUZXN0 UnVubmVyIiBvciBkaWU7Ci0KIG15ICRyZXN1bHQ7CiBpZiAoaXNBcHBsZUNvY29hV2ViS2l0KCkp IHsKLSAgICAkcmVzdWx0ID0gYnVpbGRYQ29kZVByb2plY3QoIldlYktpdFRlc3RSdW5uZXIiLCAk Y2xlYW4sIFhjb2RlT3B0aW9ucygpLCBAQVJHVik7CisgICAgJHJlc3VsdCA9IGJ1aWxkWENvZGVQ cm9qZWN0KCJTb3VyY2UvV2ViQ29yZS9XZWJDb3JlIiwgJGNsZWFuLCBYY29kZU9wdGlvbnMoKSwg KEBBUkdWLCAiLXRhcmdldCIsICJXZWJDb3JlVGVzdFN1cHBvcnQiLCAiLXRhcmdldCIsICJXZWJD b3JlVGVzdFNoaW0iKSk7CisgICAgZXhpdCBleGl0U3RhdHVzKCRyZXN1bHQpIGlmIChleGl0U3Rh dHVzKCRyZXN1bHQpKTsKKyAgICAkcmVzdWx0ID0gYnVpbGRYQ29kZVByb2plY3QoIlRvb2xzL1dl YktpdFRlc3RSdW5uZXIvV2ViS2l0VGVzdFJ1bm5lciIsICRjbGVhbiwgWGNvZGVPcHRpb25zKCks IEBBUkdWKTsKIH0gZWxzaWYgKGlzR3RrKCkgfHwgaXNXUEUoKSB8fCBpc1BsYXlTdGF0aW9uKCkg fHwgaXNBbnlXaW5kb3dzKCkpIHsKICAgICAjIEdUSyssIFdQRSwgUGxheVN0YXRpb24sIGFuZCBX aW5kb3dzIGJ1aWxkIGV2ZXJ5dGhpbmcgaW4gb25lIHNob3QuIE5vIG5lZWQgdG8gYnVpbGQgYW55 dGhpbmcgaGVyZS4KICAgICAkcmVzdWx0ID0gMDsK