194905 2019-02-21 10:07:05 -0800 [Win] Implement Minibrowser without WebKitLegacy support 2023-02-15 13:22:14 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 252131 P2 Normal --- 235959 194904 1 don.olmstead ysuzuki annulen darin ews-watchlist fujii gyuyoung.kim lforschler ryuan.choi sergio ysuzuki oldest_to_newest 1508556 0 don.olmstead 2019-02-21 10:07:05 -0800 Minibrowser on Windows currently requires WebKitLegacy support. This should not be the case. 1830505 1 449041 ysuzuki 2022-01-13 03:42:56 -0800 Created attachment 449041 Patch 1830506 2 ysuzuki 2022-01-13 03:44:32 -0800 WebKitLegacy and DumpRenderTree has many CF code. So, disabling it makes it easy to replace remaining CF things with generic implementation, and we can drop CFLite more easily. 1830610 3 don.olmstead 2022-01-13 10:22:31 -0800 (In reply to Yusuke Suzuki from comment #2) > WebKitLegacy and DumpRenderTree has many CF code. So, disabling it makes it > easy to replace remaining CF things with generic implementation, and we can > drop CFLite more easily. I am all for doing just that, and have some WIP code lying around that tries to remove more CF code, BUT before we can land this we for sure need to move the testing from Legacy to Modern WebKit. 1830671 4 fujii 2022-01-13 12:45:04 -0800 Yusuke, I'm surprised you are proposing a patch for this. Do you have a concrete problem if WinCairo is still using CFLite? AppleWin is still using WK1. And, no one is actively working on it these days. With WinCairo WK1, it's easy to maintain WK1 part for WinCairo developers. For example, Bug 234503 and Bug 234504. We should have a WinCairo WK2 testing buildbot and fix more test failures and make the tests stable enough before removing WinCairo WK1. Because removing WinCairo WK1 isn't high priority. no one have been working on it. 1831319 5 449041 fujii 2022-01-16 12:14:17 -0800 Comment on attachment 449041 Patch cq-. Don't land this patch until WinCairo has WK2 testing buildbot. 1933939 6 fujii 2023-02-15 13:22:14 -0800 *** This bug has been marked as a duplicate of bug 252131 *** 449041 2022-01-13 03:42:56 -0800 2022-01-16 12:14:17 -0800 Patch bug-194905-20220113034255.patch text/plain 1278 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3OTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc1dpbkNhaXJvLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNXaW5DYWlyby5jbWFrZQpp bmRleCA1NGRjMDk1ZDlmOThjZjAxMTZhNzA0ZTk5ZTg4MzMzZjExMDhjOGEwLi4xOTUzNTkxYmI0 NDEyY2FkYWZmNmY0NGRlZGM1Y2Q2NWJjZWZjYmJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Uv T3B0aW9uc1dpbkNhaXJvLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luQ2Fpcm8u Y21ha2UKQEAgLTEsOSArMSw4IEBACiBzZXQoV1RGX1BMQVRGT1JNX1dJTl9DQUlSTyAxKQogCi1p bmNsdWRlKE9wdGlvbnNXaW4pCi0KLSMgVE9ETzogTW92ZSB0aGlzIGFib3ZlIE9wdGlvbnNXaW4g d2hlbiBXZWJLaXRMZWdhY3kgaXMgZGVwcmVjYXRlZAorc2V0KEVOQUJMRV9XRUJLSVRfTEVHQUNZ IE9GRikKIHNldChFTkFCTEVfV0VCS0lUIE9OKQoraW5jbHVkZShPcHRpb25zV2luKQogCiBmaW5k X3BhY2thZ2UoQ2Fpcm8gMS4xNS4xMiBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShDVVJMIDcuNzcu MCBSRVFVSVJFRCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAxOGEx OGVjNjljZTdkY2IxODAyOTlhYTk5ZWIwMGRkM2JjOTZjZjBiLi44ODlmNjYwMDhlNDdlYmNlOGE1 MjIzOWYwOGVhNGQ0MmIzY2MxNTkzIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDEtMTMgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtp QGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBJbXBsZW1lbnQgTWluaWJyb3dzZXIgd2l0aG91 dCBXZWJLaXRMZWdhY3kgc3VwcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTk0OTA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQXMgTWluaUJyb3dzZXIgaXMgYWxyZWFkeSBjb25zdHJ1Y3RlZCB3aXRo b3V0IFdlYktpdExlZ2FjeSAoR1RLIG9ubHkgaGFzIFdlYktpdCksCisgICAgICAgIHdlIGNhbiBq dXN0IGRpc2FibGUgV2ViS2l0TGVnYWN5IG9uIFdpbkNhaXJvIGJ1aWxkcy4KKworICAgICAgICAq IFNvdXJjZS9jbWFrZS9PcHRpb25zV2luQ2Fpcm8uY21ha2U6CisKIDIwMjItMDEtMTIgIENocmlz IExvcmQgIDxjbG9yZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIEZpeCBidWlsZGluZyBX ZWJYUiB3aXRoIEFOR0xFIGVuYWJsZWQK