194891 2019-02-20 19:35:15 -0800 [JSC] Remove WatchpointSet creation for SymbolTable entries if VM::canUseJIT() returns false 2019-02-20 22:00:35 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue ews-watchlist ggaren keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1508425 0 ysuzuki 2019-02-20 19:35:15 -0800 [JSC] Remove WatchpointSet creation for SymbolTable entries if VM::canUseJIT() returns false 1508429 1 362584 ysuzuki 2019-02-20 20:32:15 -0800 Created attachment 362584 Patch 1508430 2 362584 ggaren 2019-02-20 20:53:13 -0800 Comment on attachment 362584 Patch r=me 1508446 3 362584 ysuzuki 2019-02-20 21:34:13 -0800 Comment on attachment 362584 Patch Thanks! 1508455 4 362584 commit-queue 2019-02-20 21:59:59 -0800 Comment on attachment 362584 Patch Clearing flags on attachment: 362584 Committed r241862: <https://trac.webkit.org/changeset/241862> 1508456 5 commit-queue 2019-02-20 22:00:00 -0800 All reviewed patches have been landed. Closing bug. 1508457 6 webkit-bug-importer 2019-02-20 22:00:35 -0800 <rdar://problem/48265021> 362584 2019-02-20 20:32:15 -0800 2019-02-20 21:59:59 -0800 Patch bug-194891-20190220203215.patch text/plain 5187 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxODU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk NDdmZDhiMDk5YWRiMjk1ZDlhOTgzY2M1YzVkZWM2ZTZkNDNiMzIxLi5kYWU0YWY2NWE4YTE1ZmZm MzY0ZWRmOGM1ZGFmOTNlYzI1MTdhZjk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOS0wMi0yMCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFJlbW92ZSBXYXRjaHBvaW50U2V0IGNyZWF0aW9uIGZvciBTeW1i b2xUYWJsZSBlbnRyaWVzIGlmIFZNOjpjYW5Vc2VKSVQoKSByZXR1cm5zIGZhbHNlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ4OTEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXYXRjaHBvaW50U2V0IGlu IFN5bWJvbFRhYmxlIGlzIHVzZWQgdG8gZm9sZCB0aGUgdmFsdWUgaW50byBhIGNvbnN0YW50IGlu IEpJVCB0aWVycy4gQW5kIGl0IGlzCisgICAgICAgIG5vdCB1c2VmdWwgdW5kZXIgdGhlIG5vbi1K SVQgbW9kZS4gVGhpcyBwYXRjaCBhdm9pZHMgY3JlYXRpb24gb2YgV2F0Y2hwb2ludFNldCBpbiBT eW1ib2xUYWJsZQorICAgICAgICBpZiBWTTo6Y2FuVXNlSklUKCkgcmV0dXJucyBmYWxzZS4KKwor ICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc206CisgICAgICAgICog bGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbToKKyAgICAgICAgKiBydW50aW1lL1N5bWJv bFRhYmxlLmNwcDoKKyAgICAgICAgKEpTQzo6U3ltYm9sVGFibGVFbnRyeTo6YWRkV2F0Y2hwb2lu dCk6IERlbGV0ZWQuCisgICAgICAgICogcnVudGltZS9TeW1ib2xUYWJsZS5oOgorICAgICAgICAo SlNDOjpTeW1ib2xUYWJsZUVudHJ5Ojppc1dhdGNoYWJsZSBjb25zdCk6CisgICAgICAgIChKU0M6 OlN5bWJvbFRhYmxlRW50cnk6OndhdGNocG9pbnRTZXQpOgorCiAyMDE5LTAyLTIwICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgY29kZSB0byB2YWxpZGF0ZSBl eHBlY3RlZCBHQyBhY3Rpdml0eSBtb2RlbGxlZCBieSBkb2VzR0MoKSBhZ2FpbnN0IHdoYXQgdGhl IHJ1bnRpbWUgZW5jb3VudGVycy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9s bGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KaW5kZXggZmYxY2U1ODY5ZTM2OTFm NDQ0OTk4NjE3MTJkZGRiN2U2ZGNmYjdmMy4uOWJiMTBkMWRkYjAzZjA0OWMzMTE2ODMzOGIzYTQz OGY4NjkyODg1YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xl dmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50 L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KQEAgLTIyNzQsNyArMjI3NCw5IEBAIGxsaW50 T3BXaXRoTWV0YWRhdGEob3BfcHV0X3RvX3Njb3BlLCBPcFB1dFRvU2NvcGUsIG1hY3JvIChzaXpl LCBnZXQsIGRpc3BhdGNoLCBtCiAgICAgICAgIGdldChtX3ZhbHVlLCB0MCkKICAgICAgICAgbG9h ZENvbnN0YW50T3JWYXJpYWJsZShzaXplLCB0MCwgdDEsIHQyKQogICAgICAgICBsb2FkcCBPcFB1 dFRvU2NvcGU6Ok1ldGFkYXRhOjptX3dhdGNocG9pbnRTZXRbdDVdLCB0MworICAgICAgICBidHB6 IHQzLCAubm9WYXJpYWJsZVdhdGNocG9pbnRTZXQKICAgICAgICAgbm90aWZ5V3JpdGUodDMsIC5w RHluYW1pYykKKyAgICAubm9WYXJpYWJsZVdhdGNocG9pbnRTZXQ6CiAgICAgICAgIGxvYWRwIE9w UHV0VG9TY29wZTo6TWV0YWRhdGE6Om1fb3BlcmFuZFt0NV0sIHQwCiAgICAgICAgIHN0b3JlaSB0 MSwgVGFnT2Zmc2V0W3QwXQogICAgICAgICBzdG9yZWkgdDIsIFBheWxvYWRPZmZzZXRbdDBdCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRl cjY0LmFzbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVy NjQuYXNtCmluZGV4IDQ1ODI1NDAxYTc4YjY4MGZhZTBhOGYwOTYyY2RjMzUwMTU5OWFhMWYuLjdi YTk0YjY4YzZjMmRjMzhmYWIxZmM4YjFkNDExMDk5MTQxNzM2MWUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCkBAIC0y MzEwLDggKzIzMTAsMTAgQEAgbGxpbnRPcFdpdGhNZXRhZGF0YShvcF9wdXRfdG9fc2NvcGUsIE9w UHV0VG9TY29wZSwgbWFjcm8gKHNpemUsIGdldCwgZGlzcGF0Y2gsIG0KICAgICAgICAgZ2V0KG1f dmFsdWUsIHQwKQogICAgICAgICBsb2FkQ29uc3RhbnRPclZhcmlhYmxlKHNpemUsIHQwLCB0MSkK ICAgICAgICAgbG9hZHAgT3BQdXRUb1Njb3BlOjpNZXRhZGF0YTo6bV93YXRjaHBvaW50U2V0W3Q1 XSwgdDIKLSAgICAgICAgbG9hZHAgT3BQdXRUb1Njb3BlOjpNZXRhZGF0YTo6bV9vcGVyYW5kW3Q1 XSwgdDAKKyAgICAgICAgYnRweiB0MiwgLm5vVmFyaWFibGVXYXRjaHBvaW50U2V0CiAgICAgICAg IG5vdGlmeVdyaXRlKHQyLCAucER5bmFtaWMpCisgICAgLm5vVmFyaWFibGVXYXRjaHBvaW50U2V0 OgorICAgICAgICBsb2FkcCBPcFB1dFRvU2NvcGU6Ok1ldGFkYXRhOjptX29wZXJhbmRbdDVdLCB0 MAogICAgICAgICBzdG9yZXEgdDEsIFt0MF0KICAgICBlbmQKIApkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3ltYm9sVGFibGUuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvU3ltYm9sVGFibGUuY3BwCmluZGV4IDI1YTJhNzNkMDBjYTUyYTA3NWFk OTY5MmE0MDJlNDk3NDIxYjg2OTcuLmM5MzYwN2U4OTE0NDdkNmFjZTNkODBjMmU0ZTM3M2Y1Njg1 ZDcyNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N5bWJvbFRh YmxlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TeW1ib2xUYWJsZS5j cHAKQEAgLTcwLDExICs3MCw2IEBAIHZvaWQgU3ltYm9sVGFibGVFbnRyeTo6cHJlcGFyZVRvV2F0 Y2goKQogICAgIGVudHJ5LT5tX3dhdGNocG9pbnRzID0gYWRvcHRSZWYobmV3IFdhdGNocG9pbnRT ZXQoQ2xlYXJXYXRjaHBvaW50KSk7CiB9CiAKLXZvaWQgU3ltYm9sVGFibGVFbnRyeTo6YWRkV2F0 Y2hwb2ludChXYXRjaHBvaW50KiB3YXRjaHBvaW50KQotewotICAgIGZhdEVudHJ5KCktPm1fd2F0 Y2hwb2ludHMtPmFkZCh3YXRjaHBvaW50KTsKLX0KLQogU3ltYm9sVGFibGVFbnRyeTo6RmF0RW50 cnkqIFN5bWJvbFRhYmxlRW50cnk6OmluZmxhdGVTbG93KCkKIHsKICAgICBGYXRFbnRyeSogZW50 cnkgPSBuZXcgRmF0RW50cnkobV9iaXRzKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1N5bWJvbFRhYmxlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9TeW1ib2xUYWJsZS5oCmluZGV4IDU5NjkxYjJlYzQxZWM3YWU5N2FkNDBjOTg0OTAxNTY0Y2Zm ZDQwMTkuLjhlODBkNGJiMmU4NTE2MWJlMzE1ZTg2OGQ1ZjgxMzYzZjk1YmI2YjIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N5bWJvbFRhYmxlLmgKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3ltYm9sVGFibGUuaApAQCAtMjI5LDcgKzIyOSw3 IEBAIHN0cnVjdCBTeW1ib2xUYWJsZUVudHJ5IHsKICAgICAKICAgICBib29sIGlzV2F0Y2hhYmxl KCkgY29uc3QKICAgICB7Ci0gICAgICAgIHJldHVybiAobV9iaXRzICYgS2luZEJpdHNNYXNrKSA9 PSBTY29wZUtpbmRCaXRzOworICAgICAgICByZXR1cm4gKG1fYml0cyAmIEtpbmRCaXRzTWFzaykg PT0gU2NvcGVLaW5kQml0cyAmJiBWTTo6Y2FuVXNlSklUKCk7CiAgICAgfQogICAgIAogICAgIC8v IEFzc2VydHMgaWYgdGhlIG9mZnNldCBpcyBhbnl0aGluZyBidXQgYSBzY29wZSBvZmZzZXQuIFRo aXMgc3RydWN0dXJlcyB0aGUgYXNzZXJ0aW9ucwpAQCAtMjkxLDggKzI5MSw2IEBAIHN0cnVjdCBT eW1ib2xUYWJsZUVudHJ5IHsKICAgICAKICAgICB2b2lkIHByZXBhcmVUb1dhdGNoKCk7CiAgICAg Ci0gICAgdm9pZCBhZGRXYXRjaHBvaW50KFdhdGNocG9pbnQqKTsKLSAgICAKICAgICAvLyBUaGlz IHdhdGNocG9pbnQgc2V0IGlzIGluaXRpYWxpemVkIGNsZWFyLCBhbmQgZ29lcyB0aHJvdWdoIHRo ZSBmb2xsb3dpbmcgc3RhdGUgdHJhbnNpdGlvbnM6CiAgICAgLy8gCiAgICAgLy8gRmlyc3Qgd3Jp dGUgdG8gdGhpcyB2YXIsIGluIGFueSBzY29wZSB0aGF0IGhhcyB0aGlzIHN5bWJvbCB0YWJsZTog Q2xlYXItPklzV2F0Y2hlZC4KQEAgLTMxMiwxMCArMzEwLDEyIEBAIHN0cnVjdCBTeW1ib2xUYWJs ZUVudHJ5IHsKICAgICAvLyBpbml0aWFsaXplcyB0aGF0IHZhciBpbiBqdXN0IG9uZSBvZiB0aGVt LiBUaGlzIG1lYW5zIHRoYXQgYSBjb21waWxhdGlvbiBjb3VsZCBjb25zdGFudC1mb2xkIHRvIG9u ZQogICAgIC8vIG9mIHRoZSBzY29wZXMgdGhhdCBzdGlsbCBoYXMgYW4gdW5kZWZpbmVkIHZhbHVl IGZvciB0aGlzIHZhcmlhYmxlLiBUaGF0J3MgZmluZSwgYmVjYXVzZSBhdCB0aGF0CiAgICAgLy8g cG9pbnQgYW55IHdyaXRlIHRvIGFueSBvZiB0aGUgaW5zdGFuY2VzIG9mIHRoYXQgdmFyaWFibGUg d291bGQgZmlyZSB0aGUgd2F0Y2hwb2ludC4KKyAgICAvLworICAgIC8vIE5vdGUgdGhhdCB3YXRj aHBvaW50U2V0KCkgcmV0dXJucyBudWxscHRyIGlmIEpJVCBpcyBkaXNhYmxlZC4KICAgICBXYXRj aHBvaW50U2V0KiB3YXRjaHBvaW50U2V0KCkKICAgICB7CiAgICAgICAgIGlmICghaXNGYXQoKSkK LSAgICAgICAgICAgIHJldHVybiAwOworICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAg ICAgIHJldHVybiBmYXRFbnRyeSgpLT5tX3dhdGNocG9pbnRzLmdldCgpOwogICAgIH0KICAgICAK