194889 2019-02-20 18:04:44 -0800 REGRESSION (240698): Fixed position banners flicker and move when scrolling on iOS 2019-02-20 19:32:58 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue koivisto simon.fraser thorton webkit-bug-importer oldest_to_newest 1508404 0 simon.fraser 2019-02-20 18:04:44 -0800 REGRESSION (240698): Fixed position banners flicker and move when scrolling on iOS 1508405 1 362580 simon.fraser 2019-02-20 18:12:34 -0800 Created attachment 362580 Patch 1508406 2 simon.fraser 2019-02-20 18:13:27 -0800 rdar://problem/47755552 1508423 3 362580 commit-queue 2019-02-20 19:32:56 -0800 Comment on attachment 362580 Patch Clearing flags on attachment: 362580 Committed r241860: <https://trac.webkit.org/changeset/241860> 1508424 4 commit-queue 2019-02-20 19:32:58 -0800 All reviewed patches have been landed. Closing bug. 362580 2019-02-20 18:12:34 -0800 2019-02-20 19:32:56 -0800 Patch bug-194889-20190220181233.patch text/plain 3508 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGMxMmIyNzg3MjQxODY3 YjA3NmQyYzNkYjgzNTIzN2I0YzZkMzUyMS4uYTE0YmNkZDI4NGVkZmI3MmVhNjRjNmU4Yjg0NmE3 OTMyMjU5YWE4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE5LTAyLTIwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KDI0MDY5OCk6IEZpeGVkIHBvc2l0aW9uIGJhbm5lcnMgZmxpY2tlciBhbmQgbW92ZSB3aGVuIHNj cm9sbGluZyBvbiBpT1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5NDg4OQorICAgICAgICByZGFyOi8vcHJvYmxlbS80Nzc1NTU1MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgQWZ0ZXIgcjI0 MDY5OCB3ZSBjb3VsZCBjb21taXQgc2Nyb2xsaW5nIGNoYW5nZXMgZm9yIGEgZml4ZWQgbm9kZSB3 aGVyZSB0aGUgInZpZXdwb3J0UmVjdEF0TGFzdExheW91dCIgYW5kIHRoZSBsYXllcgorICAgICAg ICBwb3NpdGlvbiB3ZXJlIG1pc21hdGNoZWQ7IHRoaXMgaGFwcGVuZWQgd2hlbiBBc3luY1Njcm9s bGluZ0Nvb3JkaW5hdG9yOjpyZWNvbmNpbGVTY3JvbGxpbmdTdGF0ZSgpIGNhbWUgYmFjayBmcm9t IHRoZSBVSSBwcm9jZXNzCisgICAgICAgIHdpdGggYW4gdW5zdGFibGUgdXBkYXRlIGFuZCBzZXQg YSBuZXcgbGF5b3V0Vmlld3BvcnQsIHRoZW4gc29tZSBvdGhlciBsYXlvdXQgdHJpZ2dlcmVkIGEg Y29tcG9zaXRpbmcgdHJlZSB1cGRhdGUuIER1cmluZyB0aGUgdHJlZQorICAgICAgICB1cGRhdGUs IHdlJ2QgdXBkYXRlIHRoZSBmaXhlZCBzY3JvbGxpbmcgbm9kZSB3aXRoIHRoZSBuZXcgdmlld3Bv cnQsIGFuZCBhbiBvbGQgbGF5ZXIgcG9zaXRpb24uCisgICAgICAgIAorICAgICAgICBGaXggYnkg ZW5zdXJpbmcgdGhhdCB3ZSBvbmx5IHVwZGF0ZSB0aGUgZ2VvbWV0cnkgaW5mbyBmb3IgYSBzY3Jv bGxpbmcgdHJlZSBub2RlIHdoZW4gd2UgdXBkYXRlIGxheWVyIGdlb21ldHJ5IGZvciB0aGUgY29y cmVzcG9uZGluZworICAgICAgICBsYXllci4KKworICAgICAgICBOb3QgY3VycmVudGx5IHRlc3Rh YmxlLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OnVwZGF0ZUJhY2tpbmdBbmRI aWVyYXJjaHkpOgorCiAyMDE5LTAyLTIwICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyNDE3ODg+KTogQVNTRVJUSU9OIEZBSUxF RDogIW1fbm9ybWFsRmxvd0xpc3REaXJ0eSBpbiBUZXN0V2ViS2l0QVBJLldlYktpdC5SZXNpemVS ZXZlcnNlUGFnaW5hdGVkV2ViVmlldyB0ZXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCmluZGV4IDZkZDhkMTUyNWE3ZWUyZjQzNDQz YzlmZGY5MWU5NTQ0Yjc4NTU4MTIuLjVkMDc5YTFhYjc0ZWJkYzY5NWQzYTZlN2VlOGIyNjVmMmIw NTgzN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNv bXBvc2l0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNv bXBvc2l0b3IuY3BwCkBAIC0xMTY5LDggKzExNjksMTEgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBv c2l0b3I6OnVwZGF0ZUJhY2tpbmdBbmRIaWVyYXJjaHkoUmVuZGVyTGF5ZXImIGxheWVyLCBWZWN0 b3IKICAgICAgICAgICAgIGxheWVyQmFja2luZy0+dXBkYXRlRGVidWdJbmRpY2F0b3JzKG1fc2hv d0RlYnVnQm9yZGVycywgbV9zaG93UmVwYWludENvdW50ZXIpOwogICAgICAgICB9CiAgICAgICAg IAotICAgICAgICBpZiAobGF5ZXJOZWVkc1VwZGF0ZSB8fCBsYXllci5uZWVkc0NvbXBvc2l0aW5n R2VvbWV0cnlVcGRhdGUoKSB8fCBsYXllci5uZWVkc1Njcm9sbGluZ1RyZWVVcGRhdGUoKSkKKyAg ICAgICAgT3B0aW9uU2V0PFNjcm9sbGluZ05vZGVDaGFuZ2VGbGFncz4gc2Nyb2xsaW5nTm9kZUNo YW5nZXMgPSB7IFNjcm9sbGluZ05vZGVDaGFuZ2VGbGFnczo6TGF5ZXIgfTsKKyAgICAgICAgaWYg KGxheWVyTmVlZHNVcGRhdGUgfHwgbGF5ZXIubmVlZHNDb21wb3NpdGluZ0dlb21ldHJ5VXBkYXRl KCkgfHwgbGF5ZXIubmVlZHNTY3JvbGxpbmdUcmVlVXBkYXRlKCkpIHsKICAgICAgICAgICAgIGxh eWVyQmFja2luZy0+dXBkYXRlR2VvbWV0cnkoKTsKKyAgICAgICAgICAgIHNjcm9sbGluZ05vZGVD aGFuZ2VzLmFkZChTY3JvbGxpbmdOb2RlQ2hhbmdlRmxhZ3M6OkxheWVyR2VvbWV0cnkpOworICAg ICAgICB9CiAKICAgICAgICAgaWYgKGF1dG8qIHJlZmxlY3Rpb24gPSBsYXllci5yZWZsZWN0aW9u TGF5ZXIoKSkgewogICAgICAgICAgICAgaWYgKGF1dG8qIHJlZmxlY3Rpb25CYWNraW5nID0gcmVm bGVjdGlvbi0+YmFja2luZygpKSB7CkBAIC0xMTg1LDcgKzExODgsNyBAQCB2b2lkIFJlbmRlckxh eWVyQ29tcG9zaXRvcjo6dXBkYXRlQmFja2luZ0FuZEhpZXJhcmNoeShSZW5kZXJMYXllciYgbGF5 ZXIsIFZlY3RvcgogCiAgICAgICAgIC8vIEZJWE1FOiBkbyBiYXNlZCBvbiBkaXJ0eSBmbGFncy4g TmVlZCB0byBkbyB0aGlzIGZvciBjaGFuZ2VzIG9mIGdlb21ldHJ5LCBjb25maWd1cmF0aW9uIGFu ZCBoaWVyYXJjaHkuCiAgICAgICAgIC8vIE5lZWQgdG8gYmUgY2FyZWZ1bCB0byBkbyB0aGUgcmln aHQgdGhpbmcgd2hlbiBhIHNjcm9sbC1jb29yZGluYXRlZCBsYXllciBsb3NlcyBhIHNjcm9sbC1j b29yZGluYXRlZCBhbmNlc3Rvci4KLSAgICAgICAgc3RhdGVGb3JEZXNjZW5kYW50cy5wYXJlbnRO b2RlSUQgPSB1cGRhdGVTY3JvbGxDb29yZGluYXRpb25Gb3JMYXllcihsYXllciwgc2Nyb2xsaW5n VHJlZVN0YXRlLCBsYXllckJhY2tpbmctPmNvb3JkaW5hdGVkU2Nyb2xsaW5nUm9sZXMoKSwgeyBT Y3JvbGxpbmdOb2RlQ2hhbmdlRmxhZ3M6OkxheWVyLCBTY3JvbGxpbmdOb2RlQ2hhbmdlRmxhZ3M6 OkxheWVyR2VvbWV0cnkgfSk7CisgICAgICAgIHN0YXRlRm9yRGVzY2VuZGFudHMucGFyZW50Tm9k ZUlEID0gdXBkYXRlU2Nyb2xsQ29vcmRpbmF0aW9uRm9yTGF5ZXIobGF5ZXIsIHNjcm9sbGluZ1Ry ZWVTdGF0ZSwgbGF5ZXJCYWNraW5nLT5jb29yZGluYXRlZFNjcm9sbGluZ1JvbGVzKCksIHNjcm9s bGluZ05vZGVDaGFuZ2VzKTsKICAgICAgICAgc3RhdGVGb3JEZXNjZW5kYW50cy5uZXh0Q2hpbGRJ bmRleCA9IDA7CiAKICNpZiAhTE9HX0RJU0FCTEVECg==