194885 2019-02-20 17:07:22 -0800 Web Inspector: macOS user agent option should be available in device settings menu 2019-02-21 10:00:56 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1508378 0 hi 2019-02-20 17:07:22 -0800 Since this menu only appears on remote targets, they might want to set the user agent to a desktop one to test something. 1508385 1 webkit-bug-importer 2019-02-20 17:25:33 -0800 <rdar://problem/48259253> 1508432 2 362586 hi 2019-02-20 20:59:32 -0800 Created attachment 362586 Patch 1508441 3 362586 joepeck 2019-02-20 21:28:24 -0800 Comment on attachment 362586 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362586&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Main.js:2074 > + { name: "Safari 12.2", value: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.2 Safari/605.1.15" }, I'm not sure 10_14_4 is the current shipping but that part isn't the most important bit, the rest are. > Source/WebInspectorUI/UserInterface/Base/Main.js:2076 > + ], > [ Why separate this from the other Safaris? I think it makes sense to put all the Safari's together, Mac, iPhone, iPad. We could even consider a watchOS UserAgent. 1508545 4 362586 hi 2019-02-21 09:35:29 -0800 Comment on attachment 362586 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=362586&action=review >> Source/WebInspectorUI/UserInterface/Base/Main.js:2074 >> + { name: "Safari 12.2", value: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.2 Safari/605.1.15" }, > > I'm not sure 10_14_4 is the current shipping but that part isn't the most important bit, the rest are. I got this from the most recent developer beta. One annoying thing about this is that we're going to have to update this (and the others) when the system updates. Perhaps we can add something to `InpsectorFrontendHost`. >> Source/WebInspectorUI/UserInterface/Base/Main.js:2076 >> [ > > Why separate this from the other Safaris? I think it makes sense to put all the Safari's together, Mac, iPhone, iPad. > We could even consider a watchOS UserAgent. This matches the current develop menu's structure. 1508553 5 362586 commit-queue 2019-02-21 10:00:55 -0800 Comment on attachment 362586 Patch Clearing flags on attachment: 362586 Committed r241870: <https://trac.webkit.org/changeset/241870> 1508554 6 commit-queue 2019-02-21 10:00:56 -0800 All reviewed patches have been landed. Closing bug. 362586 2019-02-20 20:59:32 -0800 2019-02-21 10:00:55 -0800 Patch bug-194885-20190220205931.patch text/plain 1910 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDY5NjIzMDNiMDE3MmQ2ZDFjMmFlM2YxNzMxOTQ3 MjE3OGIzODZlMTcuLjhiMzg0ZWEzMzJlYWQyZmM3YzY4MzhiNjEzNzY3ZmFkMGYzOWU1MTQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTAyLTIwICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBt YWNPUyB1c2VyIGFnZW50IG9wdGlvbiBzaG91bGQgYmUgYXZhaWxhYmxlIGluIGRldmljZSBzZXR0 aW5ncyBtZW51CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTQ4ODUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4MjU5MjUzPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNl L01haW4uanM6CisgICAgICAgIChXSS5faGFuZGxlRGV2aWNlU2V0dGluZ3NUb29sYmFyQnV0dG9u Q2xpY2tlZCk6CisKIDIwMTktMDItMjAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxl LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSVEw6IFNjcmlwdHMgVGltZWxpbmUgbG9h ZGluZyBpbmRpY2F0b3IgaGFzIGluY29ycmVjdCBtYXJnaW5zCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXggMjgxMzZjMDZkZmRmM2Zj ZDM0YTBjN2FmOTg0ZjI3ZjgwMTUxOGU3Yy4uODA2M2QwZDMxZGFmNDI4NWNmNzgxODU3MzJhNmNm NjkwM2ZlMzU5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQmFzZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvTWFpbi5qcwpAQCAtMjA3MCw2ICsyMDcwLDkgQEAgV0kuX2hhbmRsZURldmljZVNldHRp bmdzVG9vbGJhckJ1dHRvbkNsaWNrZWQgPSBmdW5jdGlvbihldmVudCkKICAgICAgICAgWwogICAg ICAgICAgICAgeyBuYW1lOiBXSS5VSVN0cmluZygiRGVmYXVsdCIpLCB2YWx1ZTogImRlZmF1bHQi IH0sCiAgICAgICAgIF0sCisgICAgICAgIFsKKyAgICAgICAgICAgIHsgbmFtZTogIlNhZmFyaSAx Mi4yIiwgdmFsdWU6ICJNb3ppbGxhLzUuMCAoTWFjaW50b3NoOyBJbnRlbCBNYWMgT1MgWCAxMF8x NF80KSBBcHBsZVdlYktpdC82MDUuMS4xNSAoS0hUTUwsIGxpa2UgR2Vja28pIFZlcnNpb24vMTIu MiBTYWZhcmkvNjA1LjEuMTUiIH0sCisgICAgICAgIF0sCiAgICAgICAgIFsKICAgICAgICAgICAg IHsgbmFtZTogYFNhZmFyaSAke2VtRGFzaH0gaU9TIDEyLjEuMyAke2VtRGFzaH0gaVBob25lYCwg dmFsdWU6ICJNb3ppbGxhLzUuMCAoaVBob25lOyBDUFUgaVBob25lIE9TIDEyXzFfMyBsaWtlIE1h YyBPUyBYKSBBcHBsZVdlYktpdC82MDUuMS4xNSAoS0hUTUwsIGxpa2UgR2Vja28pIFZlcnNpb24v MTIuMCBNb2JpbGUvMTVFMTQ4IFNhZmFyaS82MDQuMSIgfSwKICAgICAgICAgICAgIHsgbmFtZTog YFNhZmFyaSAke2VtRGFzaH0gaU9TIDEyLjEuMyAke2VtRGFzaH0gaVBvZCBUb3VjaGAsIHZhbHVl OiAiTW96aWxsYS81LjAgKGlQb2Q7IENQVSBpUGhvbmUgT1MgMTJfMV8zIGxpa2UgTWFjIE9TIFgp IEFwcGxlV2ViS2l0LzYwNS4xLjE1IChLSFRNTCwgbGlrZSBHZWNrbykgVmVyc2lvbi8xMi4wIE1v YmlsZS8xNUUxNDggU2FmYXJpLzYwNC4xIiB9LAo=