194875 2019-02-20 15:05:05 -0800 [Win] Guard CF usage in RenderThemeWin 2019-02-20 16:31:23 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead achristensen bfulgham commit-queue fujii pvollan webkit-bug-importer oldest_to_newest 1508289 0 don.olmstead 2019-02-20 15:05:05 -0800 Currently RenderThemeWin uses CF directly even if USE(CF) is not defined. 1508291 1 362551 don.olmstead 2019-02-20 15:08:36 -0800 Created attachment 362551 Patch 1508344 2 362551 commit-queue 2019-02-20 16:19:21 -0800 Comment on attachment 362551 Patch Clearing flags on attachment: 362551 Committed r241851: <https://trac.webkit.org/changeset/241851> 1508346 3 commit-queue 2019-02-20 16:19:23 -0800 All reviewed patches have been landed. Closing bug. 1508351 4 webkit-bug-importer 2019-02-20 16:31:23 -0800 <rdar://problem/48257305> 362551 2019-02-20 15:08:36 -0800 2019-02-20 16:19:21 -0800 Patch bug-194875.diff text/plain 3692 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyNGE5ZGEzN2RmYS4uZTZhMDA3ODgzNzAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wMi0yMCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnku Y29tPgorCisgICAgICAgIFtXaW5dIEd1YXJkIENGIHVzYWdlIGluIFJlbmRlclRoZW1lV2luCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ4NzUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICBBZGQgI2lmIFVTRShDRikgY2hl Y2tzIHRvIFJlbmRlclRoZW1lV2luIHNvIGl0IGNhbiBjb21waWxlIHdpdGhvdXQgQ0Ygc3VwcG9y dC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJUaGVtZVdpbjo6c3RyaW5nV2l0aENvbnRlbnRzT2ZGaWxlKToKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lV2luOjptZWRpYUNvbnRyb2xzU3R5bGVTaGVldCk6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZVdpbjo6bWVkaWFDb250cm9sc1NjcmlwdCk6Cisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmg6CisKIDIwMTktMDItMjAgIEFkcmlh biBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXVtH VEtdIEVuYWJsZSBzdXBwb3J0IGZvciBDT05URU5UX0VYVEVOU0lPTlMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uY3BwCmluZGV4IDIxOTY1N2UxZjI0Li42ZTQxMzgx NjRiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2lu LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uY3BwCkBA IC0xMDQ4LDkgKzEwNDgsMTAgQEAgc3RhdGljIHZvaWQgZmlsbEJ1ZmZlcldpdGhDb250ZW50c09m RmlsZShGaWxlU3lzdGVtOjpQbGF0Zm9ybUZpbGVIYW5kbGUgZmlsZSwgbG8KICAgICBidWZmZXJb ZmlsZXNpemVdID0gMDsKIH0KIAotU3RyaW5nIFJlbmRlclRoZW1lV2luOjpzdHJpbmdXaXRoQ29u dGVudHNPZkZpbGUoQ0ZTdHJpbmdSZWYgbmFtZSwgQ0ZTdHJpbmdSZWYgdHlwZSkKK1N0cmluZyBS ZW5kZXJUaGVtZVdpbjo6c3RyaW5nV2l0aENvbnRlbnRzT2ZGaWxlKGNvbnN0IFN0cmluZyYgbmFt ZSwgY29uc3QgU3RyaW5nJiB0eXBlKQogewotICAgIFJldGFpblB0cjxDRlVSTFJlZj4gcmVxdWVz dGVkVVJMUmVmID0gYWRvcHRDRihDRkJ1bmRsZUNvcHlSZXNvdXJjZVVSTCh3ZWJLaXRCdW5kbGUo KSwgbmFtZSwgdHlwZSwgMCkpOworI2lmIFVTRShDRikKKyAgICBSZXRhaW5QdHI8Q0ZVUkxSZWY+ IHJlcXVlc3RlZFVSTFJlZiA9IGFkb3B0Q0YoQ0ZCdW5kbGVDb3B5UmVzb3VyY2VVUkwod2ViS2l0 QnVuZGxlKCksIG5hbWUuY3JlYXRlQ0ZTdHJpbmcoKS5nZXQoKSwgdHlwZS5jcmVhdGVDRlN0cmlu ZygpLmdldCgpLCAwKSk7CiAgICAgaWYgKCFyZXF1ZXN0ZWRVUkxSZWYpCiAgICAgICAgIHJldHVy biBTdHJpbmcoKTsKIApAQCAtMTA3MywxMyArMTA3NCwxNiBAQCBTdHJpbmcgUmVuZGVyVGhlbWVX aW46OnN0cmluZ1dpdGhDb250ZW50c09mRmlsZShDRlN0cmluZ1JlZiBuYW1lLCBDRlN0cmluZ1Jl ZiB0eQogICAgIEZpbGVTeXN0ZW06OmNsb3NlRmlsZShyZXF1ZXN0ZWRGaWxlSGFuZGxlKTsKIAog ICAgIHJldHVybiBTdHJpbmcoZmlsZUNvbnRlbnRzLmRhdGEoKSwgc3RhdGljX2Nhc3Q8c2l6ZV90 PihmaWxlc2l6ZSkpOworI2Vsc2UKKyAgICByZXR1cm4gZW1wdHlTdHJpbmcoKTsKKyNlbmRpZgog fQogCiBTdHJpbmcgUmVuZGVyVGhlbWVXaW46Om1lZGlhQ29udHJvbHNTdHlsZVNoZWV0KCkKIHsK ICNpZiBFTkFCTEUoTUVESUFfQ09OVFJPTFNfU0NSSVBUKQogICAgIGlmIChtX21lZGlhQ29udHJv bHNTdHlsZVNoZWV0LmlzRW1wdHkoKSkKLSAgICAgICAgbV9tZWRpYUNvbnRyb2xzU3R5bGVTaGVl dCA9IHN0cmluZ1dpdGhDb250ZW50c09mRmlsZShDRlNUUigibWVkaWFDb250cm9sc0FwcGxlIiks IENGU1RSKCJjc3MiKSk7CisgICAgICAgIG1fbWVkaWFDb250cm9sc1N0eWxlU2hlZXQgPSBzdHJp bmdXaXRoQ29udGVudHNPZkZpbGUoIm1lZGlhQ29udHJvbHNBcHBsZSJfcywgImNzcyJfcyk7CiAg ICAgcmV0dXJuIG1fbWVkaWFDb250cm9sc1N0eWxlU2hlZXQ7CiAjZWxzZQogICAgIHJldHVybiBl bXB0eVN0cmluZygpOwpAQCAtMTA5MSw4ICsxMDk1LDggQEAgU3RyaW5nIFJlbmRlclRoZW1lV2lu OjptZWRpYUNvbnRyb2xzU2NyaXB0KCkKICNpZiBFTkFCTEUoTUVESUFfQ09OVFJPTFNfU0NSSVBU KQogICAgIGlmIChtX21lZGlhQ29udHJvbHNTY3JpcHQuaXNFbXB0eSgpKSB7CiAgICAgICAgIFN0 cmluZ0J1aWxkZXIgc2NyaXB0QnVpbGRlcjsKLSAgICAgICAgc2NyaXB0QnVpbGRlci5hcHBlbmQo c3RyaW5nV2l0aENvbnRlbnRzT2ZGaWxlKENGU1RSKCJtZWRpYUNvbnRyb2xzTG9jYWxpemVkU3Ry aW5ncyIpLCBDRlNUUigianMiKSkpOwotICAgICAgICBzY3JpcHRCdWlsZGVyLmFwcGVuZChzdHJp bmdXaXRoQ29udGVudHNPZkZpbGUoQ0ZTVFIoIm1lZGlhQ29udHJvbHNBcHBsZSIpLCBDRlNUUigi anMiKSkpOworICAgICAgICBzY3JpcHRCdWlsZGVyLmFwcGVuZChzdHJpbmdXaXRoQ29udGVudHNP ZkZpbGUoIm1lZGlhQ29udHJvbHNMb2NhbGl6ZWRTdHJpbmdzIl9zLCAianMiX3MpKTsKKyAgICAg ICAgc2NyaXB0QnVpbGRlci5hcHBlbmQoc3RyaW5nV2l0aENvbnRlbnRzT2ZGaWxlKCJtZWRpYUNv bnRyb2xzQXBwbGUiX3MsICJqcyJfcykpOwogICAgICAgICBtX21lZGlhQ29udHJvbHNTY3JpcHQg PSBzY3JpcHRCdWlsZGVyLnRvU3RyaW5nKCk7CiAgICAgfQogICAgIHJldHVybiBtX21lZGlhQ29u dHJvbHNTY3JpcHQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWVXaW4uaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5oCmlu ZGV4IGZlZTI0YjZkOTQ4Li44MjgwZjkxYjAwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRoZW1lV2luLmgKQEAgLTExNSw3ICsxMTUsNyBAQCBwdWJsaWM6CiAKICAgICBzdGF0 aWMgdm9pZCBzZXRXZWJLaXRJc0JlaW5nVW5sb2FkZWQoKTsKIAotICAgIHN0YXRpYyBTdHJpbmcg c3RyaW5nV2l0aENvbnRlbnRzT2ZGaWxlKENGU3RyaW5nUmVmIG5hbWUsIENGU3RyaW5nUmVmIHR5 cGUpOworICAgIHN0YXRpYyBTdHJpbmcgc3RyaW5nV2l0aENvbnRlbnRzT2ZGaWxlKGNvbnN0IFN0 cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiB0eXBlKTsKIAogICAgIGJvb2wgc3VwcG9ydHNGb2N1 c1JpbmcoY29uc3QgUmVuZGVyU3R5bGUmKSBjb25zdCBvdmVycmlkZTsKIAo=