194874 2019-02-20 15:00:09 -0800 Web Inspector: DOM Debugger: node-specific event breakpoints aren't cleared/recalculated on navigation 2019-02-21 10:56:43 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1508286 0 hi 2019-02-20 15:00:09 -0800 # STEPS TO REPRODUCE: 1. inspect any page 2. find a node with an event listener 3. set a breakpoint on that specific event listener via Node sidebar in Elements tab 4. go to the Debugger tab 5. reload/navigate the page => breakpoint for that specific event is still listed in the navigation sidebar 1508287 1 webkit-bug-importer 2019-02-20 15:01:33 -0800 <rdar://problem/48253415> 1508296 2 hi 2019-02-20 15:11:33 -0800 (In reply to Devin Rousso from comment #0) > => breakpoint for that specific event is still listed in the navigation sidebar Interestingly, these "still listed" breakpoints are unable to be removed. DOMManager.js:645:23: CONSOLE ERROR DOMManager.js:651:30: CONSOLE ERROR No event listener for given identifier. 1508308 3 362554 hi 2019-02-20 15:33:32 -0800 Created attachment 362554 Patch 1508566 4 362554 joepeck 2019-02-21 10:18:50 -0800 Comment on attachment 362554 Patch r=me 1508567 5 joepeck 2019-02-21 10:19:42 -0800 You could probably write a test for this by setting an EventListener Breakpoint, reloading, and ensuring it is gone. 1508569 6 hi 2019-02-21 10:29:40 -0800 (In reply to Joseph Pecoraro from comment #5) > You could probably write a test for this by setting an EventListener Breakpoint, reloading, and ensuring it is gone. I titled this bug slightly "overzealously". The EventListener Breakpoints were being cleared successfully (e.g. backend state is cleared), but the weren't getting removed from the UI. 1508580 7 362554 commit-queue 2019-02-21 10:56:41 -0800 Comment on attachment 362554 Patch Clearing flags on attachment: 362554 Committed r241874: <https://trac.webkit.org/changeset/241874> 1508581 8 commit-queue 2019-02-21 10:56:43 -0800 All reviewed patches have been landed. Closing bug. 362554 2019-02-20 15:33:32 -0800 2019-02-21 10:56:41 -0800 Patch bug-194874-20190220153332.patch text/plain 2095 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDI3NmE0OWJlMGQxMzg1Nzk1NDFiYzE0ZmRmMmQ4 MTgwNGZiNWMwMWIuLjJlZDQ5NTgwMjRlNmFlMWE3MzJiMDQxOTU0MWQ1YTc0NjM5OWJkZjAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTIwICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBE T00gRGVidWdnZXI6IG5vZGUtc3BlY2lmaWMgZXZlbnQgYnJlYWtwb2ludHMgYXJlbid0IGNsZWFy ZWQvcmVjYWxjdWxhdGVkIG9uIG5hdmlnYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDg3NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDgy NTM0MTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTU1hbmFnZXIuanM6CisgICAgICAgIChXSS5E T01NYW5hZ2VyLnByb3RvdHlwZS5fc2V0RG9jdW1lbnQpOgorICAgICAgICAoV0kuRE9NTWFuYWdl ci5wcm90b3R5cGUucmVtb3ZlQnJlYWtwb2ludEZvckV2ZW50TGlzdGVuZXIpOgorCiAyMDE5LTAy LTE5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogSW1wcm92ZSBFUzYgQ2xhc3MgaW5zdGFuY2VzIGluIEhlYXAgU25hcHNob3Qg aW5zdGFuY2VzIHZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTU1hbmFnZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Db250cm9sbGVycy9ET01NYW5hZ2VyLmpzCmluZGV4IDhhMDI0YzlkNWY3 YzE2MTM4NmMyNWVkMmM4NjA0MzNmYzljODUzMTcuLjk1ZWNmYzZmNTQxNDFmOTE4MTgyM2FlYTI2 OWE0NTdjOWM2OGUyMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTU1hbmFnZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NTWFuYWdlci5qcwpAQCAtMjc5LDYgKzI3 OSw5IEBAIFdJLkRPTU1hbmFnZXIgPSBjbGFzcyBET01NYW5hZ2VyIGV4dGVuZHMgV0kuT2JqZWN0 CiAgICAgX3NldERvY3VtZW50KHBheWxvYWQpCiAgICAgewogICAgICAgICB0aGlzLl9pZFRvRE9N Tm9kZSA9IHt9OworCisgICAgICAgIGZvciAobGV0IGJyZWFrcG9pbnQgb2YgdGhpcy5fYnJlYWtw b2ludHNGb3JFdmVudExpc3RlbmVycy52YWx1ZXMoKSkKKyAgICAgICAgICAgIFdJLmRvbURlYnVn Z2VyTWFuYWdlci5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV0kuRE9NRGVidWdnZXJNYW5hZ2Vy LkV2ZW50LkV2ZW50QnJlYWtwb2ludFJlbW92ZWQsIHticmVha3BvaW50fSk7CiAgICAgICAgIHRo aXMuX2JyZWFrcG9pbnRzRm9yRXZlbnRMaXN0ZW5lcnMuY2xlYXIoKTsKIAogICAgICAgICBsZXQg bmV3RG9jdW1lbnQgPSBudWxsOwpAQCAtNjUyLDggKzY1NSw3IEBAIFdJLkRPTU1hbmFnZXIgPSBj bGFzcyBET01NYW5hZ2VyIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAgICAgICAgICAgICAgcmV0dXJu OwogICAgICAgICAgICAgfQogCi0gICAgICAgICAgICBpZiAoYnJlYWtwb2ludCkKLSAgICAgICAg ICAgICAgICBXSS5kb21EZWJ1Z2dlck1hbmFnZXIuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdJ LkRPTURlYnVnZ2VyTWFuYWdlci5FdmVudC5FdmVudEJyZWFrcG9pbnRSZW1vdmVkLCB7YnJlYWtw b2ludH0pOworICAgICAgICAgICAgV0kuZG9tRGVidWdnZXJNYW5hZ2VyLmRpc3BhdGNoRXZlbnRU b0xpc3RlbmVycyhXSS5ET01EZWJ1Z2dlck1hbmFnZXIuRXZlbnQuRXZlbnRCcmVha3BvaW50UmVt b3ZlZCwge2JyZWFrcG9pbnR9KTsKICAgICAgICAgfSk7CiAgICAgfQogCg==