194870 2019-02-20 14:10:41 -0800 IndexedDB: leak UniqueIDBDatabase in layout tests 2019-02-21 15:06:30 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu alecflett beidson commit-queue ews-watchlist ggaren jsbell lforschler webkit-bug-importer oldest_to_newest 1508236 0 sihui_liu 2019-02-20 14:10:41 -0800 Example leak: STACK OF 4 INSTANCES OF 'ROOT CYCLE: malloc<16>': [thread 0x1146ea5c0]: 20 libdyld.dylib 0x1102dfca1 start + 1 19 com.apple.WebKit 0x10d7d506d 0x10d6db000 + 1024109 18 libxpc.dylib 0x1105c5ca7 xpc_main + 143 17 libxpc.dylib 0x1105c37d2 _xpc_objc_main + 555 16 com.apple.Foundation 0x10d195200 -[NSRunLoop(NSRunLoop) run] + 76 15 com.apple.Foundation 0x10d194fe0 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 211 14 com.apple.CoreFoundation 0x10f52c9f2 CFRunLoopRunSpecific + 626 13 com.apple.CoreFoundation 0x10f52d24f __CFRunLoopRun + 1295 12 com.apple.CoreFoundation 0x10f532bcf __CFRunLoopDoSources0 + 255 11 com.apple.CoreFoundation 0x10f533391 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 10 com.apple.Foundation 0x10d1ab910 __NSThreadPerformPerform + 331 9 JavaScriptCore 0x113308a49 WTF::dispatchFunctionsFromMainThread() + 249 memory:2633 8 JavaScriptCore 0x1132ec0ef WTF::CrossThreadTaskHandler::handleTaskRepliesOnMainThread() + 239 memory:2633 7 com.apple.WebCore 0x1153e5cb4 WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTaskReply() + 196 UniqueIDBDatabase.cpp:1783 6 com.apple.WebCore 0x1153d8221 WebCore::IDBServer::UniqueIDBDatabase::handleDatabaseOperations() + 65 UniqueIDBDatabase.cpp:375 5 com.apple.WebCore 0x1153d9b34 WebCore::IDBServer::UniqueIDBDatabase::handleCurrentOperation() + 36 UniqueIDBDatabase.cpp:0 4 com.apple.WebCore 0x1153d861b WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation() + 635 memory:2603 3 com.apple.WebCore 0x1153e76be WebCore::IDBServer::UniqueIDBDatabaseConnection::UniqueIDBDatabaseConnection(WebCore::IDBServer::UniqueIDBDatabase&, WebCore::IDBServer::ServerOpenDBRequest&) + 62 atomic:985 2 JavaScriptCore 0x1132fb6a1 WTF::fastMalloc(unsigned long) + 97 Allocator.h:0 1 JavaScriptCore 0x11336ee1c bmalloc::DebugHeap::malloc(unsigned long) + 12 DebugHeap.cpp:49 0 libsystem_malloc.dylib 0x110526bf8 malloc_zone_malloc + 139 ==== 83 (14.5K) << TOTAL >> ---- 19 (3.86K) ROOT CYCLE: 0x7f85daf00e40 [16] 18 (3.84K) ROOT CYCLE: 0x7f85daf0c020 [768] CYCLE BACK TO 0x7f85daf00e40 [16] 1 (48 bytes) ROOT CYCLE: 0x7f85daf0c500 [48] 1 (32 bytes) ROOT CYCLE: 0x7f85daf02c10 [32] 3 (848 bytes) 0x7f85daf02540 [48] 2 (800 bytes) 0x7f85de902610 [768] 1 (32 bytes) 0x7f85daf051e0 [32] 1 (432 bytes) 0x7f85daf13a10 [432] 1 (432 bytes) 0x7f85daf14360 [432] 1 (432 bytes) 0x7f85de804710 [432] 1 (192 bytes) 0x7f85dac01550 [192] 1 (192 bytes) 0x7f85daf0c3e0 [192] 1 (128 bytes) 0x7f85dac025f0 [128] 1 (128 bytes) 0x7f85dac09670 [128] 1 (128 bytes) 0x7f85dad01fd0 [128] 1 (64 bytes) 0x7f85daf00220 [64] 1 (48 bytes) 0x7f85daf01d70 [48] 1 (32 bytes) 0x7f85daf02430 [32] 1 (32 bytes) 0x7f85daf02bf0 [32] 1508262 1 sihui_liu 2019-02-20 14:31:44 -0800 <rdar://problem/48163812> 1508266 2 362543 sihui_liu 2019-02-20 14:34:53 -0800 Created attachment 362543 Patch 1508319 3 362543 ggaren 2019-02-20 15:48:08 -0800 Comment on attachment 362543 Patch r=me 1508685 4 362543 commit-queue 2019-02-21 15:06:28 -0800 Comment on attachment 362543 Patch Clearing flags on attachment: 362543 Committed r241913: <https://trac.webkit.org/changeset/241913> 1508686 5 commit-queue 2019-02-21 15:06:30 -0800 All reviewed patches have been landed. Closing bug. 362543 2019-02-20 14:34:53 -0800 2019-02-21 15:06:28 -0800 Patch bug-194870-20190220143453.patch text/plain 2137 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjRhOWRhMzdkZmFmMjJl NmIwMzFkOGY1ZTgzNTBmMzMxOTg4YWZjYS4uMzRjNTMxMWQ2YTgzZDcxZGJjNmNiN2M5MjU3NmRm OWE0ODIxNTZmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTAyLTIwICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIEluZGV4ZWREQjogbGVhayBV bmlxdWVJREJEYXRhYmFzZSBpbiBsYXlvdXQgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDg3MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NDgxNjM4MTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVW5pcXVlSURCRGF0YWJhc2Ugb3ducyBhIHBvaW50ZXIgdG8gaXRzZWxmIGFmdGVyIGl0IGlz IGhhcmQgY2xvc2VkLiBJdCBzaG91bGQgcmVsZWFzZSB0aGUgcG9pbnRlciB3aGVuIGl0IAorICAg ICAgICByZWNlaXZlcyBjb25maXJtYXRpb24gZnJvbSBjbGllbnRzIGFuZCBhbGwgcGVuZGluZyB0 YXNrcyBhcmUgZG9uZS4gVW5pcXVlSURCRGF0YWJhc2UgYWxyZWFkeSBjaGVja3Mgd2hldGhlciB0 aGUKKyAgICAgICAgcG9pbnRlciBzaG91bGQgYmUgcmVsZWFzZWQgd2hlbiBhIGRhdGFiYXNlIHRh c2sgZmluaXNoZXMsIGJ1dCBpdCBkaWRuJ3QgcGVyZm9ybSBhIGNoZWNrIHdoZW4gYSBjb25maXJt IG1lc3NhZ2UgCisgICAgICAgIGlzIHJlY2VpdmVkLiAKKworICAgICAgICBObyBuZXcgdGVzdCBh cyB0aGUgb3JkZXIgb2YgdGFzayBjb21wbGV0aW9uIGFuZCBjb25maXJtYXRpb24gYXJyaXZhbCBp cyB1bmNlcnRhaW4uCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVl SURCRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCU2VydmVyOjpVbmlxdWVJREJE YXRhYmFzZTo6Y29uZmlybURpZENsb3NlRnJvbVNlcnZlcik6CisKIDIwMTktMDItMjAgIEFkcmlh biBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXVtH VEtdIEVuYWJsZSBzdXBwb3J0IGZvciBDT05URU5UX0VYVEVOU0lPTlMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJREJEYXRhYmFzZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0 YWJhc2UuY3BwCmluZGV4IDcyMmU3ZTk0NjgyZDM0NTZhZDcxYmY1ZWM2MjJiMWUwYzQzNTZkNjMu Ljg3ZDcwMWE1MmZiOGVmODZmNzhkM2UxN2MyMGUzMjg3ZWU4MzlmZTAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9VbmlxdWVJREJEYXRhYmFzZS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1ZUlE QkRhdGFiYXNlLmNwcApAQCAtMTUxOSw2ICsxNTE5LDggQEAgdm9pZCBVbmlxdWVJREJEYXRhYmFz ZTo6Y29uZmlybURpZENsb3NlRnJvbVNlcnZlcihVbmlxdWVJREJEYXRhYmFzZUNvbm5lY3Rpb24m IGMKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwogICAgIExPRyhJbmRleGVkREIsICJVbmlx dWVJREJEYXRhYmFzZTo6Y29uZmlybURpZENsb3NlRnJvbVNlcnZlciAtICVzICglIiBQUkl1NjQg IikiLCBjb25uZWN0aW9uLm9wZW5SZXF1ZXN0SWRlbnRpZmllcigpLmxvZ2dpbmdTdHJpbmcoKS51 dGY4KCkuZGF0YSgpLCBjb25uZWN0aW9uLmlkZW50aWZpZXIoKSk7CiAKKyAgICBpZiAobV9oYXJk Q2xvc2VkRm9yVXNlckRlbGV0ZSkKKyAgICAgICAgbWF5YmVGaW5pc2hIYXJkQ2xvc2UoKTsKICAg ICBBU1NFUlQobV9zZXJ2ZXJDbG9zZVBlbmRpbmdEYXRhYmFzZUNvbm5lY3Rpb25zLmNvbnRhaW5z KCZjb25uZWN0aW9uKSk7CiAgICAgbV9zZXJ2ZXJDbG9zZVBlbmRpbmdEYXRhYmFzZUNvbm5lY3Rp b25zLnJlbW92ZSgmY29ubmVjdGlvbik7CiB9Cg==