194841 2019-02-19 16:24:54 -0800 [MSVC] Fix compilation errors with lambdas in Service Workers 2019-02-20 10:52:41 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead achristensen commit-queue webkit-bug-importer youennf ysuzuki oldest_to_newest 1507907 0 don.olmstead 2019-02-19 16:24:54 -0800 There are some issues around compiling Service Workers on Windows around lambdas and some declarations. 1507922 1 362454 don.olmstead 2019-02-19 17:04:27 -0800 Created attachment 362454 Patch 1508118 2 362454 achristensen 2019-02-20 10:16:54 -0800 Comment on attachment 362454 Patch r=me, even though they claim to have fixed this in a future version of MSVC 1508123 3 don.olmstead 2019-02-20 10:18:48 -0800 (In reply to Alex Christensen from comment #2) > Comment on attachment 362454 [details] > Patch > > r=me, even though they claim to have fixed this in a future version of MSVC They haven't. This is compiled using Visual Studio 2019 Preview 3. 1508124 4 362454 commit-queue 2019-02-20 10:23:26 -0800 Comment on attachment 362454 Patch Clearing flags on attachment: 362454 Committed r241820: <https://trac.webkit.org/changeset/241820> 1508125 5 commit-queue 2019-02-20 10:23:28 -0800 All reviewed patches have been landed. Closing bug. 1508142 6 webkit-bug-importer 2019-02-20 10:52:41 -0800 <rdar://problem/48243297> 362454 2019-02-19 17:04:27 -0800 2019-02-20 10:23:26 -0800 Patch bug-194841.diff text/plain 3874 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMjVkZmZiNGY0MC4uMjc1N2MzNTAyZDkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOS0wMi0xOSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnku Y29tPgorCisgICAgICAgIFtNU1ZDXSBGaXggY29tcGlsYXRpb24gZXJyb3JzIHdpdGggbGFtYmRh cyBpbiBTZXJ2aWNlIFdvcmtlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5NDg0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAg ICAgIE1TVkMgaGFzIHByb2JsZW1zIHdpdGggdGhlIHNjb3Bpbmcgb2YgYHRoaXNgIHdpdGhpbiBh IG5lc3RlZCBsYW1iZGEuIEluIHRoZXNlIGNhc2VzIGB0aGlzYCBpcworICAgICAgICByZWZlcnJp bmcgdG8gdGhlIGVuY2xvc2luZyBsYW1iZGEgYWNjb3JkaW5nIHRvIE1TVkMuIFRoaXMgcGF0Y2gg d29ya3MgYXJvdW5kIHRoaXMgYmVoYXZpb3IKKyAgICAgICAgdGhyb3VnaCBieSB1c2luZyB0aGUg YHByb3RlY3RlZFRoaXNgIHBhdHRlcm4gaW4gV2ViS2l0IGNvZGUuCisKKyAgICAgICAgKiB3b3Jr ZXJzL3NlcnZpY2Uvc2VydmVyL1JlZ2lzdHJhdGlvbkRhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlZ2lzdHJhdGlvbkRhdGFiYXNlOjpvcGVuU1FMaXRlRGF0YWJhc2UpOgorCiAyMDE5 LTAyLTE5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JF U1NJT04ocjI0MDkwOSk6IFJlbGVhc2UgYXNzZXJ0aW9uIGluIEZyYW1lTG9hZGVyOjpsb2FkUG9z dFJlcXVlc3Qgd2hlbiBvcGVuaW5nIG5ldyB3aW5kb3cKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvUmVnaXN0cmF0aW9uRGF0YWJhc2UuY3BwIGIvU291 cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9SZWdpc3RyYXRpb25EYXRhYmFzZS5j cHAKaW5kZXggNTVjOGZjZWQyOTguLjQxZTgwNTU0MzM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1JlZ2lzdHJhdGlvbkRhdGFiYXNlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1JlZ2lzdHJhdGlvbkRhdGFi YXNlLmNwcApAQCAtMTMzLDcgKzEzMyw3IEBAIHZvaWQgUmVnaXN0cmF0aW9uRGF0YWJhc2U6Om9w ZW5TUUxpdGVEYXRhYmFzZShjb25zdCBTdHJpbmcmIGZ1bGxGaWxlbmFtZSkKICAgICBMT0coU2Vy dmljZVdvcmtlciwgIlNlcnZpY2VXb3JrZXIgUmVnaXN0cmF0aW9uRGF0YWJhc2Ugb3BlbmluZyBm aWxlICVzIiwgZnVsbEZpbGVuYW1lLnV0ZjgoKS5kYXRhKCkpOwogCiAgICAgU3RyaW5nIGVycm9y TWVzc2FnZTsKLSAgICBhdXRvIHNjb3BlRXhpdCA9IG1ha2VTY29wZUV4aXQoWyYsIGVycm9yTWVz c2FnZSA9ICZlcnJvck1lc3NhZ2VdIHsKKyAgICBhdXRvIHNjb3BlRXhpdCA9IG1ha2VTY29wZUV4 aXQoW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgZXJyb3JNZXNzYWdlID0g JmVycm9yTWVzc2FnZV0gewogICAgICAgICBBU1NFUlRfVU5VU0VEKGVycm9yTWVzc2FnZSwgIWVy cm9yTWVzc2FnZS0+aXNOdWxsKCkpOwogCiAjaWYgUkVMRUFTRV9MT0dfRElTQUJMRUQKQEAgLTE0 Myw3ICsxNDMsNyBAQCB2b2lkIFJlZ2lzdHJhdGlvbkRhdGFiYXNlOjpvcGVuU1FMaXRlRGF0YWJh c2UoY29uc3QgU3RyaW5nJiBmdWxsRmlsZW5hbWUpCiAjZW5kaWYKIAogICAgICAgICBtX2RhdGFi YXNlID0gbnVsbHB0cjsKLSAgICAgICAgY2FsbE9uTWFpblRocmVhZChbcHJvdGVjdGVkVGhpcyA9 IG1ha2VSZWYoKnRoaXMpXSB7CisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW3Byb3RlY3RlZFRo aXMgPSBwcm90ZWN0ZWRUaGlzLmNvcHlSZWYoKV0gewogICAgICAgICAgICAgcHJvdGVjdGVkVGhp cy0+ZGF0YWJhc2VGYWlsZWRUb09wZW4oKTsKICAgICAgICAgfSk7CiAgICAgfSk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmlu ZGV4IDkxMDE5YmJkMTdhLi43YzdiNDIwOTM0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxOS0wMi0xOSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAg ICAgIFtNU1ZDXSBGaXggY29tcGlsYXRpb24gZXJyb3JzIHdpdGggbGFtYmRhcyBpbiBTZXJ2aWNl IFdvcmtlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5NDg0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9TdG9yYWdlL1NlcnZpY2VXb3JrZXJDbGllbnRGZXRjaC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OlNlcnZpY2VXb3JrZXJDbGllbnRGZXRjaDo6ZGlkUmVjZWl2ZVJlZGlyZWN0 UmVzcG9uc2UpOgorCiAyMDE5LTAyLTE5ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNv bT4KIAogICAgICAgICBQYXNzIHJvb3RDb250ZW50c0xheWVyIHRvIE1hYyByZW1vdGUgbGF5ZXIg dHJlZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1N0b3JhZ2UvU2Vydmlj ZVdvcmtlckNsaWVudEZldGNoLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9TdG9yYWdl L1NlcnZpY2VXb3JrZXJDbGllbnRGZXRjaC5jcHAKaW5kZXggZjA3NDczYzg1NWIuLmM5YTNmMzRm MjkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvU3RvcmFnZS9TZXJ2aWNl V29ya2VyQ2xpZW50RmV0Y2guY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9TdG9y YWdlL1NlcnZpY2VXb3JrZXJDbGllbnRGZXRjaC5jcHAKQEAgLTExNSw3ICsxMTUsNyBAQCB2b2lk IFNlcnZpY2VXb3JrZXJDbGllbnRGZXRjaDo6ZGlkUmVjZWl2ZVJlZGlyZWN0UmVzcG9uc2UoUmVz b3VyY2VSZXNwb25zZSYmIHJlcwogICAgICAgICB9CiAgICAgICAgIHJlc3BvbnNlLnNldFNvdXJj ZShSZXNvdXJjZVJlc3BvbnNlOjpTb3VyY2U6OlNlcnZpY2VXb3JrZXIpOwogCi0gICAgICAgIG1f bG9hZGVyLT53aWxsU2VuZFJlcXVlc3QobV9sb2FkZXItPnJlcXVlc3QoKS5yZWRpcmVjdGVkUmVx dWVzdChyZXNwb25zZSwgbV9zaG91bGRDbGVhclJlZmVycmVyT25IVFRQU1RvSFRUUFJlZGlyZWN0 KSwgcmVzcG9uc2UsIFtwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIHRoaXNdKFJlc291 cmNlUmVxdWVzdCYmIHJlcXVlc3QpIHsKKyAgICAgICAgbV9sb2FkZXItPndpbGxTZW5kUmVxdWVz dChtX2xvYWRlci0+cmVxdWVzdCgpLnJlZGlyZWN0ZWRSZXF1ZXN0KHJlc3BvbnNlLCBtX3Nob3Vs ZENsZWFyUmVmZXJyZXJPbkhUVFBTVG9IVFRQUmVkaXJlY3QpLCByZXNwb25zZSwgW3RoaXMsIHBy b3RlY3RlZFRoaXMgPSBwcm90ZWN0ZWRUaGlzLmNvcHlSZWYoKV0oUmVzb3VyY2VSZXF1ZXN0JiYg cmVxdWVzdCkgewogICAgICAgICAgICAgaWYgKCFtX2xvYWRlciB8fCByZXF1ZXN0LmlzTnVsbCgp KSB7CiAgICAgICAgICAgICAgICAgaWYgKGF1dG8gY2FsbGJhY2sgPSBXVEZNb3ZlKG1fY2FsbGJh Y2spKQogICAgICAgICAgICAgICAgICAgICBjYWxsYmFjayhSZXN1bHQ6OlN1Y2NlZWRlZCk7Cg==