194837 2019-02-19 15:43:47 -0800 [bmalloc] DebugHeap::malloc does not have "try" version. 2019-02-21 02:14:51 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue darin mark.lam webkit-bug-importer oldest_to_newest 1507889 0 ysuzuki 2019-02-19 15:43:47 -0800 ... 1507958 1 362468 ysuzuki 2019-02-19 18:21:55 -0800 Created attachment 362468 Patch 1508107 2 362468 mark.lam 2019-02-20 10:05:09 -0800 Comment on attachment 362468 Patch r=me 1508219 3 ysuzuki 2019-02-20 13:45:59 -0800 (In reply to Mark Lam from comment #2) > Comment on attachment 362468 [details] > Patch > > r=me Thanks! 1508242 4 362468 commit-queue 2019-02-20 14:22:18 -0800 Comment on attachment 362468 Patch Clearing flags on attachment: 362468 Committed r241837: <https://trac.webkit.org/changeset/241837> 1508243 5 commit-queue 2019-02-20 14:22:19 -0800 All reviewed patches have been landed. Closing bug. 1508247 6 webkit-bug-importer 2019-02-20 14:23:29 -0800 <rdar://problem/48251809> 1508449 7 darin 2019-02-20 21:51:11 -0800 Why not put the crash on failure at the call sites? Seems strange to pass a boolean just to do a check that the caller could have done. 1508477 8 ysuzuki 2019-02-21 02:14:51 -0800 (In reply to Darin Adler from comment #7) > Why not put the crash on failure at the call sites? Seems strange to pass a > boolean just to do a check that the caller could have done. The patch adds missing tryAllocate feature into DebugHeap, and this style is aligned to the existing DebugHeap::memalign, bmalloc allocators, and JSC GC Heap Allocators (JavaScriptCore/heap/AllocationFailureMode.h). I think our (current) typical style is, creating low-level allocator with this style, and constructing tryAllocate / allocate APIs on these low-level allocators, and expose them to clients (e.g. JSArray::tryCreate). I'm not sure the original intent of this API design. But one pros is that we can gather CRASH into one place instead of putting it at the caller sites, while we still keep good "try" or "not-try" information in stacktrace's function name (`tryAllocate` or `allocate`). But I don't have strong opinion here as long as the style is consistent :) 362468 2019-02-19 18:21:55 -0800 2019-02-20 14:22:18 -0800 Patch bug-194837-20190219182154.patch text/plain 4705 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNzg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggZmY5YTg4YTY5ZWM1Y2Rj YmIwNTE0MjViYjQwODE0MTRlNTI1ZjY5OS4uN2NlN2ZlYTRlNjhkMTcyNjlmNGYwZTc0MDQwOGQ5 MTA4ZDE1ZDhkZSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTAyLTE5ICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW2JtYWxsb2NdIERlYnVn SGVhcDo6bWFsbG9jIGRvZXMgbm90IGhhdmUgInRyeSIgdmVyc2lvbi4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDgzNworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIERlYnVnSGVhcDo6bWFsbG9j IGRvZXMgbm90IGhhdmUgInRyeSIgdmVyc2lvbiwgb3VyIHRyeUFsbG9jYXRlIGltcGxlbWVudGF0 aW9uIGRvZXMgbm90IHdvcmsgd2VsbCB3aXRoIERlYnVnSGVhcC4KKyAgICAgICAgVGhpcyBwYXRj aCBhZGRzIGNyYXNoT25GYWlsdXJlIGZsYWcgdG8gRGVidWdIZWFwOjptYWxsb2MuCisKKyAgICAg ICAgKiBibWFsbG9jL0NhY2hlLmNwcDoKKyAgICAgICAgKGJtYWxsb2M6OkNhY2hlOjp0cnlBbGxv Y2F0ZVNsb3dDYXNlTnVsbENhY2hlKToKKyAgICAgICAgKGJtYWxsb2M6OkNhY2hlOjphbGxvY2F0 ZVNsb3dDYXNlTnVsbENhY2hlKToKKyAgICAgICAgKiBibWFsbG9jL0RlYnVnSGVhcC5jcHA6Cisg ICAgICAgIChibWFsbG9jOjpEZWJ1Z0hlYXA6Om1hbGxvYyk6CisgICAgICAgICogYm1hbGxvYy9E ZWJ1Z0hlYXAuaDoKKyAgICAgICAgKiBibWFsbG9jL0lzb1RMUy5jcHA6CisgICAgICAgIChibWFs bG9jOjpJc29UTFM6OmRlYnVnTWFsbG9jKToKKwogMjAxOS0wMi0xOSAgWXVzdWtlIFN1enVraSAg PHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtibWFsbG9jXSBibWFsbG9jOjpDYWNoZSBz aG91bGQgbm90IGJlIGluc3RhbnRpYXRlZCBpZiB3ZSBhcmUgdXNpbmcgc3lzdGVtIG1hbGxvYwpk aWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9DYWNoZS5jcHAgYi9Tb3VyY2UvYm1h bGxvYy9ibWFsbG9jL0NhY2hlLmNwcAppbmRleCAyOWFkMTMwOTg2NmYxMmQ4MDlmNmYxMjFkOWY2 NTExZWQ3MzUzNjJhLi42NDI5MmExNDViY2JiOGJkMzQ2ODFlMzlhMDVjOTllODhlMmE2NjQxIDEw MDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0NhY2hlLmNwcAorKysgYi9Tb3VyY2Uv Ym1hbGxvYy9ibWFsbG9jL0NhY2hlLmNwcApAQCAtNjYsMTcgKzY2LDE5IEBAIENhY2hlOjpDYWNo ZShIZWFwS2luZCBoZWFwS2luZCkKIAogQk5PX0lOTElORSB2b2lkKiBDYWNoZTo6dHJ5QWxsb2Nh dGVTbG93Q2FzZU51bGxDYWNoZShIZWFwS2luZCBoZWFwS2luZCwgc2l6ZV90IHNpemUpCiB7Ci0g ICAgLy8gRklYTUU6IERlYnVnSGVhcCBkb2VzIG5vdCBoYXZlIHRyeUFsbG9jYXRlIGZlYXR1cmUu Ci0gICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDgzNwot ICAgIGlmIChhdXRvKiBoZWFwID0gZGVidWdIZWFwKCkpCi0gICAgICAgIHJldHVybiBoZWFwLT5t YWxsb2Moc2l6ZSk7CisgICAgaWYgKGF1dG8qIGhlYXAgPSBkZWJ1Z0hlYXAoKSkgeworICAgICAg ICBjb25zdGV4cHIgYm9vbCBjcmFzaE9uRmFpbHVyZSA9IGZhbHNlOworICAgICAgICByZXR1cm4g aGVhcC0+bWFsbG9jKHNpemUsIGNyYXNoT25GYWlsdXJlKTsKKyAgICB9CiAgICAgcmV0dXJuIFBl clRocmVhZDxQZXJIZWFwS2luZDxDYWNoZT4+OjpnZXRTbG93Q2FzZSgpLT5hdChtYXBUb0FjdGl2 ZUhlYXBLaW5kKGhlYXBLaW5kKSkuYWxsb2NhdG9yKCkudHJ5QWxsb2NhdGUoc2l6ZSk7CiB9CiAK IEJOT19JTkxJTkUgdm9pZCogQ2FjaGU6OmFsbG9jYXRlU2xvd0Nhc2VOdWxsQ2FjaGUoSGVhcEtp bmQgaGVhcEtpbmQsIHNpemVfdCBzaXplKQogewotICAgIGlmIChhdXRvKiBoZWFwID0gZGVidWdI ZWFwKCkpCi0gICAgICAgIHJldHVybiBoZWFwLT5tYWxsb2Moc2l6ZSk7CisgICAgaWYgKGF1dG8q IGhlYXAgPSBkZWJ1Z0hlYXAoKSkgeworICAgICAgICBjb25zdGV4cHIgYm9vbCBjcmFzaE9uRmFp bHVyZSA9IHRydWU7CisgICAgICAgIHJldHVybiBoZWFwLT5tYWxsb2Moc2l6ZSwgY3Jhc2hPbkZh aWx1cmUpOworICAgIH0KICAgICByZXR1cm4gUGVyVGhyZWFkPFBlckhlYXBLaW5kPENhY2hlPj46 OmdldFNsb3dDYXNlKCktPmF0KG1hcFRvQWN0aXZlSGVhcEtpbmQoaGVhcEtpbmQpKS5hbGxvY2F0 b3IoKS5hbGxvY2F0ZShzaXplKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1h bGxvYy9EZWJ1Z0hlYXAuY3BwIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9EZWJ1Z0hlYXAuY3Bw CmluZGV4IGYyMWY1YTUyZjVjMmE2NWVlYTBlZmJlOGM2MTkxNzUxYjU5MDQ5OTAuLjFmZjE3ODBi MWFlMjVkMTNjMzU3NmViMTBjM2Y5MTY4N2EyNzAxMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFs bG9jL2JtYWxsb2MvRGVidWdIZWFwLmNwcAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0Rl YnVnSGVhcC5jcHAKQEAgLTQzLDEwICs0MywxMCBAQCBEZWJ1Z0hlYXA6OkRlYnVnSGVhcChzdGQ6 OmxvY2tfZ3VhcmQ8TXV0ZXg+JikKICAgICBtYWxsb2Nfc2V0X3pvbmVfbmFtZShtX3pvbmUsICJX ZWJLaXQgVXNpbmcgU3lzdGVtIE1hbGxvYyIpOwogfQogCi12b2lkKiBEZWJ1Z0hlYXA6Om1hbGxv YyhzaXplX3Qgc2l6ZSkKK3ZvaWQqIERlYnVnSGVhcDo6bWFsbG9jKHNpemVfdCBzaXplLCBib29s IGNyYXNoT25GYWlsdXJlKQogewogICAgIHZvaWQqIHJlc3VsdCA9IG1hbGxvY196b25lX21hbGxv YyhtX3pvbmUsIHNpemUpOwotICAgIGlmICghcmVzdWx0KQorICAgIGlmICghcmVzdWx0ICYmIGNy YXNoT25GYWlsdXJlKQogICAgICAgICBCQ1JBU0goKTsKICAgICByZXR1cm4gcmVzdWx0OwogfQpA QCAtNzksMTAgKzc5LDEwIEBAIERlYnVnSGVhcDo6RGVidWdIZWFwKHN0ZDo6bG9ja19ndWFyZDxN dXRleD4mKQogewogfQogCi12b2lkKiBEZWJ1Z0hlYXA6Om1hbGxvYyhzaXplX3Qgc2l6ZSkKK3Zv aWQqIERlYnVnSGVhcDo6bWFsbG9jKHNpemVfdCBzaXplLCBib29sIGNyYXNoT25GYWlsdXJlKQog ewogICAgIHZvaWQqIHJlc3VsdCA9IDo6bWFsbG9jKHNpemUpOwotICAgIGlmICghcmVzdWx0KQor ICAgIGlmICghcmVzdWx0ICYmIGNyYXNoT25GYWlsdXJlKQogICAgICAgICBCQ1JBU0goKTsKICAg ICByZXR1cm4gcmVzdWx0OwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9E ZWJ1Z0hlYXAuaCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRGVidWdIZWFwLmgKaW5kZXggMjE5 ZjgzNzRlNTc5ZjE5YzQ1ZDg2NDVmMGY0ZTg5MGRkZDgyYjk4ZC4uNTE4YTY0NWQxMjRiYzdkM2Iz MzA1ZjE2ZGQ5M2JhZGRkNzRlNmVkYiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvYm1hbGxv Yy9EZWJ1Z0hlYXAuaAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0RlYnVnSGVhcC5oCkBA IC0zOSw3ICszOSw3IEBAIGNsYXNzIERlYnVnSGVhcCB7CiBwdWJsaWM6CiAgICAgRGVidWdIZWFw KHN0ZDo6bG9ja19ndWFyZDxNdXRleD4mKTsKICAgICAKLSAgICB2b2lkKiBtYWxsb2Moc2l6ZV90 KTsKKyAgICB2b2lkKiBtYWxsb2Moc2l6ZV90LCBib29sIGNyYXNoT25GYWlsdXJlKTsKICAgICB2 b2lkKiBtZW1hbGlnbihzaXplX3QgYWxpZ25tZW50LCBzaXplX3QsIGJvb2wgY3Jhc2hPbkZhaWx1 cmUpOwogICAgIHZvaWQqIHJlYWxsb2Modm9pZCosIHNpemVfdCwgYm9vbCBjcmFzaE9uRmFpbHVy ZSk7CiAgICAgdm9pZCBmcmVlKHZvaWQqKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvSXNvVExTLmNwcCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvSXNvVExTLmNwcAppbmRl eCBjOTZmMjIyNzc3NjdlNTdiZDBkZmYyZmZkODU0ZjY2ZjlkNmZlMjY1Li41MjA1NjVmODRhZDZh Yzg5OTQ3NDM2NzVhMWZjOWYxNGZkMjVjNzBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9i bWFsbG9jL0lzb1RMUy5jcHAKKysrIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Jc29UTFMuY3Bw CkBAIC0xODIsOCArMTgyLDEwIEBAIGJvb2wgSXNvVExTOjppc1VzaW5nRGVidWdIZWFwKCkKIGF1 dG8gSXNvVExTOjpkZWJ1Z01hbGxvYyhzaXplX3Qgc2l6ZSkgLT4gRGVidWdNYWxsb2NSZXN1bHQK IHsKICAgICBEZWJ1Z01hbGxvY1Jlc3VsdCByZXN1bHQ7Ci0gICAgaWYgKChyZXN1bHQudXNpbmdE ZWJ1Z0hlYXAgPSBpc1VzaW5nRGVidWdIZWFwKCkpKQotICAgICAgICByZXN1bHQucHRyID0gUGVy UHJvY2VzczxEZWJ1Z0hlYXA+OjpnZXQoKS0+bWFsbG9jKHNpemUpOworICAgIGlmICgocmVzdWx0 LnVzaW5nRGVidWdIZWFwID0gaXNVc2luZ0RlYnVnSGVhcCgpKSkgeworICAgICAgICBjb25zdGV4 cHIgYm9vbCBjcmFzaE9uRmFpbHVyZSA9IHRydWU7CisgICAgICAgIHJlc3VsdC5wdHIgPSBQZXJQ cm9jZXNzPERlYnVnSGVhcD46OmdldCgpLT5tYWxsb2Moc2l6ZSwgY3Jhc2hPbkZhaWx1cmUpOwor ICAgIH0KICAgICByZXR1cm4gcmVzdWx0OwogfQogCg==