194831 2019-02-19 14:54:11 -0800 CachedCall should not consider it UNLIKELY that it will not stack overflow 2019-02-19 15:18:36 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmorisset rmorisset commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1507846 0 rmorisset 2019-02-19 14:54:11 -0800 if (UNLIKELY(vm.isSafeToRecurseSoft())) { in CachedCall.h is absurd: running out of stack is not likely. 1507847 1 362438 rmorisset 2019-02-19 14:56:03 -0800 Created attachment 362438 Patch 1507852 2 362438 mark.lam 2019-02-19 15:00:01 -0800 Comment on attachment 362438 Patch r=me 1507867 3 362438 commit-queue 2019-02-19 15:17:22 -0800 Comment on attachment 362438 Patch Clearing flags on attachment: 362438 Committed r241781: <https://trac.webkit.org/changeset/241781> 1507868 4 commit-queue 2019-02-19 15:17:24 -0800 All reviewed patches have been landed. Closing bug. 1507873 5 webkit-bug-importer 2019-02-19 15:18:36 -0800 <rdar://problem/48217244> 362438 2019-02-19 14:56:03 -0800 2019-02-19 15:17:22 -0800 Patch patch194831 text/plain 1476 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDIwMzczMDUyMDJlLi4wZTgxYTY1MWNhNyAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDItMTkgIFJvYmlu IE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAgICBDYWNoZWRDYWxsIHNo b3VsZCBub3QgY29uc2lkZXIgaXQgVU5MSUtFTFkgdGhhdCBpdCB3aWxsIG5vdCBzdGFjayBvdmVy ZmxvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk0 ODMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBp bnRlcnByZXRlci9DYWNoZWRDYWxsLmg6CisgICAgICAgIChKU0M6OkNhY2hlZENhbGw6OkNhY2hl ZENhbGwpOgorCiAyMDE5LTAyLTE4ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+ CiAKICAgICAgICAgW0pTQ10gSW50cm9kdWNlIEpTTm9uRGVzdHJ1Y3RpYmxlUHJveHkgZm9yIEph dmFTY3JpcHRDb3JlLmZyYW1ld29yaydzIEdsb2JhbFRoaXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9DYWNoZWRDYWxsLmggYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaW50ZXJwcmV0ZXIvQ2FjaGVkQ2FsbC5oCmluZGV4IGMyMGE4NTU1NmI3Li44MGQ3OTc3 OTQ0NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0NhY2hl ZENhbGwuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvQ2FjaGVkQ2Fs bC5oCkBAIC00OSw3ICs0OSw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAgICAgYXV0byBz Y29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOwogCiAgICAgICAgICAgICBBU1NFUlQoIWZ1 bmN0aW9uLT5pc0hvc3RGdW5jdGlvbk5vbklubGluZSgpKTsKLSAgICAgICAgICAgIGlmIChVTkxJ S0VMWSh2bS5pc1NhZmVUb1JlY3Vyc2VTb2Z0KCkpKSB7CisgICAgICAgICAgICBpZiAoTElLRUxZ KHZtLmlzU2FmZVRvUmVjdXJzZVNvZnQoKSkpIHsKICAgICAgICAgICAgICAgICBtX2FyZ3VtZW50 cy5lbnN1cmVDYXBhY2l0eShhcmd1bWVudENvdW50KTsKICAgICAgICAgICAgICAgICBpZiAoTElL RUxZKCFtX2FyZ3VtZW50cy5oYXNPdmVyZmxvd2VkKCkpKQogICAgICAgICAgICAgICAgICAgICBt X2Nsb3N1cmUgPSBtX2ludGVycHJldGVyLT5wcmVwYXJlRm9yUmVwZWF0Q2FsbChmdW5jdGlvbi0+ anNFeGVjdXRhYmxlKCksIGNhbGxGcmFtZSwgJm1fcHJvdG9DYWxsRnJhbWUsIGZ1bmN0aW9uLCBh cmd1bWVudENvdW50ICsgMSwgZnVuY3Rpb24tPnNjb3BlKCksIG1fYXJndW1lbnRzKTsK