<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>194824</bug_id>
          
          <creation_ts>2019-02-19 11:55:45 -0800</creation_ts>
          <short_desc>Code quality cleanup in NeverDestroyed</short_desc>
          <delta_ts>2019-03-03 11:58:21 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>194833</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Keith Miller">keith_miller</reporter>
          <assigned_to name="Keith Miller">keith_miller</assigned_to>
          <cc>benjamin</cc>
    
    <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>dbates</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>kangil.han</cc>
    
    <cc>krollin</cc>
    
    <cc>mark.lam</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1507749</commentid>
    <comment_count>0</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-02-19 11:55:45 -0800</bug_when>
    <thetext>Code quality cleanup in NeverDestroyed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1507750</commentid>
    <comment_count>1</comment_count>
      <attachid>362406</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-02-19 11:58:11 -0800</bug_when>
    <thetext>Created attachment 362406
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1507751</commentid>
    <comment_count>2</comment_count>
      <attachid>362406</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2019-02-19 11:59:19 -0800</bug_when>
    <thetext>Comment on attachment 362406
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1507759</commentid>
    <comment_count>3</comment_count>
      <attachid>362406</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-02-19 12:07:36 -0800</bug_when>
    <thetext>Comment on attachment 362406
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362406&amp;action=review

&gt; Source/WTF/wtf/NeverDestroyed.h:137
&gt; -    // LazyNeverDestroyed objects are always static, so this variable is initialized to false.
&gt; -    // It must not be initialized dynamically; that would not be thread safe.
&gt; -    bool m_isConstructed;
&gt; +    bool m_isConstructed { false };

Nvm, this triggers the global constructor error to fire. We can&apos;t do this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1507762</commentid>
    <comment_count>4</comment_count>
      <attachid>362409</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-02-19 12:08:04 -0800</bug_when>
    <thetext>Created attachment 362409
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1507763</commentid>
    <comment_count>5</comment_count>
      <attachid>362410</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-02-19 12:08:31 -0800</bug_when>
    <thetext>Created attachment 362410
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1507776</commentid>
    <comment_count>6</comment_count>
      <attachid>362410</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-02-19 12:45:58 -0800</bug_when>
    <thetext>Comment on attachment 362410
Patch for landing

Clearing flags on attachment: 362410

Committed r241770: &lt;https://trac.webkit.org/changeset/241770&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1507777</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-02-19 12:45:59 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1507779</commentid>
    <comment_count>8</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-02-19 12:52:47 -0800</bug_when>
    <thetext>&lt;rdar://problem/48211208&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1507859</commentid>
    <comment_count>9</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2019-02-19 15:09:24 -0800</bug_when>
    <thetext>This caused a bunch of crashes: https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/r241770%20(7858)/results.html

Rolling out</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1509097</commentid>
    <comment_count>10</comment_count>
      <attachid>362740</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-02-22 12:02:14 -0800</bug_when>
    <thetext>Created attachment 362740
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1509104</commentid>
    <comment_count>11</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-02-22 12:11:21 -0800</bug_when>
    <thetext>Turns out the bug was that make_names.pl was just reinterpret_casting LazyNeverDestroyed to the type it holds... Not ideal. So I fixed that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1509105</commentid>
    <comment_count>12</comment_count>
      <attachid>362741</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-02-22 12:12:03 -0800</bug_when>
    <thetext>Created attachment 362741
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1510255</commentid>
    <comment_count>13</comment_count>
      <attachid>362741</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2019-02-26 16:31:44 -0800</bug_when>
    <thetext>Comment on attachment 362741
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362741&amp;action=review

r=me

&gt; Source/WTF/wtf/NeverDestroyed.h:78
&gt; +    // FIXME: Investigate whether we should allocate a hunk of virtual memory

/hunk/chunk/?

&gt; Source/WTF/wtf/NeverDestroyed.h:142
&gt; +    // FIXME: Investigate whether we should allocate a hunk of virtual memory

/hunk/chunk/?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1510259</commentid>
    <comment_count>14</comment_count>
      <attachid>362741</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-02-26 16:33:43 -0800</bug_when>
    <thetext>Comment on attachment 362741
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362741&amp;action=review

&gt;&gt; Source/WTF/wtf/NeverDestroyed.h:142
&gt;&gt; +    // FIXME: Investigate whether we should allocate a hunk of virtual memory
&gt; 
&gt; /hunk/chunk/?

Dunno, I just moved it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1510276</commentid>
    <comment_count>15</comment_count>
      <attachid>362741</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-02-26 16:59:55 -0800</bug_when>
    <thetext>Comment on attachment 362741
Patch

Clearing flags on attachment: 362741

Committed r242116: &lt;https://trac.webkit.org/changeset/242116&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1510277</commentid>
    <comment_count>16</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-02-26 16:59:57 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1511926</commentid>
    <comment_count>17</comment_count>
      <attachid>362741</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-03-03 00:45:30 -0800</bug_when>
    <thetext>Comment on attachment 362741
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362741&amp;action=review

&gt; Source/WebCore/dom/make_names.pl:776
&gt; -            print F &quot;        reinterpret_cast&lt;const WebCore::$parameters{namespace}QualifiedName*&gt;(&amp;${name}Tag),\n&quot;;
&gt; +            print F &quot;        &amp;${name}Tag.get(),\n&quot;;

I think this was done so that the tables would be generated as read-only data rather than a long sequence of inlined code that initializes the tables. I suspect this change removes that optimization. Could you check? I know it might be inelegant, but I believe it made a substantial difference in code size.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1511961</commentid>
    <comment_count>18</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2019-03-03 11:48:52 -0800</bug_when>
    <thetext>(In reply to Darin Adler from comment #17)
&gt; Comment on attachment 362741 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=362741&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/dom/make_names.pl:776
&gt; &gt; -            print F &quot;        reinterpret_cast&lt;const WebCore::$parameters{namespace}QualifiedName*&gt;(&amp;${name}Tag),\n&quot;;
&gt; &gt; +            print F &quot;        &amp;${name}Tag.get(),\n&quot;;
&gt; 
&gt; I think this was done so that the tables would be generated as read-only
&gt; data rather than a long sequence of inlined code that initializes the
&gt; tables. I suspect this change removes that optimization. Could you check? I
&gt; know it might be inelegant, but I believe it made a substantial difference
&gt; in code size.

Ah that’s a fair point there should probably be a comment about that. Is there any reason the tables can’t be a NeverDestroyed&lt;std::array&lt;&gt;&gt;? That seems like it would solve both problems.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1511965</commentid>
    <comment_count>19</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-03-03 11:58:21 -0800</bug_when>
    <thetext>(In reply to Keith Miller from comment #18)
&gt; Is there any reason the tables can’t be a NeverDestroyed&lt;std::array&lt;&gt;&gt;?
&gt; That seems like it would solve both problems.

I don’t understand how std::array would help. The issue is whether this ends being data fixed up by the linker with no code, or code run the first time the function is run. Maybe std::array will help.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>362406</attachid>
            <date>2019-02-19 11:58:11 -0800</date>
            <delta_ts>2019-02-19 12:08:02 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-194824-20190219115811.patch</filename>
            <type>text/plain</type>
            <size>4277</size>
            <attacher name="Keith Miller">keith_miller</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGJkODVjNGUzOTc3YWYwNWVlZWM0OTQ4
Y2FhMjMzOTUzMTg1MmY5NDQuLjkxYmNiYmE2YmJiMzdkMDI2YTVjYzAyY2RjZjA2M2JjYWIyMjgx
YjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDItMTkgIEtlaXRoIE1pbGxlciAgPGtlaXRo
X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ29kZSBxdWFsaXR5IGNsZWFudXAgaW4gTmV2
ZXJEZXN0cm95ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE5NDgyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg
ICAgIEZpcnN0LCBtb3ZlIGRhdGEgbWVtYmVycyB0byB0aGUgZW5kIG9mIHRoZSBjbGFzcyBwZXIg
V2ViS2l0CisgICAgICAgIHN0eWxlLiBBbHNvLCBhZGQgZm9yYmlkIGhlYXAgYWxsb2NhdGlvbiBz
aW5jZSB3ZSBleHBlY3QgdGhlCisgICAgICAgIE5ldmVyRGVzdHJveWVkIGNsYXNzZXMgdG8gYmUg
c3RhdGljLiBMYXN0bHksIHNldCBzdGF0aWMgaW50aWFsaXplcgorICAgICAgICBmb3IgZGVidWcg
bV9jb25zdHJ1Y3RlZCBhbmQgcmVtb3ZlIHVubmVlZGVkIGNvbW1lbnQuCisKKyAgICAgICAgKiB3
dGYvTmV2ZXJEZXN0cm95ZWQuaDoKKwogMjAxOS0wMi0xNiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBh
cHBsZS5jb20+CiAKICAgICAgICAgQ29udGludWUgcmVkdWNpbmcgdXNlIG9mIFN0cmluZzo6Zm9y
bWF0LCBub3cgZm9jdXNpbmcgb24gaGV4OiAiJXAiLCAiJXgiLCBldGMuCmRpZmYgLS1naXQgYS9T
b3VyY2UvV1RGL3d0Zi9OZXZlckRlc3Ryb3llZC5oIGIvU291cmNlL1dURi93dGYvTmV2ZXJEZXN0
cm95ZWQuaAppbmRleCBjMzExZjEzNmZmNWU1ODQwZWU1ZjQ5ZWU1ZjcxODY4NjE4N2Q2NGM3Li5l
OTc3YTMzYWRlZTI0Yzg3MGYzYTU3ZWUwYjZiNGQxZDU5MWE2MTNkIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV1RGL3d0Zi9OZXZlckRlc3Ryb3llZC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL05ldmVyRGVz
dHJveWVkLmgKQEAgLTI3LDYgKzI3LDcgQEAKIAogI2luY2x1ZGUgPHR5cGVfdHJhaXRzPgogI2lu
Y2x1ZGUgPHV0aWxpdHk+CisjaW5jbHVkZSA8d3RmL0ZvcmJpZEhlYXBBbGxvY2F0aW9uLmg+CiAj
aW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KIAogLy8gTmV2ZXJEZXN0cm95ZWQgaXMgYSBzbWFy
dC1wb2ludGVyLWxpa2UgY2xhc3MgdGhhdCBlbnN1cmVzIHRoYXQgdGhlIGRlc3RydWN0b3IKQEAg
LTQzLDggKzQ0LDkgQEAgbmFtZXNwYWNlIFdURiB7CiAKIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGNs
YXNzIE5ldmVyRGVzdHJveWVkIHsKICAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShOZXZlckRlc3Ry
b3llZCk7Ci0KKyAgICBXVEZfRk9SQklEX0hFQVBfQUxMT0NBVElPTjsKIHB1YmxpYzoKKwogICAg
IHRlbXBsYXRlPHR5cGVuYW1lLi4uIEFyZ3M+IE5ldmVyRGVzdHJveWVkKEFyZ3MmJi4uLiBhcmdz
KQogICAgIHsKICAgICAgICAgTWF5YmVSZWxheDxUPihuZXcgKHN0b3JhZ2VQb2ludGVyKCkpIFQo
c3RkOjpmb3J3YXJkPEFyZ3M+KGFyZ3MpLi4uKSk7CkBAIC02NiwxNiArNjgsMTYgQEAgcHJpdmF0
ZToKIAogICAgIFBvaW50ZXJUeXBlIHN0b3JhZ2VQb2ludGVyKCkgY29uc3QgeyByZXR1cm4gY29u
c3RfY2FzdDxQb2ludGVyVHlwZT4ocmVpbnRlcnByZXRfY2FzdDxjb25zdCBUKj4oJm1fc3RvcmFn
ZSkpOyB9CiAKLSAgICAvLyBGSVhNRTogSW52ZXN0aWdhdGUgd2hldGhlciB3ZSBzaG91bGQgYWxs
b2NhdGUgYSBodW5rIG9mIHZpcnR1YWwgbWVtb3J5Ci0gICAgLy8gYW5kIGhhbmQgb3V0IGNodW5r
cyBvZiBpdCB0byBOZXZlckRlc3Ryb3llZCBpbnN0ZWFkLCB0byByZWR1Y2UgZnJhZ21lbnRhdGlv
bi4KLSAgICB0eXBlbmFtZSBzdGQ6OmFsaWduZWRfc3RvcmFnZTxzaXplb2YoVCksIHN0ZDo6YWxp
Z25tZW50X29mPFQ+Ojp2YWx1ZT46OnR5cGUgbV9zdG9yYWdlOwotCiAgICAgdGVtcGxhdGU8dHlw
ZW5hbWUgUHRyVHlwZSwgYm9vbCBTaG91bGRSZWxheCA9IHN0ZDo6aXNfYmFzZV9vZjxSZWZDb3Vu
dGVkQmFzZSwgUHRyVHlwZT46OnZhbHVlPiBzdHJ1Y3QgTWF5YmVSZWxheCB7CiAgICAgICAgIGV4
cGxpY2l0IE1heWJlUmVsYXgoUHRyVHlwZSopIHsgfQogICAgIH07CiAgICAgdGVtcGxhdGU8dHlw
ZW5hbWUgUHRyVHlwZT4gc3RydWN0IE1heWJlUmVsYXg8UHRyVHlwZSwgdHJ1ZT4gewogICAgICAg
ICBleHBsaWNpdCBNYXliZVJlbGF4KFB0clR5cGUqIHB0cikgeyBwdHItPnJlbGF4QWRvcHRpb25S
ZXF1aXJlbWVudCgpOyB9CiAgICAgfTsKKworICAgIC8vIEZJWE1FOiBJbnZlc3RpZ2F0ZSB3aGV0
aGVyIHdlIHNob3VsZCBhbGxvY2F0ZSBhIGh1bmsgb2YgdmlydHVhbCBtZW1vcnkKKyAgICAvLyBh
bmQgaGFuZCBvdXQgY2h1bmtzIG9mIGl0IHRvIE5ldmVyRGVzdHJveWVkIGluc3RlYWQsIHRvIHJl
ZHVjZSBmcmFnbWVudGF0aW9uLgorICAgIHR5cGVuYW1lIHN0ZDo6YWxpZ25lZF9zdG9yYWdlPHNp
emVvZihUKSwgc3RkOjphbGlnbm1lbnRfb2Y8VD46OnZhbHVlPjo6dHlwZSBtX3N0b3JhZ2U7CiB9
OwogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBOZXZlckRlc3Ryb3llZDxUPiBtYWtlTmV2ZXJEZXN0
cm95ZWQoVCYmKTsKQEAgLTg1LDcgKzg3LDcgQEAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gTmV2ZXJE
ZXN0cm95ZWQ8VD4gbWFrZU5ldmVyRGVzdHJveWVkKFQmJik7CiAvLyBzaGFyZSBtb3JlIG9mIHRo
ZSBjb2RlIHdpdGggdGhlIG1haW4gTmV2ZXJEZXN0cm95ZWQgYWJvdmUuCiB0ZW1wbGF0ZTx0eXBl
bmFtZSBUPiBjbGFzcyBMYXp5TmV2ZXJEZXN0cm95ZWQgewogICAgIFdURl9NQUtFX05PTkNPUFlB
QkxFKExhenlOZXZlckRlc3Ryb3llZCk7Ci0KKyAgICBXVEZfRk9SQklEX0hFQVBfQUxMT0NBVElP
TjsKIHB1YmxpYzoKICAgICBMYXp5TmV2ZXJEZXN0cm95ZWQoKSA9IGRlZmF1bHQ7CiAKQEAgLTEy
NCwxMCArMTI2LDYgQEAgcHJpdmF0ZToKICAgICAgICAgcmV0dXJuIGNvbnN0X2Nhc3Q8UG9pbnRl
clR5cGU+KHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgVCo+KCZtX3N0b3JhZ2UpKTsKICAgICB9CiAK
LSAgICAvLyBGSVhNRTogSW52ZXN0aWdhdGUgd2hldGhlciB3ZSBzaG91bGQgYWxsb2NhdGUgYSBo
dW5rIG9mIHZpcnR1YWwgbWVtb3J5Ci0gICAgLy8gYW5kIGhhbmQgb3V0IGNodW5rcyBvZiBpdCB0
byBOZXZlckRlc3Ryb3llZCBpbnN0ZWFkLCB0byByZWR1Y2UgZnJhZ21lbnRhdGlvbi4KLSAgICB0
eXBlbmFtZSBzdGQ6OmFsaWduZWRfc3RvcmFnZTxzaXplb2YoVCksIHN0ZDo6YWxpZ25tZW50X29m
PFQ+Ojp2YWx1ZT46OnR5cGUgbV9zdG9yYWdlOwotCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgUHRy
VHlwZSwgYm9vbCBTaG91bGRSZWxheCA9IHN0ZDo6aXNfYmFzZV9vZjxSZWZDb3VudGVkQmFzZSwg
UHRyVHlwZT46OnZhbHVlPiBzdHJ1Y3QgTWF5YmVSZWxheCB7CiAgICAgICAgIGV4cGxpY2l0IE1h
eWJlUmVsYXgoUHRyVHlwZSopIHsgfQogICAgIH07CkBAIC0xMzYsMTAgKzEzNCwxMiBAQCBwcml2
YXRlOgogICAgIH07CiAKICNpZiAhQVNTRVJUX0RJU0FCTEVECi0gICAgLy8gTGF6eU5ldmVyRGVz
dHJveWVkIG9iamVjdHMgYXJlIGFsd2F5cyBzdGF0aWMsIHNvIHRoaXMgdmFyaWFibGUgaXMgaW5p
dGlhbGl6ZWQgdG8gZmFsc2UuCi0gICAgLy8gSXQgbXVzdCBub3QgYmUgaW5pdGlhbGl6ZWQgZHlu
YW1pY2FsbHk7IHRoYXQgd291bGQgbm90IGJlIHRocmVhZCBzYWZlLgotICAgIGJvb2wgbV9pc0Nv
bnN0cnVjdGVkOworICAgIGJvb2wgbV9pc0NvbnN0cnVjdGVkIHsgZmFsc2UgfTsKICNlbmRpZgor
CisgICAgLy8gRklYTUU6IEludmVzdGlnYXRlIHdoZXRoZXIgd2Ugc2hvdWxkIGFsbG9jYXRlIGEg
aHVuayBvZiB2aXJ0dWFsIG1lbW9yeQorICAgIC8vIGFuZCBoYW5kIG91dCBjaHVua3Mgb2YgaXQg
dG8gTmV2ZXJEZXN0cm95ZWQgaW5zdGVhZCwgdG8gcmVkdWNlIGZyYWdtZW50YXRpb24uCisgICAg
dHlwZW5hbWUgc3RkOjphbGlnbmVkX3N0b3JhZ2U8c2l6ZW9mKFQpLCBzdGQ6OmFsaWdubWVudF9v
ZjxUPjo6dmFsdWU+Ojp0eXBlIG1fc3RvcmFnZTsKIH07CiAKIHRlbXBsYXRlPHR5cGVuYW1lIFQ+
IGlubGluZSBOZXZlckRlc3Ryb3llZDxUPiBtYWtlTmV2ZXJEZXN0cm95ZWQoVCYmIGFyZ3VtZW50
KQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>362409</attachid>
            <date>2019-02-19 12:08:04 -0800</date>
            <delta_ts>2019-02-19 12:08:29 -0800</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-194824-20190219120803.patch</filename>
            <type>text/plain</type>
            <size>4110</size>
            <attacher name="Keith Miller">keith_miller</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGJkODVjNGUzOTc3YWYwNWVlZWM0OTQ4
Y2FhMjMzOTUzMTg1MmY5NDQuLjg5MTIwN2Q0YTIzYzEwYjQwNDY4ZDc4MGM0MjMzODA0YThhNDE5
NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDItMTkgIEtlaXRoIE1pbGxlciAgPGtlaXRo
X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ29kZSBxdWFsaXR5IGNsZWFudXAgaW4gTmV2
ZXJEZXN0cm95ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE5NDgyNAorCisgICAgICAgIFJldmlld2VkIGJ5IFl1c3VrZSBTdXp1a2kuCisKKyAgICAg
ICAgRmlyc3QsIG1vdmUgZGF0YSBtZW1iZXJzIHRvIHRoZSBlbmQgb2YgdGhlIGNsYXNzIHBlciBX
ZWJLaXQKKyAgICAgICAgc3R5bGUuIEFsc28sIGFkZCBmb3JiaWQgaGVhcCBhbGxvY2F0aW9uIHNp
bmNlIHdlIGV4cGVjdCB0aGUKKyAgICAgICAgTmV2ZXJEZXN0cm95ZWQgY2xhc3NlcyB0byBiZSBz
dGF0aWMuIExhc3RseSwgc2V0IHN0YXRpYyBpbnRpYWxpemVyCisgICAgICAgIGZvciBkZWJ1ZyBt
X2NvbnN0cnVjdGVkIGFuZCByZW1vdmUgdW5uZWVkZWQgY29tbWVudC4KKworICAgICAgICAqIHd0
Zi9OZXZlckRlc3Ryb3llZC5oOgorCiAyMDE5LTAyLTE2ICBEYXJpbiBBZGxlciAgPGRhcmluQGFw
cGxlLmNvbT4KIAogICAgICAgICBDb250aW51ZSByZWR1Y2luZyB1c2Ugb2YgU3RyaW5nOjpmb3Jt
YXQsIG5vdyBmb2N1c2luZyBvbiBoZXg6ICIlcCIsICIleCIsIGV0Yy4KZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XVEYvd3RmL05ldmVyRGVzdHJveWVkLmggYi9Tb3VyY2UvV1RGL3d0Zi9OZXZlckRlc3Ry
b3llZC5oCmluZGV4IGMzMTFmMTM2ZmY1ZTU4NDBlZTVmNDllZTVmNzE4Njg2MTg3ZDY0YzcuLmU3
ZThhN2VhMDM5ODljYmE0MDRlYWJiODI1MzUwMGQ1YzNmN2Y1NTMgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XVEYvd3RmL05ldmVyRGVzdHJveWVkLmgKKysrIGIvU291cmNlL1dURi93dGYvTmV2ZXJEZXN0
cm95ZWQuaApAQCAtMjcsNiArMjcsNyBAQAogCiAjaW5jbHVkZSA8dHlwZV90cmFpdHM+CiAjaW5j
bHVkZSA8dXRpbGl0eT4KKyNpbmNsdWRlIDx3dGYvRm9yYmlkSGVhcEFsbG9jYXRpb24uaD4KICNp
bmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogCiAvLyBOZXZlckRlc3Ryb3llZCBpcyBhIHNtYXJ0
LXBvaW50ZXItbGlrZSBjbGFzcyB0aGF0IGVuc3VyZXMgdGhhdCB0aGUgZGVzdHJ1Y3RvcgpAQCAt
NDMsOCArNDQsOSBAQCBuYW1lc3BhY2UgV1RGIHsKIAogdGVtcGxhdGU8dHlwZW5hbWUgVD4gY2xh
c3MgTmV2ZXJEZXN0cm95ZWQgewogICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKE5ldmVyRGVzdHJv
eWVkKTsKLQorICAgIFdURl9GT1JCSURfSEVBUF9BTExPQ0FUSU9OOwogcHVibGljOgorCiAgICAg
dGVtcGxhdGU8dHlwZW5hbWUuLi4gQXJncz4gTmV2ZXJEZXN0cm95ZWQoQXJncyYmLi4uIGFyZ3Mp
CiAgICAgewogICAgICAgICBNYXliZVJlbGF4PFQ+KG5ldyAoc3RvcmFnZVBvaW50ZXIoKSkgVChz
dGQ6OmZvcndhcmQ8QXJncz4oYXJncykuLi4pKTsKQEAgLTY2LDE2ICs2OCwxNiBAQCBwcml2YXRl
OgogCiAgICAgUG9pbnRlclR5cGUgc3RvcmFnZVBvaW50ZXIoKSBjb25zdCB7IHJldHVybiBjb25z
dF9jYXN0PFBvaW50ZXJUeXBlPihyZWludGVycHJldF9jYXN0PGNvbnN0IFQqPigmbV9zdG9yYWdl
KSk7IH0KIAotICAgIC8vIEZJWE1FOiBJbnZlc3RpZ2F0ZSB3aGV0aGVyIHdlIHNob3VsZCBhbGxv
Y2F0ZSBhIGh1bmsgb2YgdmlydHVhbCBtZW1vcnkKLSAgICAvLyBhbmQgaGFuZCBvdXQgY2h1bmtz
IG9mIGl0IHRvIE5ldmVyRGVzdHJveWVkIGluc3RlYWQsIHRvIHJlZHVjZSBmcmFnbWVudGF0aW9u
LgotICAgIHR5cGVuYW1lIHN0ZDo6YWxpZ25lZF9zdG9yYWdlPHNpemVvZihUKSwgc3RkOjphbGln
bm1lbnRfb2Y8VD46OnZhbHVlPjo6dHlwZSBtX3N0b3JhZ2U7Ci0KICAgICB0ZW1wbGF0ZTx0eXBl
bmFtZSBQdHJUeXBlLCBib29sIFNob3VsZFJlbGF4ID0gc3RkOjppc19iYXNlX29mPFJlZkNvdW50
ZWRCYXNlLCBQdHJUeXBlPjo6dmFsdWU+IHN0cnVjdCBNYXliZVJlbGF4IHsKICAgICAgICAgZXhw
bGljaXQgTWF5YmVSZWxheChQdHJUeXBlKikgeyB9CiAgICAgfTsKICAgICB0ZW1wbGF0ZTx0eXBl
bmFtZSBQdHJUeXBlPiBzdHJ1Y3QgTWF5YmVSZWxheDxQdHJUeXBlLCB0cnVlPiB7CiAgICAgICAg
IGV4cGxpY2l0IE1heWJlUmVsYXgoUHRyVHlwZSogcHRyKSB7IHB0ci0+cmVsYXhBZG9wdGlvblJl
cXVpcmVtZW50KCk7IH0KICAgICB9OworCisgICAgLy8gRklYTUU6IEludmVzdGlnYXRlIHdoZXRo
ZXIgd2Ugc2hvdWxkIGFsbG9jYXRlIGEgaHVuayBvZiB2aXJ0dWFsIG1lbW9yeQorICAgIC8vIGFu
ZCBoYW5kIG91dCBjaHVua3Mgb2YgaXQgdG8gTmV2ZXJEZXN0cm95ZWQgaW5zdGVhZCwgdG8gcmVk
dWNlIGZyYWdtZW50YXRpb24uCisgICAgdHlwZW5hbWUgc3RkOjphbGlnbmVkX3N0b3JhZ2U8c2l6
ZW9mKFQpLCBzdGQ6OmFsaWdubWVudF9vZjxUPjo6dmFsdWU+Ojp0eXBlIG1fc3RvcmFnZTsKIH07
CiAKIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IE5ldmVyRGVzdHJveWVkPFQ+IG1ha2VOZXZlckRlc3Ry
b3llZChUJiYpOwpAQCAtODUsNyArODcsNyBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBOZXZlckRl
c3Ryb3llZDxUPiBtYWtlTmV2ZXJEZXN0cm95ZWQoVCYmKTsKIC8vIHNoYXJlIG1vcmUgb2YgdGhl
IGNvZGUgd2l0aCB0aGUgbWFpbiBOZXZlckRlc3Ryb3llZCBhYm92ZS4KIHRlbXBsYXRlPHR5cGVu
YW1lIFQ+IGNsYXNzIExhenlOZXZlckRlc3Ryb3llZCB7CiAgICAgV1RGX01BS0VfTk9OQ09QWUFC
TEUoTGF6eU5ldmVyRGVzdHJveWVkKTsKLQorICAgIFdURl9GT1JCSURfSEVBUF9BTExPQ0FUSU9O
OwogcHVibGljOgogICAgIExhenlOZXZlckRlc3Ryb3llZCgpID0gZGVmYXVsdDsKIApAQCAtMTI0
LDEwICsxMjYsNiBAQCBwcml2YXRlOgogICAgICAgICByZXR1cm4gY29uc3RfY2FzdDxQb2ludGVy
VHlwZT4ocmVpbnRlcnByZXRfY2FzdDxjb25zdCBUKj4oJm1fc3RvcmFnZSkpOwogICAgIH0KIAot
ICAgIC8vIEZJWE1FOiBJbnZlc3RpZ2F0ZSB3aGV0aGVyIHdlIHNob3VsZCBhbGxvY2F0ZSBhIGh1
bmsgb2YgdmlydHVhbCBtZW1vcnkKLSAgICAvLyBhbmQgaGFuZCBvdXQgY2h1bmtzIG9mIGl0IHRv
IE5ldmVyRGVzdHJveWVkIGluc3RlYWQsIHRvIHJlZHVjZSBmcmFnbWVudGF0aW9uLgotICAgIHR5
cGVuYW1lIHN0ZDo6YWxpZ25lZF9zdG9yYWdlPHNpemVvZihUKSwgc3RkOjphbGlnbm1lbnRfb2Y8
VD46OnZhbHVlPjo6dHlwZSBtX3N0b3JhZ2U7Ci0KICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBQdHJU
eXBlLCBib29sIFNob3VsZFJlbGF4ID0gc3RkOjppc19iYXNlX29mPFJlZkNvdW50ZWRCYXNlLCBQ
dHJUeXBlPjo6dmFsdWU+IHN0cnVjdCBNYXliZVJlbGF4IHsKICAgICAgICAgZXhwbGljaXQgTWF5
YmVSZWxheChQdHJUeXBlKikgeyB9CiAgICAgfTsKQEAgLTE0MCw2ICsxMzgsMTAgQEAgcHJpdmF0
ZToKICAgICAvLyBJdCBtdXN0IG5vdCBiZSBpbml0aWFsaXplZCBkeW5hbWljYWxseTsgdGhhdCB3
b3VsZCBub3QgYmUgdGhyZWFkIHNhZmUuCiAgICAgYm9vbCBtX2lzQ29uc3RydWN0ZWQ7CiAjZW5k
aWYKKworICAgIC8vIEZJWE1FOiBJbnZlc3RpZ2F0ZSB3aGV0aGVyIHdlIHNob3VsZCBhbGxvY2F0
ZSBhIGh1bmsgb2YgdmlydHVhbCBtZW1vcnkKKyAgICAvLyBhbmQgaGFuZCBvdXQgY2h1bmtzIG9m
IGl0IHRvIE5ldmVyRGVzdHJveWVkIGluc3RlYWQsIHRvIHJlZHVjZSBmcmFnbWVudGF0aW9uLgor
ICAgIHR5cGVuYW1lIHN0ZDo6YWxpZ25lZF9zdG9yYWdlPHNpemVvZihUKSwgc3RkOjphbGlnbm1l
bnRfb2Y8VD46OnZhbHVlPjo6dHlwZSBtX3N0b3JhZ2U7CiB9OwogCiB0ZW1wbGF0ZTx0eXBlbmFt
ZSBUPiBpbmxpbmUgTmV2ZXJEZXN0cm95ZWQ8VD4gbWFrZU5ldmVyRGVzdHJveWVkKFQmJiBhcmd1
bWVudCkK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>362410</attachid>
            <date>2019-02-19 12:08:31 -0800</date>
            <delta_ts>2019-02-22 12:02:12 -0800</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-194824-20190219120830.patch</filename>
            <type>text/plain</type>
            <size>4018</size>
            <attacher name="Keith Miller">keith_miller</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGJkODVjNGUzOTc3YWYwNWVlZWM0OTQ4
Y2FhMjMzOTUzMTg1MmY5NDQuLjdlZDYzMjcwY2E0YTNjZjQ1OGQ1YmRjNzliNTA4Nzk5YTFlMTVi
MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDItMTkgIEtlaXRoIE1pbGxlciAgPGtlaXRo
X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ29kZSBxdWFsaXR5IGNsZWFudXAgaW4gTmV2
ZXJEZXN0cm95ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE5NDgyNAorCisgICAgICAgIFJldmlld2VkIGJ5IFl1c3VrZSBTdXp1a2kuCisKKyAgICAg
ICAgRmlyc3QsIG1vdmUgZGF0YSBtZW1iZXJzIHRvIHRoZSBlbmQgb2YgdGhlIGNsYXNzIHBlciBX
ZWJLaXQKKyAgICAgICAgc3R5bGUuIEFsc28sIGFkZCBmb3JiaWQgaGVhcCBhbGxvY2F0aW9uIHNp
bmNlIHdlIGV4cGVjdCB0aGUKKyAgICAgICAgTmV2ZXJEZXN0cm95ZWQgY2xhc3NlcyB0byBiZSBz
dGF0aWMuCisKKyAgICAgICAgKiB3dGYvTmV2ZXJEZXN0cm95ZWQuaDoKKwogMjAxOS0wMi0xNiAg
RGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ29udGludWUgcmVkdWNp
bmcgdXNlIG9mIFN0cmluZzo6Zm9ybWF0LCBub3cgZm9jdXNpbmcgb24gaGV4OiAiJXAiLCAiJXgi
LCBldGMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9OZXZlckRlc3Ryb3llZC5oIGIvU291
cmNlL1dURi93dGYvTmV2ZXJEZXN0cm95ZWQuaAppbmRleCBjMzExZjEzNmZmNWU1ODQwZWU1ZjQ5
ZWU1ZjcxODY4NjE4N2Q2NGM3Li5lN2U4YTdlYTAzOTg5Y2JhNDA0ZWFiYjgyNTM1MDBkNWMzZjdm
NTUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9OZXZlckRlc3Ryb3llZC5oCisrKyBiL1Nv
dXJjZS9XVEYvd3RmL05ldmVyRGVzdHJveWVkLmgKQEAgLTI3LDYgKzI3LDcgQEAKIAogI2luY2x1
ZGUgPHR5cGVfdHJhaXRzPgogI2luY2x1ZGUgPHV0aWxpdHk+CisjaW5jbHVkZSA8d3RmL0ZvcmJp
ZEhlYXBBbGxvY2F0aW9uLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KIAogLy8gTmV2
ZXJEZXN0cm95ZWQgaXMgYSBzbWFydC1wb2ludGVyLWxpa2UgY2xhc3MgdGhhdCBlbnN1cmVzIHRo
YXQgdGhlIGRlc3RydWN0b3IKQEAgLTQzLDggKzQ0LDkgQEAgbmFtZXNwYWNlIFdURiB7CiAKIHRl
bXBsYXRlPHR5cGVuYW1lIFQ+IGNsYXNzIE5ldmVyRGVzdHJveWVkIHsKICAgICBXVEZfTUFLRV9O
T05DT1BZQUJMRShOZXZlckRlc3Ryb3llZCk7Ci0KKyAgICBXVEZfRk9SQklEX0hFQVBfQUxMT0NB
VElPTjsKIHB1YmxpYzoKKwogICAgIHRlbXBsYXRlPHR5cGVuYW1lLi4uIEFyZ3M+IE5ldmVyRGVz
dHJveWVkKEFyZ3MmJi4uLiBhcmdzKQogICAgIHsKICAgICAgICAgTWF5YmVSZWxheDxUPihuZXcg
KHN0b3JhZ2VQb2ludGVyKCkpIFQoc3RkOjpmb3J3YXJkPEFyZ3M+KGFyZ3MpLi4uKSk7CkBAIC02
NiwxNiArNjgsMTYgQEAgcHJpdmF0ZToKIAogICAgIFBvaW50ZXJUeXBlIHN0b3JhZ2VQb2ludGVy
KCkgY29uc3QgeyByZXR1cm4gY29uc3RfY2FzdDxQb2ludGVyVHlwZT4ocmVpbnRlcnByZXRfY2Fz
dDxjb25zdCBUKj4oJm1fc3RvcmFnZSkpOyB9CiAKLSAgICAvLyBGSVhNRTogSW52ZXN0aWdhdGUg
d2hldGhlciB3ZSBzaG91bGQgYWxsb2NhdGUgYSBodW5rIG9mIHZpcnR1YWwgbWVtb3J5Ci0gICAg
Ly8gYW5kIGhhbmQgb3V0IGNodW5rcyBvZiBpdCB0byBOZXZlckRlc3Ryb3llZCBpbnN0ZWFkLCB0
byByZWR1Y2UgZnJhZ21lbnRhdGlvbi4KLSAgICB0eXBlbmFtZSBzdGQ6OmFsaWduZWRfc3RvcmFn
ZTxzaXplb2YoVCksIHN0ZDo6YWxpZ25tZW50X29mPFQ+Ojp2YWx1ZT46OnR5cGUgbV9zdG9yYWdl
OwotCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgUHRyVHlwZSwgYm9vbCBTaG91bGRSZWxheCA9IHN0
ZDo6aXNfYmFzZV9vZjxSZWZDb3VudGVkQmFzZSwgUHRyVHlwZT46OnZhbHVlPiBzdHJ1Y3QgTWF5
YmVSZWxheCB7CiAgICAgICAgIGV4cGxpY2l0IE1heWJlUmVsYXgoUHRyVHlwZSopIHsgfQogICAg
IH07CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgUHRyVHlwZT4gc3RydWN0IE1heWJlUmVsYXg8UHRy
VHlwZSwgdHJ1ZT4gewogICAgICAgICBleHBsaWNpdCBNYXliZVJlbGF4KFB0clR5cGUqIHB0cikg
eyBwdHItPnJlbGF4QWRvcHRpb25SZXF1aXJlbWVudCgpOyB9CiAgICAgfTsKKworICAgIC8vIEZJ
WE1FOiBJbnZlc3RpZ2F0ZSB3aGV0aGVyIHdlIHNob3VsZCBhbGxvY2F0ZSBhIGh1bmsgb2Ygdmly
dHVhbCBtZW1vcnkKKyAgICAvLyBhbmQgaGFuZCBvdXQgY2h1bmtzIG9mIGl0IHRvIE5ldmVyRGVz
dHJveWVkIGluc3RlYWQsIHRvIHJlZHVjZSBmcmFnbWVudGF0aW9uLgorICAgIHR5cGVuYW1lIHN0
ZDo6YWxpZ25lZF9zdG9yYWdlPHNpemVvZihUKSwgc3RkOjphbGlnbm1lbnRfb2Y8VD46OnZhbHVl
Pjo6dHlwZSBtX3N0b3JhZ2U7CiB9OwogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBOZXZlckRlc3Ry
b3llZDxUPiBtYWtlTmV2ZXJEZXN0cm95ZWQoVCYmKTsKQEAgLTg1LDcgKzg3LDcgQEAgdGVtcGxh
dGU8dHlwZW5hbWUgVD4gTmV2ZXJEZXN0cm95ZWQ8VD4gbWFrZU5ldmVyRGVzdHJveWVkKFQmJik7
CiAvLyBzaGFyZSBtb3JlIG9mIHRoZSBjb2RlIHdpdGggdGhlIG1haW4gTmV2ZXJEZXN0cm95ZWQg
YWJvdmUuCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBjbGFzcyBMYXp5TmV2ZXJEZXN0cm95ZWQgewog
ICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKExhenlOZXZlckRlc3Ryb3llZCk7Ci0KKyAgICBXVEZf
Rk9SQklEX0hFQVBfQUxMT0NBVElPTjsKIHB1YmxpYzoKICAgICBMYXp5TmV2ZXJEZXN0cm95ZWQo
KSA9IGRlZmF1bHQ7CiAKQEAgLTEyNCwxMCArMTI2LDYgQEAgcHJpdmF0ZToKICAgICAgICAgcmV0
dXJuIGNvbnN0X2Nhc3Q8UG9pbnRlclR5cGU+KHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgVCo+KCZt
X3N0b3JhZ2UpKTsKICAgICB9CiAKLSAgICAvLyBGSVhNRTogSW52ZXN0aWdhdGUgd2hldGhlciB3
ZSBzaG91bGQgYWxsb2NhdGUgYSBodW5rIG9mIHZpcnR1YWwgbWVtb3J5Ci0gICAgLy8gYW5kIGhh
bmQgb3V0IGNodW5rcyBvZiBpdCB0byBOZXZlckRlc3Ryb3llZCBpbnN0ZWFkLCB0byByZWR1Y2Ug
ZnJhZ21lbnRhdGlvbi4KLSAgICB0eXBlbmFtZSBzdGQ6OmFsaWduZWRfc3RvcmFnZTxzaXplb2Yo
VCksIHN0ZDo6YWxpZ25tZW50X29mPFQ+Ojp2YWx1ZT46OnR5cGUgbV9zdG9yYWdlOwotCiAgICAg
dGVtcGxhdGU8dHlwZW5hbWUgUHRyVHlwZSwgYm9vbCBTaG91bGRSZWxheCA9IHN0ZDo6aXNfYmFz
ZV9vZjxSZWZDb3VudGVkQmFzZSwgUHRyVHlwZT46OnZhbHVlPiBzdHJ1Y3QgTWF5YmVSZWxheCB7
CiAgICAgICAgIGV4cGxpY2l0IE1heWJlUmVsYXgoUHRyVHlwZSopIHsgfQogICAgIH07CkBAIC0x
NDAsNiArMTM4LDEwIEBAIHByaXZhdGU6CiAgICAgLy8gSXQgbXVzdCBub3QgYmUgaW5pdGlhbGl6
ZWQgZHluYW1pY2FsbHk7IHRoYXQgd291bGQgbm90IGJlIHRocmVhZCBzYWZlLgogICAgIGJvb2wg
bV9pc0NvbnN0cnVjdGVkOwogI2VuZGlmCisKKyAgICAvLyBGSVhNRTogSW52ZXN0aWdhdGUgd2hl
dGhlciB3ZSBzaG91bGQgYWxsb2NhdGUgYSBodW5rIG9mIHZpcnR1YWwgbWVtb3J5CisgICAgLy8g
YW5kIGhhbmQgb3V0IGNodW5rcyBvZiBpdCB0byBOZXZlckRlc3Ryb3llZCBpbnN0ZWFkLCB0byBy
ZWR1Y2UgZnJhZ21lbnRhdGlvbi4KKyAgICB0eXBlbmFtZSBzdGQ6OmFsaWduZWRfc3RvcmFnZTxz
aXplb2YoVCksIHN0ZDo6YWxpZ25tZW50X29mPFQ+Ojp2YWx1ZT46OnR5cGUgbV9zdG9yYWdlOwog
fTsKIAogdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIE5ldmVyRGVzdHJveWVkPFQ+IG1ha2VO
ZXZlckRlc3Ryb3llZChUJiYgYXJndW1lbnQpCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>362740</attachid>
            <date>2019-02-22 12:02:14 -0800</date>
            <delta_ts>2019-02-22 12:12:02 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-194824-20190222120213.patch</filename>
            <type>text/plain</type>
            <size>5419</size>
            <attacher name="Keith Miller">keith_miller</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGJkODVjNGUzOTc3YWYwNWVlZWM0OTQ4
Y2FhMjMzOTUzMTg1MmY5NDQuLjdlZDYzMjcwY2E0YTNjZjQ1OGQ1YmRjNzliNTA4Nzk5YTFlMTVi
MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDItMTkgIEtlaXRoIE1pbGxlciAgPGtlaXRo
X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ29kZSBxdWFsaXR5IGNsZWFudXAgaW4gTmV2
ZXJEZXN0cm95ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE5NDgyNAorCisgICAgICAgIFJldmlld2VkIGJ5IFl1c3VrZSBTdXp1a2kuCisKKyAgICAg
ICAgRmlyc3QsIG1vdmUgZGF0YSBtZW1iZXJzIHRvIHRoZSBlbmQgb2YgdGhlIGNsYXNzIHBlciBX
ZWJLaXQKKyAgICAgICAgc3R5bGUuIEFsc28sIGFkZCBmb3JiaWQgaGVhcCBhbGxvY2F0aW9uIHNp
bmNlIHdlIGV4cGVjdCB0aGUKKyAgICAgICAgTmV2ZXJEZXN0cm95ZWQgY2xhc3NlcyB0byBiZSBz
dGF0aWMuCisKKyAgICAgICAgKiB3dGYvTmV2ZXJEZXN0cm95ZWQuaDoKKwogMjAxOS0wMi0xNiAg
RGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ29udGludWUgcmVkdWNp
bmcgdXNlIG9mIFN0cmluZzo6Zm9ybWF0LCBub3cgZm9jdXNpbmcgb24gaGV4OiAiJXAiLCAiJXgi
LCBldGMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9OZXZlckRlc3Ryb3llZC5oIGIvU291
cmNlL1dURi93dGYvTmV2ZXJEZXN0cm95ZWQuaAppbmRleCBjMzExZjEzNmZmNWU1ODQwZWU1ZjQ5
ZWU1ZjcxODY4NjE4N2Q2NGM3Li5lN2U4YTdlYTAzOTg5Y2JhNDA0ZWFiYjgyNTM1MDBkNWMzZjdm
NTUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9OZXZlckRlc3Ryb3llZC5oCisrKyBiL1Nv
dXJjZS9XVEYvd3RmL05ldmVyRGVzdHJveWVkLmgKQEAgLTI3LDYgKzI3LDcgQEAKIAogI2luY2x1
ZGUgPHR5cGVfdHJhaXRzPgogI2luY2x1ZGUgPHV0aWxpdHk+CisjaW5jbHVkZSA8d3RmL0ZvcmJp
ZEhlYXBBbGxvY2F0aW9uLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KIAogLy8gTmV2
ZXJEZXN0cm95ZWQgaXMgYSBzbWFydC1wb2ludGVyLWxpa2UgY2xhc3MgdGhhdCBlbnN1cmVzIHRo
YXQgdGhlIGRlc3RydWN0b3IKQEAgLTQzLDggKzQ0LDkgQEAgbmFtZXNwYWNlIFdURiB7CiAKIHRl
bXBsYXRlPHR5cGVuYW1lIFQ+IGNsYXNzIE5ldmVyRGVzdHJveWVkIHsKICAgICBXVEZfTUFLRV9O
T05DT1BZQUJMRShOZXZlckRlc3Ryb3llZCk7Ci0KKyAgICBXVEZfRk9SQklEX0hFQVBfQUxMT0NB
VElPTjsKIHB1YmxpYzoKKwogICAgIHRlbXBsYXRlPHR5cGVuYW1lLi4uIEFyZ3M+IE5ldmVyRGVz
dHJveWVkKEFyZ3MmJi4uLiBhcmdzKQogICAgIHsKICAgICAgICAgTWF5YmVSZWxheDxUPihuZXcg
KHN0b3JhZ2VQb2ludGVyKCkpIFQoc3RkOjpmb3J3YXJkPEFyZ3M+KGFyZ3MpLi4uKSk7CkBAIC02
NiwxNiArNjgsMTYgQEAgcHJpdmF0ZToKIAogICAgIFBvaW50ZXJUeXBlIHN0b3JhZ2VQb2ludGVy
KCkgY29uc3QgeyByZXR1cm4gY29uc3RfY2FzdDxQb2ludGVyVHlwZT4ocmVpbnRlcnByZXRfY2Fz
dDxjb25zdCBUKj4oJm1fc3RvcmFnZSkpOyB9CiAKLSAgICAvLyBGSVhNRTogSW52ZXN0aWdhdGUg
d2hldGhlciB3ZSBzaG91bGQgYWxsb2NhdGUgYSBodW5rIG9mIHZpcnR1YWwgbWVtb3J5Ci0gICAg
Ly8gYW5kIGhhbmQgb3V0IGNodW5rcyBvZiBpdCB0byBOZXZlckRlc3Ryb3llZCBpbnN0ZWFkLCB0
byByZWR1Y2UgZnJhZ21lbnRhdGlvbi4KLSAgICB0eXBlbmFtZSBzdGQ6OmFsaWduZWRfc3RvcmFn
ZTxzaXplb2YoVCksIHN0ZDo6YWxpZ25tZW50X29mPFQ+Ojp2YWx1ZT46OnR5cGUgbV9zdG9yYWdl
OwotCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgUHRyVHlwZSwgYm9vbCBTaG91bGRSZWxheCA9IHN0
ZDo6aXNfYmFzZV9vZjxSZWZDb3VudGVkQmFzZSwgUHRyVHlwZT46OnZhbHVlPiBzdHJ1Y3QgTWF5
YmVSZWxheCB7CiAgICAgICAgIGV4cGxpY2l0IE1heWJlUmVsYXgoUHRyVHlwZSopIHsgfQogICAg
IH07CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgUHRyVHlwZT4gc3RydWN0IE1heWJlUmVsYXg8UHRy
VHlwZSwgdHJ1ZT4gewogICAgICAgICBleHBsaWNpdCBNYXliZVJlbGF4KFB0clR5cGUqIHB0cikg
eyBwdHItPnJlbGF4QWRvcHRpb25SZXF1aXJlbWVudCgpOyB9CiAgICAgfTsKKworICAgIC8vIEZJ
WE1FOiBJbnZlc3RpZ2F0ZSB3aGV0aGVyIHdlIHNob3VsZCBhbGxvY2F0ZSBhIGh1bmsgb2Ygdmly
dHVhbCBtZW1vcnkKKyAgICAvLyBhbmQgaGFuZCBvdXQgY2h1bmtzIG9mIGl0IHRvIE5ldmVyRGVz
dHJveWVkIGluc3RlYWQsIHRvIHJlZHVjZSBmcmFnbWVudGF0aW9uLgorICAgIHR5cGVuYW1lIHN0
ZDo6YWxpZ25lZF9zdG9yYWdlPHNpemVvZihUKSwgc3RkOjphbGlnbm1lbnRfb2Y8VD46OnZhbHVl
Pjo6dHlwZSBtX3N0b3JhZ2U7CiB9OwogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBOZXZlckRlc3Ry
b3llZDxUPiBtYWtlTmV2ZXJEZXN0cm95ZWQoVCYmKTsKQEAgLTg1LDcgKzg3LDcgQEAgdGVtcGxh
dGU8dHlwZW5hbWUgVD4gTmV2ZXJEZXN0cm95ZWQ8VD4gbWFrZU5ldmVyRGVzdHJveWVkKFQmJik7
CiAvLyBzaGFyZSBtb3JlIG9mIHRoZSBjb2RlIHdpdGggdGhlIG1haW4gTmV2ZXJEZXN0cm95ZWQg
YWJvdmUuCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBjbGFzcyBMYXp5TmV2ZXJEZXN0cm95ZWQgewog
ICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKExhenlOZXZlckRlc3Ryb3llZCk7Ci0KKyAgICBXVEZf
Rk9SQklEX0hFQVBfQUxMT0NBVElPTjsKIHB1YmxpYzoKICAgICBMYXp5TmV2ZXJEZXN0cm95ZWQo
KSA9IGRlZmF1bHQ7CiAKQEAgLTEyNCwxMCArMTI2LDYgQEAgcHJpdmF0ZToKICAgICAgICAgcmV0
dXJuIGNvbnN0X2Nhc3Q8UG9pbnRlclR5cGU+KHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgVCo+KCZt
X3N0b3JhZ2UpKTsKICAgICB9CiAKLSAgICAvLyBGSVhNRTogSW52ZXN0aWdhdGUgd2hldGhlciB3
ZSBzaG91bGQgYWxsb2NhdGUgYSBodW5rIG9mIHZpcnR1YWwgbWVtb3J5Ci0gICAgLy8gYW5kIGhh
bmQgb3V0IGNodW5rcyBvZiBpdCB0byBOZXZlckRlc3Ryb3llZCBpbnN0ZWFkLCB0byByZWR1Y2Ug
ZnJhZ21lbnRhdGlvbi4KLSAgICB0eXBlbmFtZSBzdGQ6OmFsaWduZWRfc3RvcmFnZTxzaXplb2Yo
VCksIHN0ZDo6YWxpZ25tZW50X29mPFQ+Ojp2YWx1ZT46OnR5cGUgbV9zdG9yYWdlOwotCiAgICAg
dGVtcGxhdGU8dHlwZW5hbWUgUHRyVHlwZSwgYm9vbCBTaG91bGRSZWxheCA9IHN0ZDo6aXNfYmFz
ZV9vZjxSZWZDb3VudGVkQmFzZSwgUHRyVHlwZT46OnZhbHVlPiBzdHJ1Y3QgTWF5YmVSZWxheCB7
CiAgICAgICAgIGV4cGxpY2l0IE1heWJlUmVsYXgoUHRyVHlwZSopIHsgfQogICAgIH07CkBAIC0x
NDAsNiArMTM4LDEwIEBAIHByaXZhdGU6CiAgICAgLy8gSXQgbXVzdCBub3QgYmUgaW5pdGlhbGl6
ZWQgZHluYW1pY2FsbHk7IHRoYXQgd291bGQgbm90IGJlIHRocmVhZCBzYWZlLgogICAgIGJvb2wg
bV9pc0NvbnN0cnVjdGVkOwogI2VuZGlmCisKKyAgICAvLyBGSVhNRTogSW52ZXN0aWdhdGUgd2hl
dGhlciB3ZSBzaG91bGQgYWxsb2NhdGUgYSBodW5rIG9mIHZpcnR1YWwgbWVtb3J5CisgICAgLy8g
YW5kIGhhbmQgb3V0IGNodW5rcyBvZiBpdCB0byBOZXZlckRlc3Ryb3llZCBpbnN0ZWFkLCB0byBy
ZWR1Y2UgZnJhZ21lbnRhdGlvbi4KKyAgICB0eXBlbmFtZSBzdGQ6OmFsaWduZWRfc3RvcmFnZTxz
aXplb2YoVCksIHN0ZDo6YWxpZ25tZW50X29mPFQ+Ojp2YWx1ZT46OnR5cGUgbV9zdG9yYWdlOwog
fTsKIAogdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIE5ldmVyRGVzdHJveWVkPFQ+IG1ha2VO
ZXZlckRlc3Ryb3llZChUJiYgYXJndW1lbnQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k
b20vbWFrZV9uYW1lcy5wbCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBsCmluZGV4
IGIxZTc2Y2ZkYTFmYTg3ZmU5OTllZmRlNjI0NGI2ZDM3YjgwMGMyMGEuLjNiYWU0OTFkNzJiZWJk
NTMzMTk3NDczYTM4N2MxZDY1MDY2NWFhNjUgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv
bS9tYWtlX25hbWVzLnBsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBsCkBA
IC03NzMsNyArNzczLDcgQEAgc3ViIHByaW50TmFtZXNDcHBGaWxlCiAgICAgICAgIHByaW50IEYg
IlxuXG5jb25zdCBXZWJDb3JlOjokcGFyYW1ldGVyc3tuYW1lc3BhY2V9UXVhbGlmaWVkTmFtZSog
Y29uc3QqIGdldCRwYXJhbWV0ZXJze25hbWVzcGFjZX1UYWdzKClcbiI7CiAgICAgICAgIHByaW50
IEYgIntcbiAgICBzdGF0aWMgY29uc3QgV2ViQ29yZTo6JHBhcmFtZXRlcnN7bmFtZXNwYWNlfVF1
YWxpZmllZE5hbWUqIGNvbnN0ICRwYXJhbWV0ZXJze25hbWVzcGFjZX1UYWdzW10gPSB7XG4iOwog
ICAgICAgICBmb3IgbXkgJG5hbWUgKHNvcnQga2V5cyAlYWxsVGFncykgewotICAgICAgICAgICAg
cHJpbnQgRiAiICAgICAgICByZWludGVycHJldF9jYXN0PGNvbnN0IFdlYkNvcmU6OiRwYXJhbWV0
ZXJze25hbWVzcGFjZX1RdWFsaWZpZWROYW1lKj4oJiR7bmFtZX1UYWcpLFxuIjsKKyAgICAgICAg
ICAgIHByaW50IEYgIiAgICAgICAgJiR7bmFtZX1UYWcuZ2V0KCksXG4iOwogICAgICAgICB9CiAg
ICAgICAgIHByaW50IEYgIiAgICB9O1xuIjsKICAgICAgICAgcHJpbnQgRiAiICAgIHJldHVybiAk
cGFyYW1ldGVyc3tuYW1lc3BhY2V9VGFncztcbiI7CkBAIC03ODgsNyArNzg4LDcgQEAgc3ViIHBy
aW50TmFtZXNDcHBGaWxlCiAgICAgICAgIHByaW50IEYgIlxuXG5jb25zdCBXZWJDb3JlOjpRdWFs
aWZpZWROYW1lKiBjb25zdCogZ2V0JHBhcmFtZXRlcnN7bmFtZXNwYWNlfUF0dHJzKClcbiI7CiAg
ICAgICAgIHByaW50IEYgIntcbiAgICBzdGF0aWMgY29uc3QgV2ViQ29yZTo6UXVhbGlmaWVkTmFt
ZSogY29uc3QgJHBhcmFtZXRlcnN7bmFtZXNwYWNlfUF0dHJzW10gPSB7XG4iOwogICAgICAgICBm
b3IgbXkgJG5hbWUgKHNvcnQga2V5cyAlYWxsQXR0cnMpIHsKLSAgICAgICAgICAgIHByaW50IEYg
IiAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxjb25zdCBXZWJDb3JlOjpRdWFsaWZpZWROYW1lKj4o
JiR7bmFtZX1BdHRyKSxcbiI7CisgICAgICAgICAgICBwcmludCBGICIgICAgICAgICYke25hbWV9
QXR0ci5nZXQoKSxcbiI7CiAgICAgICAgIH0KICAgICAgICAgcHJpbnQgRiAiICAgIH07XG4iOwog
ICAgICAgICBwcmludCBGICIgICAgcmV0dXJuICRwYXJhbWV0ZXJze25hbWVzcGFjZX1BdHRycztc
biI7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>362741</attachid>
            <date>2019-02-22 12:12:03 -0800</date>
            <delta_ts>2019-02-26 16:59:55 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-194824-20190222121203.patch</filename>
            <type>text/plain</type>
            <size>6099</size>
            <attacher name="Keith Miller">keith_miller</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGJkODVjNGUzOTc3YWYwNWVlZWM0OTQ4
Y2FhMjMzOTUzMTg1MmY5NDQuLmM5MDE4MTdiOWZkNThlNzA0ZDY5ZjI1MTM1YjIwNDNmNTJlY2Zh
M2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDItMjIgIEtlaXRoIE1pbGxlciAgPGtlaXRo
X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ29kZSBxdWFsaXR5IGNsZWFudXAgaW4gTmV2
ZXJEZXN0cm95ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE5NDgyNAorCisgICAgICAgIFJldmlld2VkIGJ5IFl1c3VrZSBTdXp1a2kuCisKKyAgICAg
ICAgRmlyc3QsIG1vdmUgZGF0YSBtZW1iZXJzIHRvIHRoZSBlbmQgb2YgdGhlIGNsYXNzIHBlciBX
ZWJLaXQKKyAgICAgICAgc3R5bGUuIEFsc28sIGFkZCBmb3JiaWQgaGVhcCBhbGxvY2F0aW9uIHNp
bmNlIHdlIGV4cGVjdCB0aGUKKyAgICAgICAgTmV2ZXJEZXN0cm95ZWQgY2xhc3NlcyB0byBiZSBz
dGF0aWMuCisKKyAgICAgICAgKiB3dGYvTmV2ZXJEZXN0cm95ZWQuaDoKKwogMjAxOS0wMi0xNiAg
RGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ29udGludWUgcmVkdWNp
bmcgdXNlIG9mIFN0cmluZzo6Zm9ybWF0LCBub3cgZm9jdXNpbmcgb24gaGV4OiAiJXAiLCAiJXgi
LCBldGMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cKaW5kZXggYTZkYTUzZmU4ZTA0YWQ3OWRkMDZjMTE3YzQxMGEwNDBiMmI5
N2U3Ni4uYzFkYmY3N2NkZmRmN2EwMWU4Mjg5ZDljMWQ1MTE5ODQ3Y2Q4YjRkOCAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAyLTIyICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxs
ZXJAYXBwbGUuY29tPgorCisgICAgICAgIENvZGUgcXVhbGl0eSBjbGVhbnVwIGluIE5ldmVyRGVz
dHJveWVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x
OTQ4MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBu
YW1lX25hbWVzLnBsIHNob3VsZCBub3QganVzdCBhc3N1bWUgdGhlIGxheW91dCBvZiBMYXp5TmV2
ZXJEZXN0cm95ZWQuCisKKyAgICAgICAgKiBkb20vbWFrZV9uYW1lcy5wbDoKKyAgICAgICAgKHBy
aW50TmFtZXNDcHBGaWxlKToKKwogMjAxOS0wMi0xOSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1
ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjI0MTcy
Mi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL05ldmVyRGVzdHJveWVkLmggYi9Tb3VyY2Uv
V1RGL3d0Zi9OZXZlckRlc3Ryb3llZC5oCmluZGV4IGMzMTFmMTM2ZmY1ZTU4NDBlZTVmNDllZTVm
NzE4Njg2MTg3ZDY0YzcuLmU3ZThhN2VhMDM5ODljYmE0MDRlYWJiODI1MzUwMGQ1YzNmN2Y1NTMg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL05ldmVyRGVzdHJveWVkLmgKKysrIGIvU291cmNl
L1dURi93dGYvTmV2ZXJEZXN0cm95ZWQuaApAQCAtMjcsNiArMjcsNyBAQAogCiAjaW5jbHVkZSA8
dHlwZV90cmFpdHM+CiAjaW5jbHVkZSA8dXRpbGl0eT4KKyNpbmNsdWRlIDx3dGYvRm9yYmlkSGVh
cEFsbG9jYXRpb24uaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogCiAvLyBOZXZlckRl
c3Ryb3llZCBpcyBhIHNtYXJ0LXBvaW50ZXItbGlrZSBjbGFzcyB0aGF0IGVuc3VyZXMgdGhhdCB0
aGUgZGVzdHJ1Y3RvcgpAQCAtNDMsOCArNDQsOSBAQCBuYW1lc3BhY2UgV1RGIHsKIAogdGVtcGxh
dGU8dHlwZW5hbWUgVD4gY2xhc3MgTmV2ZXJEZXN0cm95ZWQgewogICAgIFdURl9NQUtFX05PTkNP
UFlBQkxFKE5ldmVyRGVzdHJveWVkKTsKLQorICAgIFdURl9GT1JCSURfSEVBUF9BTExPQ0FUSU9O
OwogcHVibGljOgorCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUuLi4gQXJncz4gTmV2ZXJEZXN0cm95
ZWQoQXJncyYmLi4uIGFyZ3MpCiAgICAgewogICAgICAgICBNYXliZVJlbGF4PFQ+KG5ldyAoc3Rv
cmFnZVBvaW50ZXIoKSkgVChzdGQ6OmZvcndhcmQ8QXJncz4oYXJncykuLi4pKTsKQEAgLTY2LDE2
ICs2OCwxNiBAQCBwcml2YXRlOgogCiAgICAgUG9pbnRlclR5cGUgc3RvcmFnZVBvaW50ZXIoKSBj
b25zdCB7IHJldHVybiBjb25zdF9jYXN0PFBvaW50ZXJUeXBlPihyZWludGVycHJldF9jYXN0PGNv
bnN0IFQqPigmbV9zdG9yYWdlKSk7IH0KIAotICAgIC8vIEZJWE1FOiBJbnZlc3RpZ2F0ZSB3aGV0
aGVyIHdlIHNob3VsZCBhbGxvY2F0ZSBhIGh1bmsgb2YgdmlydHVhbCBtZW1vcnkKLSAgICAvLyBh
bmQgaGFuZCBvdXQgY2h1bmtzIG9mIGl0IHRvIE5ldmVyRGVzdHJveWVkIGluc3RlYWQsIHRvIHJl
ZHVjZSBmcmFnbWVudGF0aW9uLgotICAgIHR5cGVuYW1lIHN0ZDo6YWxpZ25lZF9zdG9yYWdlPHNp
emVvZihUKSwgc3RkOjphbGlnbm1lbnRfb2Y8VD46OnZhbHVlPjo6dHlwZSBtX3N0b3JhZ2U7Ci0K
ICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBQdHJUeXBlLCBib29sIFNob3VsZFJlbGF4ID0gc3RkOjpp
c19iYXNlX29mPFJlZkNvdW50ZWRCYXNlLCBQdHJUeXBlPjo6dmFsdWU+IHN0cnVjdCBNYXliZVJl
bGF4IHsKICAgICAgICAgZXhwbGljaXQgTWF5YmVSZWxheChQdHJUeXBlKikgeyB9CiAgICAgfTsK
ICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBQdHJUeXBlPiBzdHJ1Y3QgTWF5YmVSZWxheDxQdHJUeXBl
LCB0cnVlPiB7CiAgICAgICAgIGV4cGxpY2l0IE1heWJlUmVsYXgoUHRyVHlwZSogcHRyKSB7IHB0
ci0+cmVsYXhBZG9wdGlvblJlcXVpcmVtZW50KCk7IH0KICAgICB9OworCisgICAgLy8gRklYTUU6
IEludmVzdGlnYXRlIHdoZXRoZXIgd2Ugc2hvdWxkIGFsbG9jYXRlIGEgaHVuayBvZiB2aXJ0dWFs
IG1lbW9yeQorICAgIC8vIGFuZCBoYW5kIG91dCBjaHVua3Mgb2YgaXQgdG8gTmV2ZXJEZXN0cm95
ZWQgaW5zdGVhZCwgdG8gcmVkdWNlIGZyYWdtZW50YXRpb24uCisgICAgdHlwZW5hbWUgc3RkOjph
bGlnbmVkX3N0b3JhZ2U8c2l6ZW9mKFQpLCBzdGQ6OmFsaWdubWVudF9vZjxUPjo6dmFsdWU+Ojp0
eXBlIG1fc3RvcmFnZTsKIH07CiAKIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IE5ldmVyRGVzdHJveWVk
PFQ+IG1ha2VOZXZlckRlc3Ryb3llZChUJiYpOwpAQCAtODUsNyArODcsNyBAQCB0ZW1wbGF0ZTx0
eXBlbmFtZSBUPiBOZXZlckRlc3Ryb3llZDxUPiBtYWtlTmV2ZXJEZXN0cm95ZWQoVCYmKTsKIC8v
IHNoYXJlIG1vcmUgb2YgdGhlIGNvZGUgd2l0aCB0aGUgbWFpbiBOZXZlckRlc3Ryb3llZCBhYm92
ZS4KIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGNsYXNzIExhenlOZXZlckRlc3Ryb3llZCB7CiAgICAg
V1RGX01BS0VfTk9OQ09QWUFCTEUoTGF6eU5ldmVyRGVzdHJveWVkKTsKLQorICAgIFdURl9GT1JC
SURfSEVBUF9BTExPQ0FUSU9OOwogcHVibGljOgogICAgIExhenlOZXZlckRlc3Ryb3llZCgpID0g
ZGVmYXVsdDsKIApAQCAtMTI0LDEwICsxMjYsNiBAQCBwcml2YXRlOgogICAgICAgICByZXR1cm4g
Y29uc3RfY2FzdDxQb2ludGVyVHlwZT4ocmVpbnRlcnByZXRfY2FzdDxjb25zdCBUKj4oJm1fc3Rv
cmFnZSkpOwogICAgIH0KIAotICAgIC8vIEZJWE1FOiBJbnZlc3RpZ2F0ZSB3aGV0aGVyIHdlIHNo
b3VsZCBhbGxvY2F0ZSBhIGh1bmsgb2YgdmlydHVhbCBtZW1vcnkKLSAgICAvLyBhbmQgaGFuZCBv
dXQgY2h1bmtzIG9mIGl0IHRvIE5ldmVyRGVzdHJveWVkIGluc3RlYWQsIHRvIHJlZHVjZSBmcmFn
bWVudGF0aW9uLgotICAgIHR5cGVuYW1lIHN0ZDo6YWxpZ25lZF9zdG9yYWdlPHNpemVvZihUKSwg
c3RkOjphbGlnbm1lbnRfb2Y8VD46OnZhbHVlPjo6dHlwZSBtX3N0b3JhZ2U7Ci0KICAgICB0ZW1w
bGF0ZTx0eXBlbmFtZSBQdHJUeXBlLCBib29sIFNob3VsZFJlbGF4ID0gc3RkOjppc19iYXNlX29m
PFJlZkNvdW50ZWRCYXNlLCBQdHJUeXBlPjo6dmFsdWU+IHN0cnVjdCBNYXliZVJlbGF4IHsKICAg
ICAgICAgZXhwbGljaXQgTWF5YmVSZWxheChQdHJUeXBlKikgeyB9CiAgICAgfTsKQEAgLTE0MCw2
ICsxMzgsMTAgQEAgcHJpdmF0ZToKICAgICAvLyBJdCBtdXN0IG5vdCBiZSBpbml0aWFsaXplZCBk
eW5hbWljYWxseTsgdGhhdCB3b3VsZCBub3QgYmUgdGhyZWFkIHNhZmUuCiAgICAgYm9vbCBtX2lz
Q29uc3RydWN0ZWQ7CiAjZW5kaWYKKworICAgIC8vIEZJWE1FOiBJbnZlc3RpZ2F0ZSB3aGV0aGVy
IHdlIHNob3VsZCBhbGxvY2F0ZSBhIGh1bmsgb2YgdmlydHVhbCBtZW1vcnkKKyAgICAvLyBhbmQg
aGFuZCBvdXQgY2h1bmtzIG9mIGl0IHRvIE5ldmVyRGVzdHJveWVkIGluc3RlYWQsIHRvIHJlZHVj
ZSBmcmFnbWVudGF0aW9uLgorICAgIHR5cGVuYW1lIHN0ZDo6YWxpZ25lZF9zdG9yYWdlPHNpemVv
ZihUKSwgc3RkOjphbGlnbm1lbnRfb2Y8VD46OnZhbHVlPjo6dHlwZSBtX3N0b3JhZ2U7CiB9Owog
CiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgTmV2ZXJEZXN0cm95ZWQ8VD4gbWFrZU5ldmVy
RGVzdHJveWVkKFQmJiBhcmd1bWVudCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9t
YWtlX25hbWVzLnBsIGIvU291cmNlL1dlYkNvcmUvZG9tL21ha2VfbmFtZXMucGwKaW5kZXggYjFl
NzZjZmRhMWZhODdmZTk5OWVmZGU2MjQ0YjZkMzdiODAwYzIwYS4uM2JhZTQ5MWQ3MmJlYmQ1MzMx
OTc0NzNhMzg3YzFkNjUwNjY1YWE2NSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL21h
a2VfbmFtZXMucGwKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL21ha2VfbmFtZXMucGwKQEAgLTc3
Myw3ICs3NzMsNyBAQCBzdWIgcHJpbnROYW1lc0NwcEZpbGUKICAgICAgICAgcHJpbnQgRiAiXG5c
bmNvbnN0IFdlYkNvcmU6OiRwYXJhbWV0ZXJze25hbWVzcGFjZX1RdWFsaWZpZWROYW1lKiBjb25z
dCogZ2V0JHBhcmFtZXRlcnN7bmFtZXNwYWNlfVRhZ3MoKVxuIjsKICAgICAgICAgcHJpbnQgRiAi
e1xuICAgIHN0YXRpYyBjb25zdCBXZWJDb3JlOjokcGFyYW1ldGVyc3tuYW1lc3BhY2V9UXVhbGlm
aWVkTmFtZSogY29uc3QgJHBhcmFtZXRlcnN7bmFtZXNwYWNlfVRhZ3NbXSA9IHtcbiI7CiAgICAg
ICAgIGZvciBteSAkbmFtZSAoc29ydCBrZXlzICVhbGxUYWdzKSB7Ci0gICAgICAgICAgICBwcmlu
dCBGICIgICAgICAgIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgV2ViQ29yZTo6JHBhcmFtZXRlcnN7
bmFtZXNwYWNlfVF1YWxpZmllZE5hbWUqPigmJHtuYW1lfVRhZyksXG4iOworICAgICAgICAgICAg
cHJpbnQgRiAiICAgICAgICAmJHtuYW1lfVRhZy5nZXQoKSxcbiI7CiAgICAgICAgIH0KICAgICAg
ICAgcHJpbnQgRiAiICAgIH07XG4iOwogICAgICAgICBwcmludCBGICIgICAgcmV0dXJuICRwYXJh
bWV0ZXJze25hbWVzcGFjZX1UYWdzO1xuIjsKQEAgLTc4OCw3ICs3ODgsNyBAQCBzdWIgcHJpbnRO
YW1lc0NwcEZpbGUKICAgICAgICAgcHJpbnQgRiAiXG5cbmNvbnN0IFdlYkNvcmU6OlF1YWxpZmll
ZE5hbWUqIGNvbnN0KiBnZXQkcGFyYW1ldGVyc3tuYW1lc3BhY2V9QXR0cnMoKVxuIjsKICAgICAg
ICAgcHJpbnQgRiAie1xuICAgIHN0YXRpYyBjb25zdCBXZWJDb3JlOjpRdWFsaWZpZWROYW1lKiBj
b25zdCAkcGFyYW1ldGVyc3tuYW1lc3BhY2V9QXR0cnNbXSA9IHtcbiI7CiAgICAgICAgIGZvciBt
eSAkbmFtZSAoc29ydCBrZXlzICVhbGxBdHRycykgewotICAgICAgICAgICAgcHJpbnQgRiAiICAg
ICAgICByZWludGVycHJldF9jYXN0PGNvbnN0IFdlYkNvcmU6OlF1YWxpZmllZE5hbWUqPigmJHtu
YW1lfUF0dHIpLFxuIjsKKyAgICAgICAgICAgIHByaW50IEYgIiAgICAgICAgJiR7bmFtZX1BdHRy
LmdldCgpLFxuIjsKICAgICAgICAgfQogICAgICAgICBwcmludCBGICIgICAgfTtcbiI7CiAgICAg
ICAgIHByaW50IEYgIiAgICByZXR1cm4gJHBhcmFtZXRlcnN7bmFtZXNwYWNlfUF0dHJzO1xuIjsK
</data>

          </attachment>
      

    </bug>

</bugzilla>