194816 2019-02-19 05:31:34 -0800 test262-runner ends with SIGPIPE signal 2019-11-28 08:55:16 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino webkit-unassigned aperez cgarcia commit-queue ews-feeder keith_miller lforschler mcatanzaro msaboff webkit-bug-importer ysuzuki oldest_to_newest 1507653 0 dpino 2019-02-19 05:31:34 -0800 In certain environments when running `test262-runner` the program ends abruptly with a SIGPIPE signal. Example: ``` $ Tools/Scripts/test262-runner --release Settings: Test262 Dir: JSTests/test262 JSC: WebKitBuild/Release/bin/jsc Child Processes: 256 DYLD_FRAMEWORK_PATH: /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/bin Config file: JSTests/test262/config.yaml Expectations file: JSTests/test262/expectations.yaml --- $ echo $? 141 ``` This is inconvenient because `test262-runner` ends without printing out tests summary results. By certain environments I mean the issue always happens in one specific host, while I have no issues in a different host. 1507654 1 362382 dpino 2019-02-19 05:41:03 -0800 Created attachment 362382 Patch 1507655 2 dpino 2019-02-19 05:54:01 -0800 Explanation of the patch. I debugged the issue using 'Carp::Trace'. I captured SIGPIPE signals and printed out a trace. I got the following output: ``` Test262::Runner::main [3] scalar - new stash /home/slave/webkitgtk/gtk-linux-64-release/build/Tools/Scripts/test262/Runner.pm line 122 Test262::Runner::(eval) [2] scalar - no new stash /home/slave/webkitgtk/gtk-linux-64-release/build/Tools/Scripts/test262/Runner.pm line 416 Test262::Runner::__ANON__ [1] scalar - new stash /home/slave/webkitgtk/gtk-linux-64-release/build/Tools/Scripts/test262/Runner.pm line 416 ``` This pattern occurred several times in the output. IIRC, a SIGPIPE happens when attempting to write on a closed pipe. In the case of the suspecting line (416), I think what is happening if that child is trying to write on a closed socket (the parent was closed right before that loop). In any case, it seems to me this block of code is redundant, so I removed it. After applying the patch, `test262-runner --release` runs just fine (exit status is 0). 1593966 3 384441 dpino 2019-11-28 00:44:56 -0800 Created attachment 384441 Patch 1593996 4 384441 dpino 2019-11-28 03:27:00 -0800 Comment on attachment 384441 Patch Carlos López reviewed the patch and granted r+ on private conversation. 1593997 5 384441 ews-feeder 2019-11-28 03:27:30 -0800 Comment on attachment 384441 Patch Rejecting attachment 384441 from review queue. dpino@igalia.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 1594063 6 384441 commit-queue 2019-11-28 08:54:20 -0800 Comment on attachment 384441 Patch Clearing flags on attachment: 384441 Committed r252930: <https://trac.webkit.org/changeset/252930> 1594064 7 commit-queue 2019-11-28 08:54:21 -0800 All reviewed patches have been landed. Closing bug. 1594065 8 webkit-bug-importer 2019-11-28 08:55:16 -0800 <rdar://problem/57521420> 362382 2019-02-19 05:41:03 -0800 2019-11-28 00:44:50 -0800 Patch bug-194816-20190219134102.patch text/plain 1223 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNTkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjYxMTVhYmRlNDU1ODAxOWQ2ZjhkMzQzNDc0MmJjM2Jk MzAwNTZhZC4uNWM5MjVjNDMzYWY1MTVlNzZhNWU3ZDZlMWJlNzYwMDRmYmQzY2U3MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTAyLTE5ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgdGVzdDI2Mi1ydW5uZXIgZW5kcyB3aXRoIFNJR1BJUEUgc2lnbmFsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ4MTYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvdGVzdDI2 Mi9SdW5uZXIucG06CisgICAgICAgIChtYWluKToKKwogMjAxOS0wMi0xMCAgRGFyaW4gQWRsZXIg IDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVwbGFjZSBtb3JlIHVzZXMgb2YgU3RyaW5n Ojpmb3JtYXQgd2l0aCBTdHJpbmdDb25jYXRlbmF0ZSAobW9zdGx5IG5vbi1BcHBsZSBwbGF0Zm9y bS1zcGVjaWZpYyBjYXNlcykKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvdGVzdDI2Mi9SdW5u ZXIucG0gYi9Ub29scy9TY3JpcHRzL3Rlc3QyNjIvUnVubmVyLnBtCmluZGV4IGU5NDhhNDQwYzNj ZjkyODIyMWE5ZTA1YzQyZWE5Zjc3ZDk4Yjc1MmEuLjM3NzdkMjYyNTRmODRlNDAxNzZjZTY1YmU2 MmExYjI3YTZjOWE5NjggMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvdGVzdDI2Mi9SdW5uZXIu cG0KKysrIGIvVG9vbHMvU2NyaXB0cy90ZXN0MjYyL1J1bm5lci5wbQpAQCAtNDAxLDE0ICs0MDEs NiBAQCBzdWIgbWFpbiB7CiAgICAgICAgICRfLT5jbG9zZSgpOwogICAgIH0KIAotICAgIG15ICRj b3VudCA9IDA7Ci0gICAgZm9yIG15ICRwYXJlbnQgKEBwYXJlbnRzKSB7Ci0gICAgICAgIG15ICRj aGlsZCA9ICRjaGlsZHJlblskY291bnRdOwotICAgICAgICBwcmludCAkY2hpbGQgIkVORFxuIjsK LSAgICAgICAgJHBhcmVudC0+Y2xvc2UoKTsKLSAgICAgICAgJGNvdW50Kys7Ci0gICAgfQotCiAg ICAgJHBtLT53YWl0X2FsbF9jaGlsZHJlbjsKIAogICAgICMgUmVhZCByZXN1bHRzIGZyb20gZmls ZSBpbnRvIEByZXN1bHRzIGFuZCBjbG9zZQo= 384441 2019-11-28 00:44:56 -0800 2019-11-28 08:54:20 -0800 Patch bug-194816-20191128094455.patch text/plain 1167 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjUyOTE2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTIzMjNhZGNiNzFlZDkwNmVkY2YwMzAzOTdlNzJlMDU4 NjQ0MjhhOS4uYzA3YWFiODZhNmExNTZiZDI1N2QyYjFmMTY2MDUwNzNlY2Q1MmFhOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTExLTI4ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgdGVzdDI2Mi1ydW5uZXIgZW5kcyB3aXRoIFNJR1BJUEUgc2lnbmFsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQ4MTYKKworICAgICAg ICBSZXZpZXdlZCBieSBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJlei4KKworICAgICAgICAqIFNj cmlwdHMvdGVzdDI2Mi9SdW5uZXIucG06CisgICAgICAgIChtYWluKToKKwogMjAxOS0xMS0yNyAg WmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdIFVucmV2aWV3 ZWQgdGVzdCBnYXJkZW5pbmcuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3Rlc3QyNjIvUnVu bmVyLnBtIGIvVG9vbHMvU2NyaXB0cy90ZXN0MjYyL1J1bm5lci5wbQppbmRleCAyNjVjOTgzNTFi NDVhMDRiMDMzMzAxMzRhMTlmODUxZTgxNzVhM2Y5Li5lN2M1OGUzY2JkNDkzY2MxZTI2ZTg5YmQx ZWVkNTA2ZGVkNmUzZmY4IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3Rlc3QyNjIvUnVubmVy LnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvdGVzdDI2Mi9SdW5uZXIucG0KQEAgLTQwMSwxNCArNDAx LDYgQEAgc3ViIG1haW4gewogICAgICAgICAkXy0+Y2xvc2UoKTsKICAgICB9CiAKLSAgICBteSAk Y291bnQgPSAwOwotICAgIGZvciBteSAkcGFyZW50IChAcGFyZW50cykgewotICAgICAgICBteSAk Y2hpbGQgPSAkY2hpbGRyZW5bJGNvdW50XTsKLSAgICAgICAgcHJpbnQgJGNoaWxkICJFTkRcbiI7 Ci0gICAgICAgICRwYXJlbnQtPmNsb3NlKCk7Ci0gICAgICAgICRjb3VudCsrOwotICAgIH0KLQog ICAgICRwbS0+d2FpdF9hbGxfY2hpbGRyZW47CiAKICAgICAjIFJlYWQgcmVzdWx0cyBmcm9tIGZp bGUgaW50byBAcmVzdWx0cyBhbmQgY2xvc2UK