194795 2019-02-18 15:11:29 -0800 Clean-up output from generate-xcfilelists so it can be filtered 2019-02-19 13:52:04 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino joepeck krollin webkit-bug-importer oldest_to_newest 1507474 0 dino 2019-02-18 15:11:29 -0800 Clean-up output from generate-xcfilelists so it can be filtered 1507477 1 362345 dino 2019-02-18 15:13:22 -0800 Created attachment 362345 Patch 1507512 2 362345 joepeck 2019-02-18 16:00:11 -0800 Comment on attachment 362345 Patch r=me! 1507519 3 krollin 2019-02-18 16:14:50 -0800 We should reconsider removing the '...' without a replacement for it. The '...' is used to ferry some logging across the "Xcode barrier". generate-xcfilelist runs in two contexts: standalone, and from within Xcode. To achieve this, when running standalone, generate-xcfilelist can launch Xcode and then invoke itself to continue some operations. If, when debugging, it's necessary to enable logging, both the standalone generate-xcfilelist and the one sub-launched under Xcode both emit logging. But, at the same time, Xcode will spew out a lot of logging. We want the generate-xcfilelist logging, but not the Xcode logging. In order to distinguish between the two generate-xcfilelist will scan all of the logging from the Xcode process, keep the logging starting with '...' and discarding the rest. There are also cases where we need to ferry error messages across this Xcode barrier. We we like to receive this logging without also receiving Xcode's native logging. For examples of where we filter based on ..., see: sed -E -e 's/^/... /' < "${GX_TEMP}/std.err" and: WK_SUBLAUNCH_SCRIPT_PARAMETERS=("${GX_ARGS[@]}") xcodebuild "${GX_XCODE_PARAMETERS[@]}" | grep '^\.\.\. ' I'll be the first to admit that this is a bit of a hack. If anyone has a better approach to pick apart the generate-xcfilelist logging from Xcode's native logging, we can use that instead. 1507526 4 krollin 2019-02-18 16:18:56 -0800 Will filter-webkit-build handle "Generating all .xcfilelists"? This logging doesn't seem to match the regex added in the patch. Is plain old "Generating .+" handled elsewhere? 1507692 5 dino 2019-02-19 09:58:57 -0800 (In reply to Keith Rollin from comment #4) > Will filter-webkit-build handle "Generating all .xcfilelists"? This logging > doesn't seem to match the regex added in the patch. Is plain old "Generating > .+" handled elsewhere? It won't. Well noticed. It's not such a big deal since a fbwk "failure" will just let the output go through. But I'll fix it. 1507693 6 dino 2019-02-19 10:01:40 -0800 (In reply to Keith Rollin from comment #3) > We should reconsider removing the '...' without a replacement for it. The > '...' is used to ferry some logging across the "Xcode barrier". > > generate-xcfilelist runs in two contexts: standalone, and from within Xcode. > To achieve this, when running standalone, generate-xcfilelist can launch > Xcode and then invoke itself to continue some operations. > > If, when debugging, it's necessary to enable logging, both the standalone > generate-xcfilelist and the one sub-launched under Xcode both emit logging. > But, at the same time, Xcode will spew out a lot of logging. We want the > generate-xcfilelist logging, but not the Xcode logging. In order to > distinguish between the two generate-xcfilelist will scan all of the logging > from the Xcode process, keep the logging starting with '...' and discarding > the rest. > > There are also cases where we need to ferry error messages across this Xcode > barrier. We we like to receive this logging without also receiving Xcode's > native logging. > > For examples of where we filter based on ..., see: > > sed -E -e 's/^/... /' < "${GX_TEMP}/std.err" > > and: > > WK_SUBLAUNCH_SCRIPT_PARAMETERS=("${GX_ARGS[@]}") xcodebuild > "${GX_XCODE_PARAMETERS[@]}" | grep '^\.\.\. ' > > I'll be the first to admit that this is a bit of a hack. If anyone has a > better approach to pick apart the generate-xcfilelist logging from Xcode's > native logging, we can use that instead. OK. I definitely shouldn't land my patch in this state then. Maybe we could prefix generate-xcfilelist output with something other than "..." and have fbwk identify it. 1507705 7 krollin 2019-02-19 10:27:54 -0800 (In reply to Dean Jackson from comment #6) > > Maybe we could prefix generate-xcfilelist output with something other than > "..." and have fbwk identify it. I had a similar thought during development of the script. I was thinking of keeping the ==='s and ...'s and filtering based on them. But you see a need to remove them and replace them with some other prefix? Personally, I'm fine with anything. We could use "GXCF:", for example. 1507728 8 362345 joepeck 2019-02-19 11:19:21 -0800 Comment on attachment 362345 Patch r- based on the comment thread 1507803 9 dino 2019-02-19 13:50:01 -0800 Committed r241771: <https://trac.webkit.org/changeset/241771> 1507804 10 webkit-bug-importer 2019-02-19 13:52:04 -0800 <rdar://problem/48213591> 362345 2019-02-18 15:13:22 -0800 2019-02-19 11:19:21 -0800 Patch bug-194795-20190219101320.patch text/plain 4571 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQxNzQwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjllMmYxMmJjZjdjYmZkYjM4MmQ0OWJhMDljMmM5ZDI1 ZmYwOTA0Mi4uZjQxNzc3ZmYxNzUyYjUxMjI3YWIwM2I4NzBmNjQxNzcwNGQxMmU2YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTAyLTE4ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAg ICBDbGVhbi11cCBvdXRwdXQgZnJvbSBnZW5lcmF0ZS14Y2ZpbGVsaXN0cyBzbyBpdCBjYW4gYmUg ZmlsdGVyZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5NDc5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbW92ZSB0aGUgIi4uLiIgYW5kICI9PT0iIGZyb20gZ2VuZXJhdGUteGNmaWxlbGlzdHMgb3V0 cHV0LCBhbmQKKyAgICAgICAgbWFrZSBhIHNsaWdodCB0d2VhayB0byBmaWx0ZXItYnVpbGQtd2Vi a2l0IHNvIHN1Y2ggbGluZXMgYXJlIG1hcmtlZAorICAgICAgICBhcyBwbGFpbi4KKworICAgICAg ICAqIFNjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdDoKKyAgICAgICAgKiBTY3JpcHRzL2dlbmVy YXRlLXhjZmlsZWxpc3RzOgorCiAyMDE5LTAyLTE4ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlz dGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IEFQSSB0ZXN0IGFmdGVyIHIyNDE3MjgK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdCBiL1Rvb2xzL1Nj cmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdAppbmRleCA1YjYyOWVjZTVhNzQ0ODdiNTJkMzU4YzY5 MGM2ODU3ODE0OTg4ZWUyLi5iN2ZlNDM0Nzk4YTc5ODFjMDcyZTZmMjRhODZjMjhlZTZiNGY3NzYw IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2ZpbHRlci1idWlsZC13ZWJraXQKKysrIGIvVG9v bHMvU2NyaXB0cy9maWx0ZXItYnVpbGQtd2Via2l0CkBAIC0xNjAsMTMgKzE2MCwxMyBAQCBmb3Ig KG15ICRwcmV2aW91c0xpbmUgPSAiIiwgbXkgJGxpbmUgPSA8PjsgJGxpbmU7ICRwcmV2aW91c0xp bmUgPSAkbGluZSwgJGxpbmUgPQogICAgICAgICBwcmludExpbmUoIiRjb21tYW5kICRwYXRoIiwg U1RZTEVfUExBSU4pOwogICAgIH0gZWxzaWYgKCRsaW5lID1+IC9eb2ZmbGluZWFzbVw6IC8pIHsK ICAgICAgICAgcHJpbnRMaW5lKCRsaW5lLCBTVFlMRV9QTEFJTik7Ci0gICAgfSBlbHNpZiAoJGxp bmUgPX4gL15HZW5lcmF0aW5nIChcUyspIGZyb20gKFxTKykvKSB7Ci0gICAgICAgIHByaW50TGlu ZSgkbGluZSwgU1RZTEVfUExBSU4pOwogICAgIH0gZWxzaWYgKCRsaW5lID1+IC9eR2VuZXJhdGlu ZyBiaW5kaW5ncyBmb3IgdGhlIChcUyspIGJ1aWx0aW5cLi8pIHsKICAgICAgICAgcHJpbnRMaW5l KCJHZW5lcmF0aW5nICQxIGJ1aWx0aW4iLCBTVFlMRV9QTEFJTik7CiAgICAgfSBlbHNpZiAoJGxp bmUgPX4gL15HZW5lcmF0aW5nIChiaW5kaW5nc3xtZXNzYWdlcz8gKGhlYWRlcnxyZWNlaXZlcnxk aXNwYXRjaGVyKXxkZXJpdmVkIHNvdXJjZSkgZm9yIChcUyspXC5cLlwuLykgewogICAgICAgICBt eSAoJGNvbW1hbmQsICRwYXRoKSA9ICgkMSwgYmFzZW5hbWUoJDMpKTsKICAgICAgICAgcHJpbnRM aW5lKCJHZW5lcmF0aW5nICRjb21tYW5kICRwYXRoIiwgU1RZTEVfUExBSU4pOworICAgIH0gZWxz aWYgKCRsaW5lID1+IC9eKEdlbmVyYXRpbmd8TWVyZ2luZykgKFxTKykgKGZyb218Zm9yKSAoXFMr KS8pIHsKKyAgICAgICAgcHJpbnRMaW5lKCRsaW5lLCBTVFlMRV9QTEFJTik7CiAgICAgfSBlbHNp ZiAoJGxpbmUgPX4gL15QcmUtcHJvY2Vzc2luZyAoXFMrKSBzYW5kYm94IHByb2ZpbGUvKSB7CiAg ICAgICAgIHByaW50TGluZSgkbGluZSwgU1RZTEVfUExBSU4pOwogICAgIH0gZWxzaWYgKCRsaW5l ID1+IC9eKFxTK1wvY2MpLio/KFxTKylcLihvdXR8ZXhwKS8pIHsKZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvZ2VuZXJhdGUteGNmaWxlbGlzdHMgYi9Ub29scy9TY3JpcHRzL2dlbmVyYXRlLXhj ZmlsZWxpc3RzCmluZGV4IDZkYzI3MjJiZmQyNzY3MDFjZDEwMGY4MTQ3MmEyZjllYjAzZjY0MDku LmIyYzA2MzFkODgzNjM2ZGNmZGU4MTI1YzM2OWQ1ODgxYmEzOTk4MmUgMTAwNzU1Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvZ2VuZXJhdGUteGNmaWxlbGlzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9nZW5l cmF0ZS14Y2ZpbGVsaXN0cwpAQCAtMTkxLDcgKzE5MSw2IEBAIGZ1bmN0aW9uIGNsZWFudXAoKQog ICAgIGZpCiB9CiAKLQogZnVuY3Rpb24gbXlfZXhpdCgpCiB7CiAgICAgbG9jYWwgR1hfRVJSPSQx CkBAIC0yMTAsNyArMjA5LDcgQEAgZnVuY3Rpb24gZGllKCkKIAogZnVuY3Rpb24gbG9nX2RlYnVn KCkKIHsKLSAgICAoKCAiJHtHWF9ERUJVR30iID4gMCApKSAmJiBzdGRlcnIgIi4uLiAkQCIKKyAg ICAoKCAiJHtHWF9ERUJVR30iID4gMCApKSAmJiBzdGRlcnIgIiRAIgogfQogCiAKQEAgLTIzNSwx NCArMjM0LDE0IEBAIGZ1bmN0aW9uIGxvZ19jYWxsc3RhY2tfYW5kX3BhcmFtZXRlcnMoKQogICAg ICAgICBsb2NhbCBHWF9BUkdTPSgiJEAiKQogICAgICAgICBsb2NhbCBHWF9DQUxMU1RBQ0s9KCIk e0ZVTkNOQU1FW0BdfSIpCiAgICAgICAgIHVuc2V0IEdYX0NBTExTVEFDS1swXQotICAgICAgICBz dGRlcnIgIi4uLiAoJHtHWF9DQUxMU1RBQ0tbQF19KTogJHtHWF9BUkdTW0BdfSIKKyAgICAgICAg c3RkZXJyICIoJHtHWF9DQUxMU1RBQ0tbQF19KTogJHtHWF9BUkdTW0BdfSIKICAgICBmaQogfQog CiAKIGZ1bmN0aW9uIGxvZ19wcm9ncmVzcygpCiB7Ci0gICAgc3Rkb3V0ICIuLi4gJEAiCisgICAg c3Rkb3V0ICIkQCIKIH0KIAogCkBAIC0xMTAzLDkgKzExMDIsOSBAQCBmdW5jdGlvbiBkb19nZW5l cmF0ZSgpCiAKICAgICBpZiBbWyAteiAiJHtHWF9QUk9KRUNUX1RBR30iIF1dCiAgICAgdGhlbgot ICAgICAgICBsb2dfcHJvZ3Jlc3MgIj09PSBHZW5lcmF0aW5nIGFsbCAueGNmaWxlbGlzdHMgPT09 IgorICAgICAgICBsb2dfcHJvZ3Jlc3MgIkdlbmVyYXRpbmcgYWxsIC54Y2ZpbGVsaXN0cyIKICAg ICBlbHNlCi0gICAgICAgIGxvZ19wcm9ncmVzcyAiPT09IEdlbmVyYXRpbmcgLnhjZmlsZWxpc3Rz IGZvciAke0dYX1BST0pFQ1RfVEFHfSA9PT0iCisgICAgICAgIGxvZ19wcm9ncmVzcyAiR2VuZXJh dGluZyAueGNmaWxlbGlzdHMgZm9yICR7R1hfUFJPSkVDVF9UQUd9IgogICAgIGZpCiAKICAgICBm b3JfZWFjaF9wcm9qZWN0IFwKQEAgLTExMjIsOSArMTEyMSw5IEBAIGZ1bmN0aW9uIGRvX21lcmdl KCkKIAogICAgIGlmIFtbIC16ICIke0dYX1BST0pFQ1RfVEFHfSIgXV0KICAgICB0aGVuCi0gICAg ICAgIGxvZ19wcm9ncmVzcyAiPT09IE1lcmdpbmcgYWxsIC54Y2ZpbGVsaXN0cyBpbnRvIHBsYWNl ID09PSIKKyAgICAgICAgbG9nX3Byb2dyZXNzICJNZXJnaW5nIGFsbCAueGNmaWxlbGlzdHMgaW50 byBwbGFjZSIKICAgICBlbHNlCi0gICAgICAgIGxvZ19wcm9ncmVzcyAiPT09IE1lcmdpbmcgLnhj ZmlsZWxpc3RzIGZvciAke0dYX1BST0pFQ1RfVEFHfSA9PT0iCisgICAgICAgIGxvZ19wcm9ncmVz cyAiTWVyZ2luZyAueGNmaWxlbGlzdHMgZm9yICR7R1hfUFJPSkVDVF9UQUd9IgogICAgIGZpCiAK ICAgICBmb3JfZWFjaF9wcm9qZWN0IFwKQEAgLTExNDUsOSArMTE0NCw5IEBAIGZ1bmN0aW9uIGRv X2NoZWNrKCkKIAogICAgIGlmIFtbIC16ICIke0dYX1BST0pFQ1RfVEFHfSIgXV0KICAgICB0aGVu Ci0gICAgICAgIGxvZ19wcm9ncmVzcyAiPT09IENoZWNraW5nIGFsbCAueGNmaWxlbGlzdHMgPT09 IgorICAgICAgICBsb2dfcHJvZ3Jlc3MgIkNoZWNraW5nIGFsbCAueGNmaWxlbGlzdHMiCiAgICAg ZWxzZQotICAgICAgICBsb2dfcHJvZ3Jlc3MgIj09PSBDaGVja2luZyAueGNmaWxlbGlzdHMgZm9y ICR7R1hfUFJPSkVDVF9UQUd9ID09PSIKKyAgICAgICAgbG9nX3Byb2dyZXNzICJDaGVja2luZyAu eGNmaWxlbGlzdHMgZm9yICR7R1hfUFJPSkVDVF9UQUd9IgogICAgIGZpCiAKICAgICBmb3JfZWFj aF9wcm9qZWN0IFwKQEAgLTExNjUsNyArMTE2NCw3IEBAIGZ1bmN0aW9uIGRvX3N1YmdlbmVyYXRl KCkKICAgICBbWyAtbiAiJHtHWF9QUk9KRUNUX1RBR30iIF1dIHx8IGRpZSAiR1hfUFJPSkVDVF9U QUcgaXMgbm90IGRlZmluZWQuIgogICAgIFtbIC1uICIke1BST0pFQ1RfTkFNRX0iIF1dIHx8IGRp ZSAic3ViZ2VuZXJhdGUgc2hvdWxkIG9ubHkgYmUgaW52b2tlZCBpbiBhbiBYY29kZSBjb250ZXh0 LiIKIAotICAgIGxvZ19wcm9ncmVzcyAiPT09IEdlbmVyYXRpbmcgLnhjZmlsZWxpc3RzIGZvciAk e1BST0pFQ1RfTkFNRX0vJHtQTEFURk9STV9OQU1FfS8ke0NPTkZJR1VSQVRJT059ID09PSIKKyAg ICBsb2dfcHJvZ3Jlc3MgIkdlbmVyYXRpbmcgLnhjZmlsZWxpc3RzIGZvciAke1BST0pFQ1RfTkFN RX0vJHtQTEFURk9STV9OQU1FfS8ke0NPTkZJR1VSQVRJT059IgogCiAgICAgc2V0X3Byb2plY3Rf c2V0dGluZ3MKIAo=